BuffEnough 

Hi,

I love the idea behind this mod. In fact, I've written one of my own, but yours seems much simpler to use (judging from the description. I'm at work so I haven't tried the mod yet), so I'd like to swap to using yours if it does what I need.

My own mod is currently also doing a buff check on my pet (I'm a warlock). For example, I can tell when my Imp isn't phase shifted (because he doesn't have the 'Phase Shift' buff), and because I'm affliction with a obsessive interest in min/maxing, I'm also scanning him for things like Blessing of Kings, Blessing of Wisdom, MotW, AI/AB, Divine Spirit and Sporling Snacks (things that increase his mana pool or mana regen is the theme here).

Similarly, my own buffs are checked for Blood Pact when the Imp is out, to ensure I've got it on auto-cast etc (i.e. I haven't screwed something up somewhere).

As a side-note/idea, I see from the screenshots that the buff-check is manually initiated (avoids chewing CPU time which is a good move on your part). Does the mod (or would you considering making it) react to a raid 'ready check' so that I'm informed enough to declare my readiness or otherwise without having to manually initiate the check?

Does your mod do this sort of thing, or are you planning on a future update that will?

Thanks for the feedback, Footrot!

BuffEnough will auto-check on certain events - buffs coming up or down, raid members changing, etc. But it doesn't just constantly check (to save CPU like you mentioned). You can also manually do a check if you want to. In the update I just uploaded, I added the auto-check to trigger on ready checks as well.

I was contemplating adding some pet buff checks as well, but that isn't in there yet. I'll add that to the "to do" list.

This doesn't load properly with disembbeded libraries.

BuffEnough v2, USEng client/server. LibLogger-1.0 & LibTalentQuery-1.0 libraries are embedded, the rest of the libraries are disembeddeed (installed as stadalones from the Wowace SVN). Log on and two errors occur (recorded with BugSack/BuGrabber mods):

BuffEnough-1.0\Frame.lua:22: Cannot find a library instance of "LibSharedMedia-3.0".
Ace2\AceLibrary\AceLibrary.lua:49: in function `LibStub'
BuffEnough-1.0\Frame.lua:22: in main chunk

BuffEnough-1.0\Config.lua:434: attempt to index field 'db' (a nil value)
BuffEnough-1.0\BuffEnough.lua:101: in function `DoEnable'
BuffEnough-1.0\BuffEnough.lua:91: in function <Interface\AddOns\BuffEnough\BuffEnough.lua:89>
(tail call): ?:
<in C code>: ?
<string>:"safecall Dispatcher[1]":9: in function <[string "safecall Dispatcher[1]"]:5>
(tail call): ?:
AceAddon-3.0\AceAddon-3.0.lua:341: in function `EnableAddon'
AceAddon-3.0\AceAddon-3.0.lua:411: in function <Interface\AddOns\Ace3\AceAddon-3.0\AceAddon-3.0.lua:397>
<in C code>: in function `LoadAddOn'
Interface\FrameXML\UIParent.lua:908: in function `UIParentLoadAddOn':
Interface\FrameXML\UIParent.lua:234: in function `CombatLog_LoadUI':
Interface\FrameXML\UIParent.lua:327: in function `UIParent_OnEvent':
<string>:"*:OnEvent":1: in function <[string "*:OnEvent"]:1>

Typically happens when the needed libraries are not actually present. But I do extensive testing of mods and for sure have the needed libraries loading standalone, rarely/if ever have encountered this. LibSharedMedia-3.0
& SharedMedia are loading properly at logon here (standalone). No other mod I have that uses LibSharedMedia-3.0 is throwing up errors.

Any chance to see this on the wowace svn for downloading without libraries?

I haven't tried the addon in a raid yet, but it sounds really promising.

Druid Thorns appears to be missing. I am not a hard core raider, not sure if this was left out on purpose.

Thanks for the detailed report, Zidomo. Not sure what the deal is there, but if the problem is limited to LibSharedMedia, I may just pull it for the time being. I had thrown it in there thinking I would have some sort of customization features, but there isn't exactly a lot to customize, aesthetically speaking.

Applied for an SVN account a week or so back. Apparently it takes some time. I'll definitely get in there when I'm allowed.

Wasn't quite sure what to do with thorns. Some people put it up on everyone, some people only put it up on the tanks, some people don't really use it at all. In cases where I wasn't sure what the 'obvious' behavior should be, I left it out, rather than imposing what I thought the behavior should be, or creating something overly complex. What I may end up doing in a future version is adding the ability to add custom buffs to monitor in cases where something doesn't work "out of the box".

In that case (and you're right, thorns is a sticky one, pardon the pun), would you consider Thorns as a required buff for 'tanks' if the group has a druid present?

And thanks for the fast response to my other post.

I put Thorns on my to do list to "figure out". Also updated with a few more features and some bug fixes. Thanks to everyone who's been providing feedback, much appreciated!

Still not loading properly. Log on with v3 and still getting this error at logon, as before:

BuffEnough-1.0\Config.lua:434: attempt to index field 'db' (a nil value)
BuffEnough-1.0\BuffEnough.lua:101: in function `DoEnable'
BuffEnough-1.0\BuffEnough.lua:91: in function <Interface\AddOns\BuffEnough\BuffEnough.lua:89>
(tail call): ?:
<in C code>: ?
<string>:"safecall Dispatcher[1]":9: in function <[string "safecall Dispatcher[1]"]:5>
(tail call): ?:
AceAddon-3.0\AceAddon-3.0.lua:341: in function `EnableAddon'
AceAddon-3.0\AceAddon-3.0.lua:411: in function <Interface\AddOns\Ace3\AceAddon-3.0\AceAddon-3.0.lua:397>
<in C code>: in function `LoadAddOn'
Interface\FrameXML\UIParent.lua:908: in function `UIParentLoadAddOn':
Interface\FrameXML\UIParent.lua:234: in function `CombatLog_LoadUI':
Interface\FrameXML\UIParent.lua:327: in function `UIParent_OnEvent':
<string>:"*:OnEvent":1: in function <[string "*:OnEvent"]:1>

After that error occurs, cannot bring up the mod's options with "/be" or "/buffenough", meaning it hasn't loaded. The error with LibSharedMedia is gone.

The problem with standalone libraries is that you did not add all of the libraries your addon requires to the OptionalDeps field in the toc, so the libraries are (generally) not loaded before the addon tries to load.

Thanks for the hint, Phanx. I'm a relative Ace3 newbie (this addon actually began as just me experimenting with the Ace3 framework and messing around) so I wasn't sure what might be going wrong.

Zidomo, I'll see if I can get that issue cleared up with my next update, which will be in a day or two. I've added some additional stuff and cleaned up some code so I want to run it through a raid and make sure everything's working before I upload.

Do let me know if issues persist.

got these error when I logged my little rogue in.

[2008/05/24 22:37:27-349-x1]: BuffEnough\Classes\Rogue.lua:33: attempt to index global 'L' (a nil value)
BuffEnough\BuffEnough.lua:195: in function `RunCheck'
BuffEnough\BuffEnough.lua:130: in function `DoEnable'
BuffEnough\BuffEnough.lua:93: in function <Interface\AddOns\BuffEnough\BuffEnough.lua:91>
(tail call): ?:
<in C code>: ?
<string>:"safecall Dispatcher[1]":9: in function <[string "safecall Dispatcher[1]"]:5>
(tail call): ?:
AceAddon-3.0\AceAddon-3.0.lua:341: in function `EnableAddon'
AceAddon-3.0\AceAddon-3.0.lua:411: in function <...s\AckisRecipeList\libs\AceAddon-3.0\AceAddon-3.0.lua:397>
<in C code>: in function `LoadAddOn'
Interface\FrameXML\UIParent.lua:908: in function `UIParentLoadAddOn':
Interface\FrameXML\UIParent.lua:234: in function `CombatLog_LoadUI':
Interface\FrameXML\UIParent.lua:327: in function `UIParent_OnEvent':
<string>:"*:OnEvent":1: in function <[string "*:OnEvent"]:1>

---


[2008/05/24 22:37:31-349-x1]: BuffEnough\Classes\Rogue.lua:33: attempt to index global 'L' (a nil value)
BuffEnough\BuffEnough.lua:195: in function <Interface\AddOns\BuffEnough\BuffEnough.lua:182>
(tail call): ?:
<in C code>: ?
<string>:"safecall Dispatcher[2]":9: in function <[string "safecall Dispatcher[2]"]:5>
(tail call): ?:
AceBucket-3.0\AceBucket-3.0.lua:87: in function <...dOns\BuffEnough\Libs\AceBucket-3.0\AceBucket-3.0.lua:80>
(tail call): ?:
<in C code>: ?
<string>:"safecall Dispatcher[1]":9: in function <[string "safecall Dispatcher[1]"]:5>
(tail call): ?:
AceTimer-3.0\AceTimer-3.0.lua:142: in function <...rface\AddOns\Omen\Libs\AceTimer-3.0\AceTimer-3.0.lua:114>

---

That should be fixed in the newest update, Balsta.

Also, this addon is now available in the wowace SVN for those of you that would prefer to download it that way, or download it without the externals.

Ok, so I figured that I would install this addon and I would be able to check to see if I had the "best" buffs (or I could select every buff that I wanted to check for from a list based on specific enchants, flasks, potions, etc...) but I can't.

is there any way to be able to add a tab that allows someone to check off the specific buffs that they want for their character? Right now, I get the red screen, and when i left click, it doesn't report to me which buffs I am missing and if I right click, it says all buffs accounted for though at the time I am not buffed.