(5Kb)

Updated: 10-31-10 08:39 AM

Add Favorite

Install Help

Pictures

File Info

Updated:	10-31-10 08:39 AM
Created:	04-23-09 04:14 PM
Downloads:	4,152
Favorites:	23
MD5:

SkillMonitor

Version: 1.2

by: Verissi [More]

SkillMonitor displays a progress bar that shows how a selected skill is coming along. Let’s say you just decided to level fishing. Well, no more constantly popping open that annoyingly large profession window to check on your progress! Just right-click the progress bar, select Fishing from SkillMonitor’s pop-up menu, and you can see a progress bar that updates as you gain skill.

Commands:

/sm reset - Resets the progress bar position in case it got lost
/sm show - Shows the progress bar
/sm hide - Hides the progress bar
/sm lock - Locks/unlocks the progress bar in place
/sm mouse - Enables/disables mouse interaction entirely (will lock the bar position)
/sm config - Opens the configuration window

1.2
* Update for 4.0.1
* Bump TOC
* Reworked functions and menu for the new profession functions instead of the old skillline stuff
* Fixed some code formatting
1.1.2
* Update for 3.3.0
* Force-load Blizzard's achievement UI temporarily since they moved the template definition
* Bump TOC
* Fix indenting...stupid text editor
1.1.1
* Enable changing the bar's scale in the options panel
* Note: The bar's position will likely "dance" a bit, so if it moves off screen, reset the
position with /sm reset. I'm working on a better way to anchor it.
1.1.0
* Display the version number on the bar as well when no skill is selected
* Added an options panel finally and broke out mouse interaction into its own option
* New command: /sm mouse - toggles mouse interaction for the bar (does what /sm lock used to do)
* Reworked: /sm lock - locks/unlocks the skill bar's position (for dragging) only
* New command: /sm config - opens the options panel directly
* /sm lock and /sm mouse are toggles now; removed /sm unlock
1.0.7
* Stop trying to update the bar twice on initial loading (caused trackID reset issues)
* Rename a function-scoped tracking variable to avoid confusing me again
1.0.6
* Double-check that the bar and menu are created before updating (solves a load order problem)
* Check bounds of the saved ID number for the tracked skill before attempting to get skill info
* Reset the saved ID to 0 if it's higher than GetNumSkillLines() reports or less than 1
1.0.5
* Fixed a bug in the dropdown menu initialisation code (reported by metalchoir)
1.0.4
* Altered lock/unlock to also toggle mouse interaction with the bar
* Fixed link to the project homepage
1.0.3
* Initial release on WoWInterface

Comment Options

Page 1 of 2

04-23-09, 05:52 PM
Dridzt A Pyroguard Emberseer Forum posts: 1360 File comments: 829 Uploads: 55	Brilliant idea. Don't know how many times I've thought to myself to make something along these lines. Now I don't have to. I really like the concept Thanks for sharing. Edit: I do have an initial feature request Would it be possible to make your statusbar click-through (non mouse-interactive frame:EnableMouse(false)) when you lock it? Last edited by Dridzt : 04-23-09 at 05:57 PM.

04-23-09, 07:08 PM
Verissi Premium Member Forum posts: 99 File comments: 29 Uploads: 2	I was thinking of enabling click-through, but I just got in the habit of hiding it. I'll add that to the (very short) to-do list for the next update

04-28-09, 12:02 PM
Verissi Premium Member Forum posts: 99 File comments: 29 Uploads: 2	Status update: I'll be uploading 1.0.4 in the next day or so with the implementation of Dridzt's suggestion. Lock/unlock will also toggle mouse interaction entirely with the status bar frame in the new version. I made a "to do" note for myself to implement a small options menu for 1.1.0 (likely to be the next upload after 1.0.4) to provide a choice between current mouse-click behaviour versus the behaviour in 1.0.4. I also plan on having the option to customise which skills you see in the drop-down selection menu. For classes like warriors, that list can get a little long and it should allow you to selectively hide skills like armour proficiencies/languages. The menu customisation may not be ready for 1.1.0, but I will try to squeeze it in there and anticipate it being ready for 1.1.1 at the latest. Thank you all for the interest!

05-01-09, 10:08 AM
metalchoir A Kobold Labourer Forum posts: 0 File comments: 32 Uploads: 0	Bug Report You may miss some codes at line#172 in SkillMonitor.lua So, It needs to be changed like that before: function SM_InitialiseMenu() After : function SM_InitialiseMenu(self, level) Check it, plz

05-03-09, 05:38 PM

Verissi

Premium Member

Forum posts: 99

File comments: 29

Uploads: 2

Re: Bug Report

Originally posted by metalchoir
You may miss some codes at line#172 in SkillMonitor.lua
So, It needs to be changed like that

before: function SM_InitialiseMenu()
After : function SM_InitialiseMenu(self, level)

Check it, plz

*smacks forehead* I'll fix that in 1.0.5 (next day or so). Thanks!

__________________
"I can calculate the motions of the heavenly bodies, but not the madness of people." - Sir Isaac Newton
"Half of twice as intimidating as Saurfang is still one whole Saurfang worth of intimidation." - Anticlaus, Gorefiend server

05-04-09, 07:43 AM

Dridzt

A Pyroguard Emberseer

Forum posts: 1360

File comments: 829

Uploads: 55

v1.0.5 seems to work ok but on every load I get this error twice:

Code:

SkillMonitor-10005\SkillMonitor.lua:153: Usage: GetSkillLineInfo(index)
SkillMonitor-10005\SkillMonitor.lua:153: in function `SM_UpdateBar'
SkillMonitor-10005\SkillMonitor.lua:39: in function `?'
SkillMonitor-10005\SkillMonitor.lua:62: in function <Interface\AddOns\SkillMonitor\SkillMonitor.lua:61>
<in C code>: in function `ExpandSkillHeader'

I can see no adverse effects from it, the status bar displays and shows what I told it to.

05-04-09, 11:43 AM

Verissi

Premium Member

Forum posts: 99

File comments: 29

Uploads: 2

Originally posted by Dridzt
v1.0.5 seems to work ok but on every load I get this error twice:

Code:

SkillMonitor-10005\SkillMonitor.lua:153: Usage: GetSkillLineInfo(index) SkillMonitor-10005\SkillMonitor.lua:153: in function `SM_UpdateBar' SkillMonitor-10005\SkillMonitor.lua:39: in function `?' SkillMonitor-10005\SkillMonitor.lua:62: in function <Interface\AddOns\SkillMonitor\SkillMonitor.lua:61> <in C code>: in function `ExpandSkillHeader'

I can see no adverse effects from it, the status bar displays and shows what I told it to.

I'll check into it. I think this is an old problem that crept back in.

Edit: I'm willing to bet that the skill ID isn't being stored properly, leading to a nil or bad argument being passed to GetSkillLineInfo. I'll try to make the bar update function more picky about skill line numbers and just reset it to 0 if it's not valid

If you get a chance, can you post (or PM) the SkillMonitor.lua file in your SavedVariables? I'm curious to see what it's storing.

Last edited by Verissi : 05-04-09 at 10:29 PM.

05-05-09, 03:20 AM
Dridzt A Pyroguard Emberseer Forum posts: 1360 File comments: 829 Uploads: 55	The error I posted about previously only appeared on a fresh install (no saved variables present) It did not re-appear from second and subsequent load. It has been replaced by this initialization error. Code: SkillMonitor-10005\SkillMonitor.lua:154: attempt to index upvalue 'SM_StatusBar' (a nil value) SkillMonitor-10005\SkillMonitor.lua:39: in function `?' SkillMonitor-10005\SkillMonitor.lua:62: in function <Interface\AddOns\SkillMonitor\SkillMonitor.lua:61> <in C code>: in function `ExpandSkillHeader' It also does not seem to affect addon function for the rest of the session. This one actually looks like it's coming from event firing order during the loading process. In particular SKILL_LINES_CHANGED firing before PLAYER_LOGIN that calls the OnLoad and creates the bar. No idea why that would happen but event firing order during the loading process has changed after 3.x Edit in response (SV file of one of the affected chars): Code: SM_options = { ["frameShown"] = true, ["frameLocked"] = true, ["trackID"] = 6, ["x"] = 381.0000172108409, ["y"] = 767.9999427795418, } Last edited by Dridzt : 05-08-09 at 03:26 AM.

05-11-09, 04:08 AM
Verissi Premium Member Forum posts: 99 File comments: 29 Uploads: 2	1.0.6 Uploaded Just uploaded 1.0.6, which should solve the problems Dridzt reported The event firing order issue seems to be situational (I can't trigger it personally, but I know it's possible), so I'm checking to make sure the bar/menu are created before trying to update them just in case. Still plodding away on the rudimentary options menu. Time's been limited for me, but I'm working on it. __________________ "I can calculate the motions of the heavenly bodies, but not the madness of people." - Sir Isaac Newton "Half of twice as intimidating as Saurfang is still one whole Saurfang worth of intimidation." - Anticlaus, Gorefiend server

05-12-09, 04:04 AM
Dridzt A Pyroguard Emberseer Forum posts: 1360 File comments: 829 Uploads: 55	No more lua errors with 1.0.6 but there is a little bug present (more of an inconvenience than anything). The tracked skill doesn't persist across logins, bar appears with the static "SkillMonitor" label, until I set a skill to track again.

05-12-09, 05:14 AM

Verissi

Premium Member

Forum posts: 99

File comments: 29

Uploads: 2

Originally posted by Dridzt
The tracked skill doesn't persist across logins, bar appears with the static "SkillMonitor" label,
until I set a skill to track again.

Very puzzling, especially since I wiped my SavedVariables a few times to test some of the new code and didn't run into this. I'll wipe them again and take another look at the code to see if I can figure this one out.

05-16-09, 02:24 AM
Verissi Premium Member Forum posts: 99 File comments: 29 Uploads: 2	1.0.7 uploaded today I found the problem with the tracking not persisting and it should be fixed properly in the new upload. Thanks for the patience __________________ "I can calculate the motions of the heavenly bodies, but not the madness of people." - Sir Isaac Newton "Half of twice as intimidating as Saurfang is still one whole Saurfang worth of intimidation." - Anticlaus, Gorefiend server

05-16-09, 03:12 AM

Dridzt

A Pyroguard Emberseer

Forum posts: 1360

File comments: 829

Uploads: 55

Re: 1.0.7 uploaded today

Originally posted by Verissi
I found the problem with the tracking not persisting and it should be fixed properly in the new upload. Thanks for the patience

Hehe, likewise.
I know how hard is to debug an issue you're not observing yourself.

Thanks for taking the time.

07-11-09, 04:26 AM
Verissi Premium Member Forum posts: 99 File comments: 29 Uploads: 2	Version 1.1.0 Plans Status update on v1.1.0 I'm done with most of the work on v1.1.0, which is currently being written against the builds on PTR. If it looks like things are going to drag on with 3.2's PTR testing period, I'll test the changes on live and do the upload before 3.2 goes live. Since this is a benign little addon, though, I doubt any of the new stuff will be missed in the meantime The only visible changes are: Added an options panel to the Blizzard Interface Options New command: /sm config Takes you to the options panel New command: /sm mouse Enable/disable mouse interaction (does what /sm lock does in 1.0.7) Reworked command: /sm lock Now enables/disables dragging the bar without disabling mouse interaction entirely (just locks the bar's position, but doesn't prevent you from clicking to open the dropdown menu) /sm lock and /sm mouse will toggle their respective settings now (no need to /sm unlock any longer, just call /sm lock again) Clicking on the Defaults button in the options panel will do the same thing as /sm reset I had to rewrite some things to work with the new options panel, but I think the result is a bit easier to work with going forward. Still on my to-do list (no particular order, and my not make the cut for 1.1.0): Allow "filtering" of the skills dropdown menu so you can hide skills that you don't want to ever see on there Behind-the-scenes code cleanup and optimisation pass __________________ "I can calculate the motions of the heavenly bodies, but not the madness of people." - Sir Isaac Newton "Half of twice as intimidating as Saurfang is still one whole Saurfang worth of intimidation." - Anticlaus, Gorefiend server

07-13-09, 10:38 PM
nickyjean Premium Member Forum posts: 284 File comments: 114 Uploads: 0	Have you thought of a "Alt" Click or "Contl" Click which might then open the Trade skill panel in question (Mining would access Smelting of course)? I just figure it might be a convenience. But I totally love this addon. It's so awesome when I'm leveling toons. Last edited by nickyjean : 07-13-09 at 10:38 PM.

Page 1 of 2

Report this File

Category Jump: