Absorption Tracker

function AbsorbTracker_Absorbed() does not properly calculate nil values.

solution: i want to suggest that nil values need to be converted to zeros. example:

function AbsorbTracker_Absorbed(sGUID, sName, dGUID, dName, amt)
--check that you shielded that person
if(shields[dName]) then
...
if(PWSamt==nil) then PWSamt = 0 end
if(DAamt==nil) then DAamt = 0 end
...
end
end


note: author already fix it for DA. but the error come out for PWS.

using my formula:
4850 with 1703 spell power.
5084 with 1877 spell power.

to verify it, your glyph should heal around
970 with 1703 spell power.
1017 with 1877 spell power.


^_^

First of all, I'm new to WoW and add-on writing. but i'm not new to programming ^_^

Currently, I'm looking for a reliable "shield tracker" and few of my friends recommended yours. Since you will not update/fix it, i try do it myself. while vetting through your codes i noticed that you have a different value of absortion for rank11 and rank12 compare to wowhead (and other reference site). the rest are the same. may i ask why?

from wowhead.com
spellID(25217) == 1125 absorption
spellID(25218) == 1265 absorption

from absorbtracker.lua
spellID(25217) == 1147 absorption
spellID(25218) == 1315 absorption



edit:
i also come out with my own calculation of "total absorption". however, it is using different spell coefficient (94.22%)

i got my "total absorption" from total of heals from glyph of PW:S.


case:
maxBT; maxImprovedPW:S
maxTD; maxFP (doesn't count towards total absorption calculation)
spellpower = 1419
PW:S(rank14) = 2230 based
(suggested) PW:S coefficient = 94.22%
total heal by glyph = 894 = 20% of 4470 <-- "total absorption"? (i'll show its verification from my formula later).
total heal by glyph (crits!) = 1340 = 20% of 6700

note1: the in-game tooltip of PW:S shows that ImprovedPW:S affect base spell total before any coefficient is taken account.
PW:S tooltip shows 2564 = base*(1+maxImprovedPW:S) = 2230*1.15 (roughly)

note2: read borrowedTime tooltip carefully. the buff is just an "addition" towards "total absorption"
addition = (1+maxBT)*SP = 1.4*1419 = 567.6

note3: the final addition towards "total absorption" is total SP coefficient
SP coeffecient = SP*PW:S coef = 1419*0.9422 = 1337

therefore, "total absorption" is:
=(base*(1+maxImprovedPW:S)) + borrowedTime buff + SP coefficient
=2564 + 567.6 + 1337
=4469 (rounded up)

for criticals "total absorption" the value should be:
=normal "total absorption" * 150%(because of critical)
=4469*1.5
=6703 (rounded up)


i've sampled with every spell rank with the above setup and it hold true for each of them.

edit2:
also, your original code was bugged.

function AbsorbTracker_AbsorptionAmount(spellID)
...
local impShield = select(5,GetTalentInfo(1,5))*impshieldcoef
...
return shieldamt
end

where, "GetTalentInfo(1,5)" will fetch current rank for "Improved Power Word: Fortitude". I believe the correct one should be "GetTalentInfo(1,7)".

note: for the coming patch 3.1.0 it should be "GetTalentInfo(1,9)" because the swap of location with "meditation"


[email protected]nia
(probably it doesnt matter since i'm level 80 already)

As of last night (3.0.8 build 9464) with 5/5 Twin Disciplines, 2/2 Focused Power, 3/3 Improved PW:S, and 5/5 Borrowed Time my shield would absorb:

5371 with 1703 spell power.
5635 with 1877 spell power.


The formula being used in the tracker is

(1+impShield)*(1+focusedPower)*(1+twinDisciplines)*((shieldingCoefficient*(1+borrowedTime))*heal + baseAbsorb)

which for the previous tests be

1.15*1.04*1.05*((0.807*1.4)*1703 + 2230) = 5216
and
1.15*1.04*1.05*((0.807*1.4)*1877 + 2230) = 5463

respectively.


As of last night TD and FP certainly appear to contribute and in the same way they do to other spells. Borrowed time is also additive to the coefficient instead of multiplicative. The resulting value also appears to be floored.

The formula

(1+impShield)*(1+ focusedPower + twinDisciplines)*((shieldingCoefficient + borrowedTime)*heal + baseAbsorb)

produces

1.15*1.09*(1.207*1703+2230) = 5371
and
1.15*1.09*(1.207*1877+2230) = 5635


Keep up the good work.

-- Moor

Ah, good work. I didn't see this one, cheers ^-^

Santiclause, I hope posting this doesn't offend you but I thought it might be helpful to non-priests:

http://www.wowinterface.com/download...ldmonitor.html

It is something that monitors all shields, and shows the one that will be absorbed by damage first (meaning, if you have ice barrier and PW:S up, it'll show the ice barrier status).

If additional shields are planned for this mod, then ice barrier should be the first step. With the shattered barrier talent in particular, this mod would be very useful.

Any plans to expand this to Ice Barrier? It'd be greatly appreciated.

Absorbs 3300 damage, 80% coefficient.

Epic.

Any chance Mage and warlock shields could be supported. (IE. Mana Shield, Ice Barrier, VW Sacrifice) Thank you.