| Tested: | Hour of Twilight 4.3 |
| Updated: | 11-29-11 09:37 PM |
| Created: | 11-03-08 06:07 PM |
| Downloads: | 3,887 |
| Favorites: | 96 |
| MD5: |
![]() |
Comment Options |
|
|
||||
|
A Kobold Labourer
Forum posts: 0
File comments: 8
Uploads: 0
|
In other words, only build it if it's changed and then only sort when you need to load it. If nothing has changed since last edit focus, then you'd only be building your display until another character is entered, at which point for every character you're sorting a smaller chunk which is a much, much smaller impact. Oh, and saving the selection choices would be nice. The XML causes it to default to all on. Thanks |
|||
|
|
|
|
||
Part of the code design was to prevent excessive CPU use when scanning isn't necessary. In my own testing and constant use, it's working as intended without much if any impact on framerate. The only improvements I could think of is rewrite the command scanner to find the secure slash commands on load. They can only be defined in ChatFrame.lua and aren't able to be modified. For normal commands, I could go back to scanning from SlashCmdList. I'll also look into an event-driven approach using OnFocusGained/OnFocusLost and OnTextChanged/OnTextSet. There's a list of other changes I want to do which equates in total to another complete rewrite. The change to version 3.0 was just to regain full operation with the new IM style chat frames. Version 3.1 was a minor fix to the options frame. |
||
|
|
|
|
|
|
A Kobold Labourer
Forum posts: 0
File comments: 8
Uploads: 0
|
instead of grabbing a fresh list everytime you update, how about
-making a table that only updates during your SetOwner function -recycle it when done -work out of that while editbox is active -only build the table and start working after a user enters something like Code:
// would avoid all the rate drop when not searching for a command and always have a current list in the case of LoD
Last edited by doom0r : 10-24-10 at 01:53 AM.
|
|
|
|
|
|
|
Re: Busted in 3.3.5
Sorry I've been out for a while.
The change they did in 3.3.5 was to change the existing chat system to an IM style. There's now multiple edit boxes to manage, one for each chat frame. I'm working on new display code to help manage this and also give API support for compilation authors. As far as CPU consumption, all the work is done in one frame each time the text in the associated edit box changes. The method used to scan for slash commands searches through all top level global variables. This is to find secure commands as the secure variant of SlashCmdList is stored as a local variable in ChatFrame.lua. This'll be version 3.0 and I'll see about improving performance in the command search code in a later version. |
|
|
|
|
|
|
|
A Kobold Labourer
Forum posts: 0
File comments: 7
Uploads: 0
|
Busted in 3.3.5
Not only does it not work in 3.3.5, but it also reduced by framerate by around 75%. Better not use it, but hope it gets updated.
|
|
|
|
|
||
|
A Kobold Labourer
Forum posts: 1
File comments: 13
Uploads: 0
|
|
|
|
|
|
|
|
|
A Kobold Labourer
Forum posts: 0
File comments: 81
Uploads: 0
|
The latest patch broke this, unfortunately. Something to do w/ the changes they made to the chatbox.
|
|
|
|
|
|
|
lol never thought of that. thanks
![]() |
|
|
|
|
|
|
|
Might want to change the anchor on SlashHelpOptionsFrame the same way, otherwise the frame will hover down in the middle of the screen. This would be line 233 in the XML file.
|
|
|
|
![]() |