I'm having an issue where instead of displaying the name of the spell/attack, etc, it is displaying a number which i assume is the ID# for the action/spell. I have already deleted the saved variables files and deleted the whole broker_hitcrit directory, same issue.

Yup, you were right, the database must have been corrupted. I deleted the saved variables files and it's working fine now. Thanks.

Date: 2011-07-07 11:32:18
ID: 2
Error occured in: Global
Count: 1
Message: ..\AddOns\Broker_HitCrit\Broker_HitCrit.lua line 889:
attempt to index field 'hit' (a nil value)
Debug:
[C]: ?
Broker_HitCrit\Broker_HitCrit.lua:889: drawTooltip()
Broker_HitCrit\Broker_HitCrit.lua:1039:
Broker_HitCrit\Broker_HitCrit.lua:1036
Titan\LDBToTitan.lua:303:
Titan\LDBToTitan.lua:262
AddOns:
Swatter, v5.12.5184 (QuirkyKiwi)
MiniBlobs, v4.2.0.1
acbCastBar, v10.10.12
acbMirror, v10.10.12
AckisRecipeList, v2.2.6b
Altoholic, v4.2.001
Archy, v1.8.3
AucAdvanced, v5.12.5184 (QuirkyKiwi)
AucFilterBasic, v5.12.5184 (QuirkyKiwi)
AucFilterOutlier, v5.12.5184.4828(5.12/embedded)
AucMatchUndercut, v5.12.5184.4828(5.12/embedded)
AucStatHistogram, v5.12.5184 (QuirkyKiwi)
AucStatiLevel, v5.12.5184 (QuirkyKiwi)
AucStatPurchased, v5.12.5184 (QuirkyKiwi)
AucStatSales, v5.12.5184.4838(5.12/embedded)
AucStatSimple, v5.12.5184 (QuirkyKiwi)
AucStatStdDev, v5.12.5184 (QuirkyKiwi)
AucStatWOWEcon, v5.12.5184.4828(5.12/embedded)
AucUtilAHWindowControl, v5.12.5184.5133(5.12/embedded)
AucUtilAppraiser, v5.12.5184.5015(5.12/embedded)
AucUtilAskPrice, v5.12.5184.5162(5.12/embedded)
AucUtilAutoMagic, v5.12.5184.5184(5.12/embedded)
AucUtilCompactUI, v5.12.5184.5016(5.12/embedded)
AucUtilEasyBuyout, v5.12.5184.4897(5.12/embedded)
AucUtilFixAH, v5.12.5184 (QuirkyKiwi)
AucUtilGlypher, v5.12.5184.5061(5.12/embedded)
AucUtilGlypherPost, v5.12.5184.5159(5.12/embedded)
AucUtilItemSuggest, v5.12.5184.5144(5.12/embedded)
AucUtilPriceLevel, v5.12.5184.4861(5.12/embedded)
AucUtilScanButton, v5.12.5184.5159(5.12/embedded)
AucUtilScanFinish, v5.12.5184.5159(5.12/embedded)
AucUtilScanProgress, v5.12.5184.4979(5.12/embedded)
AucUtilScanStart, v5.12.5184.5159(5.12/embedded)
AucUtilSearchUI, v5.12.5184.5184(5.12/embedded)
AucUtilSimpleAuction, v5.12.5184.4993(5.12/embedded)
AucUtilVendMarkup, v5.12.5184.4828(5.12/embedded)
Auditor2, v4.4.2
AzCastBar, v10.10.14
Babylonian, v5.1.DEV.312(/embedded)
BadBoy, vv6.505
Bartender4, v4.4.19
BeanCounter, v5.12.5184 (QuirkyKiwi)
BonusScanner, v5.3
BrokerAuditor, v4.4.2
BrokerGroup, v
BrokerHitCrit, v2.22.2-release
ButtonFacade, v4.0.340
ButtonFacadeTrinity, v40200.1
Chinchilla, vv2.3.1
ComboPointsRedux, v2.2.2
Configator, v5.1.DEV.312(/embedded)
CooldownAlpha, v1.4
DataStore, v4.2.001
DataStoreAchievements, v4.2.001
DataStoreAgenda, v4.2.001
DataStoreAuctions, v4.2.001
DataStoreCharacters, v4.2.001
DataStoreContainers, v4.2.001
DataStoreCrafts, v4.2.001
DataStoreCurrencies, v4.2.001
DataStoreInventory, v4.2.001
DataStoreMails, v4.2.001
DataStorePets, v4.2.001
DataStoreQuests, v4.2.001
DataStoreReputations, v4.2.001
DataStoreSpells, v4.2.001
DataStoreStats, v4.2.001
DataStoreTalents, v4.2.001
DebugLib, v5.1.DEV.312(/embedded)
DropTheCheapestThing, vv3.6
Engraved, v1.6
famBags, v1.2.5
ForteCasting, v
ForteCooldown, v
ForteCore, v1.975.5
ForteDeathKnight, v
ForteTalent, v
ForteTimer, v
ForteVehicle, v
GatherMate2, v1.15
GatherSageCT, v4.3b
GupPet, v2.018
HealBot, v4.2.0.0
Informant, v5.12.5184 (QuirkyKiwi)
LearningAid, v1.11.1
LeatrixPlus, v4.2.00
LibExtraTip, v5.12.DEV.311(/embedded)
LineemUp, v1.09
Molinari, v40100.10-Beta
MoveAnything, v12.2.0
NeonChat, v
Pawn, v1.5.11
pHishMedia, v3.0
PitBull4, vv4.0.0-beta29
PitBull4AltPowerBar, vv4.0.0-beta29
PitBull4Aura, vv4.0.0-beta29
PitBull4Background, vv4.0.0-beta29
PitBull4BlankSpace, vv4.0.0-beta29
PitBull4Border, vv4.0.0-beta29
PitBull4CombatFader, vv4.0.0-beta29
PitBull4CombatIcon, vv4.0.0-beta29
PitBull4ComboPoints, vv4.0.0-beta29
PitBull4ExperienceBar, vv4.0.0-beta29
PitBull4HealthBar, vv4.0.0-beta29
PitBull4HideBlizzard, vv4.0.0-beta29
PitBull4HostilityFader, vv4.0.0-beta29
PitBull4LuaTexts, vv4.0.0-beta29
PitBull4PhaseIcon, vv4.0.0-beta29
PitBull4Portrait, vv4.0.0-beta29
PitBull4PowerBar, vv4.0.0-beta29
PitBull4PvPIcon, vv4.0.0-beta29
PitBull4QuestIcon, vv4.0.0-beta29
PitBull4RangeFader, vv4.0.0-beta29
PitBull4RestIcon, vv4.0.0-beta29
PitBull4RoleIcon, vv4.0.0-beta29
PitBull4Sounds, vv4.0.0-beta29
PitBull4VisualHeal5, vv4.0.0-beta29
Postal, v3.4.10
Prat30, v3.4.24
Prat30Libraries, v
ReputationBars, v1.1.9 (rev 86)
Routes, vv1.4.1
SharedMedia, v3.0.1-177
SharedMediaAdditionalFonts, v1.0
Skada, v1.2-34
SkadaAbsorbs, v1.0
SkadaCC, v1.0
SkadaDamage, v1.0
SkadaDamageTaken, v1.0
SkadaDeaths, v1.0
SkadaDebuffs, v1.0
SkadaDispels, v1.0
SkadaEnemies, v1.0
SkadaHealing, v1.0
SkadaPower, v1.0
SkadaThreat, v1.0
Skillet, v
SkillLevel, v1
SlideBar, v5.12.5184 (QuirkyKiwi)
SpellFlash, v5.97.1
SpellFlashDeathKnight, v1.04
SpellFlashRacials, v2.5.2
SpellFlashCore, v1.39.2
Stubby, v5.12.5184 (QuirkyKiwi)
TidyPlates, v6.3.1 Revision: 289
TidyPlatesGrey, v
TidyPlatesHub, v
TipHelper, v5.12.DEV.310(/embedded)
TipTac, v10.12.05
TipTacItemRef, v10.12.06
TipTacTalents, v10.11.23
Titan, v5.0.6.40200 - Revision 519
TitanBag, v5.0.6.40200
TitanClock, v5.0.6.40200
TitanDefense, v3.0.15.40200
TitanRepair, v5.0.6.40200
TitanRestPlus, v4.0.4
TomTom, vv40200-1.4.1
VanasKoS, v4.30-$Rev: 495 $
WhoFramedWatcherWabbit, v1.7
XToLevel, v4.2.0_30
BlizRuntimeLib_enUS v4.2.0.40200 <eu>
(ck=1397)

Hi,

I fixed the combat time errors by changing the following code at line number 394, 395:

Original:

function HitCrit:COMBAT_LOG_EVENT_UNFILTERED(
_, _, eType, hideCaster, sGUID, sName, sFlags, dGUID, dName, dFlags, ... )

Changed:


function HitCrit:COMBAT_LOG_EVENT_UNFILTERED(
_, _, eType, hideCaster, sGUID, sName, sFlags, sourceRaidFlags, dGUID, dName, dFlags, destRaidFlags, ... )


Hope it helps.

Cheers,
StillWaters

Hi,

I am getting 2 errors in 4.2. First error is in combat. I guess the 4.2 Combat Log changes are responsible. The error text is:

Date: 2011-07-01 21:32:07
ID: -18
Error occured in: Global
Count: 10
Message: ..\AddOns\Broker_HitCrit\Broker_HitCrit.lua line 206:
bad argument #6 to 'format' (number expected, got string)
Debug:
(tail call): ?
(tail call): ?
[C]: format()
Broker_HitCrit\Broker_HitCrit.lua:206: AlertNew()
Broker_HitCrit\Broker_HitCrit.lua:364: HitCrit_CheckInsertAlert()
Broker_HitCrit\Broker_HitCrit.lua:534: ?()
...ist\libs\CallbackHandler-1.0\CallbackHandler-1.0.lua:147:
...ist\libs\CallbackHandler-1.0\CallbackHandler-1.0.lua:147
[string "safecall Dispatcher[19]"]:4:
[string "safecall Dispatcher[19]"]:4
[C]: ?
[string "safecall Dispatcher[19]"]:13: ?()
...ist\libs\CallbackHandler-1.0\CallbackHandler-1.0.lua:92: Fire()
...s\AckisRecipeList\libs\AceEvent-3.0\AceEvent-3.0.lua:120:
...s\AckisRecipeList\libs\AceEvent-3.0\AceEvent-3.0.lua:119

Also,

Date: 2011-07-01 21:32:52
ID: -17
Error occured in: Global
Count: ∞
Message: ..\AddOns\Broker_HitCrit\Broker_HitCrit.lua line 291:
attempt to perform arithmetic on field 'total' (a nil value)
Debug:
(tail call): ?
(tail call): ?
Broker_HitCrit\Broker_HitCrit.lua:291: HitCrit_CheckInsertAlert()
Broker_HitCrit\Broker_HitCrit.lua:534: ?()
...ist\libs\CallbackHandler-1.0\CallbackHandler-1.0.lua:147:
...ist\libs\CallbackHandler-1.0\CallbackHandler-1.0.lua:147
[string "safecall Dispatcher[19]"]:4:
[string "safecall Dispatcher[19]"]:4
[C]: ?
[string "safecall Dispatcher[19]"]:13: ?()
...ist\libs\CallbackHandler-1.0\CallbackHandler-1.0.lua:92: Fire()
...s\AckisRecipeList\libs\AceEvent-3.0\AceEvent-3.0.lua:120:
...s\AckisRecipeList\libs\AceEvent-3.0\AceEvent-3.0.lua:119


2nd error is when I mouse over to the HitCrit icon on my LDB bar. The error text is:


Date: 2011-07-04 20:33:32
ID: 2
Error occured in: Global
Count: 1
Message: ..\AddOns\Broker_HitCrit\Broker_HitCrit.lua line 886:
attempt to index field 'hit' (a nil value)
Debug:
(tail call): ?
[C]: ?
Broker_HitCrit\Broker_HitCrit.lua:886: drawTooltip()
Broker_HitCrit\Broker_HitCrit.lua:1036: OnEnter()
Bazooka\Bazooka.lua:1400: showTip()
Bazooka\Bazooka.lua:1247:
Bazooka\Bazooka.lua:1238


Hope this helps you fix it for 4.2. Thanks for the addon.

Cheers,
StillWaters

Date: 2011-03-24 23:20:19
ID: 1
Error occured in: Global
Count: 1
Message: ..\AddOns\Broker_HitCrit\Broker_HitCrit.lua line 942:
attempt to index field '?' (a nil value)
Debug:
(tail call): ?
[C]: ?
Broker_HitCrit\Broker_HitCrit.lua:942: drawTooltip()
Broker_HitCrit\Broker_HitCrit.lua:597: _OnMouseDown_func()
...dOns\Broker_HitCrit\libs\LibQTip-1.0\LibQTip-1.0.lua:1162:
...dOns\Broker_HitCrit\libs\LibQTip-1.0\LibQTip-1.0.lua:1161

Yep. Zhinjio forgot a ton of commas when he updated the table.

__________________
"You'd be surprised how many people violate this simple principle every day of their lives and try to fit square pegs into round holes, ignoring the clear reality that Things Are As They Are." -Benjamin Hoff, The Tao of Pooh

Date: 2011-03-19 21:14:42
ID: 1
Error occured in: Global
Count: 1
Message: ..\AddOns\Broker_HitCrit\Broker_HitCrit.lua line 79:
'}' expected (to close '{' at line 68) near '='
Debug:
[C]: ?
AddOns:
Swatter, v3.2.3 (<%codename%>)
AckisRecipeList, v2.2.2