TradeFilter : WoWInterface Downloads : Chat Mods

		WoWInterface Downloads » Stand-Alone Addons » Chat Mods
TradeFilter

Category: Chat Mods

Addon Information

Works with 3.2

Author:	evonder [more]
Version:	3.1.4-release
Date:	10-22-2009 01:49 AM
Size:	151.65 Kb
Downloads:	533
Favorites:	18
MD5:

Pictures

No Spam

Flow

TradeFilter

Not just any old filter!
Translators needed - Help localize HERE

If you like the addon and use it please add it to you favorites!

TradeFilter only allows strings that match your pattern list to pass. TradeFilter does not only filter trade but has the ability to filter General, LookingforGroup, Say and Yell channels all which are configurable through the blizzard options panel.

TradeFilter has a set of patterns for trade channel and separate set of patterns for all other channels, or "base" channels as we will call them. This allows the user to define what patterns may be good for trade but not other channels and vise versa. The user has the ability to add patterns of their own to be matched against for both trade and "base" channel filters.

Trade Filters:

Code:

lf port,
buying,
wt[bBsStT],
lf[wWeEmM],
lf enchant,
lf jc,
AH,
looking for work,
lockpick,
selling,
buying,

Channel Filters:

Code:

lf dps,
lf tank,
lf healer,
lf#m?,
lfm?,
lfg,
2v2,
3v3,
5v5

Adding a set, ie [xXyY], will attempt to find a match for any character given in a set. Example: lf[wWeEmM] will match for lfw, lfe and lfm.

Black and White Lists
TradeFilter also has a build in Black and White list. A sentence, or "string". that contains a black list match will cease to be checked any more and be filtered out completely. A string found that contains a white list match will also cease to be checked and will be allowed to passed un-filtered.

Filtering Priorities

Configuration

Code:

/tf or /filter

To Do
Nothing planned

ChangeLog
r167

Added simple duel spam block

r159

Keep lists sorted!

r155

LDB support for Repeats Blocked
Ability for Whitelist to bypass repeat filter
GUI layout changed a little

r148

Minor code cleanup

AceTimer lib added for repeat table recycling

r145

Rewrite on DB functions, Repeat Function and Friends functions
Show repeat count with ability to reset count
Ability to enable/disable Black and White list checking
Debug: Black and White list debugging messages contain whitespaces
Debug: Black and White list debugging messages now show what they matched in your pattern list
Debug: Option to strip "Checking for Match" when debugging

r144

Debug: Further Debug output cleanup
Better repeat detection
Whitelisted strings still have to pass repeat test
Whitelisted strings also needs to pass Blacklist

r132

Typo causing reset buttons to error out fixed
Added all strings to locale
Keys are no longer necessary when adding filter or list patterns
Cleaned up debugging output, will now show what pattern that was matched to allow it to not be filtered

r131

Repeat filtration
Configurable number of repeats before filtered
Configurable time required between repeats in seconds

r126

Option: Reset to default filters

r122

Distinguish between Trade channel and LFG/General for the ability to have differant filter tables for pattern matching.
Ability to edit entire filter tables rather than having static lists.

r82

TradeFilter also will not filter any messages from your friends, they must be on your current characters friends list for this functionality to work.

Supported Translations
Translators needed - Help localize HERE
German - 100%
Simplified Chinese - 46.7%
Traditional Chinese - 24.8%
French - 27.6%

Change Log - TradeFilter

------------------------------------------------------------------------
r191 | networkerror | 2009-10-22 04:41:13 +0000 (Thu, 22 Oct 2009) | 1 line
Changed paths:
A /tags/3.1.4-release (from /trunk:190)

Tagging as 3.1.4-release
------------------------------------------------------------------------
r190 | networkerror | 2009-10-19 05:49:28 +0000 (Mon, 19 Oct 2009) | 2 lines
Changed paths:
M /trunk/TradeFilter3.lua

TradeFilter3
- Friends import prints to debug frame instead of default
------------------------------------------------------------------------
r189 | networkerror | 2009-10-19 05:47:37 +0000 (Mon, 19 Oct 2009) | 2 lines
Changed paths:
M /trunk/TradeFilter3.lua

TradeFilter3
- Only print friends imported to exemption list if debug is enabled
------------------------------------------------------------------------
r188 | networkerror | 2009-10-06 05:23:08 +0000 (Tue, 06 Oct 2009) | 2 lines
Changed paths:
M /trunk/TradeFilter3.lua

TradeFilter3
- LDB Tooltip cleanup and localization
------------------------------------------------------------------------
r187 | networkerror | 2009-09-30 02:53:38 +0000 (Wed, 30 Sep 2009) | 1 line
Changed paths:
A /tags/3.1.3-release (from /trunk:186)

Tagging as 3.1.3-release
------------------------------------------------------------------------
r186 | networkerror | 2009-09-15 14:33:13 +0000 (Tue, 15 Sep 2009) | 2 lines
Changed paths:
M /trunk/TradeFilter3.lua

TradeFilter3
- Player names in debug and spam windows are now class colored and player links
------------------------------------------------------------------------
r185 | networkerror | 2009-09-06 05:22:12 +0000 (Sun, 06 Sep 2009) | 2 lines
Changed paths:
M /trunk/TradeFilter3Locale.lua

TradeFilter3
- Locale touch
------------------------------------------------------------------------
r183 | networkerror | 2009-08-31 05:03:47 +0000 (Mon, 31 Aug 2009) | 2 lines
Changed paths:
M /trunk/TradeFilter3.toc

TradeFilter3
- Touch for Locale update
------------------------------------------------------------------------
r182 | networkerror | 2009-08-16 07:53:41 +0000 (Sun, 16 Aug 2009) | 1 line
Changed paths:
A /tags/3.1.1-release (from /trunk:181)

Tagging as 3.1.1-release
------------------------------------------------------------------------
r172 | networkerror | 2009-08-15 09:10:58 +0000 (Sat, 15 Aug 2009) | 2 lines
Changed paths:
M /trunk/TradeFilter3.lua
M /trunk/TradeFilter3Options.lua

TradeFilter3
- Ensure DuelFilter sets on login
------------------------------------------------------------------------
r171 | networkerror | 2009-08-15 06:46:52 +0000 (Sat, 15 Aug 2009) | 2 lines
Changed paths:
M /trunk/TradeFilter3.lua
M /trunk/TradeFilter3Options.lua

TradeFilter3
- Fix LDB Repeat display not resetting when count is reset through config GUI
------------------------------------------------------------------------
r168 | networkerror | 2009-08-13 23:20:34 +0000 (Thu, 13 Aug 2009) | 3 lines
Changed paths:
M /trunk/TradeFilter3.toc

TradeFilter3
- TOC add X-WoWI-ID
- Locale bump
------------------------------------------------------------------------
r167 | networkerror | 2009-08-08 03:08:46 +0000 (Sat, 08 Aug 2009) | 4 lines
Changed paths:
M /trunk/TradeFilter3.lua
M /trunk/TradeFilter3Options.lua

TradeFilter3
- Added option whitelist bypass blacklist
- Added simple duel spam block
- Fix repeat filter not actually being off
------------------------------------------------------------------------
r166 | networkerror | 2009-08-05 18:38:21 +0000 (Wed, 05 Aug 2009) | 2 lines
Changed paths:
M /trunk/TradeFilter3.lua

TradeFilter3
- LDB refresh when repeats reset
------------------------------------------------------------------------
r165 | networkerror | 2009-08-05 02:34:59 +0000 (Wed, 05 Aug 2009) | 1 line
Changed paths:
A /tags/3.0.164-release (from /trunk:164)

Tagging as 3.0.164-release
------------------------------------------------------------------------
r164 | networkerror | 2009-08-04 22:50:17 +0000 (Tue, 04 Aug 2009) | 2 lines
Changed paths:
M /trunk/TradeFilter3.toc

TradeFilter3
- TOC bump
------------------------------------------------------------------------
r163 | networkerror | 2009-08-04 04:32:15 +0000 (Tue, 04 Aug 2009) | 1 line
Changed paths:
A /tags/3.0.162-release (from /trunk:162)

Tagging as 3.0.162-release
------------------------------------------------------------------------
r162 | networkerror | 2009-08-04 04:05:39 +0000 (Tue, 04 Aug 2009) | 3 lines
Changed paths:
M /trunk/TradeFilter3.toc
M /trunk/TradeFilter3Options.lua

TradeFilter3
- Reset for special filters
- AddonLoader delayed
------------------------------------------------------------------------
r161 | networkerror | 2009-08-03 03:47:13 +0000 (Mon, 03 Aug 2009) | 2 lines
Changed paths:
M /trunk/TradeFilter3.lua
M /trunk/TradeFilter3Options.lua

TradeFilter3
- small cleanup
------------------------------------------------------------------------
r160 | networkerror | 2009-07-30 05:47:29 +0000 (Thu, 30 Jul 2009) | 2 lines
Changed paths:
M /trunk/TradeFilter3.lua
M /trunk/TradeFilter3Options.lua

TradeFilter3
- Sorting should work now
------------------------------------------------------------------------
r159 | networkerror | 2009-07-30 04:22:17 +0000 (Thu, 30 Jul 2009) | 2 lines
Changed paths:
M /trunk/Docs/changelog.txt
M /trunk/TradeFilter3.lua
M /trunk/TradeFilter3Options.lua

TradeFilter3
- Keep lists sorted!
------------------------------------------------------------------------
r157 | networkerror | 2009-07-29 05:51:12 +0000 (Wed, 29 Jul 2009) | 2 lines
Changed paths:
M /trunk/TradeFilter3.lua

TradeFilter3
- LDB fix
------------------------------------------------------------------------
r156 | networkerror | 2009-07-29 05:30:27 +0000 (Wed, 29 Jul 2009) | 3 lines
Changed paths:
M /trunk/.pkgmeta

TradeFilter3
- LDB embed fix
- Locale touch
------------------------------------------------------------------------
r155 | networkerror | 2009-07-29 03:45:30 +0000 (Wed, 29 Jul 2009) | 4 lines
Changed paths:
M /trunk/.pkgmeta
M /trunk/Docs/changelog.txt
M /trunk/TradeFilter3.lua
M /trunk/TradeFilter3.toc
M /trunk/TradeFilter3Options.lua

TradeFilter3
- LDB support for Repeats Blocked
- Ability for Whitelist to bypass repeat filter
- GUI layout changed a little
------------------------------------------------------------------------
r154 | networkerror | 2009-07-26 04:09:26 +0000 (Sun, 26 Jul 2009) | 3 lines
Changed paths:
M /trunk/TradeFilter3.toc

TradeFilter3
- Locale touch
- TOC update
------------------------------------------------------------------------
r153 | networkerror | 2009-07-25 20:10:12 +0000 (Sat, 25 Jul 2009) | 5 lines
Changed paths:
M /trunk/TradeFilter3.lua
M /trunk/TradeFilter3Options.lua

TradeFilter3
- GUI Icon added
- Some table fault tolerance added for pattern lists
- Initial code for AddOn Channel messages(Not fully tested)
- Added special channel filtering ability
------------------------------------------------------------------------
r150 | networkerror | 2009-07-18 16:29:25 +0000 (Sat, 18 Jul 2009) | 2 lines
Changed paths:
M /trunk/Docs/main.txt
M /trunk/TradeFilter3.lua

TradeFilter3
- Added msgID(arg11) to debug and spam output.

Archived Versions - TradeFilter

File Name	Version	Size	Author	Date
TradeFilter	3.1.3-release	151kB	evonder	09-30-2009 10:18 PM

Comments - TradeFilter

Comment Options

Page 1 of 3

08-07-2009, 11:27 PM

evonder

A Kobold Labourer

Forum posts: 0

File comments: 23

Uploads: 1

Re: Suggestions

Quote:

Originally posted by thantik
Could we have seperate white/black lists per major channel? I'd just like a bit better control over what's let through and what's not.

Also...the 'in bed' filter...currently blacklists anyone who links any gem with "inscribed" listed in the name. Might wanna redo the regex to be a little more specific by default.

Also - if you were to make seperate black/white lists, some little pre-set regex list to be able to add/remove to each black/white list would make setting it up really easy.

The defaults are amazing right now otherwise, just some minor quirks and I'm a control freak.

I have a feeling that having a configurable whitelist per-channel would make the addon far to convoluted and make the average user confused. The blacklist actually wasn't blocking the [Inscribed ...] item links but a bug that I found while adding a new option, which will do what Contiki requested earlier but I failed to understand. I think I understand what you are saying about the pre-sets though I don't think really see the use of it if we only have one list, what type of situation would call for changing pre-sets?

Updates: Alpha r167
- Added option whitelist bypass blacklist
- Added simple duel spam block
- Fix repeat filter and blacklist not actually being off

__________________
Author: TradeFilter, CheckFearWard and Bloodsurge

08-06-2009, 02:46 AM
thantik A Kobold Labourer Forum posts: 0 File comments: 3 Uploads: 0	Suggestions Could we have seperate white/black lists per major channel? I'd just like a bit better control over what's let through and what's not. Also...the 'in bed' filter...currently blacklists anyone who links any gem with "inscribed" listed in the name. Might wanna redo the regex to be a little more specific by default. Also - if you were to make seperate black/white lists, some little pre-set regex list to be able to add/remove to each black/white list would make setting it up really easy. The defaults are amazing right now otherwise, just some minor quirks and I'm a control freak.

08-01-2009, 08:55 AM
Contiki A Kobold Labourer Forum posts: 0 File comments: 51 Uploads: 1	Hi, I've had a chance to test special channel filtering and it seems to work fine. If I've interpreted TradeFilter's bevahior correctly, however, the black list does not (yet) apply to special channels and the hidden guild add-on channel. If the black list is used for special channels, too, I must've set something incorrectly. I couldn't find any suspicios options though. In case this behavior is intended, could you modify TradeFilter so that special channels don't bypass the black list anymore? While I was testing EverTrade with a guildie I missed the appropriate output in the SPAM and DEBUG chat frames. In case EverTrade messages indeed aren't displayed in those chat frames yet, could you change TradeFilter so that those messages are displayed there? The bottom line is that special channels support is already working great. Makes the combination of EverTrade (and others) and TradeFilter a lot nicer than with former TradeFilter versions. As for the sorting mechanism, it's way better than before. Now the sorting is predictable since it's always alphabetically from a to z. If possible, a next step in sorting greatness might be to actually save the player's sorting. That way players who prefer to group their filter and black list entries by context can retain their custom sorting, too. As in "here's everything about dungeons", "here's everything about obscenities" and "here's the valid profession stuff". Keep it up! ;-) All the best __________________ Be prepared... to simplify your life.

07-30-2009, 12:35 AM

evonder

A Kobold Labourer

Forum posts: 0

File comments: 23

Uploads: 1

Quote:

Originally posted by Contiki
This is an actual issue. I think. When I hit the Accept button underneath each of the filter input fields like Trade filter, Black list and so on, the fields' entries are randomly mixed.

Ok give this on a shot =) r160

EDIT:: little fix - r160 should keep list sorting constant

__________________
Author: TradeFilter, CheckFearWard and Bloodsurge

Last edited by evonder : 07-30-2009 at 02:00 AM.

07-29-2009, 08:47 PM

evonder

A Kobold Labourer

Forum posts: 0

File comments: 23

Uploads: 1

Quote:

Originally posted by Contiki
I've added German translations for the four new strings. Looks like the key RPTBYPASSD has a mistake, namely "Allow strings that match your a pattern in your whitelist to bypass the repeat filter." Nothing else to ***** and moan about though ;-)

aghh yes, it is now fixed. I also added "[Experimental]" to keys GAC and GACD

__________________
Author: TradeFilter, CheckFearWard and Bloodsurge

07-29-2009, 09:50 AM
Contiki A Kobold Labourer Forum posts: 0 File comments: 51 Uploads: 1	I've added German translations for the four new strings. Looks like the key RPTBYPASSD has a mistake, namely "Allow strings that match *your a* pattern in your whitelist to bypass the repeat filter." Nothing else to ***** and moan about though ;-) __________________ Be prepared... to simplify your life. Last edited by Contiki : 07-29-2009 at 09:50 AM.

07-28-2009, 03:03 AM
Contiki A Kobold Labourer Forum posts: 0 File comments: 51 Uploads: 1	Hi, see, now I get it ;-) Now that I know it's because of the Ace localization system it's all good. I didn't have that in mind when thinking about the possible advantages of table dictionaries over table arrays. As for the duplicate strings, they're no big deal. I wanted to make sure this wasn't a mistake or an oversight. __________________ Be prepared... to simplify your life.

07-28-2009, 02:31 AM
evonder A Kobold Labourer Forum posts: 0 File comments: 23 Uploads: 1	Contiki, the only reason for the use of dictionary tables is to take advantage of the Ace localisation system which doesn't allow for standard array tables. As far as the duplicate name they are different namespaces plus its only one phrase thats a duplicate and I will get the TOC one fixed as soon as I can get this dang thing to commit to the SVN :P __________________ Author: TradeFilter, CheckFearWard and Bloodsurge

07-27-2009, 11:20 AM
Contiki A Kobold Labourer Forum posts: 0 File comments: 51 Uploads: 1	Hi, I don't quite get it with arrays and dictionaries. I've read the page you linked and the way I understand it you could declare your tables as arrays instead of dictionaries. That'd allow you to read from them with the ipairs() function instead of the pairs() function. You would then get the properly ordered array contents; ordered the same way they were last saved. Like so: Code: array={"enchant:%d+[^%a%d]", "item:%d+[^%a%d]", "spell:%d+[^%a%d]", "trade:%d+[^%a%d]"} for i,v in ipairs(array) do print(i,v) end \| 1 enchant:%d+[^%a%d] \| 2 item:%d+[^%a%d] \| 3 spell:%d+[^%a%d] \| 4 trade:%d+[^%a%d] Or did I get that part wrong and table arrays are only possible with numbers and if you wanna save arbitrary strings you have to use table dictionaries? I mean I understand now that table dictionaries are output in a random order in Lua. Howevr, I don't get why dictionaries make more sense than arrays for TradeFilter's purposes. Don't get me wrong here. This isn't actually an issue. I've been living with this behavior ever since and it won't impact me negatively if it stays this way ;-) It's more of a curiosity thing now that I know why the input fields get reordered every time I hit the Accept button. All the best, Contiki //Edit: just realized on the localization page that you've changed the Notes key to "Not just any old filter". I've changed the German translation accordingly. However, only recently you've added the key NJAOF. Both are identical now. Wouldn't it be easier to maintain if you used just one key instead of two? __________________ Be prepared... to simplify your life. Last edited by Contiki : 07-27-2009 at 02:44 PM.

07-27-2009, 02:05 AM

evonder

A Kobold Labourer

Forum posts: 0

File comments: 23

Uploads: 1

Quote:

Originally posted by Contiki
Nope, not yet.

On a side note, I was just looking through a text file named tradefilter.txt I had on my desktop. Was wondering what was in there and lo and behold, during the last weeks I had jotted down suggestions and strange/unwanted behavior in TradeFilter I had totally forgotten about. So here goes.
A while ago you changed TradeFilter's slogan from "Filter the **** outta Trade channel!" to "Not just any old filter!" Initially only on the WowAce homepage, later here on wowinterface, too. I like that slogan better than the former one and was wondering what you'd think about adding it to the TOC file, too. So for consistency's sake, what do you think about adding "Not just any old filter!" to the TOC file, too?

This is an actual issue. I think. When I hit the Accept button underneath each of the filter input fields like Trade filter, Black list and so on, the fields' entries are randomly mixed. Consider me entering these terms into the filter list:
one
two
three
four
five

Now I hit the Accept button an bam, the list looks like this:
three
five
one
four
two

I've learned to live with this bevahior and am keeping a copy of the properly ordered filter terms separate. However, wouldn't it be cool if the add-on didn't reorder the list? That way players woudn't need to keep a separate copy of their filter terms and could instead change them in the input fields ;-) By the way, when I repeatedly hit Accept without actually changing the filter terms the lists get reordered repeatedly, too. I have to admit that looks kinda funny. *wonder what's up at the top the next time I hit accept*

That's it, that's the two things I had in my text file. Going to delete it now that I've let you know.

As for helping out with feedback, reports, translations 'n' stuff, you're welcome!

All the best,

Contiki

1) Localisation for Title has been changed, forgot all about that one

2) This is because the tables are dictionary style and as such have to use pairs to iterate over the tables, the caveat of pairs is that it does not return in a predetermined order. The reason for the table reorders itself every time you hit the accept button is the way that the table is wiped and repopulated with the given values that you supply...hence pairs iterates over it again to return you the values and poof reordered again :P

__________________
Author: TradeFilter, CheckFearWard and Bloodsurge

07-27-2009, 01:49 AM

Contiki

A Kobold Labourer

Forum posts: 0

File comments: 51

Uploads: 1

Quote:

Originally posted by evonder
Btw did you get a chance to see if the "Special Channel" or AddOn channel was being filtered properly?

Nope, not yet.

On a side note, I was just looking through a text file named tradefilter.txt I had on my desktop. Was wondering what was in there and lo and behold, during the last weeks I had jotted down suggestions and strange/unwanted behavior in TradeFilter I had totally forgotten about. So here goes.

A while ago you changed TradeFilter's slogan from "Filter the **** outta Trade channel!" to "Not just any old filter!" Initially only on the WowAce homepage, later here on wowinterface, too. I like that slogan better than the former one and was wondering what you'd think about adding it to the TOC file, too. So for consistency's sake, what do you think about adding "Not just any old filter!" to the TOC file, too?
This is an actual issue. I think. When I hit the Accept button underneath each of the filter input fields like Trade filter, Black list and so on, the fields' entries are randomly mixed. Consider me entering these terms into the filter list:
- one
  two
  three
  four
  five
Now I hit the Accept button an bam, the list looks like this:
- three
  five
  one
  four
  two
I've learned to live with this bevahior and am keeping a copy of the properly ordered filter terms separate. However, wouldn't it be cool if the add-on didn't reorder the list? That way players woudn't need to keep a separate copy of their filter terms and could instead change them in the input fields ;-) By the way, when I repeatedly hit Accept without actually changing the filter terms the lists get reordered repeatedly, too. I have to admit that looks kinda funny. *wonder what's up at the top the next time I hit accept*

That's it, that's the two things I had in my text file. Going to delete it now that I've let you know.

As for helping out with feedback, reports, translations 'n' stuff, you're welcome!

All the best,

Contiki

__________________
Be prepared... to simplify your life.

07-27-2009, 01:00 AM

evonder

A Kobold Labourer

Forum posts: 0

File comments: 23

Uploads: 1

Quote:

Originally posted by Contiki
Hi,

**Snip**

The white list optionally bypassing the black would be neat.

All the best,
Contiki

I will add that to the "To Do" list.

Quote:

Originally posted by Contiki

//Edit: Added translations for the one modified and one new string.

Thank you sir, you have been a great help not only with translations but with such well thought out descriptions of problems or possible enhancements.

EDIT:: Btw did you get a chance to see if the "Special Channel" or AddOn channel was being filtered properly?

__________________
Author: TradeFilter, CheckFearWard and Bloodsurge

Last edited by evonder : 07-27-2009 at 01:01 AM.

07-27-2009, 12:30 AM
Contiki A Kobold Labourer Forum posts: 0 File comments: 51 Uploads: 1	Hi, I see where you're coming from and especially in case of these anal this-and-this item links it makes sense. However, at lesat on my server this anal meme thingy isn't an issue. I'm using TradeFilter to get the actual Trade channel back; the way I think it was intended. My filter list contains all the good and valid stuff that usually happens in Trade: item links, profession links and whatnot. So that's allowed. Since at least on my realm some players like to use Trade as a substitute for LFG I've put all the LFG-related stuff - among other terms - on the black list: "naxx", "ulduar", "druid", "tank" and whatnot. By now both lists work well enough to come to the right decision 98% of the time. Roughly 2% of the valid Trade stuff get's lost and roughly 2% of the non-Trade stuff shows up in Trade. That's already great and I'm further fine-tuning the lists. One issue I see is with items such as the [Relic of Ulduar]. I can modify the black list so it does trigger with "ulduar[^%]]", meaning with any "ulduar" followed by something else than the closing brackets ("]") of the item link. That way "lf tank for ulduar 10-man" gets blacklisted while "looking for 400 [Relic of Ulduar]" passes through. Problem is (that's where part of the missing 2% come from) when players ask for relics without an item link. Then there are no brackets to check for and the very valid Trade-related question for them gets thrown out. There are quite a few more items of this kind. [Hunter's Scout of the Bandit] comes to mind which could easily be cought by the "hunter" black list entry unless players provide the item link. The list goes on quite a bit, even though these make up a minority of Trade messages. What I'm thinking about is to allow players to "free" the white list from black list checking. Like an option "Allow white list to bypass black list". I'm aware that this option may not be the right thing for all players. There's, however, the benefit of further customizing one's lists. The white list could take the most common mistakable item names and allow them to show up in Trade. Another benefit comes to mind. The white list could allow the links for enchant:%d+[^%a%d], item:%d+[^%a%d], spell:%d+[^%a%d] and trade:%d+[^%a%d] to pass through. That way "wts a tank's dream [Enchant Weapon - Blade Ward]" shows up in Trade where it otherwise wouldn't due to the "tank" black list entry. On the one hand, at least in my situation an option to "Allow white list to bypass black list" would "only" add another 1% to the 98% success rate. But then, its even closer to the perfect Trade channel. Plus, when players already have a white list, and when players already customize TradeFilter, it makes sense to give them such an option, too. Oh and I don't see any tangible benefit in such an option for the repeat filter either. As in "Allow white list to bypass repeat filter". That wouldn't make sense. Allowing that would increase clutter in Trade. If a message is white-listed and it does not get thrown out by the black list (anymore), it will show up in Trade. No need for it to show up every ten seconds. The white list optionally bypassing the black would be neat. All the best, Contiki //Edit: Added translations for the one modified and one new string. __________________ Be prepared... to simplify your life. Last edited by Contiki : 07-27-2009 at 12:50 AM.

07-25-2009, 09:42 PM

evonder

A Kobold Labourer

Forum posts: 0

File comments: 23

Uploads: 1

Quote:

Originally posted by Contiki
Greetings,

thanks very much for adding this feature to TradeFilter! I've translated the new strings to German and downloaded r153. I'm going to test it with a guildie who's also using EverTrade and provide proper feedback as soon as I can.

I hope that the Guild AddOn message channel is filtered properly, without having someone to test with I am kinda shooting in the dark. Using the "Global" channel in EverTrade in conjunction with TradeFilter's "Special Channel" list should work just fine.

Quote:

Originally posted by Contiki

As for the changes during the last revisions, I didn't notice any bugs or strange/unwanted behavior despite me monitoring the add-on's activity more or less closely. One thing I did notice, however, is in the filter priorities diagram. If I remember correctly the white list's purpose was to always allow certain messages. Once the white list triggered the message was shown no matter what. However, the diagram says that white-listed messages can still be discarded if they match something from the black list, too. Is that intended?

All the best,

Contiki

It is intended as I believe that even though it passes our white list it still should be at the scrutiny of our black list and our repeat filter, e.g. "Anal [ITEM LINK]" or just plain repeating the same advert that passes our white list a million times without being blocked.

__________________
Author: TradeFilter, CheckFearWard and Bloodsurge

07-25-2009, 08:52 PM
Contiki A Kobold Labourer Forum posts: 0 File comments: 51 Uploads: 1	Greetings, thanks very much for adding this feature to TradeFilter! I've translated the new strings to German and downloaded r153. I'm going to test it with a guildie who's also using EverTrade and provide proper feedback as soon as I can. In the localizations' Activity Log you see I've changed one of the strings' translation temporarily to "Test" and back to its correct translation. I'm using Firefox here and am seeing a glitch where the localization text boxes are shown twice. The upper text box doesn't actually work. Though it took quite some time for me track that down as the reason why I couldn't translate any string. I've found the respective bug report and read there that the second box actually works. Had to verify that for myself hence the temporary "Test" and its change back to the right translation. As for the changes during the last revisions, I didn't notice any bugs or strange/unwanted behavior despite me monitoring the add-on's activity more or less closely. One thing I did notice, however, is in the filter priorities diagram. If I remember correctly the white list's purpose was to always allow certain messages. Once the white list triggered the message was shown no matter what. However, the diagram says that white-listed messages can still be discarded if they match something from the black list, too. Is that intended? All the best, Contiki __________________ Be prepared... to simplify your life.

Page 1 of 3

Report this File

Category Jump:

Support AddOn Development!

You have just downloaded by the author . If you like this AddOn why not consider supporting the author? This author has set up a donation account. Donations ensure that authors can continue to develop useful tools for everyone.

[Disable these notices]