Download
(17 Kb)
Download
Updated: 11-29-09 06:18 PM
Pictures
File Info
Updated:11-29-09 06:18 PM
Created:09-03-09 01:04 AM
Downloads:2,596
Favorites:27
MD5:
Tweaker
Version: 1.2.2
by: RaeVanMorlock [More]
Latest News

11/15

I republished my first Tweaker tutorial for the new site: http://www.tweakeraddon.com/tuts/modifying-the-viewport

There are some other tutorials listed in the menu, but they're not created yet. All the tut and doc stuff is still static at this point and it takes awhile to create.


11/1

Looking back at how big Tweaker grew with version 1.2, it struck me that some documentation is going to be handy. I certainly don't expect people to read through all the code in order to see what's available, but that's about all that you can do at the moment. Well, that, and using /dump can give a rundown of what's available -- /dump TweakerColorizer, for instance, will show all the properties and methods and what-not of that class.

But that's still a pain, so I'm working on the documentation. It's not polished yet, but the data for TweakerColorizer is up. Let me know what ya think.

http://tweakeraddon.appspot.com/docs/TweakerColorizer

I'm also in the process of getting http://www.tweakeraddon.com to work but these DNS and CNAME things can take up to 2 days to propagate.

Update
I had some fun with MooTools and made the menus on the doc page move up and down with the page, and I'm loving the results. If your browser window is too small to fit the entire menu, it gets really smart and only moves as needed, to either the top or bottom edge depending on the direction you scrolled.

I also said 50 Hail Marys and opened up IE to see how the page would look. I swear, that browser is the worst thing to happen to the web. I managed to get the menus moving just fine in IE8, but the code highlighting... well, it's not pretty. Apparently, IE normalizes their stored HTML, not just what's rendered, so when Javascript tries to access it, it gets the normalized version. This means when my script goes to parse the code, white space is all reduced to a single space character. That means not only can I not display line breaks and tabs, but I can't even detect them in order to know, say, when a comment ends.

Thank you, Microsoft, for saving me those precious bytes of memory.

Get a real browser

(Is it ironic that my IE just froze up?)


10/29

Tweaker 1.2 is being released today. It's been stable for quite some time for myself now, and the other features that are pending for Tweaker can wait for another version. My time has been scarce lately and it's already been far too long of a wait. The website will hopefully be more of a focus now as I try to get it going so that Tweaker can be better documented. In the meantime, feel free to browse the source code or use the /dump command to see what functionality is available.

/dump Tweaker
/dump TweakerColorizer
/dump TweakerLogger
/dump TweakerSlash

TWEAKER 1.2 CHANGELOG

File Structure

- Users will no longer be confined to creating their tweaks in config.lua. Tweaks can be made and registered to Tweaker at any time. As such, common tweaks will be able to be packaged and distributed. You may also want to consider making a MyTweaks addon for your custom tweaks. This change will add overhead, but I'll keep it as minimal as possible.

- config.lua will be loaded after Tweaker, so people using config.lua can make use of the Tweaker Global API (which will be more important now than before)

Development Tools

Coloring

- It's a common task, why not have a tool for it? I've found myself using it throughout various modules.

- TweakerColorizer:new() to instantiate, new() takes an optional table of name/color pairs, where name is any string and color is a series of 6 hexadecimal digits following standard notation, rrggbb, such that ffffff is white and 000000 is black. (I should probably update this in the future to take 6 or 8 digits so alpha can optionally be included.)

- Colorizers can be instantiated from other colorizers, and thus inherit their colors. So if a = TweakerColorizer:new() and a defines a color, burple, and b is a new colorizer created from a, such that b = a:new(), then b will also have access to burple and any other colors that a has, regardless of them being added before or after b's instantiation. You may also redefine colors on b to have them take precedence. You'll find that I frequently name colors in my modules according to functionality, so the Logger module has a color named trace that's used for trace messages. Anything inheriting from my logger module will also have a trace color that can then be set to whatever color the person wants to use for his/her trace messages.

- :Apply(color, string, ...) takes a color, by name, and applies it to the string. If additional arguments are included, string is assumed to be a formatstring, and string.format(formstring, ...) is called. If color is not the name of a defined color, it's treated as the color itself. The resultant string is returned.

- :RegexApply(color, regex, string, ...) Here, a regex pattern is also included. Any characters matching the pattern will have the color applied to them in the returned string result.

- Many more, check the files or /dump TweakerColorizer

Logging

- Enhanced logging features. I've borrowed the logging style used in the log4j java module to implement levels of logging. Tweaks will be able to define their own level of logging separate from the global default so users can get details on a particular tweak that they're working on and not every tweak in their repertoire.

- Tweaker itself will have more log messages than before, and users will be able to use Tweaker to generate logging messages for their tweaks.

- Log messages can be throttled. A global setting will be available to determine how often the same log message can be repeated, and disabling the setting will disable the throttling. (I'm not too sure about keeping this. Since trace messages can be somewhat generic and inferred by their context, the throttling can remove some that you expect to see when debugging.) Removed

- TweakerLogger is a new class that can be instantiated via TweakerLogger:new(). Users may use Tweaker's log via Tweaker.log or instantiate their own if need be.

Slash Command Handling

- TweakerSlashCommand:new() and TweakerSlashCommandHandler:new() to create a command and a handler, respectively.

- SlashCommand objects should have the following properties: commands (array of strings, such as "apples" or "oranges", to follow the base slash command), help (the help text to include when using the help command, briefly explaining what the command does, such as "gives the requested number of apples, defaults to 1"), args (the args that can be included after the command, such as "[<any digit>]" to say that any digit may optionally be included), call (the function to call when the command is requested by the user in order to process any arguments)

- call currently supports only one arguments, text, and it's up to the call function to interpret and parse the text, or throw an error.

- SlashCommandHandler objects should be defined with two properties: Name and Commands (notice the capitalization here). Name is how the handler will identify itself to the end user. For instance, "Tweaker." Commands is an array of slash commands, such as { "/tweaker", "/tweak" }

- All new SlashCommandHandler objects have a default help command, which can be called simply via /slash help or for detailed info via /slash help command.

/dump command

- Enhanced /dump command (can be turned off). I love that WoW finally includes its own /dump command, but I think it's ugly. I've created one similar to what AceConsole offers, but it's currently using 300-350 lines of code instead of the 2500-3000 lines that Ace uses.

The Tweaker Process

- Tweaks are no longer created at PLAYER_LOGIN. They are put into a queue and created as soon as all of their requirements are met: ie. Parent widget must exist, Template tweaks must have been processed, and Requirements widgets must all exist.

- Tweaker_Data has been removed. Use Tweaker.RegisterTweak({}) and Tweaker.RegisterTweaks({{}, {}, {}})

Tweak Attributes

Widget Names

- Tweaks will no longer be given a default name if one is not supplied, the resulting widget will just be unnamed and users will not be able to reference it. With the new structure, there is no simple top-to-bottom order of tweaks, so there's no way of consistently naming them. I might as well not bother naming them at all.

- Names are no longer assumed to be alphanumeric. The Widget API allows any character, so I figure I need to as well. I will not support tweaks with duplicate names though.

- Many properties are being redone for various reasons, although many are because of the change in names. The current shorthand will still be available (hopefully, maybe, for some things) for tweaks/widgets that don't use spaces in their name though, and I advise everyone to abide by the standard alphanumeric pattern for naming things.

Templating

- Template has been renamed to Templates (with an s) since, like Points, Textures, FontStrings, etc, it's designed to take a table. In this case, each item in the table should be the name of a tweak to inherit attributes from. Like with Points, the shorthand Templates = "BaseTweak" does work if there's only one tweak to inherit from (and it's likely less memory use).

- InheritsFrom has been added, and only applies to tweaks that are creating new objects. It specifies what standard WoW widget should be inherited from: CreateFrame(Type, Name, Parent, InheritsFrom)

Requirements

- Requirements has been added and works like Templates and Points in that it can be a table of string values or just a string if there's one value. Requirements are those widgets that must exist before the tweak can be processed. If you're creating a tweak for a widget that may not exist yet, you can specify as much with: { Name = "DelayedWidget", Requirements = "DelayedWidget" } -- the tweak won't be processed until the widget exists, at which point the tweak will apply itself to that widget instead of creating a new one.

Scripts/Functions

- OnLoad is no longer called as soon as a tweak is processed. Instead, Startup is a new supported attribute of tweaks, and defines a function to call at this same point in time.

Timers

- Timers is a new attribute, and defines a list of timers. The advantage here is that there's a single function handling timer execution, the user doesn't need to track elapsed time manually every place that a periodic event is needed.
Code:
Timers = {
  {
    Name = <string>,
    Interval = <number>,
    Function = <function (self, elapsed)>
  },
  {
    Name = <string>,
    ...
  },
  ...
}
Name is optional and currently doesn't have a use. Interval defaults to 0, which means to repeat as often as possible. Function is called whenever the elapsed time meets or exceeds the Interval and then elapsed time is reset.

Custom Attributes

- Custom attributes can no longer be defined in the main area of the Tweak. Instead, the CustomAttributes attribute has been defined and can hold any custom data that needs to be propagated to the widget.
Code:
{
  Name = "MyTweak",
  CustomAttributes = {
    myBool = true,
    myInt = 2,
    myFunc = function() end,
    ...
  },
  ...
}
The resulting widget will have the CustomAttributes accessible at its base level, MyTweak.myBool, MyTweak.myInt, myTweak.myFunc, etc.



DESCRIPTION
Tweaker is the public start of an experiment in addon design. I love having options, but giving options to addons is a complicated process. Libraries have been written to simplify things for addon authors, but the mechanics behind them are still rather involved. I currently have over 200 folders in my AddOns directory. I have over 30 megs of SavedVariable files for my main toon. I need a change, and I imagine others do as well (for more of my thoughts on this, please visit my blog post entitled New Addon Design).

When it comes to the appearance of something, I want as many options available to me as the WoW Widget API will allow. Obviously, it's not practical to include that many settings in any addon. I started to use panel addons to give myself some flexibility. I couldn't modify existing things, but I could create panels, and they looked neat.

Tweaker started off that way. Like other panel addons, it could create panels of varying sizes and colors. Images and text could be added. Unlike many though, multiple images and text strings could be added to a single panel. Everything could be positioned not with just a single anchor, but with many anchors. It grew to the point that the entire widget API was exposed. I was only using half as much memory as my previous panel addon, but I still wanted more out of it.

So I added event handling. It was simple to do, and simpler to use. With panels being able to respond to events, they could change dynamically. I had been using a LDB display plugin along with a data plugin to display my current zone somewhere other than over the minimap. I decided to use Tweaker to create a frame for it instead. My own code ended up with a much smaller memory footprint (virtually none) and it was able to change the color of the text based on if the area was friendly, hostile, neutral, or whatever just like the tooltip for the minimap's zone panel. I also have it designed to show both the primary and sub zone names. Well, there's one addon I can get rid of now.

I moved on to create one for showing my coordinates. Got rid of an old addon for that. Another for the current time. And dropped another addon.

I then figured I could create buttons just as easily as panels, so I made a button for my calendar, and an icon for my mail. I also wanted a way to easily see if I was at the defense minimum and if I was hit or expertise capped, so I created a panel for that info too.

All these things are currently in my screenshot on the right. The arrow is from TomTom, and it fits quite nicely where it is. I plan to add more later.

None of these things were difficult to do, but this addon isn't for everyone either. It's not user friendly. It will take me time to write up appropriate documentation. I also intend on writing a number of tutorials for the things I've mentioned above, and more. But if you're like me and you like to tweak things, give Tweaker a try. Leave comments with any questions or suggestions you have, and I'll try to get some documentation and tutorials out as quickly as I can.

Some important notes for the time being:
- If you supply the name of an existing UI element, tweaker will operate on that element instead of creating a new one.
- If you declare an element with Virtual = true listed in its properties, it will not be created in the game but will instead remain "virtual" (this is handy for inheritance)
- For any element, you can create a Templates property. This property takes an array of elements (by name) to inherit from. Example: Templates = { "BasePanel", "TextPanel" } will inherit the properties of BasePanel and then those of TextPanel. Only properties that aren't defined in the inheriting tweak are inherited.
- There's not much error checking. That adds overhead that I'd prefer to avoid. If you do mess things up, a simple reloadui should fix them. There is some logging by calling Tweaker:SetGlobalLogLevel(level) where level can be "trace", "debug", "info", "warn", "error", or "fatal" -- all higher levels are also logged and tweak-specific levels can be declared by setting the LogLevel property of a tweak to one of the above levels as well.

DIRECTIONS
- Download and extract to Interface\Addons like normal
- In the Tweaker folder, create a file named config.lua
- In config.lua, call Tweaker:RegisterTweaks with an array of tables
- Populate the tables in a manner similar to the example below

EXAMPLE config.lua
Code:
Tweaker:RegisterTweaks({
    {
        Name = "SamplePanel",
        Parent = "UIParent",
        FrameStrata = "BACKGROUND",
        FrameLevel = 2,
        Points = {
            "CENTER",
        },
        Width = 200,
        Height = 50,
        Textures = {
            {
                Name = "$parentBorder",
                DrawLayer = "BACKGROUND",
                Texture = "0.12 0.12 0.12",
                Points = {
                    "TOPLEFT -3 3",
                    "BOTTOMRIGHT 3 -3",
                },
            },
            {
                Name = "$parentBackground",
                DrawLayer = "BORDER",
                Texture = "0.05 0.05 0.05",
                Points = "ALL",
            },
        },
        FontStrings = {
            {
                Name = "$parentText",
                Font = "Fonts\FRIZQT__.TTF 12 OUTLINE",
                JustifyH = "CENTER",
                JustifyV = "MIDDLE",
                Points = "ALL",
                Text = "Sample",
            },
        },
    },
})
1.2.2
- Backdrop now works -- every other widget API call I've seen takes a set of arguments but this one takes a table, hooray for consistency
- Consequently, I also put some dirty code in so that BackdropColorand BackdropBorderColor are called after Backdrop -- otherwise they don't work. It's messy and they actually get called twice now and I'm sure there are more scenarios that will need similar behavior but it'll do for now until I get some standardized code in to handle these scenarios.


1.2.1
- Added some additional tweaker-level logging
- Fixed the logger to colorize its messages
- Fixed Tweaker.util.unpack_if_table to return all unpacked values instead of just the first -- this consequently fixes some other issues, such as requiring all templates and requirements properly instead of just the first in each list


1.2.0

Core

- Instead of creating tweaks in Tweaker_Data, tweaks can now be created and registered via Tweaker:RegisterTweak or Tweaker:RegisterTweaks at any time. This creates the possibility to package tweaks as separate addons and avoids the chance of me accidentally packaging config.lua and overwriting yours. config.lua can still be used, but Tweaker_Data is no longer read from.

Coloring

-


1.1.2
* Fixed a bug that I apparently imagined fixing before -- provided you define a font, Tweaker should set it before trying to set text now. Thanks kellewic.

1.1.1
* First of many oversights, I'm sure. If you RegisterForDrag but don't SetMovable, then you get an error! Joy of joys... I've updated Tweaker to also call SetMovable(true) when defining a drag event.

1.1.0
* Added SecureHooks functionality. SecureHooks = { funcName = function() end } will create a secure hook to an existing function on an existing widget.
* Added DragEvent detection. When creating OnDragStart and OnDragStop events, Tweaker will automatically call RegisterForDrag("LeftButton"). If you want to drag with other buttons, it's up to you to handle that.
* Reworked the way that properties are handled from the config. Previously, any property was assumed to be an existing function on the widget, Parent = frame:SetParent(value), Hide = frame:Hide(), etc. Tweaker now supports custom properties so users can do MyCoolFunc = function() end and have widget.MyCoolFunc exist. Also works with scalars. MyCoolString = "hello!" will create widget.MyCoolString.
Optional Files (0)


Archived Files (6)
File Name
Version
Size
Author
Date
1.2.1
16kB
RaeVanMorlock
11-29-09 11:24 AM
1.2.0
16kB
RaeVanMorlock
10-29-09 11:04 PM
1.1.2
3kB
RaeVanMorlock
09-15-09 11:38 PM
1.1.1
3kB
RaeVanMorlock
09-08-09 04:59 PM
1.1.0
3kB
RaeVanMorlock
09-08-09 03:53 PM
1.0.0
3kB
RaeVanMorlock
09-03-09 01:04 AM


Post A Reply Comment Options
Unread 11-30-09, 01:56 AM  
Lonny
Guest

Join Date: Not Yet
Forum posts: 0
File comments: 0
Uploads: 0
I think it's awesome! keep up the good work, it's going to be very interesting.
Report comment to moderator  
Edit/Delete Message Reply With Quote
Unread 09-24-09, 05:45 PM  
Ahm
A Fallenroot Satyr
AddOn Author - Click to view AddOns

Forum posts: 20
File comments: 83
Uploads: 7
Tweaker Beta 1

The first beta of Tweaker is now available on the main page. As such, I've removed the link to the Dump package since I don't want to maintain two identical sets of code.

The Tweaker 1.2 Changelog has also been updated and formatted a bit nicer.

It's worth noting (somewhere, might as well be here) that:
- /dump now displays decimal numbers instead of rounding off to the nearest whole number
- /dump now has a (roughly) 5 second timeout, at which point it will stop generating output, in order to avoid freezing wow
- /dump now tracks what tables it's dumped, and will only give the header of a table that's been dumped in the same /dump command

If you hadn't guessed, I managed to create and dump a table that had a reference to itself. The timeout was my attempt to stop wow from crashing -- which allowed me to see the output and spot the self-reference and prompt the third change.
Ahm is offline Report comment to moderator  
Reply With Quote
Unread 09-22-09, 03:55 AM  
Ahm
A Fallenroot Satyr
AddOn Author - Click to view AddOns

Forum posts: 20
File comments: 83
Uploads: 7
Tweaker update

Two brief but nice updates for the dump package:

- dumping nested tables looks better now

I wasn't sure if it would work at all since I hadn't tested it yet, but while debugging today, I dumped a table that had nested tables in it. I think I want to change the way that works, but at least it's prettier for the time-being.

- /dump 1, 2, 3, 4, 5 works now

Yup, dump now supports multiple values. /dump unpack({1, 2, 3}, 2) kept dumping 2 and I wasn't sure if it was really just returning a single value or if it was working like select(2, unpack({1, 2, 3}) so I had to find out -- turns out the latter was the right answer



In order to iterate through keys of a table, it's best to supply the table as the only argument. Repeated calls to /dump WorldMapFrame, 1 will only ever show you the first 20 (or however many you set) keys of WorldMapFrame because it's then dumping 1 so on the next call to dump WorldMapFrame, the last dumped value was 1 -- not WorldMapFrame. I might consider changing this behavior if I can find a real need for it, but I don't see that happening.

As an FYI, consider table = { nested_table = { ... }, ... } -- repeated /dump table calls will iterate over table, not nested_table, but nested_table's keys will iterate as a side-effect. If nested_tables has more keys than table, you won't be able to see them all. If it has less, it might loop oddly. This is why I wanted to change the way it currently works, but my quick fix didn't work so it'll have to wait. The proper way to iterate over the keys in nested_table would be to /dump table.nested_table



As for Tweaker itself...

I need to finish Template inheritance, add a few new features, and do some major code cleanup. Then the testing shall commence. I'll likely open testing of the full package up to the community like I did for the dump command for anyone that's interested. It's big enough that I could use the help.

And then I have two more utilities that I want to create and package in with it -- one is a rewrite of /framestack because Blizz's version is broken (anyone else ever notice that? it's like the offsets are wrong), and the other is something I've never seen anyone offer before. I think it'll be pretty neat and fun to play with, and I got the proof of concept working earlier today so I'm pretty confident that I can get it in there for 1.2.

If you're curious (I was), the current version of Tweaker is 10,148 bytes of code. The new one is 39,522 bytes and counting. There's also been about 80-90 KB of code written for the upcoming site so far... so yes, I have been quite busy.

Performance-wise, 1.2 is noticeably heavier, but I don't think it's too bad so far and there's still some optimization to do. A clean install without any tweaks to register is currently using 49.65 KB of memory and 1-5 ms of cpu time every minute. Those numbers are up from roughly 0.08 KB of memory and 0 ms of CPU in the current version. The changes are worth it, but I'll still see what I can do about it.



The progress on the main page has also been updated recently with the following:

-- Development Tools --

- Log messages can be throttled. A global setting will be available to determine how often the same log message can be repeated, and disabling the setting will disable the throttling.

-- Tweak Properties --

- Names are no longer assumed to be alphanumeric. The Widget API allows any character, so I figure I need to as well. I will not allow tweaks with duplicate names though.

- Many properties are being redone for various reasons, although many are because of the change in names. The current shorthand will still be available for tweaks/widgets that don't use spaces in their name though, and I advise everyone to abide by the standard alphanumeric pattern for naming things.
Last edited by Ahm : 09-22-09 at 04:03 AM.
Ahm is offline Report comment to moderator  
Reply With Quote
Unread 09-21-09, 03:20 PM  
Ahm
A Fallenroot Satyr
AddOn Author - Click to view AddOns

Forum posts: 20
File comments: 83
Uploads: 7
Blizzard, you disappoint me

Did you know widget names can contain spaces? In fact, "@)!#$*@ #)$( @_).:12938-1 sldkjf23 - -= [;,/" is a valid name. In fact, "WorldMapFrame" is a valid widget name... even though it's already taken. Consider this:

Code:
_G.WorldMapFrame = nil
CreateFrame("FRAME", "WorldMapFrame")
Ya know what that does? Well, everything that used to affect Blizz's WorldMapFrame... it now affects yours. Makes it pretty much impossible to open it up.

CreateFrame basically does something like this:
Code:
function CreateFrame(type, name, parent, inheritsFrom)
  -- Create it however
  _G[name] = _G[name] or newlyCreatedFrame
So yeah, you can have 1000 widgets all of the same type and name if you really want to. Whichever is made first will get the slot in _G. But if you nil that, then whatever one is made next gets it. Trippy, huh?

Of course that's assuming you supply a name. _G[nil] isn't valid so it won't even try it then.

Here's a fun addon:
Code:
for k,v in pairs(_G) do _G[k] = nil end
Yup, I tried that out. Everything became completely unresponsive... I'd click action buttons and they'd stay highlighted, no cast. The edit box on the chat wouldn't go away so any key presses just went there (bummer!). I considered closing it in code, but it no longer had a global reference so that was a no go. I could scroll the chat with those buttons... but I couldn't use my menu. I couldn't even move or turn my character.

Oh boy...

Here's a fun project: create an addon that doesn't break when that code is ran! People should be using locals anyhow... they're faster.

Anyhow, I'm going to have to rethink basically every assumption I made when writing this addon.
Ahm is offline Report comment to moderator  
Reply With Quote
Unread 09-19-09, 06:37 PM  
Ahm
A Fallenroot Satyr
AddOn Author - Click to view AddOns

Forum posts: 20
File comments: 83
Uploads: 7
Tweaker-Dev-Dump update

Another update.

While fixing the iif() issue, I realized I was only accounting for string/number keys. They're certainly the majority, but there are other types.

Code:
/dump { [false] = 1, [true] = 2, [1] = 3, [2] = 4, ["string1"] = 5, ["string2"] = 6, [CreateFrame] = 7, [function() end] = 8, [string.find] = 9, [Minimap] = 10, [string] = 11, [{}] = 12 }
The above now works. I'm not sure how to create thread and userdata objects so I can't test them. If anyone could help me out here, I'd appreciate it.

I know widgets have userdata.. for instance, WorldFrame[0] is a userdata object... but still not sure how to just simply create them so I can play around and test them. I don't want to mess with the widgets.

In the meantime, trying to dump userdata or thread objects will just output "userdata" or "thread" as appropriate.

Oh, I made the code a bit more organized too. God that was messy before.

Anyhow.. this was a fun update. Enjoy it!
Ahm is offline Report comment to moderator  
Reply With Quote
Unread 09-19-09, 03:34 PM  
Ahm
A Fallenroot Satyr
AddOn Author - Click to view AddOns

Forum posts: 20
File comments: 83
Uploads: 7
iif() fail

So... there's a problem with iif() now

Using <condition> and <valueA> or <valueB>

The values are only calculated if they need to be, so everything is happy.

Using iif().. everything is calculated right away in order to send the results to the function... so a < b doesn't work so well anymore when a and b are not the same type.

You may not want to download the current package just yet...
Ahm is offline Report comment to moderator  
Reply With Quote
Unread 09-19-09, 02:42 PM  
Ahm
A Fallenroot Satyr
AddOn Author - Click to view AddOns

Forum posts: 20
File comments: 83
Uploads: 7
Tweaker-Dev-Dump update

The Tweaker-Dev-Dump package has been updated again.

I had a hunch that /dump _G was freezing up WoW because of get_global_name... I haven't taken the time to really analyze the code, but that was my hunch, and I made code changes so that it would do things slightly differently when dealing with _G in order to account for it.

Happy to say, /dump _G works now.

There's about a one second delay or so on my system... I imagine it takes time to grab and sort over 30,000 keys... but it's certainly bearable if you really need to dump _G. Interestingly, whether I dump 20 values or 200 at a time, the delay seems to be about the same. I imagine that could be worse if I figure out how to have function dumps include more info.. but I like to keep the default at 20 anyhow or else you're scrolling way up just to scroll back down through the list. An even smaller value might be better so you don't have to scroll at all... but that's why it's a global.. so you can decide for yourself through Tweaker.DumpSize.

Ciao!
Last edited by Ahm : 11-02-09 at 09:21 AM.
Ahm is offline Report comment to moderator  
Reply With Quote
Unread 09-18-09, 11:11 PM  
Ahm
A Fallenroot Satyr
AddOn Author - Click to view AddOns

Forum posts: 20
File comments: 83
Uploads: 7
Re: Re: Re: Nice update

Originally posted by kellewic
Running /dump through its paces and got:

Code:
[2009/09/18 20:13:14-322-x1]: Tweaker-Dev-Dump\Tweaker-Dev-Dump.lua:110: invalid order function for sorting
...
What I did was the following in-game:

Code:
/run LL = {1,2,3,4,5}
/tweaker dump LL
So I'm a big fan of the iif shorthand.. which equates to: val = <condition> and <valueA> or <valueB> in lua... but, apparently, not exactly.. because if valueA is false, then it sends valueB.. even if the condition was true.

So in the following:
Code:
local function get_sorted_keys(...)
    local keys, keyCount = get_keys(...)
    table.sort(keys, function(a,b)
        local ta,tb = type(a),type(b)
        return ta==tb and a < b or ta=="number"
    end)
    return keys, keyCount
end
.. obviously had some problems with {1, 2, 3, 4} -- essentially, the types always matched, but if a < b, it'd still return true because ta=="number" -- so everything was less than everything else... and the sort epic failed.

I'll probably make my own iif() function for future use, but for now.. make the fix yourself or download the updated copy from the main page (same url as before).

Thanks!!

Code:
local function get_sorted_keys(...)
    local keys, keyCount = get_keys(...)
    table.sort(keys, function(a,b)
        local ta,tb = type(a),type(b)
        if ta==tb then
            return a < b
        end
        return ta=="number"
    end)
    return keys, keyCount
end
Ahm is offline Report comment to moderator  
Reply With Quote
Unread 09-18-09, 10:02 PM  
kellewic
A Defias Bandit
 
kellewic's Avatar
Premium Member
AddOn Author - Click to view AddOns

Forum posts: 2
File comments: 128
Uploads: 3
Re: Re: Nice update

Originally posted by RaeVanMorlock
Thanks, kell!

The Tweaker site isn't ready for public release yet, but, since it is up on the web, I took the opportunity to learn how to deliver .zip files from it so anyone interested can just grab the zip: http://tweakeraddon.appspot.com/Tweaker-Dev-Dump.zip

The link is also on the main page now. I might make more packages like this in the future, so be sure to check the main page for their announcements.

Gosh, when did the sun go down? I wish I had music to listen to while I work instead of movies to watch.. it'd probably be less distracting.
Running /dump through its paces and got:

Code:
[2009/09/18 20:13:14-322-x1]: Tweaker-Dev-Dump\Tweaker-Dev-Dump.lua:110: invalid order function for sorting
Tweaker-Dev-Dump\Tweaker-Dev-Dump.lua:110: in function <...terface\AddOns\Tweaker-Dev-Dump\Tweaker-Dev-Dump.lua:108>
Tweaker-Dev-Dump\Tweaker-Dev-Dump.lua:143: in function <...terface\AddOns\Tweaker-Dev-Dump\Tweaker-Dev-Dump.lua:117>
(tail call): ?:
Tweaker-Dev-Dump\Tweaker-Dev-Dump.lua:181: in function `Dump'
<string>:"Tweaker.Dump( {1,2,3,4})":1: in function `f'
Tweaker-Dev-Dump\Tweaker-Dev-Dump.lua:208: in function `value'
Interface\FrameXML\ChatFrame.lua:3529: in function `ChatEdit_ParseText':
Interface\FrameXML\ChatFrame.lua:3177: in function `ChatEdit_SendText':
Interface\FrameXML\ChatFrame.lua:3201: in function `ChatEdit_OnEnterPressed':
<string>:"*:OnEnterPressed":1: in function <[string "*:OnEnterPressed"]:1>
What I did was the following in-game:

Code:
/run LL = {1,2,3,4,5}
/tweaker dump LL
__________________
Kellewic - 80 Warlock - Ghostlands
kellewic is offline Report comment to moderator  
Reply With Quote
Unread 09-17-09, 09:18 PM  
Ahm
A Fallenroot Satyr
AddOn Author - Click to view AddOns

Forum posts: 20
File comments: 83
Uploads: 7
Re: Nice update

Originally posted by kellewic
Nice update on the front page

If you have any code you want tested, shoot me an email and I'd be happy to check it out.
Thanks, kell!

The Tweaker site isn't ready for public release yet, but, since it is up on the web, I took the opportunity to learn how to deliver .zip files from it so anyone interested can just grab the zip: http://tweakeraddon.appspot.com/Tweaker-Dev-Dump.zip

The link is also on the main page now. I might make more packages like this in the future, so be sure to check the main page for their announcements.

Gosh, when did the sun go down? I wish I had music to listen to while I work instead of movies to watch.. it'd probably be less distracting.
Ahm is offline Report comment to moderator  
Reply With Quote
Unread 09-17-09, 08:02 PM  
kellewic
A Defias Bandit
 
kellewic's Avatar
Premium Member
AddOn Author - Click to view AddOns

Forum posts: 2
File comments: 128
Uploads: 3
Nice update

Nice update on the front page

If you have any code you want tested, shoot me an email and I'd be happy to check it out.
__________________
Kellewic - 80 Warlock - Ghostlands
kellewic is offline Report comment to moderator  
Reply With Quote
Unread 09-15-09, 11:35 PM  
Ahm
A Fallenroot Satyr
AddOn Author - Click to view AddOns

Forum posts: 20
File comments: 83
Uploads: 7
Re: Font issue

Originally posted by kellewic
...

I end up with an error on Tweaker trying to build up kell_Coords1Text since it is trying to call $parentText:SetText("TEST") before assigning the Font to the FontString. Since there is no assigned font, it can't set a text value.

This means Tweaker will have to ensure a Font is assigned before SetText is called.
Hm.. I thought I had accounted for that. Thanks for the report. I'll release 1.1.2 in a bit to fix it. *fingers crossed*
Ahm is offline Report comment to moderator  
Reply With Quote
Unread 09-15-09, 10:24 PM  
kellewic
A Defias Bandit
 
kellewic's Avatar
Premium Member
AddOn Author - Click to view AddOns

Forum posts: 2
File comments: 128
Uploads: 3
Font issue

Found a potential problem with FontStrings. I have the following configuration:

Code:
local tweakName = "kell_Coords"

Tweaker:RegisterTweak({
	Name = "kell_BasePanelTemplate",
	Virtual = true,
	Width = 80,
	Height = 13,
	Points = {"CENTER"},
	ClampedToScreen = true,
	Textures = {
		{
			DrawLayer = "BACKGROUND",
			Texture = "0 0 0",
		},
	},
	FontStrings = {
		{
			Name = "$parentText",
			Font = "Fonts\\FRIZQT__.ttf 10",
		},
	},
	Events = {			
		OnDragStart = true,
		
		OnDragStop = function(self)
			self:StopMovingOrSizing()
			--save_points(self)
		end,
		
		PLAYER_LOGIN = function(self)
			--get_coords()
			--set_points(self)
		end,
	},
})

Tweaker:RegisterTweaks({
	{
		Template = "kell_BasePanelTemplate",
		Debug = true,
		Name = tweakName,

		FontStrings = {
			{
				Name = tweakName .. "Text",
				Font = "Fonts\\FRIZQT__.ttf 10",
			},
		},
	},

	{
		Template = "kell_BasePanelTemplate",
		Debug = true,
		Name = tweakName .. "1",
		FontStrings = {
			{
				Name = "$parentText",
				Text = "TEST"
			},
		},
	}
})
I end up with an error on Tweaker trying to build up kell_Coords1Text since it is trying to call $parentText:SetText("TEST") before assigning the Font to the FontString. Since there is no assigned font, it can't set a text value.

This means Tweaker will have to ensure a Font is assigned before SetText is called.
__________________
Kellewic - 80 Warlock - Ghostlands
kellewic is offline Report comment to moderator  
Reply With Quote
Unread 09-13-09, 10:47 PM  
Ahm
A Fallenroot Satyr
AddOn Author - Click to view AddOns

Forum posts: 20
File comments: 83
Uploads: 7
Re: Re: Re: Re: Re: Event

Originally posted by kellewic
I noticed there is a bug in the code I emailed:

Code:
local noop = function end
should be:

Code:
local noop = function() end
I've been up like 36 hours now so...
Lol, yes, I found it. No worries.

I emailed you back a little while ago. About to start some testing and see where I want to start with this lengthy list of changes.

Get some sleep!
Last edited by Ahm : 09-13-09 at 10:47 PM.
Ahm is offline Report comment to moderator  
Reply With Quote
Unread 09-13-09, 07:44 PM  
kellewic
A Defias Bandit
 
kellewic's Avatar
Premium Member
AddOn Author - Click to view AddOns

Forum posts: 2
File comments: 128
Uploads: 3
Re: Re: Re: Re: Event

Originally posted by RaeVanMorlock
Well I'm glad to see somebody enjoying Tweaker

That's definitely taking it further faster than I had planned, but I like it. I appreciate it.

In fact, it's inspired me to reevaluate Tweaker at this stage in development. It's a long post, but I've written about the birth of tweaker and expressed what's going through my mind at this juncture. I'd really appreciate some feedback from you and everyone visiting these comments... either leave your thoughts here or on the blog, it doesn't matter.

I think 1.2 is going to be very big for Tweaker.
I sent you an email; had too much to say


EDIT

I noticed there is a bug in the code I emailed:

Code:
local noop = function end
should be:

Code:
local noop = function() end
I've been up like 36 hours now so...
__________________
Kellewic - 80 Warlock - Ghostlands
Last edited by kellewic : 09-13-09 at 08:14 PM.
kellewic is offline Report comment to moderator  
Reply With Quote
Post A Reply



Category Jump: