Minion Beta! - Help us test our new AddOn updater. Get it now!
Download
(114 Kb)
Download
Updated: 11-25-14 05:03 PM
Pictures
File Info
Compatibility:
Warlords of Draenor Pre-Patch (6.0.3)
Updated:11-25-14 05:03 PM
Created:01-30-12 09:23 AM
Downloads:5,277
Favorites:89
MD5:
Categories:Character Advancement, Utility Mods
6.0.3

Faction Addict  Popular! (More than 5000 hits)

Version: 1.25
by: gmz323 [More]

Description:
Faction Addict is a stand-alone addon that provides additional faction information to your characters working towards faction based achievements. Intended for those players who work on gaining exalted with many factions but also helpful to those that do not. There are in game achievements for being exalted with 1, 5, 10, 15, 20, 25, 30, 35, 40, 45, 50, 55, and 60 factions respectively.

Faction Addict also provides a reputation logging system that allows the player to see what reputation gains they have made in the current and previous sessions.

Use slash commands /fa or /factionaddict or click the new button on the upper right corner of your characters reputation panel to open and/or close the addon window.


Usage: (slash commands)

  • /fa
  • /factionaddict
  • *click button* on upper right corder of character's reputation page
Features:
  • Factions - Shows all factions - including those not "known" by your character.
  • Log - Reputation gain logging - shows reputation gains your characters has made in the current and previous sessions.
  • Faction info panel - click on a faction in the addon to see more specific info.
  • Exalted Count - Shows count of exalted factions and how many required for next achievement.
  • Exalted Achievements Tooltip - Show which character earned which achievement on what date
  • Display Ordering - Faction display can be ordered by % to exalted or faction name.
  • Display Filters - Faction display can be filtered by standing, expansion, alliance/horde only.
  • Auto-Change Reputation Bar - reputation bar will auto-change to faction that had last gain
  • Hide Inactive Factions - Faction display will hide any factions your mark as inactive in the default reputation ui. (Click 'Move to Inactive')
  • Search - click the search icon to toggle the input field to search the factions
Localizations:

Files are in place for basic localization support. If you would like to help complete the Faction Addict localizations please contact us!


In the FactionAddict\Locales addon folder are the following files for localization. They should be your starting point if you want to help out.
  • enUS.lua - english client (complete!)
  • deDE.lua - deutsch client (complete! Thanks Harry!)
  • esES.lua - spanish client
  • frFR.lua - french client


Official Homepage:My Other Addons:
  • Tabard Addict - tracks how many tabards have been equipped for the various tabard achievements.
  • Below Average Items - puts indicators on low level items on character sheet.
Changelog:
  • See 'Change Log' tab for details of each revision.
  • Lastest Version: v1.25 (2014-11-25)

v1.25 (2014-11-25)
------------------
* BUGFIX: Auto-Change Reputation Bar - auto-change would not work if the Faction Addict window had not been opened prior to there being a CHAT_MSG_COMBAT_FACTION_CHANGE event. (for example - 'Reputation with Lower City increased by 300.' in the chat) Changed to make sure required data is loaded prior to addon window being opened.

v1.24 (2014-11-12)
------------------
* NEW: Key Bindings support - you can now setup a custom keybinding to open/close Faction Addict via the 'AddOns' category of the Key Bindings menu in-game.
* Enjoy Warlords of Draenor everyone!

v1.23 (2014-11-11)
------------------
* NEW FEATURE: a search feature has been added to the main factions tab. Click the search icon in the top right of the addon (next to standing filter) to toggle the search field

v1.22 (2014-10-28)
------------------
* BUGFIX: exalted achievements tooltip - there was a case where character name was not returned by server when getting achievement data causing the name to be blank () in tooltip. This usually occurs on lower lever characters with few addons where the character loads into the game very quickly.

v1.21 (2014-10-27)
------------------
* German Localization Added - All credit and thanks to Harry! for submitting the changes for the german [deDE] localization.
* Exalted Achievements Tooltip UPDATED! - Now more easily tell which character on your account earned which exalted achievement and the date it was earned. To show this summary tooltip hover the mouse over the Next/Shown/Exalted text at the bottom of the main addon tab.

v1.20 (2014-10-24)
------------------
* BUGFIX: fix for error 'attempt to concatenate local faction a nil value' - lua error when the first reputation gain of the sessions was for your guild

v1.19 (2014-10-14)
------------------
* BUGFIX: fix for error 'attempt to concatenate upvalue lfgBonusFactionID' if you were seeing that one

v1.18 (2014-10-14)
------------------
* Added 'Star' indicator from default UI to support LFG Bonus Faction
* [ESC] will now close the addon with all other UI elements.
* Clean up some unnecessary table allocations.
* Force data update on PLAYER_LOGIN event - client was not getting all faction data on initial addon load
* Other minor bugfixes

v1.17 (2014-09-19)
------------------
* Add config option for display of Warlords of Draenor factions.
* Add new Warlords of Draenor and Barracks Bodyguards factions.

v1.16 (2014-09-17)
------------------
* WoW version 6.0 compatibility release.

v1.15 (2013-09-15)
------------------
* Added Emperor Shaohao faction
* Order/Filter modes updated to support game changes to Tillers subfactions (Ella, Gina Mudclaw, Jogu, etc...)

v1.14 (2013-09-10)
------------------
* Updated for WoW 5.4

v1.13 (2013-05-21)
------------------
* Updated for WoW 5.3

v1.12 (2013-04-06)
------------------
* New Feature! - Auto-Change Reputation Bar - reputation bar will now auto-change to faction that had last gain, not including your guild faction gains. This feature can be turned on/off via the config tab.
* New Feature! - Hide Inactive Factions - Faction display will hide any factions your mark as inactive in the default reputation ui. (Click 'Move to Inactive') This feature can be turned on/off via the config tab.
* Much credit to Phanx for help on this update. Thanks Phanx!

v1.11 (2013-03-28)
------------------
* Added indicator on reputation bars for account wide 'bonus reputation'. This is the bonus unlocked when you buy the various Grand Commendations from faction quartermasters. (Same indicator as used in the default ui)
* NOTE - 'Champion a faction' star indicators still to be added in future release

v1.10 (2013-03-05)
------------------
* Updated for client 5.2
* Added new factions - Shado-Pan Assault, Sunreaver Onslaught, and Kirin Tor Offensive
* NOTE! - Indicators for account 'Bonus Reputation and 'Champion a faction' will be added in future release.

v1.09 (2012-12-3)
------------------
* Added new 5.1 factions - Dominance Offensive, Operation: Shieldwall, and Akama's Trust.

v1.08 (2012-11-28)
------------------
* update toc for client 5.1

v1.07 (2012-10-20)
------------------
* Minor tweaks to layout of faction logos.

v1.06 (2012-8-28)
------------------
* Changes to support Mists of Pandaria, client 5.0.4.
* Added many new factions identified in MoP. More sorting and config options will be added for them in the future.

v1.05 (2012-4-16)
------------------
* (bugfix) Fix generic reputation gain case where reputation gain message didn't include a value. - ie "Reputation with FACTION increased" instead of "Reputation with FACTION increased by VALUE".
* (bugfix) Fix reputation gains that include a "refer-a-friend" bonus in chat message.

v1.04 (2012-3-7)
------------------
* Added new tooltip containing list of all the exalted reputation achievements. Tooltip is shown when mouse over "Next Achievement" text at bottom of addon.

v1.03 (2012-2-20)
------------------
* increased reputation logging to hold more previous days of reputation gains
* changes to make addon more localization friendly in the future
* fixed refresh issue with info panel

v1.02 (2012-2-1)
------------------
* (bugfix) Fix handling of guild name faction on character load.

v1.01 (2012-01-30)
------------------
* Initial release of Faction Addict
Archived Files (22)
File Name
Version
Size
Author
Date
1.24
114kB
gmz323
11-12-14 09:07 AM
1.23
113kB
gmz323
11-11-14 08:29 AM
1.22
109kB
gmz323
10-28-14 08:51 AM
1.21
109kB
gmz323
10-26-14 05:33 PM
1.20
108kB
gmz323
10-24-14 10:34 AM
1.19
108kB
gmz323
10-14-14 02:21 PM
1.18
108kB
gmz323
10-14-14 08:05 AM
1.15
104kB
gmz323
09-15-13 08:17 AM
1.14
104kB
gmz323
09-10-13 06:00 AM
1.13
104kB
gmz323
05-21-13 07:15 AM
1.12
104kB
gmz323
04-06-13 09:50 AM
1.11
102kB
gmz323
03-28-13 08:12 AM
1.10
101kB
gmz323
03-05-13 09:32 AM
1.09
101kB
gmz323
12-03-12 08:44 AM
1.08
101kB
gmz323
11-28-12 07:08 AM
1.07
101kB
gmz323
10-21-12 08:09 AM
1.06
101kB
gmz323
08-28-12 05:24 AM
1.05
99kB
gmz323
04-16-12 01:07 PM
1.04
99kB
gmz323
03-07-12 08:58 AM
1.03
98kB
gmz323
02-20-12 09:07 AM
1.02
94kB
gmz323
02-01-12 10:08 AM
1.01
94kB
gmz323
01-30-12 09:23 AM


Post A Reply Comment Options
Unread 10-24-14, 06:30 AM  
gmz323
A Kobold Labourer
 
gmz323's Avatar
AddOn Author - Click to view AddOns

Forum posts: 1
File comments: 46
Uploads: 3
Re: Bug! AAIGH!!

Thanks Barleduq! I should have a release to address this later today.


Originally Posted by Barleduq
Sorry. I'm late and it's tired.

Just clicked the bucket in Area 52, got this error.

Thank you!
gmz323 is offline Report comment to moderator  
Reply With Quote
Unread 10-24-14, 12:00 AM  
Barleduq
Ruler of All I Survey
 
Barleduq's Avatar

Forum posts: 63
File comments: 273
Uploads: 0
Bug! AAIGH!!

Sorry. I'm late and it's tired.

Just clicked the bucket in Area 52, got this error.

Thank you!

Code:
Date: 2014-10-24 02:24:31
ID: 3
Error occured in: Global
Count: 1
Message: ..\AddOns\FactionAddict\FactionAddict.lua line 1715:
   attempt to concatenate local 'faction' (a nil value)
Debug:
   FactionAddict\FactionAddict.lua:1715: FactionAddict_OnEvent()
   [string "*:OnEvent"]:1:
      [string "*:OnEvent"]:1
Locals:
self = frameFactionAddict {
 0 = <userdata>
 Tab3Label = frameFactionAddictTab3 {
 }
 FactionAddictFramePortrait = frameFactionAddict_FactionAddictFramePortrait {
 }
 faTitleText = frameFactionAddict_faTitleText {
 }
 Tab2Label = frameFactionAddictTab2 {
 }
 Tab4Label = frameFactionAddictTab4 {
 }
 numTabs = 4
 Tab1Label = frameFactionAddictTab1 {
 }
 selectedTab = 1
}
event = "CHAT_MSG_COMBAT_FACTION_CHANGE"
arg1 = "Reputation with Guild increased by 125."
arg2 = ""
arg3 = ""
arg4 = ""
arg5 = ""
arg6 = ""
arg7 = 0
arg8 = 0
arg9 = ""
arg10 = 0
arg11 = 16
factionDecrease = false
s1 = 1
e1 = 39
faction = nil
amount = "125"
rep = 125
(*temporary) = <function> defined @Interface\AddOns\FactionAddict\FactionAddict.lua:139
(*temporary) = "Faction: "
(*temporary) = nil
(*temporary) = " Rep: 125"
(*temporary) = "125"
(*temporary) = "125"
(*temporary) = "125"
(*temporary) = "attempt to concatenate local 'faction' (a nil value)"
fa_DebugOut = <function> defined @Interface\AddOns\FactionAddict\FactionAddict.lua:139
FACTION_ADDICT_LOGGING_VERSION = 1
fa_UpdateLogVersion = <function> defined @Interface\AddOns\FactionAddict\FactionAddict.lua:793
FactionAddictConfigDefaults = <table> {
 CB_CATEGORY_CATA = true
 CB_STANDING_NEUTRAL1 = true
 CB_STANDING_UNFRIENDLY = true
 CB_CATEGORY_CF = true
 CB_CATEGORY_MOP = true
 CB_STANDING_REVERED = true
 CB_CATEGORY_BC = true
 CB_STANDING_HONORED = true
 CB_STANDING_FRIENDLY = true
 CB_STANDING_EXALTED = true
 CB_STANDING_HOSTILE = true
 RB_ORDERBY = 1
 CB_CATEGORY_WOTLK = true
 CB_STANDING_NEUTRAL0 = true
 CB_OPTION_HIDEINACTIVE = true
 CB_OPTION_AUTOBAR = true
 CB_CATEGORY_WOD = true
 CB_FILTER_SHOW_HO = true
 CB_FILTER_SHOW_AO = true
 CB_STANDING_HATED = true
}
fa_CleanConfigVars = <function> defined @Interface\AddOns\FactionAddict\FactionAddict.lua:777
lfgBonusFactionID = nil
running = nil
doServerFactionQuery = 1
fa_PopulateDisplayTable = <function> defined @Interface\AddOns\FactionAddict\FactionAddict.lua:618
fa_SortDisplayTable = <function> defined @Interface\AddOns\FactionAddict\FactionAddict.lua:504
fa_InfoWindow_LoadInfo = <function> defined @Interface\AddOns\FactionAddict\FactionAddict.lua:1377
pattern_standing_inc = "Reputation with (.+) increased by (%d+)."
pattern_standing_dec = "Reputation with (.+) decreased by (%d+)."
faPlayerGuildName = nil
fa_PopulateAllFactionDataTable = <function> defined @Interface\AddOns\FactionAddict\FactionAddict.lua:517
tempFactionIDsByName = <table> {
}
faLastRepGainStr = "Last Gain - None This Session"
L = <table> {
 TAB2_TT = "Log"
 CONFIG_TT_HO = "Show Horde only factions."
 EXALTED_TXT = "Exalted: "
 TAB3_DISPLAY_ORDER_TXT = "Order factions by"
 TAB1_DESC_TXT = "Click a faction for more info."
 SHOWN_TXT = "Shown: "
 TAB3_CONFIG_WOD = "Warlords of Draenor Factions"
 TAB3_CONFIG_WOTLK = "Wrath of the Lich King Factions"
 TAB3_CONFIG_ORDER_PCT = "% to Exalted"
 KNOWN_TXT = "Known: "
 CONFIG_TT_OrderPct = "Order factions by percent to exalted."
 CATEGORY_TXT = "Category: "
 CONFIG_TT_AO = "Show Alliance only factions."
 PCT_TO_EXALTED_TXT = "Pct to Exalted: "
 CONFIG_TT_OrderName = "Order factions by faction name."
 CONFIG_TT_WOD = "Show Warlords of Draenor factions."
 TAB3_CONFIG_HORDE_ONLY = "Show Horde Only Factions"
 CONFIG_TT_AUTOBAR = "Automatically change the reputation bar to faction with last reputation gain."
 TAB2_SESSIONTOTAL_TXT = "Session Total: "
 TAB3_CONFIG_CF = "Classic Factions"
 LAUNCH_WATCH_PANEL_TXT = "Launch Watch Panel"
 TAB3_CONFIG_HIDEINACTIVE = "Hide Inactive Factions"
 ABOUT_TXT = "Faction Addict is an addon that helps the player easily view and track information related to the various factions in the game. Great for those working towards exalted reputations with different factions. 

Use slash commands /fa or /factionaddict to open and/or close the window. The default ui reputation panel also has a launch button in the upper-right corner.

Download updates and leave comments at: wowinterface.com and wow.curse.com

Authored by: gmz323 (Greg)"
 TAB3_DISPLAY_OP
AddOns:
  Swatter, v4.4.2 (<%codename%>)
  WowheadLooter, v60004
  AchieveIt, v
  ACP, v3.4.14 
  AdvancedXPBar, v2.0.1
  Altoholic, v5.4.008
  Analyst, v1.3.0
  Archy, v1.8.43
  AucAdvanced, v5.21.5490 (SanctimoniousSwamprat)
  AucFilterBasic, v5.21.5490 (SanctimoniousSwamprat)
  AucFilterOutlier, v5.21.5490.5459(5.21a/embedded)
  AucMatchUndercut, v5.21.5490.5364(5.21a/embedded)
  AucStatHistogram, v5.21.5490 (SanctimoniousSwamprat)
  AucStatiLevel, v5.21.5490 (SanctimoniousSwamprat)
  AucStatPurchased, v5.21.5490 (SanctimoniousSwamprat)
  AucStatSales, v5.21.5490.5476(5.21a/embedded)
  AucStatSimple, v5.21.5490 (SanctimoniousSwamprat)
  AucStatStdDev, v5.21.5490 (SanctimoniousSwamprat)
  AucStatWOWEcon, v5.21.5490.5323(5.21a/embedded)
  AucUtilAHWindowControl, v5.21.5490.5347(5.21a/embedded)
  AucUtilAppraiser, v5.21.5490.5462(5.21a/embedded)
  AucUtilAskPrice, v5.21.5490.5447(5.21a/embedded)
  AucUtilAutoMagic, v5.21.5490.5443(5.21a/embedded)
  AucUtilCompactUI, v5.21.5490.5444(5.21a/embedded)
  AucUtilEasyBuyout, v5.21.5490.5458(5.21a/embedded)
  AucUtilFixAH, v5.21.5490 (SanctimoniousSwamprat)
  AucUtilItemSuggest, v5.21.5490.5417(5.21a/embedded)
  AucUtilPriceLevel, v5.21.5490.5458(5.21a/embedded)
  AucUtilScanButton, v5.21.5490.5403(5.21a/embedded)
  AucUtilScanFinish, v5.21.5490.5347(5.21a/embedded)
  AucUtilScanProgress, v5.21.5490.4979(5.21a/embedded)
  AucUtilScanStart, v5.21.5490.5347(5.21a/embedded)
  AucUtilSearchUI, v5.21.5490.5481(5.21a/embedded)
  AucUtilSimpleAuction, v5.21.5490.5452(5.21a/embedded)
  AucUtilVendMarkup, v5.21.5490.4828(5.21a/embedded)
  AutoRepair, v
  Awwwww, v2.0.1
  Babylonian, v5.1.DEV.332(/embedded)
  BadBoy, v12.412
  BadBoyCCleaner, v
  BadBoyHistory, v1.31
  BeanCounter, v5.21.5490 (SanctimoniousSwamprat)
  BelowAverageItems, v1.12
  BetterTooltips, vv1.4b
  CandyBuckets, v6.0.0.141023
  ChatLoot, v1.5
  Compass, v1.0.5
  Configator, v5.1.DEV.359(/embedded)
  CritterEmote, v1.7
  DarkmoonProfessional, v6.0.2.1
  DataStore, v6.0.001
  DataStoreAchievements, v6.0.001
  DataStoreAgenda, v6.0.001
  DataStoreAuctions, v6.0.001
  DataStoreCharacters, v6.0.001
  DataStoreContainers, v6.0.001
  DataStoreCrafts, v6.0.001
  DataStoreCurrencies, v6.0.001
  DataStoreInventory, v6.0.001
  DataStoreMails, v6.0.001
  DataStorePets, v6.0.001
  DataStoreQuests, v6.0.001
  DataStoreReputations, v6.0.001
  DataStoreSpells, v6.0.001
  DataStoreStats, v6.0.001
  DataStoreTalents, v6.0.001
  DebugLib, v5.1.DEV.337(/embedded)
  DragEmAll, v1.0.5
  Dresser, v6.0.0.141016
  Elephant, v3.3.8
  Exonumist, v6.0.2.45
  FactionAddict, v1.19
  FBMergeDatabase, v1.2p
  FBOutfitDisplayFrame, v1.3
  FBTrackingFrame, v1.2p
  FishingBuddy, v1.4d
  FlightMapEnhanced, v1.5.37
  Gatherer, v4.4.2
  Grail, v065
  GrailAchievements, v011
  GrailReputations, v007
  GrailWhen, v001
  GuildRosterButtons, v3.9
  IgnoreMore, v1.1.1-40300
  InFlightLoad, v6.0.001
  Informant, v5.21.5490 (SanctimoniousSwamprat)
  LagBar, v3.2
  LegacyQuest, vv1.0
  LibExtraTip, v5.12.DEV.363(/embedded)
  LightHeaded, v373
  Linkerize, v005
  MerchantFilterButtons, v2.1
  MetaMap, v6.0.2.1
  MetaMapBWP, v6.0.0
  MetaMapFWM, v6.0.0
  MetaMapNBK, v6.0.0
  MetaMapQST, v6.0.0
  MetaMapTRK, v6.0.0
  MetaMapWKB, v6.0.0
  Overachiever, v0.80
  OverachieverTrade, v0.80
  PetLeash, v3.0.1
  Postal, v3.5.1
  QuestPlates, v0.7
  RangeDisplay, vv4.2.5
  SanityCheck, vv1.61
  SilverDragon, vv3.1.0
  SimpleGold, v5.4.2
  SlideBar, v4.4.2 (<%codename%>)
  SpeedyGonzales, v1.7.1
  StoreBeGone, v1.2
  Stubby, v5.21.5490 (SanctimoniousSwamprat)
  SwindlerPreventer, v5.0.1 (15799) BETA
  TabardAddict, v2.23
  TinyPad, v2.0.2
  TipHelper, v5.12.DEV.351(/embedded)
  TipTop, v2.13.5 WoDBeta
  TomTom, vv60000-1.0.0-f4ee865
  TrackOMatic, v1.7.0
  TradeSkillDW, v1.96
  Volumizer, v6.0.2.1
  Wholly, v045
  ZoneAchievementTracker, v6.0.2.35
  BlizRuntimeLib_enUS v6.0.2.60000 <none>
  (ck=f3a)
Barleduq is offline Report comment to moderator  
Reply With Quote
Unread 10-10-14, 04:25 PM  
gmz323
A Kobold Labourer
 
gmz323's Avatar
AddOn Author - Click to view AddOns

Forum posts: 1
File comments: 46
Uploads: 3
Hi all! Below are the Faction Addict changes that are completed for the upcoming Warlords of Draenor pre-patch. (6.0.2) Will be available for download on patch day.

v1.18 (2014-10-14)
  • Added 'Star' indicator from default UI to support LFG Bonus Faction
  • [ESC] will now close the addon with all other UI elements.
  • Clean up some unnecessary table allocations.
  • Other minor bugfixes
v1.17 (2014-09-19)
  • Add config option for display of Warlords of Draenor factions.
  • Add new Warlords of Draenor and Barracks Bodyguards factions.
v1.16 (2014-09-17)
  • WoW version 6.0 compatibility release.

gmz323 is offline Report comment to moderator  
Reply With Quote
Unread 04-03-13, 08:30 AM  
gmz323
A Kobold Labourer
 
gmz323's Avatar
AddOn Author - Click to view AddOns

Forum posts: 1
File comments: 46
Uploads: 3
Thanks again Phanx! I have the initial implementation working now and will probably spend a few days with it before putting out the release.

I really appreciate the time you've spent helping with these features and have learned more along the way.

In case you need to reuse this snippet in the future below is an updated paste. There were a few tiny syntactic changes plus a case to handle when 'Inactive' header is collapsed.

http://pastebin.com/Pm4v6nKD

Thanks again!
gmz323 is offline Report comment to moderator  
Reply With Quote
Unread 04-02-13, 04:20 PM  
Phanx
A Pyroguard Emberseer
 
Phanx's Avatar
AddOn Author - Click to view AddOns

Forum posts: 4740
File comments: 2137
Uploads: 43
I don't know why Blizzard designs APIs like this... the pet journal is the same, but infinitely worse. Anyway, a simple flag to prevent recursion should be sufficient. I updated my previous code and combined them:

http://pastebin.com/V9gmF9kH

You can continue to call UpdateInactiveFactionList() in response to UPDATE_FACTION; it won't run again if it's already in the middle of a run. SetWatchedFactionByID(factionID) will still trigger the events, but won't cause UpdateInactiveFactionList to run while it's running. Instead of a table lookup to determine if a faction is inactive, call IsFactionInactive(factionID).
__________________
Author/maintainer of Grid, PhanxChat, ShieldsUp, and many more.
Troubleshoot an addonTurn any code into an addonMore addon resources
Need help with your code? Post all of your actual code! Attach or paste your files.
Please don’t PM me about addon bugs or code questions. Post a comment or forum thread instead!
Last edited by Phanx : 04-02-13 at 04:21 PM.
Phanx is offline Report comment to moderator  
Reply With Quote
Unread 04-02-13, 08:48 AM  
gmz323
A Kobold Labourer
 
gmz323's Avatar
AddOn Author - Click to view AddOns

Forum posts: 1
File comments: 46
Uploads: 3
Originally Posted by Phanx
With the latter, you just need to call the UpdateInactiveFactionsList function in response to the UPDATE_FACTION event, and then you can check InactiveFactions[factionID] to see if a particular faction should be ignored...
Hi Phanx. I was able to implement the auto-change reputation bar without issue. However having some problem with inactive factions.

The problem is that UpdateInactiveFactionsList itself generates multiple UPDATE_FACTION events as the headers are expanded and collapsed. So the whole thing kind of recurses on itself and stack overflows when you call it in response to an UPDATE_FACTION event. I had a thought of unregistering that event handler while in the function but seems a bit risky. Any thoughts?
gmz323 is offline Report comment to moderator  
Reply With Quote
Unread 03-28-13, 03:53 PM  
gmz323
A Kobold Labourer
 
gmz323's Avatar
AddOn Author - Click to view AddOns

Forum posts: 1
File comments: 46
Uploads: 3
Appreciate the code and time you spent on this Phanx. It must be a feature you're really interested in!

I'll work on rolling this support into the next release.
gmz323 is offline Report comment to moderator  
Reply With Quote
Unread 03-28-13, 01:54 PM  
Phanx
A Pyroguard Emberseer
 
Phanx's Avatar
AddOn Author - Click to view AddOns

Forum posts: 4740
File comments: 2137
Uploads: 43
Set watched faction by ID:
http://pastebin.com/9Tb6X3Lm

Get list of inactive factions:
http://pastebin.com/BqDGmc0s

With the latter, you just need to call the UpdateInactiveFactionsList function in response to the UPDATE_FACTION event, and then you can check InactiveFactions[factionID] to see if a particular faction should be ignored:

Code:
if InactiveFactions[factionID] then
	-- don't display
else
	-- display
end
Both functions will have no visible impact on the state of the default faction panel, so even if the user is currently viewing it, they won't notice the headers being collapsed/expanded.
__________________
Author/maintainer of Grid, PhanxChat, ShieldsUp, and many more.
Troubleshoot an addonTurn any code into an addonMore addon resources
Need help with your code? Post all of your actual code! Attach or paste your files.
Please don’t PM me about addon bugs or code questions. Post a comment or forum thread instead!
Last edited by Phanx : 03-28-13 at 01:59 PM.
Phanx is offline Report comment to moderator  
Reply With Quote
Unread 03-23-13, 07:15 AM  
gmz323
A Kobold Labourer
 
gmz323's Avatar
AddOn Author - Click to view AddOns

Forum posts: 1
File comments: 46
Uploads: 3
Thanks for the feedback Phanx.

This is somewhat difficult with the current implementation of Faction Addict. FA was written to be independent of the default reputation UI. That means it can only use faction APIs that pass faction ID and can't really use those that pass a faction INDEX. When I looked into workaround sometime back for mapping INDEXes to IDs I realized that the indexes keep changing based on what is currently displayed and/or folded/unfolded in the default display. It added a level of complexity that I didn't want to deal with.

This is also why I've not been able to easily implement the quick change reputation bar as SetWatchedFactionIndex(index) uses the indexes instead of Faction IDs.

It is more likely that I would implement custom standalone active/inactive and reputatation bar features into the addon than try to find a workaround with the indexes. But it will take some time.

Thanks!

Originally Posted by Phanx
Could you add an option to not display factions the player has moved to the Inactive group? When you're scanning the faction list, just check the text of each header you encounter against the FACTION_INACTIVE global. If it's a match, stop the scan; all the remaining factions are in the Inactive group.

This would help keep the list clean. For example, I don't need to see Forest Hozen at the top of the list (99.52% Revered)... Blizzard failed to consider that not all players are guilded (with the +rep bonus from their guild) when setting the rep rewards for those quests, and didn't fix it until after I'd already leveled through Jade Forest and done all the quests, so I can never gain any more rep with them to get Exalted. Then there are some factions that are just totally useless, like the Gelkis and Magram Clan Centaur from the level 30 quests in Desolace back in Vanilla... I'm not even sure those quests exist anymore.
gmz323 is offline Report comment to moderator  
Reply With Quote
Unread 03-23-13, 02:51 AM  
Phanx
A Pyroguard Emberseer
 
Phanx's Avatar
AddOn Author - Click to view AddOns

Forum posts: 4740
File comments: 2137
Uploads: 43
Could you add an option to not display factions the player has moved to the Inactive group? When you're scanning the faction list, just check the text of each header you encounter against the FACTION_INACTIVE global. If it's a match, stop the scan; all the remaining factions are in the Inactive group.

This would help keep the list clean. For example, I don't need to see Forest Hozen at the top of the list (99.52% Revered)... Blizzard failed to consider that not all players are guilded (with the +rep bonus from their guild) when setting the rep rewards for those quests, and didn't fix it until after I'd already leveled through Jade Forest and done all the quests, so I can never gain any more rep with them to get Exalted. Then there are some factions that are just totally useless, like the Gelkis and Magram Clan Centaur from the level 30 quests in Desolace back in Vanilla... I'm not even sure those quests exist anymore.
__________________
Author/maintainer of Grid, PhanxChat, ShieldsUp, and many more.
Troubleshoot an addonTurn any code into an addonMore addon resources
Need help with your code? Post all of your actual code! Attach or paste your files.
Please don’t PM me about addon bugs or code questions. Post a comment or forum thread instead!
Phanx is offline Report comment to moderator  
Reply With Quote
Unread 10-19-12, 06:18 AM  
gmz323
A Kobold Labourer
 
gmz323's Avatar
AddOn Author - Click to view AddOns

Forum posts: 1
File comments: 46
Uploads: 3
Originally Posted by Aisenfaire
Hello! Just wanted to mention your link to "Below Average Items" in your description seems to be broken.

Great addons!
Thanks Aisenfaire! I won't be able to update the link until the next file update so heres the link for now:
Below Average Items Link - http://www.wowinterface.com/download...Indicator.html
gmz323 is offline Report comment to moderator  
Reply With Quote
Unread 10-18-12, 07:15 PM  
Aisenfaire
A Murloc Raider

Forum posts: 4
File comments: 270
Uploads: 0
Hello! Just wanted to mention your link to "Below Average Items" in your description seems to be broken.

Great addons!
Aisenfaire is offline Report comment to moderator  
Reply With Quote
Unread 09-06-12, 05:39 AM  
Barleduq
Ruler of All I Survey
 
Barleduq's Avatar

Forum posts: 63
File comments: 273
Uploads: 0
Just a note...

... thanking you for working to update this for all the new stuff.

Thank you!

Barleduq is offline Report comment to moderator  
Reply With Quote
Unread 05-13-12, 07:22 AM  
gmz323
A Kobold Labourer
 
gmz323's Avatar
AddOn Author - Click to view AddOns

Forum posts: 1
File comments: 46
Uploads: 3
Re: Feature suggestion

Thanks for the suggestions Hentaya!

I will look into what info is available via the api in regards to having some guild level functionality in the addon and consider adding some guild level features to it.

Thanks!
gmz323 is offline Report comment to moderator  
Reply With Quote
Unread 05-12-12, 10:09 AM  
Hentaya
A Deviate Faerie Dragon
AddOn Author - Click to view AddOns

Forum posts: 10
File comments: 19
Uploads: 1
Thumbs up Feature suggestion

Haven't started using it yet, but reading the blurbs make me pretty sure I want to.

One tracking feature that would be useful would be to track the guild achievement for 55 exalted reps. Even BETTER would be if it had a way to figure out if anyone else in your guild (for whatever value of 'anyone else' is accessable to the API level) is closer than you to ones that are needed.

Of course, going the latter way makes one think of lots of features for Guild Achievement Addict. I just haven't gotten around to examining the API for access to guild member info. Right now, my guild on Elune doesn't seem to exist to the Armory, so there's more desire for me to get info via addons.
Hentaya is offline Report comment to moderator  
Reply With Quote
Post A Reply



Category Jump: