Download
(2 Kb)
Download
Updated: 09-27-12 04:25 PM
Pictures
File Info
Compatibility:
Mists of Pandaria (5.0.4)
Updated:09-27-12 04:25 PM
Created:09-26-12 10:18 PM
Downloads:3,653
Favorites:78
MD5:
PetCaught
Version: 1.1
by: lifetapt [More]
Note: Blizzard is implementing this functionality into the default UI with Patch 5.1, so this addon will be made obsolete at that point.

What's this?

PetCaught is a very simple addon that appends a "Caught" or "Not Caught" note to the tooltips of any wild battle pets you may encounter. The goal is to help you catch 'em all more easily, removing the need to check the pet journal to determine if you've already captured a certain pet.

The addon will add the note to both world tooltips as well as minimap tracking tooltips. In addition, it will note the quality of your captured pet (for example, Poor, or Uncommon) so that you can decide if you want to try to capture a higher quality of a pet you already have.

PetCaught has no UI or configuration, just drop it into your addons folder and you're good to go. If you've got suggestions or screenshots, let me know in the comments below.
-Fixed a Lua error thrown when using the Filter text box in the Pet Journal
Optional Files (0)


Archived Files (1)
File Name
Version
Size
Author
Date
1.0
2kB
lifetapt
09-26-12 10:18 PM


Post A Reply Comment Options
Unread 03-15-13, 12:21 PM  
rigdig
A Kobold Labourer

Forum posts: 0
File comments: 1
Uploads: 0
broke??

I can't get this to work. It doesn't pop up saying if i have the pet. I disabled all other addons and it still didn't work


any ideas??
rigdig is offline Report comment to moderator  
Reply With Quote
Unread 12-16-12, 10:18 PM  
kittykatmax
A Deviate Faerie Dragon
 
kittykatmax's Avatar

Forum posts: 16
File comments: 212
Uploads: 0
Love this addon. Just wanted to report:

37x PetCaught\PetCaught-1.1.lua:23: attempt to compare number with nil
PetCaught\PetCaught-1.1.lua:23: in function "OnEvent"
PetCaught\PetCaught-1.1.lua:6: in function <PetCaught\PetCaught.lua:6>
<in C code>
<in C code>
<in C code>
Blizzard_PetJournal\Blizzard_PetJournal-1.0.lua:846: in function <Blizzard_PetJournal\Blizzard_PetJournal.lua:839>




Thanks.
kittykatmax is offline Report comment to moderator  
Reply With Quote
Unread 11-30-12, 02:53 PM  
SomeoneSneaky
A Kobold Labourer

Forum posts: 0
File comments: 1
Uploads: 0
Oh, please please don't discontinue this addon! Yes, they added the caught pets number to the tooltip, but PetCaught is awesome for the minimap mouseover telling you what quality you have in your journal. The default WoW tooltip doesn't do that, only gives a number -- and even then, you have to land and find the critter in the first place in order to target it, or stop and search for the pet in your journal to see what you own.

PetCaught has been an invaluable thing to have while hunting new pets and upgrading ones I already own. It would be sad to see it go just because WoW adds a default that is sort of (but not really) the same.
SomeoneSneaky is offline Report comment to moderator  
Reply With Quote
Unread 10-15-12, 12:49 AM  
Phanx
A Pyroguard Emberseer
 
Phanx's Avatar
AddOn Author - Click to view AddOns

Forum posts: 4240
File comments: 1953
Uploads: 39
Re: Minimap color

Originally Posted by BronzeMoy
... change the minimap color of the pets. It is always green and I have to stop, mouseover and check ...
Unfortunately, this isn't possible, since addons can't even see minimap tracking blips, let alone find out what each blip is tracking. Mousing over the icon is your only option.
__________________
Author/maintainer of Grid, PhanxChat, ShieldsUp, and many more.
Troubleshoot an addonTurn any code into an addonMore addon resources
Need help with your code? Post all of your actual code! Attach or paste your files.
Please don’t PM me about addon bugs or code questions. Post a comment or forum thread instead!
Last edited by Phanx : 10-15-12 at 12:50 AM.
Phanx is offline Report comment to moderator  
Reply With Quote
Unread 10-02-12, 04:13 AM  
BronzeMoy
A Kobold Labourer
AddOn Author - Click to view AddOns

Forum posts: 0
File comments: 1
Uploads: 1
Minimap color

Hi

I love your addon since I like to collect pets. I have a few suggestions though...

Mainly its to change the minimap color of the pets. It is always green and I have to stop, mouseover and check if I have it or not.
My suggestion is to change the icon color depending on for example:

Rarity: Green, Blue, Purple
Caught: Grey
Hard: Red

(hard: say when the pet level is above 5 or 10 levels above my highest pet so i have no chance of catching it anyway)

I realize that changing this icon may or may not be hard to do so I humbly suggest it.

Thanks again for a nice addon!
BronzeMoy is offline Report comment to moderator  
Reply With Quote
Unread 09-30-12, 12:12 PM  
Negatron
A Kobold Labourer

Forum posts: 0
File comments: 1
Uploads: 0
Really nice mod, but I think its blocking my achievements. Not from getting them, but seeing them.

For example, in the last 30 minutes or so, I have got 2 battle pet achievements, getting a pet to 10 and getting my first rare. both of them never showed, if I checked my achievements it said I never got them, reloading my ui didn't change it, and I had to relog for them to show.

the only other mods I use is Recount and WarcraftpetsExpress.

Any idea if this is your mod doing it, a glitch, or what? anyone else having this issue? no error report displays.

Other than that, I really like this mod. super helpful because I'm stuck in a "Gotta catch'em all" mindset right now. Love this mod, I actually just now registered to WoW Interface because I'm hoping you can fix this, if its your mod doing it.

thanks
Negatron is offline Report comment to moderator  
Reply With Quote
Unread 09-29-12, 10:03 AM  
Lemon
A Kobold Labourer

Forum posts: 0
File comments: 12
Uploads: 0
I got some errors, when i'm searching pet's.

Code:
Message: Interface\AddOns\PetCaught\PetCaught.lua:23: attempt to compare number with nil
Time: 09/29/12 17:59:43
Count: 2
Stack: [C]: ?
Interface\AddOns\PetCaught\PetCaught.lua:23: in function `OnEvent'
Interface\AddOns\PetCaught\PetCaught.lua:6: in function <Interface\AddOns\PetCaught\PetCaught.lua:6>
[C]: in function `SetSearchFilter'
...e\AddOns\Blizzard_PetJournal\Blizzard_PetJournal.lua:837: in function <...e\AddOns\Blizzard_PetJournal\Blizzard_PetJournal.lua:830>

Locals:
Lemon is offline Report comment to moderator  
Reply With Quote
Unread 09-28-12, 07:40 AM  
QuickBASIC37
Premium Member
 
QuickBASIC37's Avatar
Premium Member

Forum posts: 0
File comments: 1
Uploads: 0
Just For Fun

Should have named it "CaughtOrNot.com" (parody of Hotornot.com).
Last edited by QuickBASIC37 : 09-28-12 at 07:41 AM.
QuickBASIC37 is offline Report comment to moderator  
Reply With Quote
Unread 09-28-12, 12:58 AM  
Tiberion1701
A Kobold Labourer

Forum posts: 0
File comments: 2
Uploads: 0
Ah, I went through and found out what was causing it; I had just updated Dominos (a bar mod) and it seems to be the culprit, the previous version wasn't doing it.


I did find a genuine issue with your addon though, that was causing the detection to "fail" on the tooltips. if you use the filters in the pet journal (say to show only favorites) then any pet that is "hidden" in the journal will display as "not caught" in the world, even if you have caught it. I turned it on and off several times to confirm
Tiberion1701 is offline Report comment to moderator  
Reply With Quote
Unread 09-28-12, 12:08 AM  
lifetapt
A Murloc Raider
 
lifetapt's Avatar
AddOn Author - Click to view AddOns

Forum posts: 6
File comments: 30
Uploads: 6
Originally Posted by Tiberion1701
It seems that the addon is making the menu icons (charsheet, spellbook, questlog, etc..) that appear in the little box on the right side during a Pet Battle disappear.

If you use a menu hotkey (like L to open the questlog, or shift+P for the pet journal) the icons come back. So yeah.

Edit: actually opening/closing the map is what makes the icons show up again.

Edit2: saw another issue; Found a skunk wandering in Duskwood, it said "not caught" - but I do have one caught from the same zone. I used the "click to open in Journal" link to make sure it was the same Pet ID

Liking it so far, can't wait for more features. I would like to see rarity color and caught/not caught show somewhere on the info cards/tooltips that show up during pet battles, as there is no way to tell if you have the 2nd pet in a wild-battle, or its rarity (there is another pet addon that does this currently)
I wasn't able to reproduce the issue with the minibar icons disappearing. Make sure you disable all addons except for PetCaught, then try fighting a pet again. The code for the addon is really simple and it doesn't touch anything UI-related other than tooltips so I'm not sure how that could even be occurring. :S

I'll look into adding rarity inside of pet battles, since that's something I've been wanting also. I don't think I'll be adding a ton of crazy features though... I'm sure very deep and complex "Pokédex" type addons will start to pop up in a few months once other coders have had time to play with the new API, and I have no doubt that they'll do a better job than I ever could. This addon was really meant as just a quick fix for a very minor UI annoyance. :P


Originally Posted by Ratso Steamwheedle
VERY useful addon. Thanks for taking the time.

I did notice that when you get multiple creatures in the same tooltip its looks a little strange. i.e.

Frog
Toad
Caught
Uncaught

Other than that I dig it. Seems like it should be standard in the Blizz UI.
Yeah, unfortunately the API is very limiting and clunky when it comes to those minimap tooltips and I wasn't able to devise an elegant solution to that issue at the time (it was 2AM, I was tired, and I kept getting distracted by pet battles...).

It's a little messy, but for now it'll have to do. Once I've gotten over my MoP release leveling binge I'll see what I can do.
Last edited by lifetapt : 09-28-12 at 12:17 AM.
lifetapt is offline Report comment to moderator  
Reply With Quote
Unread 09-27-12, 09:22 PM  
Tiberion1701
A Kobold Labourer

Forum posts: 0
File comments: 2
Uploads: 0
It seems that the addon is making the menu icons (charsheet, spellbook, questlog, etc..) that appear in the little box on the right side during a Pet Battle disappear.

If you use a menu hotkey (like L to open the questlog, or shift+P for the pet journal) the icons come back. So yeah.

Edit: actually opening/closing the map is what makes the icons show up again.

Edit2: saw another issue; Found a skunk wandering in Duskwood, it said "not caught" - but I do have one caught from the same zone. I used the "click to open in Journal" link to make sure it was the same Pet ID

Liking it so far, can't wait for more features. I would like to see rarity color and caught/not caught show somewhere on the info cards/tooltips that show up during pet battles, as there is no way to tell if you have the 2nd pet in a wild-battle, or its rarity (there is another pet addon that does this currently)
Last edited by Tiberion1701 : 09-27-12 at 09:40 PM.
Tiberion1701 is offline Report comment to moderator  
Reply With Quote
Unread 09-27-12, 06:53 PM  
Ratso Steamwheedle
A Kobold Labourer
 
Ratso Steamwheedle's Avatar
AddOn Author - Click to view AddOns

Forum posts: 1
File comments: 19
Uploads: 4
VERY useful addon. Thanks for taking the time.

I did notice that when you get multiple creatures in the same tooltip its looks a little strange. i.e.

Frog
Toad
Caught
Uncaught

Other than that I dig it. Seems like it should be standard in the Blizz UI.
Ratso Steamwheedle is offline Report comment to moderator  
Reply With Quote
Unread 09-27-12, 04:34 PM  
lifetapt
A Murloc Raider
 
lifetapt's Avatar
AddOn Author - Click to view AddOns

Forum posts: 6
File comments: 30
Uploads: 6
Re: Re: Re: error when trying to search journal

Originally Posted by txamethyst
Originally Posted by lifetapt
Originally Posted by txamethyst
first off - addon works great as intended to function. problem i have is when i open the journal to search something as soon as i type the first letter, and for each subsequent letter i get this error:

<snip>
Thanks for catching that. I've uploaded a fix for it just now.
greatly appreciated - tyvm
Looks like the file is still pending approval from a moderator. The fix is tiny, literally a single line, so you can paste it into the code for the current version if you want.

Open up PetCaught.lua and look for the line that says:

Code:
local _, _, _, _, rarity = C_PetJournal.GetPetStats(petID)
Create a new line before that one and paste the following:

Code:
if (petID == nil) then return end
Then save the file and you're good to go.
lifetapt is offline Report comment to moderator  
Reply With Quote
Unread 09-27-12, 04:23 PM  
txamethyst
A Fallenroot Satyr
 
txamethyst's Avatar

Forum posts: 29
File comments: 52
Uploads: 0
Re: Re: error when trying to search journal

Originally Posted by lifetapt
Originally Posted by txamethyst
first off - addon works great as intended to function. problem i have is when i open the journal to search something as soon as i type the first letter, and for each subsequent letter i get this error:

<snip>
Thanks for catching that. I've uploaded a fix for it just now.
greatly appreciated - tyvm
txamethyst is offline Report comment to moderator  
Reply With Quote
Unread 09-27-12, 04:22 PM  
lifetapt
A Murloc Raider
 
lifetapt's Avatar
AddOn Author - Click to view AddOns

Forum posts: 6
File comments: 30
Uploads: 6
Re: error when trying to search journal

Originally Posted by txamethyst
first off - addon works great as intended to function. problem i have is when i open the journal to search something as soon as i type the first letter, and for each subsequent letter i get this error:

<snip>
Thanks for catching that. I've uploaded a fix for it just now.
lifetapt is offline Report comment to moderator  
Reply With Quote
Post A Reply



Category Jump: