Minion Beta! - Help us test our new AddOn updater. Get it now!
Download
(6 Kb)
Download
Updated: 10-15-14 12:12 PM
Pictures
File Info
Compatibility:
Warlords of Draenor Pre-Patch (6.0.2)
Updated:10-15-14 12:12 PM
Created:10-16-12 03:45 AM
Downloads:1,800
Favorites:12
MD5:

LastEffect

Version: 0.38
by: another [More]

Shows last damage/heal done by spell as button's text.

There is 3 types of more or less accurate spell effect you can expect by casting:

  1. Tooltip data from Blizzard (seems always lower than actual effect)
  2. Heavy calculations and tuning like DrDamage do
  3. Collect data and show (like this addon)
For now supports only Blizzard's action buttons and Bartender4 since v0.20.

How it works

Lot of spells quite plain: you pressing button, it have spell id, through combat log addon receives damage/healing info. For example you casting "Smite" - log contains spell cast started and damage info (effect will be shown on next spell cast).
Some spells more complicated: you casting instant spell "Icy Touch", it contains cast success, direct damage info, "Frost Fever" aura applied that causing extra damage per tick. Some of such spells solved already, some not (I have only several 80+ alts). So if you want to get more info read next section "Howto".

Howto

To add damage/heal caused by spell's side effects:
  1. Find "Target Dummy"
  2. Enable debug mode like "/le debug"
  3. Cast your spell and see log in chat
  4. There will be cast and auras info (format is "event, spellId, spellName, amount or buff"), add your side effect spellId to LE_SpellPartOf in Spells.lua like [sideEffectId] = mainSpellId
  5. "/reload" and see is it works
  6. Disable debug mode typing "/le debug" again

To toggle debug mode use slash command /le debug (or /LastEffect debug).

v0.38
toc changed for WoD

v0.37
toc changed for v5.4

v0.36
toc changed for v5.3

v0.35
monk's "Surging Mist" and "Enveloping Mist" added

v0.34
toc changed for v5.1.0

v0.33
fixed: button text disappearing
fixed: stopped working on changing stances and presences

v0.32
Shaman's "Fire Nova" and "Stormstrike" added

v0.31
libstub and EasyStorage fix

v0.30
cleanup
effect calculated between button clicks: helps with channeled spells
"average" mode (optional): "average" switch in slash commands

v0.23
added text to macro based buttons (if GetMacroSpell able to retrieve spell id from macro)

v0.22b
pet's damage can be shown
hunter: "Kill Command" damage added

v0.21b
fix: "attempt to index local 'fname' (a nil value)"

v0.20b
Bartender4 support

v0.18b
more checks to prevent using on wrong buttons
ACTIONBAR_PAGE_CHANGED event: fixes on changing action bar pages

v0.17b
added several procs and auras for: mage, priest, dk, hunter, paladin
counter resets on next cast only

v0.16a
taint fix
speed issue fix

v0.15a
added readme.txt
added event hadlers to update associated action buttons
added some comments to main.lua and Spells.lua
fixed: TinyExtraBars link

v0.10a
initial alpha
Archived Files (16)
File Name
Version
Size
Author
Date
0.37
6kB
another
09-16-13 12:54 AM
0.36
6kB
another
07-15-13 04:49 AM
0.35
6kB
another
01-20-13 07:22 AM
0.34
6kB
another
11-28-12 10:47 AM
0.33
6kB
another
11-25-12 03:03 PM
0.32
6kB
another
11-22-12 09:55 AM
0.31
6kB
another
11-17-12 06:49 AM
0.30
6kB
another
11-16-12 02:41 PM
0.23
6kB
another
11-15-12 05:14 AM
0.22b
6kB
another
10-28-12 04:54 AM
0.21b
6kB
another
10-23-12 01:57 PM
0.20b
5kB
another
10-23-12 05:38 AM
0.17b
5kB
another
10-19-12 04:01 AM
0.16a
5kB
another
10-17-12 05:42 AM
0.15a
5kB
another
10-16-12 11:42 AM
0.1a
4kB
another
10-16-12 03:45 AM


Post A Reply Comment Options
Unread 01-23-13, 12:25 PM  
another
A Deviate Faerie Dragon
AddOn Author - Click to view AddOns

Forum posts: 11
File comments: 168
Uploads: 14
Originally Posted by Nasreen
Hello - unfortunately it seems like none of my spells are there by default, so Im having to add them all. I'm having trouble understanding how do this. Specifically the "sideEffectId" term from your How-To are confusing me, I cant figure out where you find that ("[sideEffectId] = mainSpellId"). I tried looking at the previous comments about Fire Nova but he's got so much going on in that log it confuses me.
None of spells shown? I have elemental shammy and at least "Lightning Bolt" works by itself (spell id for damage is same that casting spell id). Are you using standard Blizzard's bars or something based on this bars (like Bartender or Dominos)?

"How to" is simple, you have in your log for example "SPELL_CAST_START, 51505, Lava Burst" (spell id 51505). "Side effects" for example if you casting spell with spell id X and have damage from spell id Y (damage from applied dots for example). Since addon can't figure such things you should assign in Spells.lua "[Y] = X, --can comment here" to add damage from effect Y to casted spell X.

From your log you have "SPELL_CAST_START, 51505, Lava Burst" (id 51505)
damage "SPELL_DAMAGE, 51505, Lava Burst, 17483" (id 51505, amount 17483)
damage "SPELL_DAMAGE, 77451, Lava Burst, 34122" (id 77451, amount 34122)
to get all damage done by "Lava Burst" you need "[77451] = 51505," in Spells.lua
if everything correct you will see in log "77451 added to 51505"

Slightly more complicated things like casting "Icy Touch" and adding damage from "Frost Fever" (but there is spell tooltip, "Icy Touch blasts ... and apply ..."). Except in case of DK many things applying "Frost Fever" and it is reasonable to set only one spell as "Frost Fever" damage collector.

What's the sideEffectId?
SPELL_DAMAGE, 77451, Lava Burst, 34122 (casted spell have another id "SPELL_CAST_START, 51505")

Finally you can try TinyExtraBars, it have own "LastEffect".
Last edited by another : 01-23-13 at 12:43 PM.
another is offline Report comment to moderator  
Reply With Quote
Unread 01-23-13, 12:03 AM  
Nasreen
A Kobold Labourer

Forum posts: 0
File comments: 7
Uploads: 0
Hello - unfortunately it seems like none of my spells are there by default, so Im having to add them all. I'm having trouble understanding how do this. Specifically the "sideEffectId" term from your How-To are confusing me, I cant figure out where you find that ("[sideEffectId] = mainSpellId"). I tried looking at the previous comments about Fire Nova but he's got so much going on in that log it confuses me.


SPELL_CAST_START, 51505, Lava Burst
51505 added to 51505
SPELL_DAMAGE, 51505, Lava Burst, 17439
51505 added to 51505
In this example, 51505 is the "mainSpellId" for Lava Burst, and 17439 is the damage done. What's the sideEffectId?

Here's a bit more of the log:

SPELL_CAST_START, 117014, Elemental Blast
117014 added to 117014
SPELL_DAMAGE, 117014, Elemental Blast, 32371
117014 added to 117014
SPELL_CAST_START, 51505, Lava Burst
51505 added to 51505
SPELL_DAMAGE, 51505, Lava Burst, 17483
51505 added to 51505
SPELL_DAMAGE, 77451, Lava Burst, 34122
77451 added to 77451
SPELL_CAST_START, 403, Lightning Bolt
403 added to 403
SPELL_MISSED, 403, Lightning Bolt, MISS
403 added to 403
SPELL_CAST_START, 403, Lightning Bolt
403 added to 403
SPELL_DAMAGE, 403, Lightning Bolt, 17169
403 added to 403
And naturally, half my toons are DOT-classes, so if I can figure *this* out, my next step is figuring out how to add periodic damage.


Thank you for the help.
Nasreen is offline Report comment to moderator  
Reply With Quote
Unread 11-21-12, 04:45 PM  
Luvis
A Murloc Raider

Forum posts: 4
File comments: 7
Uploads: 0
Re: Re: Stormstrike

Thanks and all that worked fine




Originally Posted by another
Originally Posted by Luvis
Originally Posted by another
[32175] = 17364, --Stormstrike

Edit: which addon allow to copy chat text?
Except it strikes with both weapons on different spell numbers, other one is 32176.
Oh, add then

[32176] = 17364, --Stormstrike offhand

also. It will add effects from both mainhand and offhand to casted "Stormstrike". If it works I will add this lines into next patch.
Luvis is offline Report comment to moderator  
Reply With Quote
Unread 11-20-12, 05:55 PM  
another
A Deviate Faerie Dragon
AddOn Author - Click to view AddOns

Forum posts: 11
File comments: 168
Uploads: 14
Re: Stormstrike

Originally Posted by Luvis
Originally Posted by another
[32175] = 17364, --Stormstrike

Edit: which addon allow to copy chat text?
Except it strikes with both weapons on different spell numbers, other one is 32176.
Oh, add then

[32176] = 17364, --Stormstrike offhand

also. It will add effects from both mainhand and offhand to casted "Stormstrike". If it works I will add this lines into next patch.
Last edited by another : 11-20-12 at 05:58 PM.
another is offline Report comment to moderator  
Reply With Quote
Unread 11-20-12, 04:32 PM  
Luvis
A Murloc Raider

Forum posts: 4
File comments: 7
Uploads: 0
Re: Re: Re: Re: Re: Re: Great Thanks!

Originally Posted by another
[32175] = 17364, --Stormstrike

Edit: which addon allow to copy chat text?
Except it strikes with both weapons on different spell numbers, other one is 32176.
Luvis is offline Report comment to moderator  
Reply With Quote
Unread 11-20-12, 04:30 AM  
Luvis
A Murloc Raider

Forum posts: 4
File comments: 7
Uploads: 0
Re: Re: Re: Re: Re: Re: Great Thanks!

Originally Posted by another
[32175] = 17364, --Stormstrike

Edit: which addon allow to copy chat text?

Chatter
Luvis is offline Report comment to moderator  
Reply With Quote
Unread 11-19-12, 06:51 AM  
another
A Deviate Faerie Dragon
AddOn Author - Click to view AddOns

Forum posts: 11
File comments: 168
Uploads: 14
Re: Re: Re: Re: Re: Great Thanks!

[32175] = 17364, --Stormstrike

Edit: which addon allow to copy chat text?
Last edited by another : 11-19-12 at 07:03 AM.
another is offline Report comment to moderator  
Reply With Quote
Unread 11-19-12, 02:23 AM  
Luvis
A Murloc Raider

Forum posts: 4
File comments: 7
Uploads: 0
Re: Re: Re: Re: Great Thanks!

Hmmm try this...

DebugSpellMode = true
SWING_DAMAGE, 8867, 8866
SPELL_CAST_SUCCESS, 17364, Stormstrike
17364 added to 17364
ShamanFriend: Missing: Elemental Shield
SPELL_AURA_APPLIED, 17364, Stormstrike, DEBUFF
17364 added to 17364
SPELL_DAMAGE, 32175, Stormstrike, 30785
32175 added to 32175
SPELL_DAMAGE, 32176, Stormstrike Off-Hand, 9621
32176 added to 32176
SPELL_AURA_APPLIED, 53817, Maelstrom Weapon, BUFF
53817 added to 53817
SPELL_ENERGIZE, 63375, Primal Wisdom, 3000
63375 added to 63375
SPELL_AURA_APPLIED_DOSE, 53817, Maelstrom Weapon, BUFF
53817 added to 53817
SPELL_ENERGIZE, 63375, Primal Wisdom, 3000
63375 added to 63375
SPELL_DAMAGE, 116616, Elemental Force, 4802
116616 added to 116616
SPELL_DAMAGE, 116616, Elemental Force, 4403
116616 added to 116616
ShamanFriend: MH Windfury: 47857 (1 proc kill)
SPELL_DAMAGE, 25504, Windfury Attack, 7451
25504 added to 25504
ShamanFriend: MH Windfury Single crit: 18246 (1 proc kill)
SPELL_DAMAGE, 25504, Windfury Attack, 18246
25504 added to 25504
ShamanFriend: MH Windfury: 8998 (1 proc kill)
SPELL_DAMAGE, 25504, Windfury Attack, 8998
25504 added to 25504
SPELL_DAMAGE, 10444, Flametongue Attack, 1791
10444 added to 10444
SPELL_ENERGIZE, 63375, Primal Wisdom, 3000
63375 added to 63375
SPELL_AURA_APPLIED, 16278, Flurry, BUFF
16278 added to 16278
SPELL_ENERGIZE, 63375, Primal Wisdom, 3000
63375 added to 63375
SWING_MISSED, MISS, 1
SWING_MISSED, MISS, nil
DebugSpellMode = false
Luvis is offline Report comment to moderator  
Reply With Quote
Unread 11-18-12, 02:34 AM  
another
A Deviate Faerie Dragon
AddOn Author - Click to view AddOns

Forum posts: 11
File comments: 168
Uploads: 14
Re: Re: Re: Great Thanks!

Ah, "Fire Nova" spell id is 1535, while damage from spell id 8349

SPELL_CAST_SUCCESS, 1535, Fire Nova
SPELL_DAMAGE, 8349, Fire Nova, 3537

Try to add in Spells.lua (it is text file, can edit with Notepad or anything else) in table LE_SpellPartOf (somewhere below paladin spells)

Code:
	--shaman
	[8349]		= 1535,	--Fire Nova
Can't see anything about "Storm Strike" in your log (it seems you really tried hard to kill target dummy ). If it works I will add this info in next version.
another is offline Report comment to moderator  
Reply With Quote
Unread 11-17-12, 07:09 PM  
Luvis
A Murloc Raider

Forum posts: 4
File comments: 7
Uploads: 0
Re: Re: Great Thanks!

Originally Posted by another
Originally Posted by Luvis
... couple of things I noticed quickly on my enhance shammy, the buttons for Storm Strike and fire nova are not registering ...
Well, my shaman elemental/resto and only 46. But adding some spells quite simple: by activating debug mode you will see log in chat as "event, spellId, spell name, amount/buff". So if some spell after cast creates another aura by id - you should add to Spell.lua LE_SpellPartOf table like "[additional effect id] = casted spell id,". For example dk's "Icy Touch" (id 45477) causing "Frost Fever" (id 55095), so it is "[55095] = 45477," in those table. You should look for DAMAGE and HEAL events.
Post your data here and I will add this to Spell.lua for others.
10444 added to 10444
SPELL_DAMAGE, 403, Lightning Bolt, 30617
403 added to 403
SPELL_AURA_APPLIED_DOSE, 77661, Searing Flames, BUFF
77661 added to 77661
SWING_DAMAGE, 2320, 2319, nil
SPELL_CAST_START, 421, Chain Lightning
421 added to 421
SPELL_PERIODIC_DAMAGE, 8050, Flame Shock, 3246
8050 added to 8050
SPELL_AURA_APPLIED, 53817, Maelstrom Weapon, BUFF
53817 added to 53817
SPELL_DAMAGE, 116616, Elemental Force, 4284
116616 added to 116616
SPELL_AURA_REMOVED, 118472, Unleashed Fury, BUFF
118472 added to 118472
SPELL_AURA_REMOVED, 73683, Unleash Flame, BUFF
73683 added to 73683
SPELL_DAMAGE, 10444, Flametongue Attack, 2307
10444 added to 10444
SPELL_DAMAGE, 26364, Lightning Shield, 6135
26364 added to 26364
SPELL_CAST_FAILED, 1535, Fire Nova, Another action is in progress
1535 added to 1535
SPELL_AURA_APPLIED_DOSE, 77661, Searing Flames, BUFF
77661 added to 77661
SPELL_AURA_REMOVED, 53817, Maelstrom Weapon, BUFF
53817 added to 53817
SPELL_DAMAGE, 421, Chain Lightning, 4919
421 added to 421
SPELL_DAMAGE, 421, Chain Lightning, 6162
421 added to 421
SPELL_DAMAGE, 421, Chain Lightning, 7775
421 added to 421
SWING_DAMAGE, 5586, 5585
SPELL_AURA_REMOVED, 118470, Unleashed Fury, DEBUFF
118470 added to 118470
SPELL_DAMAGE, 116616, Elemental Force, 4276
116616 added to 116616
SPELL_PERIODIC_DAMAGE, 8050, Flame Shock, 6491
8050 added to 8050
SPELL_CAST_SUCCESS, 1535, Fire Nova
1535 added to 1535
SPELL_DAMAGE, 8349, Fire Nova, 3537
8349 added to 8349
SPELL_DAMAGE, 8349, Fire Nova, 3499
8349 added to 8349
SPELL_DAMAGE, 8349, Fire Nova, 3514
8349 added to 8349
SPELL_DAMAGE, 116616, Elemental Force, 4597
116616 added to 116616
SWING_DAMAGE, 2851, 2850, nil
SWING_DAMAGE, 9310, 9309
SPELL_AURA_APPLIED, 53817, Maelstrom Weapon, BUFF
53817 added to 53817
SPELL_DAMAGE, 10444, Flametongue Attack, 2447
10444 added to 10444
SPELL_DAMAGE, 116616, Elemental Force, 4627
116616 added to 116616
SPELL_AURA_REMOVED, 16278, Flurry, BUFF
16278 added to 16278
SPELL_AURA_APPLIED, 16278, Flurry, BUFF
16278 added to 16278
DebugSpellMode = false
Luvis is offline Report comment to moderator  
Reply With Quote
Unread 11-16-12, 02:51 PM  
another
A Deviate Faerie Dragon
AddOn Author - Click to view AddOns

Forum posts: 11
File comments: 168
Uploads: 14
v0.30 uploaded

Addon logic changed to amount of damage/heal between button clicks. It helps to solve issue with channeled spells that looks like several independent casts in combat log. Also that required to make average mode.
Added optional "average" mode (see slash commands: type "/le" or "/LastEffect" in chat to see available). This mode suppose to show average of last 10 casts.

Possible issue: there is time between click and actual damage (depends from distance) and by casting nonstop sometime 2 casts can be count as 1. Can't find solution yet.

Feedback would be nice.
another is offline Report comment to moderator  
Reply With Quote
Unread 11-04-12, 12:11 PM  
Radoznali
A Murloc Raider
 
Radoznali's Avatar

Forum posts: 4
File comments: 128
Uploads: 0
Any chance for Ion support?
Radoznali is offline Report comment to moderator  
Reply With Quote
Unread 10-24-12, 11:14 AM  
another
A Deviate Faerie Dragon
AddOn Author - Click to view AddOns

Forum posts: 11
File comments: 168
Uploads: 14
ElvUI

It probably can be made ElvUI compatible with this lines
Code:
			elseif fname:match("^ElvUI_Bar%dButton%d+$") then
				local action = SecureButton_GetModifiedAttribute(frame, "action", SecureButton_GetEffectiveButton(frame))
				if action then
					ActionToButton[action] = frame
					--uncomment to print all buttons spell ids
					--print(action, fname)
					SetButtonRefByAction(action)
				end
at lines 328-333 in main.lua v0.21 (use editor like Notepad++, replace commented text there by text above). Confirm is it works or throwing errors. I'm not ElvUI user and not trying to use it - ElvUI changes global variables and I have headache fixing my chat window etc.
another is offline Report comment to moderator  
Reply With Quote
Unread 10-23-12, 01:54 PM  
another
A Deviate Faerie Dragon
AddOn Author - Click to view AddOns

Forum posts: 11
File comments: 168
Uploads: 14
Re: Great Thanks!

Originally Posted by Luvis
... couple of things I noticed quickly on my enhance shammy, the buttons for Storm Strike and fire nova are not registering ...
Well, my shaman elemental/resto and only 46. But adding some spells quite simple: by activating debug mode you will see log in chat as "event, spellId, spell name, amount/buff". So if some spell after cast creates another aura by id - you should add to Spell.lua LE_SpellPartOf table like "[additional effect id] = casted spell id,". For example dk's "Icy Touch" (id 45477) causing "Frost Fever" (id 55095), so it is "[55095] = 45477," in those table. You should look for DAMAGE and HEAL events.
Post your data here and I will add this to Spell.lua for others.
another is offline Report comment to moderator  
Reply With Quote
Unread 10-23-12, 10:00 AM  
Luvis
A Murloc Raider

Forum posts: 4
File comments: 7
Uploads: 0
Thumbs up Great Thanks!

You just became my favorite person!, since DR damage is no more I was really missing this, couple of things I noticed quickly on my enhance shammy, the buttons for Storm Strike and fire nova are not registering, will test some more on some alts later once again Thank you !
Luvis is offline Report comment to moderator  
Reply With Quote
Post A Reply



Category Jump: