Download
(4 Kb)
Download
Updated: 01-05-14 12:00 AM
Pictures
File Info
Compatibility:
Siege of Orgrimmar (5.4)
Updated:01-05-14 12:00 AM
Created:09-23-13 02:22 AM
Downloads:1,637
Favorites:23
MD5:
5.4
A Bigger Bag
Version: 1.0e
by: corveroth [More]
Working on [Going To Need A Bigger Bag]? You're going to need A Bigger Bag.

A Bigger Bag adds tooltip information to any relevant NPC in Pandaria:
  • Which achievement-related items drop
  • Which other NPCs drop the same item
  • Whether you've collected that item before
1.0e: Better fix for the prior fix, I'll learn one of these days.
1.0d: Better fix for the prior bug, I'll learn one of these days.
1.0c: Fixed a bug where pet battles could cause Lua errors.
1.0b: Fixed a bug where dying units could cause Lua errors.
1.0a: Fixed a bug where ABB would fail to detect collection of items with dashes in their names.
Optional Files (0)


Archived Files (5)
File Name
Version
Size
Author
Date
1.0d
4kB
corveroth
01-04-14 12:41 AM
1.0c
4kB
corveroth
12-11-13 12:38 AM
1.0b
3kB
corveroth
10-02-13 04:00 PM
1.0a
3kB
corveroth
09-23-13 07:26 PM
1.0
3kB
corveroth
09-23-13 02:22 AM


Post A Reply Comment Options
Old 07-18-14, 07:59 PM  
Stanzilla
A Deviate Faerie Dragon
AddOn Author - Click to view AddOns

Forum posts: 14
File comments: 114
Uploads: 1
https://cdn.mediacru.sh/QDpvoKIRtI7Y.png it does not seem to want to update on this one.
Stanzilla is offline Report comment to moderator  
Reply With Quote
Old 03-06-14, 04:04 AM  
Maelynn
A Deviate Faerie Dragon
 
Maelynn's Avatar

Forum posts: 15
File comments: 181
Uploads: 0
Originally Posted by corveroth
This addon doesn't gather any information from your other characters - it is character specific. I suspect that whatever item it shows you've completed was previously looted from another mob, as several of the achievement's criteria pre-date the introduction of the Timeless Isle.

If you're sure it's a bug, could I get a screenshot of the relevant tooltip(s), as well as a link to the Armory?
It took me a while to get back, because I had to wait till one of my alts hit level 90 so I could test this with a 'clean slate'.

You're right, it does indeed save the info on a per character basis - I suspect it was as you said, that the item was looted off another mob and the tooltip therefore confused me by saying I had the item but not yet killed the mob. Mea culpa!
__________________
Just remember... if the world didn't suck, we'd all fall off.
Maelynn is offline Report comment to moderator  
Reply With Quote
Old 02-23-14, 10:03 PM  
corveroth
A Fallenroot Satyr
AddOn Author - Click to view AddOns

Forum posts: 28
File comments: 86
Uploads: 13
This addon doesn't gather any information from your other characters - it is character specific. I suspect that whatever item it shows you've completed was previously looted from another mob, as several of the achievement's criteria pre-date the introduction of the Timeless Isle.

If you're sure it's a bug, could I get a screenshot of the relevant tooltip(s), as well as a link to the Armory?

Originally Posted by Maelynn
Awesome addon. The only thing I'd like to ask, though, is if you can make it on a per character basis. The achievement isn't account-wide, and as such it can be confusing to see that a certain item is marked as complete when I've never even killed that mob on the toon I'm logged to. Other than that, it's great to see this nicely listed in the tooltip, rather than having to keep my own notes and sources separately. ^^
corveroth is offline Report comment to moderator  
Reply With Quote
Old 02-23-14, 07:10 AM  
Maelynn
A Deviate Faerie Dragon
 
Maelynn's Avatar

Forum posts: 15
File comments: 181
Uploads: 0
Awesome addon. The only thing I'd like to ask, though, is if you can make it on a per character basis. The achievement isn't account-wide, and as such it can be confusing to see that a certain item is marked as complete when I've never even killed that mob on the toon I'm logged to. Other than that, it's great to see this nicely listed in the tooltip, rather than having to keep my own notes and sources separately. ^^
__________________
Just remember... if the world didn't suck, we'd all fall off.
Maelynn is offline Report comment to moderator  
Reply With Quote
Old 01-05-14, 12:01 AM  
corveroth
A Fallenroot Satyr
AddOn Author - Click to view AddOns

Forum posts: 28
File comments: 86
Uploads: 13
Woops, alright, try version 1.0e. If you're still running into issues with that, see if you can narrow down exactly what causes it.

Originally Posted by Stanzilla
oh sorry, forgot to mention that the error happened during pet battles, with the new version I randomly get this one:
corveroth is offline Report comment to moderator  
Reply With Quote
Old 01-04-14, 04:34 PM  
Stanzilla
A Deviate Faerie Dragon
AddOn Author - Click to view AddOns

Forum posts: 14
File comments: 114
Uploads: 1
Originally Posted by corveroth
Not sure what scenario this was popping up in, but I took a look and tightened up some of the safety checks involved. Try out the newest version and see what you get.

Originally Posted by Stanzilla
8x ABiggerBag\ABiggerBag.lua:270: bad argument #1 to 'strsub' (string expected, got nil)
oh sorry, forgot to mention that the error happened during pet battles, with the new version I randomly get this one:

Code:
1x ABiggerBag\ABiggerBag.lua:265: Usage: UnitGUID("unit")
[C]: in function `UnitGUID'
ABiggerBag\ABiggerBag.lua:265: in function <ABiggerBag\ABiggerBag.lua:263>
[C]: ?
[C]: ?
[C]: in function `SetUnit'
PitBull4\UnitFrame.lua:458: in function <PitBull4\UnitFrame.lua:453>
[C]: ?
FrameXML\SecureHandlers.lua:264: in function <FrameXML\SecureHandlers.lua:261>
[C]: ?
FrameXML\SecureHandlers.lua:320: in function <FrameXML\SecureHandlers.lua:304>
(tail call): ?

Locals:
self = GameTooltip {
 0 = <userdata>
 SetSpellBookItem = <function> defined =[C]:-1
 SetHyperlink = <function> defined =[C]:-1
 SetTradeSkillItem = <function> defined =[C]:-1
 SetOwner = <function> defined =[C]:-1
 comparing = false
 Show = <function> defined @TipTac\core.lua:913
 default = 1
 SetUnitDebuff = <function> defined =[C]:-1
 SetItemByID = <function> defined =[C]:-1
 SetLootItem = <function> defined =[C]:-1
 SetQuestItem = <function> defined =[C]:-1
 FadeOut = <function> defined @TipTac\core.lua:899
 SetInboxItem = <function> defined =[C]:-1
 shoppingTooltips = <table> {
 }
 SetQuestLogItem = <function> defined =[C]:-1
 SetTradeTargetItem = <function> defined =[C]:-1
 SetSpellByID = <function> defined =[C]:-1
 SetTradePlayerItem = <function> defined =[C]:-1
 SetIconTextureAndText = <function> defined @TipTacItemRef\core.lua:50
 ttIcon = <unnamed> {
 }
 updateTooltip = 0.018999987095594
 SetInventoryItem = <function> defined =[C]:-1
 ttCount = <unnamed> {
 }
 SetLootRollItem = <function> defined =[C]:-1
 SetUnitAura = <function> defined =[C]:-1
 SetAuctionSellItem = <function> defined =[C]:-1
 SetBagItem = <function> defined =[C]:-1
 SetUnitBuff = <function> defined =[C]:-1
 SetAction = <function> defined =[C]:-1
 SetGuildBankItem = <function> defined =[C]:-1
 SetSendMailItem = <function> defined =[C]:-1
 SetAuctionItem = <function> defined =[C]:-1
}
name = "Manifestation"
unit = nil
ABB = <unnamed> {
 0 = <userdata>
 sources = <table> {
 }
 IsCompleted = <function> defined @ABiggerBag\ABiggerBag.lua:241
 drops = <table> {
 }
 GetDrops = <function> defined @ABiggerBag\ABiggerBag.lua:229
 GetSources = <function> defined @ABiggerBag\ABiggerBag.lua:233
 GetName = <function> defined @ABiggerBag\ABiggerBag.lua:237
 names = <table> {
 }
}
achieveName = "Going To Need A Bigger Bag"
ItemScanner = <unnamed> {
 0 = <userdata>
 AddToItemPool = <function> defined @ABiggerBag\ABiggerBag.lua:13
 left = <table> {
 }
 itemWaitingPool = <table> {
 }
}
Stanzilla is offline Report comment to moderator  
Reply With Quote
Old 01-04-14, 12:40 AM  
corveroth
A Fallenroot Satyr
AddOn Author - Click to view AddOns

Forum posts: 28
File comments: 86
Uploads: 13
Not sure what scenario this was popping up in, but I took a look and tightened up some of the safety checks involved. Try out the newest version and see what you get.

Originally Posted by Stanzilla
8x ABiggerBag\ABiggerBag.lua:270: bad argument #1 to 'strsub' (string expected, got nil)
corveroth is offline Report comment to moderator  
Reply With Quote
Old 01-01-14, 07:29 AM  
Stanzilla
A Deviate Faerie Dragon
AddOn Author - Click to view AddOns

Forum posts: 14
File comments: 114
Uploads: 1
8x ABiggerBag\ABiggerBag.lua:270: bad argument #1 to 'strsub' (string expected, got nil)
[C]: in function `strsub'
ABiggerBag\ABiggerBag.lua:270: in function <ABiggerBag\ABiggerBag.lua:263>
[C]: ?
[C]: ?

Locals:
self = GameTooltip {
0 = <userdata>
SetSpellBookItem = <function> defined =[C]:-1
SetHyperlink = <function> defined =[C]:-1
SetTradeSkillItem = <function> defined =[C]:-1
hasMoney = 1
SetOwner = <function> defined =[C]:-1
comparing = false
Show = <function> defined @TipTac\core.lua:913
default = 1
SetUnitDebuff = <function> defined =[C]:-1
SetItemByID = <function> defined =[C]:-1
SetLootItem = <function> defined =[C]:-1
SetQuestItem = <function> defined =[C]:-1
FadeOut = <function> defined @TipTac\core.lua:899
numMoneyFrames = 1
SetInboxItem = <function> defined =[C]:-1
shoppingTooltips = <table> {
}
SetQuestLogItem = <function> defined =[C]:-1
SetTradeTargetItem = <function> defined =[C]:-1
SetSpellByID = <function> defined =[C]:-1
SetTradePlayerItem = <function> defined =[C]:-1
SetIconTextureAndText = <function> defined @TipTacItemRef\core.lua:50
ttIcon = <unnamed> {
}
updateTooltip = 0.14399999827147
SetInventoryItem = <function> defined =[C]:-1
ttCount = <unnamed> {
}
SetLootRollItem = <function> defined =[C]:-1
SetUnitAura = <function> defined =[C]:-1
SetAuctionSellItem = <function> defined =[C]:-1
SetBagItem = <function> defined =[C]:-1
SetUnitBuff = <function> defined =[C]:-1
SetAction = <function> defined =[C]:-1
SetGuildBankItem = <function> defined =[C]:-1
SetSendMailItem = <function> defined =[C]:-1
SetAuctionItem = <function> defined =[C]:-1
}
name = ""
unit = "mouseover"
ABB = <unnamed> {
0 = <userdata>
sources = <table> {
}
IsCompleted = <function> defined @ABiggerBag\ABiggerBag.lua:241
drops = <table> {
}
GetDrops = <function> defined @ABiggerBag\ABiggerBag.lua:229
GetSources = <function> defined @ABiggerBag\ABiggerBag.lua:233
GetName = <function> defined @ABiggerBag\ABiggerBag.lua:237
names = <table> {
}
}
achieveName = "Going To Need A Bigger Bag"
ItemScanner = <unnamed> {
0 = <userdata>
AddToItemPool = <function> defined @ABiggerBag\ABiggerBag.lua:13
left = <table> {
}
itemWaitingPool = <table> {
}
}
Stanzilla is offline Report comment to moderator  
Reply With Quote
Old 12-11-13, 12:23 AM  
corveroth
A Fallenroot Satyr
AddOn Author - Click to view AddOns

Forum posts: 28
File comments: 86
Uploads: 13
So apparently pets are weird. I've got a fix uploading right now - it should be available as 1.0c soon. Thanks for hunting this down! =)

Originally Posted by 2amcoffee
b) During pet battles - if I mouse over an enemy pet
corveroth is offline Report comment to moderator  
Reply With Quote
Old 12-10-13, 07:49 PM  
2amcoffee
A Defias Bandit

Forum posts: 2
File comments: 15
Uploads: 0
a) Yes, version 1.0b - the version on the wowinterface site. I re-downloaded it, deleted the old copy completely from my interface/addons folder and reinstalled the latest version.
b) During pet battles - if I mouse over an enemy pet
c) Yes this error still crops up with TipTac completely turned off.
d) The unit that gets printed when the error occurs is "mouseover"

Originally Posted by corveroth
I can't seem to replicate the issue. Can you answer a few questions?

a) Are you on version 1.0b? Earlier versions would occasionally see this error.
b) When does this happen? Every time you mouseover a character? Sometimes? Cross-realm only? When it dies? Something else?
c) Does this still occur if you turn off TipTac?

If you can't narrow it down, try adding "print(unit)", sans quotes, to line 267, save the file, and reload your interface. Let me know what it prints into chat when you get the error.

Originally Posted by 2amcoffee
Getting this error today with patch 5.4.2:
2amcoffee is offline Report comment to moderator  
Reply With Quote
Old 12-10-13, 05:58 PM  
corveroth
A Fallenroot Satyr
AddOn Author - Click to view AddOns

Forum posts: 28
File comments: 86
Uploads: 13
I can't seem to replicate the issue. Can you answer a few questions?

a) Are you on version 1.0b? Earlier versions would occasionally see this error.
b) When does this happen? Every time you mouseover a character? Sometimes? Cross-realm only? When it dies? Something else?
c) Does this still occur if you turn off TipTac?

If you can't narrow it down, try adding "print(unit)", sans quotes, to line 267, save the file, and reload your interface. Let me know what it prints into chat when you get the error.

Originally Posted by 2amcoffee
Getting this error today with patch 5.4.2:
Last edited by corveroth : 12-10-13 at 06:30 PM.
corveroth is offline Report comment to moderator  
Reply With Quote
Old 12-10-13, 04:17 PM  
2amcoffee
A Defias Bandit

Forum posts: 2
File comments: 15
Uploads: 0
Getting this error today with patch 5.4.2:

107x ABiggerBag\ABiggerBag.lua:268: bad argument #1 to "strsub" (string expected, got nil)
<in C code>
ABiggerBag\ABiggerBag.lua:268: in function <ABiggerBag\ABiggerBag.lua:263>
<in C code>

Locals:
self = GameTooltip {
0 = <userdata>
ttGradient = <unnamed> {
}
numMoneyFrames = 1
shoppingTooltips = <table> {
}
SetHyperlink = <function> defined =[C]:-1
SetUnitBuff = <function> defined =[C]:-1
SetIconTextureAndText = <function> defined @Interface\AddOns\TipTacItemRef\core.lua:50
ttIcon = <unnamed> {
}
updateTooltip = 0.15999999716878
ttCount = <unnamed> {
}
SetUnitAura = <function> defined =[C]:-1
Show = <function> defined @Interface\AddOns\TipTac\core.lua:913
SetCurrencyByID = <function> defined @Interface\AddOns\BankItems\BankItems.lua:4253
default = 1
SetUnitDebuff = <function> defined =[C]:-1
SetCurrencyToken = <function> defined @Interface\AddOns\BankItems\BankItems.lua:4261
hasMoney = 1
FadeOut = <function> defined @Interface\AddOns\TipTac\core.lua:899
comparing = false
}
name = ""
unit = "mouseover"
ABB = <unnamed> {
0 = <userdata>
sources = <table> {
}
IsCompleted = <function> defined @Interface\AddOns\ABiggerBag\ABiggerBag.lua:241
drops = <table> {
}
GetDrops = <function> defined @Interface\AddOns\ABiggerBag\ABiggerBag.lua:229
GetSources = <function> defined @Interface\AddOns\ABiggerBag\ABiggerBag.lua:233
GetName = <function> defined @Interface\AddOns\ABiggerBag\ABiggerBag.lua:237
names = <table> {
}
}
achieveName = "Going To Need A Bigger Bag"
ItemScanner = <unnamed> {
0 = <userdata>
AddToItemPool = <function> defined @Interface\AddOns\ABiggerBag\ABiggerBag.lua:13
left = <table> {
}
itemWaitingPool = <table> {
}
}
2amcoffee is offline Report comment to moderator  
Reply With Quote
Old 10-04-13, 02:50 AM  
penguinsane
A Kobold Labourer

Forum posts: 0
File comments: 27
Uploads: 0
Originally Posted by corveroth
Woops! Sorry about that, I'd fixed it a few days ago but apparently forgot to upload it. Check for 1.0b shortly. =)
Thanks for such a quick update. Updated addon, working perfectly now. Thanks again, and keep up the good work!
penguinsane is offline Report comment to moderator  
Reply With Quote
Old 10-02-13, 04:01 PM  
corveroth
A Fallenroot Satyr
AddOn Author - Click to view AddOns

Forum posts: 28
File comments: 86
Uploads: 13
Woops! Sorry about that, I'd fixed it a few days ago but apparently forgot to upload it. Check for 1.0b shortly. =)
corveroth is offline Report comment to moderator  
Reply With Quote
Old 10-02-13, 10:59 AM  
penguinsane
A Kobold Labourer

Forum posts: 0
File comments: 27
Uploads: 0
Getting this error in BugSack, not sure if it's when I login or when I mouse over something:

Code:
170x ABiggerBag\ABiggerBag.lua:267: Usage: UnitGUID("unit")
<in C code>
ABiggerBag\ABiggerBag.lua:267: in function <ABiggerBag\ABiggerBag.lua:263>
<in C code>
Informant-5.18.5433 (PassionatePhascogale)\Libs\LibExtraTip\LibExtraTip.lua:432: in function <Informant\Libs\LibExtraTip\LibExtraTip.lua:426>
<in C code>

Locals:
self = GameTooltip {
 0 = <userdata>
 SetQuestLogRewardSpell = <func> @Informant\Libs\..\LibExtraTip.lua:381
 SetSpellBookItem = <func> @Informant\Libs\..\LibExtraTip.lua:381
 Outfitter_OrigSetBagItem = <func> =[C]:-1
 SetCurrencyToken = <func> @Informant\Libs\..\LibExtraTip.lua:381
 SetTradeSkillItem = <func> @Informant\Libs\..\LibExtraTip.lua:381
 SetVoidItem = <func> =[C]:-1
 SetVoidDepositItem = <func> =[C]:-1
 SetVoidWithdrawalItem = <func> =[C]:-1
 default = 1
 Outfitter_OrigSetHyperlink = <func> =[C]:-1
 SetQuestRewardSpell = <func> @Informant\Libs\..\LibExtraTip.lua:381
 SetGuildBankItem = <func> @Informant\Libs\..\LibExtraTip.lua:381
 ARK_Data = <table> {}
 Show = <func> @TipTac\core.lua:913
 SetHyperlink = <func> @..\Outfitter.lua:7939
 SetPetAction = <func> @Informant\Libs\..\LibExtraTip.lua:381
 SetUnitDebuff = <func> @Informant\Libs\..\LibExtraTip.lua:381
 SetItemByID = <func> =[C]:-1
 SetLootItem = <func> @Informant\Libs\..\LibExtraTip.lua:381
 SetQuestItem = <func> @Informant\Libs\..\LibExtraTip.lua:381
 SetOwner = <func> =[C]:-1
 SetTrainerService = <func> @Informant\Libs\..\LibExtraTip.lua:381
 comparing = false
 Outfitter_OrigSetInventoryItem = <func> @Informant\Libs\..\LibExtraTip.lua:381
 SetShapeshift = <func> @Informant\Libs\..\LibExtraTip.lua:381
 SetInboxItem = <func> @Informant\Libs\..\LibExtraTip.lua:381
 SetBuybackItem = <func> @Informant\Libs\..\LibExtraTip.lua:381
 shoppingTooltips = <table> {}
 SetHyperlinkCompareItem = <func> =[C]:-1
 SetMerchantItem = <func> @Informant\Libs\..\LibExtraTip.lua:381
 SetMerchantCostItem = <func> =[C]:-1
 SetBackpackToken = <func> =[C]:-1
 SetUnitBuff = <func> @Informant\Libs\..\LibExtraTip.lua:381
 SetSpellByID = <func> =[C]:-1
 SetTradePlayerItem = <func> @Informant\Libs\..\LibExtraTip.lua:381
 SetIconTextureAndText = <func> @TipTacItemRef\core.lua:50
 SetSendMailItem = <func> @Informant\Libs\..\LibExtraTip.lua:381
 FadeOut = <func> @TipTac\core.lua:899
 updateTooltip = 0.11499999724329
 SetInventoryItem = <func> @..\Outfitter.lua:7919
 SetUnit = <func> @Informant\Libs\..\LibExtraTip.lua:381
 ttCount = <unnamed> {}
 SetLootRollItem = <func> @Informant\Libs\..\LibExtraTip.lua:381
 SetUnitAura = <func> =[C]:-1
 SetTalent = <func> @Informant\Libs\..\LibExtraTip.lua:381
 SetAuctionSellItem = <func> @Informant\Libs\..\LibExtraTip.lua:381
 SetBagItem = <func> @..\Outfitter.lua:7905
 SetQuestLogItem = <func> @Informant\Libs\..\LibExtraTip.lua:381
 SetAction = <func> =[C]:-1
 SetTradeTargetItem = <func> @Informant\Libs\..\LibExtraTip.lua:381
 ttIcon = <unnamed> {}
 SetAuctionItem = <func> @Informant\Libs\..\LibExtraTip.lua:381
}
name = "Meladorindra"
unit = nil
(*temporary) = <func> =[C]:-1
ABB = <unnamed> {
 0 = <userdata>
 sources
Last edited by penguinsane : 10-02-13 at 10:59 AM.
penguinsane is offline Report comment to moderator  
Reply With Quote
Post A Reply



Category Jump: