Download
(188 Kb)
Download
Updated: 03-27-10 02:48 PM
Addon for:
FuBar 3.6.5.
Pictures
File Info
Updated:03-27-10 02:48 PM
Created:unknown
Downloads:95,132
Favorites:690
MD5:
FuBar - Top ScoreFu  Popular! (More than 5000 hits)
Version: v1.0.7
by: phyber [More]
Keeps track of your top hits, heals, criticals, etc.

German translation: Chinkuwaila
French translation: Lantares
Chinese translation: mcc

TO INSTALL: Put the FuBar_TopScoreFu folder into
\World of Warcraft\Interface\AddOns\

Features
  1. Keeps track of damage and heals.
  2. Keeps track of criticals.
  3. Can distinguish between PvP and PvE.
  4. Shift-clicking can put information in the chat box, to send to others.
  5. Can stop tracking of heals.

If you find _any_ bugs, feel free to submit them at
http://phyber.wowinterface.com/porta...118&a=listbugs

If you want to request any features, feel free to submit your ideas at
http://phyber.wowinterface.com/porta...a=listfeatures

SVN: http://svn.wowace.com/root/trunk/FuBar_TopScoreFu
------------------------------------------------------------------------------
2010-03-27:
Many fixes, check the changelogs on wowace.com for a full list.

2009-04-16: v1.0.3
TOC bump for 3.1

2008-11-05: v1.0.2
Upgrade to LibSink-2.0

18/11/2008: v.1.0.1
Updated TOC for 3.0.2
Fixed for 3.0 combatlog changes. Thanks Arrowmaster.

07/05/2008: r72055
Updated for 2.4 combat log changes.
Added many mobs/bosses to the Vulnerable list. Additionally, the vulnerable mobs lists now use the NPCIDs instead of the mobs localised name.
Display '?' instead of '-1' in the top scores list when viewing top scores on mobs where the level was not available.
Maintain a cache of the players currently available spells, this should result in a speed increase when checking if a player really did cast a certain spell (previously the whole spellbook was checked each time).
Added znCN translation. Various updates to other translations.
FuBar is no longer a dependency.

2.3.57669:
Updated TOC to 20300.
Should now track Druids Pounce and Mangle properly.
Should now track Paladins Seal of Vengeance/Vengeance properly.
Should now be able to display floating text through any popular floating combat text type addons.
Added various mobs to the vulnerabilities lists.
Various translation updates.
Various other small fixes.

2.0.36344:
Can now track the Warlock "Hellfire Effect".
Removed an unnecessary Deformat-2.0 reference.
Updated TOC for WoW 2.1.

2.0.32370:
Can now click specific top scores to paste to chat.
Spanish translation by shiftos added.
Notification support for MSBT.
Now uses Parser-3.0 for parsing combat logs.
New option to ignore vulnerable mobs.

2.0.19609:
Updated to work with 2.0.
Added Chinese translation (thanks mcc).

2.0.14429:
Upgraded to AceLocale-2.2, Babble-Class-2.2 and Babble-Spell-2.2.
Fixed colouring of highest normal hit.

2.0.11984:
Fixed a small bug related to PvP and some left over Ace1 code.
Removed silly extra version number (the .2). Not sure what I was thinking.

2.0.2.9945:
Fixed version number, previous should have been 2.0.1 not 2.1.
Really fixed IsOnlyPvP() error when pasting scores into chat.

2.1.9820:
Fixed a small bug with pasting the scores into the chat.

2.0.9446:
Upgraded to FuBar2.
Updated TOC to 11200.

1.1.2989:
changed splash width from 512 to GetScreenWidth()
updated for BabbleLib-1.2
fixed .toc
changed good slashes (/) to evil slashes (\) in the .toc

1.1.1391:
added purging of data.
Now can handle resists.

1.1.1328:
now works for Paladin Judgements

1.1.1111:
updated for procedural tooltips.

1.1.1014:
updated TOC and README.txt

1.1.998:
added deDE translation (thanks to Chinkuwaila)

1.1.937:
Updated for 1.1

1.0.794:
now LoadOnDemand

1.0.762:
no longer records if player is charmed.

1.0.584:
added per-spell filtering.
Added heal-only filtering.

1.0.285:
Updated for 1.0

0.9.99.339:
Fixed typo that made /tsfu not work.

0.9.99.333:
Optimized for Compost.
Changed FuBarTooltip to self.tooltip

0.9.10.243:
Updated for BabbleLib

0.9.9.213:
Fixed BossPanelUtils typo.

0.9.9:
Changed name to Top ScoreFu

0.9.7.175:
Fix releaseDate typo

0.9.6.163:
Can now support trivial (gray) units with an option.

0.9.6.143:
Fixed the code to insert text into the edit box

0.9.5.114:
Shift-clicking now can insert info into the chat edit box.

0.9.5.93:
Fixed bpCompatible typo

0.9.5.75:
Checks if a unit is trivial (gray) better.
Fixed ordering of splash.

0.9.4:
Fixed ordering of chat catches for better localization support.

0.9.3:
Updated TOC to 11000.

0.9.1.1:
Now can reset your scores.
Now can change the position of the splash (only available through command line).
changed "party1pet" to "partypet1", etc.

0.9.1:
Initial
Archived Files (2)
File Name
Version
Size
Author
Date
v1.0.3
188kB
phyber
04-16-09 01:33 AM
v1.0.1
209kB
phyber
11-18-08 02:28 AM


Post A Reply Comment Options
Old 12-05-09, 12:23 PM  
DaKillerCow
A Kobold Labourer
 
DaKillerCow's Avatar
AddOn Author - Click to view AddOns

Forum posts: 1
File comments: 5
Uploads: 2
LUA Error

100th Comment

Anyway, this only happened recently, was working fine before, don't know what happened. These are the details of the error:

Code:
Date: 2009-12-05 19:15:38
ID: 2
Error occured in: Global
Count: 1
Message: ..\AddOns\FuBar_TopScoreFu\TopScoreFu.lua line 692:
   attempt to index field '?' (a nil value)
Debug:
   [C]: ?
   FuBar_TopScoreFu\TopScoreFu.lua:692: OnTooltipUpdate()
   ...AtlasLootFu\Libs\FuBarPlugin-2.0\FuBarPlugin-2.0.lua:393: runChildren()
   ...nterface\AddOns\FuBar\libs\Tablet-2.0\Tablet-2.0.lua:2370: children()
   ...nterface\AddOns\FuBar\libs\Tablet-2.0\Tablet-2.0.lua:2414: Open()
   ...nterface\AddOns\FuBar\libs\Tablet-2.0\Tablet-2.0.lua:2548:
      ...nterface\AddOns\FuBar\libs\Tablet-2.0\Tablet-2.0.lua:2542
   ...AtlasLootFu\Libs\FuBarPlugin-2.0\FuBarPlugin-2.0.lua:442:
      ...AtlasLootFu\Libs\FuBarPlugin-2.0\FuBarPlugin-2.0.lua:441
AddOns:
  Swatter, v5.6.4424 (KangaII)
  Corpse, v3.2.0.1
  NPCScan, v3.2.0.8
  AckisRecipeList, v1.0 2695
  ACP, v3.2.0.23 
  AFA, v1.3
  AspectedAgain, v3.0.2.0
  Atlas, v1.15.1
  AtlasBattlegrounds, v1.15.1
  AtlasDungeonLocs, v1.15.1
  AtlasOutdoorRaids, v1.15.1
  AtlasTransportation, v1.15.1
  AtlasLoot, vv5.08.10
  AtlasLootFu, vv5.08.10
  AucAdvanced, v5.6.4424 (KangaII)
  AucFilterBasic, v5.6.4424 (KangaII)
  AucFilterOutlier, v5.6.4424.2531
  AucMatchUndercut, v5.6.4424.2531
  AucStatClassic, v5.6.4424 (KangaII)
  AucStatHistogram, v5.6.4424 (KangaII)
  AucStatiLevel, v5.6.4424 (KangaII)
  AucStatPurchased, v5.6.4424 (KangaII)
  AucStatSales, v5.6.4424.2842
  AucStatSimple, v5.6.4424 (KangaII)
  AucStatStdDev, v5.6.4424 (KangaII)
  AucStatWOWEcon, v5.6.4424.2530
  AucUtilAHWindowControl, v5.6.4424.3311
  AucUtilAppraiser, v5.6.4424.2530
  AucUtilAskPrice, v5.6.4424.3175
  AucUtilAutoMagic, v5.6.4424.3142
  AucUtilCompactUI, v5.6.4424.2530
  AucUtilEasyBuyout, v5.6.4424.3583
  AucUtilFixAH, v5.6.4424 (KangaII)
  AucUtilItemSuggest, v5.6.4424.3108
  AucUtilPriceLevel, v5.6.4424.2545
  AucUtilScanButton, v5.6.4424.2530
  AucUtilScanFinish, v5.6.4424.2530
  AucUtilScanProgress, v5.6.4424.2530
  AucUtilSearchUI, v5.6.4424.3655
  AucUtilSimpleAuction, v5.6.4424.0
  AucUtilVendMarkup, v5.6.4424.2530
  AuctionProfit, v0.9
  Auctionator, v2.5.2
  AutoGratz, v1
  AutoRes, v
  Babylonian, v5.1.DEV.130
  BadBoy, v4.0.1.2
  Bagnon, v2.12.0
  BagnonForever, v1.1.2
  BagnonTooltips, v
  BeanCounter, v5.6.4424 (KangaII)
  BetterInbox, v
  BetterOutbox, v
  BioPulse, v0.3
  BioTint, v0.1
  Carbonite, v3.23
  CarboniteTransfer, v1.01
  Collectinator, vBeta 3
  Configator, v5.1.DEV.130
  CrapAway, v
  CurseProfiler, v
  DBMBurningCrusade, v
  DBMCore, v
  DebugLib, v5.1.DEV.130
  Enchantrix, v5.6.4424 (KangaII)
  EnchantrixBarker, v5.6.4424 (KangaII)
  epgplootmaster, v0.4.5
  epgplootmasterml, v0.4.5
  Flightmap, v
  FuBar, v
  FuBarAtlasFu, v
  FuBarCalendarFu, v3.0.0
  FuBarClockFu, v3.0
  FuBarDurabilityFu, v2.11
  FuBarExitFu, v1.1
  FuBarFriendsFu, v2.4.4-103
  FuBarGuildFu, v2.4.4-117
  FuBarIceHudFu, v1.5
  FuBarMoneyFu, vv1.2.2
  FuBarPerformanceFu, v2.0.0
  FuBarRecountFu, v3.10
  FuBarReloadUI, v2.0.0
  FuBarTopScoreFu, vv1.0.6
  FubarWintergrasperFu, v1.11
  FuBarXPerlFu, v0.2
  GnomeSage, v1.0
  Grid, v1.30200.2009120101
  GuildFilter, v
  GuildWelcome, v3.16
  HealBot, v3.2.2.9
  IceHUD, v1.5.15 (Revision: 447)
  Informant, v5.6.4424 (KangaII)
  InnerFire, v
  LibRock10, v
  MikScrollingBattleText, v5.4.66
  Misspelled, v0.3.41
  Omfg, v30200.2
  OmniCC, v2.5.7
  Prat30, v3.2.10 
  Prat30Libraries, v
  Quartz, v1.0
  QuartzBuff, v1.0
  QuartzFlight, v1.0
  QuartzFocus, v1.0
  QuartzGCD, v1.0
  QuartzInterrupt, v1.0
  QuartzLatency, v1.0
  QuartzMirror, v1.0
  QuartzPet, v1.0
  QuartzPlayer, v1.0
  QuartzRange, v1.0
  QuartzSwing, v1.0
  QuartzTarget, v1.0
  QuartzTimer, v1.0
  QuartzTradeskill, v1.0
  Recount, v
  SexyMap, v
  SharedMedia, v3.0.1-177
  SharedMediaAdditionalFonts, v1.0
  Skinner, vb2.10835.3
  SlideBar, v5.6.4424 (KangaII)
  SpartanUISpinCam, v2.6.0.30200
  Stubby, v5.6.4424 (KangaII)
  Toons, v2.5.2
  VisualHeal, v
  WIM, v3.2.2
  XLoot, v0.9
  XLootGroup, v0.5
  XLootMaster, v0.8
  XPerl, v3.0.6
  XPerlArcaneBar, v
  XPerlParty, v
  XPerlPartyPet, v
  XPerlPlayer, v
  XPerlPlayerBuffs, v
  XPerlPlayerPet, v
  XPerlRaidAdmin, v
  XPerlRaidFrames, v
  XPerlRaidHelper, v
  XPerlRaidMonitor, v
  XPerlRaidPets, v
  XPerlTarget, v
  XPerlTargetTarget, v
  BlizRuntimeLib_enUS v3.2.2.30200 <eu>
  (ck=dee)
Thanks
Last edited by DaKillerCow : 12-05-09 at 12:25 PM.
DaKillerCow is offline Report comment to moderator  
Reply With Quote
Old 05-25-09, 03:13 PM  
Michalev
A Kobold Labourer

Forum posts: 0
File comments: 1
Uploads: 0
Ok so I have been manually editing the LUA for the last few releases and I thought i would share the code for the vulnerable mobs in WotLK. As Naxx is included in vanilla wow and OS doesnt have any vulnerable mobs all that is needed is EoE and Ulduar.

*Edit* Added TotC Bosses.

Code:
        ---------------------[[
	--  WotLK Instances  --
	---------------------]]
	-- Eye of Eternity
	[28859] = true, -- Malygos
	[30084] = true, -- Power Spark
	[30245] = true, -- Nexus Lord
	[30249] = true, -- Scion of Eternity
	-- Ulduar
	[33329] = true, -- Heart of the Deconstructor
	[32857] = true, -- Stormcaller Brundir
	[32927] = true, -- Runemaster Molgeim
	[32867] = true, -- Steelbreaker
	[32958] = true, -- Lightning Elemental
	[32845] = true, -- Hodir
	[32938] = true, -- Flash Freeze
	[32926] = true, -- Flash Freeze
	[32915] = true, -- Elder Brightleaf
	[32906] = true, -- Freya
	[33203] = true, -- Ancient Conservator
	[32918] = true, -- Detonating Lasher
	[33202] = true, -- Ancient Water Spirit
	[32919] = true, -- Storm Lasher
	[32916] = true, -- Snaplasher
	[33670] = true, -- Aerial Command Unit
	[33271] = true, -- General Vezax
	[33488] = true, -- Saronite Vapors
	[33524] = true, -- Saronite Animus
	[33288] = true, -- Yogg-Saron
	[33890] = true, -- Brain of Yogg-Saron
	[33136] = true, -- Guradian of Yogg-Saron
	[33988] = true, -- Immortal Guradian
	[33983] = true, -- Constrictor Tentacle
	[33966] = true, -- Crusher Tentacle
	[33985] = true, -- Corruptor Tentacle
	--Trial of the Crusader
	[34797] = true, -- Icehowl
	[34496] = true, -- Eydis Darkbane
	[34497] = true, -- Fjola Lightbane
Last edited by Michalev : 09-04-09 at 06:01 PM.
Michalev is offline Report comment to moderator  
Reply With Quote
Old 05-22-09, 01:47 PM  
phyber
A Murloc Raider
AddOn Author - Click to view AddOns

Forum posts: 6
File comments: 72
Uploads: 14
Oh, also, if you happen to know the names/spellids of thigns that give those insane damage buffs/debuffs on bosses, post those too. I can start building up a blacklist then
phyber is offline Report comment to moderator  
Reply With Quote
Old 05-22-09, 02:54 AM  
phyber
A Murloc Raider
AddOn Author - Click to view AddOns

Forum posts: 6
File comments: 72
Uploads: 14
Re: Updated Vulnerable Mobs

Thanks for those. They'll appear in the next released version
Haven't raided myself for a while, so I don't see quite as many vulnerable mobs now
Originally posted by Unskilled
Code:
	--  WotLK Instances  --
	---------------------]]
	-- The Eye of Eternity --
	[28859] = true, -- Malygos
	--      Ulduar       --
	[33329] = true, -- Heart of the Deconstructor
	[32867] = true, -- Steelbreaker
	[32927] = true, -- Runemaster Molgeim
	[32857] = true, -- Stormcaller Brundir
So far, this is all i know of in Ulduar atm.
Anyone else know more, just post the name and ill update it here.
phyber is offline Report comment to moderator  
Reply With Quote
Old 05-09-09, 06:51 PM  
Unskilled
A Kobold Labourer

Forum posts: 0
File comments: 1
Uploads: 0
Updated Vulnerable Mobs

Code:
	--  WotLK Instances  --
	---------------------]]
	-- The Eye of Eternity --
	[28859] = true, -- Malygos
	--      Ulduar       --
	[33329] = true, -- Heart of the Deconstructor
	[32867] = true, -- Steelbreaker
	[32927] = true, -- Runemaster Molgeim
	[32857] = true, -- Stormcaller Brundir
So far, this is all i know of in Ulduar atm.
Anyone else know more, just post the name and ill update it here.
Unskilled is offline Report comment to moderator  
Reply With Quote
Old 04-02-09, 06:44 PM  
AmiYuy
A Deviate Faerie Dragon
 
AmiYuy's Avatar
AddOn Author - Click to view AddOns

Forum posts: 12
File comments: 64
Uploads: 1
Originally posted by phyber
It's not ideal, but for those still receiving the 't' nil value errors, you can try:
Code:
/script TopScoreFu:FixIt()
which should spam your chat window a bit telling you which bits were broken as it fixes them.

You might want to backup your saved variables for TopScoreFu just in case something terrible happens, but this is the function I used to fix my own SavedVars.
This function has actually been in TSF for a while, but it just isn't documented anywhere.
That did it, thanks!
AmiYuy is offline Report comment to moderator  
Reply With Quote
Old 03-23-09, 07:30 AM  
phyber
A Murloc Raider
AddOn Author - Click to view AddOns

Forum posts: 6
File comments: 72
Uploads: 14
It's not ideal, but for those still receiving the 't' nil value errors, you can try:
Code:
/script TopScoreFu:FixIt()
which should spam your chat window a bit telling you which bits were broken as it fixes them.

You might want to backup your saved variables for TopScoreFu just in case something terrible happens, but this is the function I used to fix my own SavedVars.
This function has actually been in TSF for a while, but it just isn't documented anywhere.
phyber is offline Report comment to moderator  
Reply With Quote
Old 02-19-09, 01:08 AM  
AmiYuy
A Deviate Faerie Dragon
 
AmiYuy's Avatar
AddOn Author - Click to view AddOns

Forum posts: 12
File comments: 64
Uploads: 1
Originally posted by Naurbrannon
I often a similar message when using rain of fire:
..\AddOns\FuBar_TopScoreFu\TopScoreFu.lua line 517:
attempt to index local 't' (a nil value)
Same error when I use Volley.

I was really hoping to see this updated!
AmiYuy is offline Report comment to moderator  
Reply With Quote
Old 02-04-09, 12:32 PM  
Pseudopath
A Murloc Raider
AddOn Author - Click to view AddOns

Forum posts: 4
File comments: 70
Uploads: 1
incorrect numbers

I've attempted to use this addon a couple of times but it records my critical judgements incorrectly. instead of a 9.5k crit I have and entry for 2.5k. Although healing appears to be fine just damage is having problems. hope you can fix this as I like to keep an eye on my progress. Thanks.

- Pseudopath.
Last edited by Pseudopath : 02-04-09 at 12:36 PM.
Pseudopath is offline Report comment to moderator  
Reply With Quote
Old 01-06-09, 02:19 PM  
Naurbrannon
A Defias Bandit
AddOn Author - Click to view AddOns

Forum posts: 2
File comments: 18
Uploads: 2
Originally posted by Ookami.kun
Hoping this addon get's updated along with all the other FuBar mods. Anyway, ran into the error today. Figured I'd post it to let you know for any future fixes. Thanks.

Date: 2008-11-07 22:23:29
ID: 24
Error occured in: Global
Count: 1
Message: ..\AddOns\FuBar_TopScoreFu\TopScoreFu.lua line 506:
attempt to index local 't' (a nil value)
Debug:
...ce\AddOns\Skillet\Libs\AceEvent-2.0\AceEvent-2.0.lua:299: TriggerEvent()
...ce\AddOns\Skillet\Libs\AceEvent-2.0\AceEvent-2.0.lua:910:
...ce\AddOns\Skillet\Libs\AceEvent-2.0\AceEvent-2.0.lua:903
AddOns:
I often a similar message when using rain of fire:
..\AddOns\FuBar_TopScoreFu\TopScoreFu.lua line 517:
attempt to index local 't' (a nil value)
Naurbrannon is offline Report comment to moderator  
Reply With Quote
Old 12-16-08, 03:05 AM  
Blackout05
A Defias Bandit

Forum posts: 3
File comments: 13
Uploads: 0
Any option with 1.0.2 to turn off the chat text that says New attack record
Blackout05 is offline Report comment to moderator  
Reply With Quote
Old 11-24-08, 03:18 PM  
Crazytoo
A Kobold Labourer

Forum posts: 1
File comments: 35
Uploads: 0
I turned it off but it still keep showing New Record.
I would really like it to go away.
Thank You for your time
Crazytoo is offline Report comment to moderator  
Reply With Quote
Old 11-07-08, 08:26 PM  
Ookami.kun
A Theradrim Guardian
 
Ookami.kun's Avatar

Forum posts: 68
File comments: 175
Uploads: 0
Hoping this addon get's updated along with all the other FuBar mods. Anyway, ran into the error today. Figured I'd post it to let you know for any future fixes. Thanks.

Date: 2008-11-07 22:23:29
ID: 24
Error occured in: Global
Count: 1
Message: ..\AddOns\FuBar_TopScoreFu\TopScoreFu.lua line 506:
attempt to index local 't' (a nil value)
Debug:
...ce\AddOns\Skillet\Libs\AceEvent-2.0\AceEvent-2.0.lua:299: TriggerEvent()
...ce\AddOns\Skillet\Libs\AceEvent-2.0\AceEvent-2.0.lua:910:
...ce\AddOns\Skillet\Libs\AceEvent-2.0\AceEvent-2.0.lua:903
AddOns:
Ookami.kun is offline Report comment to moderator  
Reply With Quote
Old 10-19-08, 08:47 PM  
Cilraaz
An Aku'mai Servant
 
Cilraaz's Avatar
AddOn Author - Click to view AddOns

Forum posts: 36
File comments: 67
Uploads: 9
Fixes for 3.0.2

Originally posted by NeadayanDrakhon
Top ScoreFu no longer recognizing a difference between crit and non crit.

*EDIT* Am using r80865.1 downloaded from wowace on 8/15/08
[NOTE: The information below is based on version 1.0, released on Curse on 10/7/08.]

I figured out the fix for this. The default code doesn't take into consideration the new overkill/overhealing variables put out by COMBAT_LOG_EVENT_UNFILTERED, so the variable being passed as "critical" is actually the "absorbed" variable. To correct it, edit TopScoreFu.lua, changing lines 254 to 286 (beginning and end of "function TopScoreFu:COMBAT_LOG_EVENT_UNFILTERED") to:

Code:
function TopScoreFu:COMBAT_LOG_EVENT_UNFILTERED(timestamp, eventtype, srcGUID, srcName, srcFlags, dstGUID, dstName, dstFlags, ...)
	if bit_band(srcFlags, COMBATLOG_FILTER_ME) == COMBATLOG_FILTER_ME then
		local spellId, spellName, spellSchool, amount, overkill, overhealing, school, resisted, blocked, absorbed, critical, glancing, crushing
		local unitid, heal
		if eventtype == "SWING_DAMAGE" then
			amount, overkill, school, resisted, blocked, absorbed, critical, glancing, crushing = ...
			heal = false
		elseif eventtype == "RANGE_DAMAGE" or eventtype == "SPELL_DAMAGE" or eventtype == "SPELL_PERIODIC_DAMAGE" then
			spellId, spellName, spellSchool, amount, overkill, school, resisted, blocked, absorbed, critical, glancing, crushing = ...
			heal = false
		elseif eventtype == "SPELL_HEAL" or eventtype == "SPELL_PERIODIC_HEAL" then
			spellId, spellName, spellSchool, amount, overhealing, critical = ...
			heal = true
		else
			return
		end
		-- Quickly check if this is a vulnerable NPC.  No point continuing if it is.
		if bit_band(dstFlags, COMBATLOG_FILTER_NPC) == COMBATLOG_FILTER_NPC then
			if self:IsIgnoringVulnerable() and self:IsVulnerable(getNPCID(dstGUID)) then
				return
			end
		end
		--
		if UnitExists(dstName) then
			unitid = dstName
		elseif bit_band(dstFlags, COMBATLOG_OBJECT_TARGET) == COMBATLOG_OBJECT_TARGET then
			unitid = "target"
		elseif bit_band(dstFlags, COMBATLOG_OBJECT_FOCUS) == COMBATLOG_OBJECT_FOCUS then
			unitid = "focus"
		end
		self:RecordHit(spellName or spelldata["attack"], amount, dstName, unitid, critical, heal, bit_band(dstFlags, COMBATLOG_FILTER_PVP) == COMBATLOG_FILTER_PVP)
	end
end
This adds in the overkill/overhealing variables, pushing "critical" to the proper column, allowing the mod to recognize the difference between crit and non-crit. A quick test (running out of Crossroads with my lowbie Priest and firing Smite until I got a crit) confirmed this, as it registered the non-crits as regular and the crit as a critical.

Also, I would suggest commenting out (put "--", without quotes, in front of) lines 21-33 and lines 398-404. The spell numbers were changed for the Paladin, Warlock, and Shaman spells that these bits of code were meant to handle, so it's no longer viable.
Last edited by Cilraaz : 10-19-08 at 08:58 PM.
Cilraaz is offline Report comment to moderator  
Reply With Quote
Old 10-16-08, 01:42 AM  
NeadayanDrakhon
A Murloc Raider

Forum posts: 4
File comments: 10
Uploads: 0
Top ScoreFu no longer recognizing a difference between crit and non crit.

*EDIT* Am using r80865.1 downloaded from wowace on 8/15/08
Last edited by NeadayanDrakhon : 10-16-08 at 01:44 AM.
NeadayanDrakhon is offline Report comment to moderator  
Reply With Quote
Post A Reply



Category Jump:

Support AddOn Development!

You have just downloaded by the author . If you like this AddOn why not consider supporting the author? This author has set up a donation account. Donations ensure that authors can continue to develop useful tools for everyone.