Download
(26 Kb)
Download
Updated: 06-18-07 05:49 PM
Pictures
File Info
Updated:06-18-07 05:49 PM
Created:unknown
Downloads:3,121
Favorites:17
MD5:
SimpleBankState
Version: 149
by: rophy [More]
This is an offline bank statement mod, this is NOT a bag / bank UI replacement mod.

Type /sbs (or set a keybinding) to show the search frame, enter a keyword to search for matching items in bank, bags, mails and equipments of all your characters, that's it.

Left click a column to sort, right click to configure filters on that column.

v137 is a complete rewrite, I took this chance to change the version numbering, it's probably easier to just use revision as the version number.

Some major changes:
- Redesigned the search frame, shows item texture, shift click to insert item link to chat.
- Redesigned the data structure on item list built by the search frame to cost much less memory (the data structure of saved variables didn't change, so fully backward compatible).
- Filters are now check lists instead of drop down lists.
- Added the ability to select what columns to show. Added column "Item Type" and "Equip Location".
- Changed the backbone framework from Ace2 to Dongle.
Optional Files (0)


Post A Reply Comment Options
Unread 07-27-07, 07:38 PM  
rophy
A Fallenroot Satyr
AddOn Author - Click to view AddOns

Forum posts: 24
File comments: 126
Uploads: 12
Re: feature request

Originally posted by BlackZam
I got two feature I think would be nice.
1. Be able to shift-left link in to the search box.
2. Don't show stacks one row per stack but instead show the total of the item you search for and then in the result have a column showing how many stacks it is.

other then that, this was the right addon I needed when I have mailed stuff to my alts in panic and now try to find everything again...


I can't reset the filters and/or clear the window.
And if you could add so that you can browse with the mouse-wheel in the window, that would be nice...
I'll see what I can do about shift-click and mouse-wheel.

Alt-right click the filter button at left top corner should reset the column filters, it isn't working for you?

About stacks, I'm not sure how to display when there are multiple stacks with different size. May be I'll only merge those with the same size and the same location.
Last edited by rophy : 07-27-07 at 07:45 PM.
rophy is offline Report comment to moderator  
Reply With Quote
Unread 07-26-07, 11:21 PM  
BlackZam
A Murloc Raider

Forum posts: 7
File comments: 51
Uploads: 0
feature request

I got two feature I think would be nice.
1. Be able to shift-left link in to the search box.
2. Don't show stacks one row per stack but instead show the total of the item you search for and then in the result have a column showing how many stacks it is.

other then that, this was the right addon I needed when I have mailed stuff to my alts in panic and now try to find everything again...


I can't reset the filters and/or clear the window.
And if you could add so that you can browse with the mouse-wheel in the window, that would be nice...
Last edited by BlackZam : 07-26-07 at 11:43 PM.
BlackZam is offline Report comment to moderator  
Reply With Quote
Unread 02-03-07, 05:51 AM  
rophy
A Fallenroot Satyr
AddOn Author - Click to view AddOns

Forum posts: 24
File comments: 126
Uploads: 12
Re: Re: possible lockup

Originally posted by Zidomo
Very interesting, detailed analysis.

Only thing with the conclusion is that I am not running a slow computer here. Not the latest, but not slow, either. 3 Ghz, 1GB of RAM, fully updated Windows XP, the latest video, sound & network drivers (I'm vigilant in keeping those updated as I know what I'm doing with computers), DSL, 105-125 ms median latency, no background processes whatsoever using up CPU or disk read/writes, 45 FPS median frame rate. Never have a problem with lag here, unless its caused server-side.

I left the thing up for a full 30 minutes or so during one of the testing trials before killing it; it remained frozen throughout that time. So its really is in effect a complete freeze rather than a big slow down.

Will give this another go when another WoW patch comes up.
You're right, it's a complete freeze, I was able to reproduce it by sending lots of junks to one character of mine - about 40 mails.

After the character has lots of mails, remove the 'cache' directory of WoW, using v1.2.21 of the mod, log in, open mailbox, the client start receiving massive MAIL_INBOX_UPDATE, WOW freezes.

Now remove the 'cache' directory again, use the newest v1.2.30, log in the same character, open mail, and the client passed the massive MAIL_INBOX_UPDATE events.

So 1.2.30 should have fixed the problem, sorry for the inconvenience and thanks for the reports everyone.

Something interesting is that you also receive massive BAG_UPDATE after clearing the cache, where many bag-related mods will try to parse bags on such event. So after every patch (or when you have cleared the cache directory), it helps if you first log in with all mods turned off, and turn the mods on after the cache is built.
Last edited by rophy : 02-03-07 at 05:58 AM.
rophy is offline Report comment to moderator  
Reply With Quote
Unread 02-02-07, 11:37 AM  
Zidomo
A Cliff Giant
 
Zidomo's Avatar

Forum posts: 76
File comments: 1049
Uploads: 0
Re: possible lockup

Originally posted by rophy
After some searching and testing, I think I have (hopefully) found the cause of lockup, although I still can't reproduce it myself.

When you cleared the cache folder (or have a server patch), WoW client have to rebuilt the cache info, and it seems to be firing massive MAIL_INBOX_UPDATE on such case.

After the cache is built, I receive one MAIL_INBOX_UPDATE after opening the mailbox, but when it is buiding the cache, I receive like 10 MAIL_INBOX_UPDATE events for only 3 mails in my inbox, some mods mentioned they received like 400 events for 30 mails.

So if you have a low end PC with lots of mail. it's possible that it could cause a big slow down (not a complete freeze).

If the cause is known, then the problem can be fixed. I used anther mechanism to handle the caching of items, which should not be affected by massive MAIL_INBOX_UPDATE events. Please try 1.2.30 and see if the problem still exists.
Very interesting, detailed analysis.

Only thing with the conclusion is that I am not running a slow computer here. Not the latest, but not slow, either. 3 Ghz, 1GB of RAM, fully updated Windows XP, the latest video, sound & network drivers (I'm vigilant in keeping those updated as I know what I'm doing with computers), DSL, 105-125 ms median latency, no background processes whatsoever using up CPU or disk read/writes, 45 FPS median frame rate. Never have a problem with lag here, unless its caused server-side.

I left the thing up for a full 30 minutes or so during one of the testing trials before killing it; it remained frozen throughout that time. So its really is in effect a complete freeze rather than a big slow down.

Will give this another go when another WoW patch comes up.
Last edited by Zidomo : 02-02-07 at 11:44 AM.
Zidomo is offline Report comment to moderator  
Reply With Quote
Unread 02-02-07, 01:12 AM  
rophy
A Fallenroot Satyr
AddOn Author - Click to view AddOns

Forum posts: 24
File comments: 126
Uploads: 12
possible lockup

After some searching and testing, I think I have (hopefully) found the cause of lockup, although I still can't reproduce it myself.

When you cleared the cache folder (or have a server patch), WoW client have to rebuilt the cache info, and it seems to be firing massive MAIL_INBOX_UPDATE on such case.

After the cache is built, I receive one MAIL_INBOX_UPDATE after opening the mailbox, but when it is buiding the cache, I receive like 10 MAIL_INBOX_UPDATE events for only 3 mails in my inbox, some mods mentioned they received like 400 events for 30 mails.

So if you have a low end PC with lots of mail. it's possible that it could cause a big slow down (not a complete freeze).

If the cause is known, then the problem can be fixed. I used anther mechanism to handle the caching of items, which should not be affected by massive MAIL_INBOX_UPDATE events. Please try 1.2.30 and see if the problem still exists.
rophy is offline Report comment to moderator  
Reply With Quote
Unread 02-01-07, 05:45 AM  
rophy
A Fallenroot Satyr
AddOn Author - Click to view AddOns

Forum posts: 24
File comments: 126
Uploads: 12
Originally posted by chilljf
I was having the exact same lockup problems as described below after deleting my cache(wbd) folder. Upon logging in my 1st time after a cache clear, I will lockup checking my mailbox. Simple solution I had was to disable simplebankstate, login & check my mailbox, than reenable simplebankstate & all is kosher I figured it was related to rebuilding the cache of my mailbox items & simplebank was trying to check the items b4 they got cached. Im far from a programmer to help in a solution but if u try deleting your cache folder, that should reproduce the error.

This problem still exist with 1.2.21 btw
I tried deleting cache directory many times when Zidomo reported the problem, and couldn't reproduce the problem at all.

Can you reproduce the lockup by clearing the cache directory? If you can, try downloading Sanity2 and see if it has the same problem?
rophy is offline Report comment to moderator  
Reply With Quote
Unread 01-30-07, 11:05 PM  
chilljf
A Kobold Labourer

Forum posts: 0
File comments: 4
Uploads: 0
I was having the exact same lockup problems as described below after deleting my cache(wbd) folder. Upon logging in my 1st time after a cache clear, I will lockup checking my mailbox. Simple solution I had was to disable simplebankstate, login & check my mailbox, than reenable simplebankstate & all is kosher I figured it was related to rebuilding the cache of my mailbox items & simplebank was trying to check the items b4 they got cached. Im far from a programmer to help in a solution but if u try deleting your cache folder, that should reproduce the error.

This problem still exist with 1.2.21 btw
Last edited by chilljf : 01-30-07 at 11:09 PM.
chilljf is offline Report comment to moderator  
Reply With Quote
Unread 01-18-07, 08:36 PM  
rophy
A Fallenroot Satyr
AddOn Author - Click to view AddOns

Forum posts: 24
File comments: 126
Uploads: 12
Re: Re: Re: This mod causes a severe WoW problem

It's impossible to reproduce a cross-patch login test, so I can only guess.

The thing that got changed cross-patch is the item cache (it got resets every patch), but I doubt that's the cause of a freeze.

You mentioned MaterialsTracker, in fact by searching on the google, I found that even SanityInventory had comments on freezing at mailbox, so I believe it's true that iterating through the mailbox can cause a freeze on some unknown situation.

By looking at the code of both MateralsTracker and Sanity2, they both seems to be thinking that the freeze is caused by multiple MAIL_INBOX_UPDATE events being fired on parallel, so the mailbox handler were being run twice on parallel, which cause unexpected behavior.

To my knowledge WoW's event system is single threaded and I have never seen two events being fired on parallel. But anyway the check I added in 1.2.21 is an attempt to prevent parallel MAIL_INBOX_UPDATE events, which is similar to the one in MaterialsTracker. So I hope this solves the problem, but if there are no way to reproduce it, I have no way to confirm.
rophy is offline Report comment to moderator  
Reply With Quote
Unread 01-18-07, 07:34 AM  
Zidomo
A Cliff Giant
 
Zidomo's Avatar

Forum posts: 76
File comments: 1049
Uploads: 0
Re: Re: This mod causes a severe WoW problem

Originally posted by rophy
I have never experience a freeze myself, and the code for mailbox event handling is so simple that I can't find anything wrong with it. So I have no idea on how to solve the problem.

Anyway I added a pre-check on the mailbox event handling code as an attempt to fix the problem, I hope you can give it another test to see if the code works.

If you have any info on how to reproduce the freeze it'll be very helpful too.
The problem only occurs under a very specific (but common) circumstance. And only occurs within a limited time frame. So its hard to replicate unless you are within the same time frame.

As in:

--Exit WoW before an official WoW patch that increases the version number (such as 2.0.4 to 2.0.5). have SimpleBankState active at the time you last exited WoW.

--Come back into WoW after the patch.

--Open a mailbox on any character on a single account after a patch (with SimpleBankState still enabled). Within 2-10 seconds, WoW locks up. The mailbox inventory list doesn't completely finalize showing. As in you will see "Alliance Auction House" or "Unknown" in the mail headers but the item icon doesn't appear before the lockup/screen freeze happens.

--Kill WoW, come back in (after rebooting if needed and/or doing a disc scan to repair files corrupted by having to reboot before all apps could be closed), try a different character on the same account. WoW locks up again as above.

--Kill WoW, come back on the first character tried. Still locks up.

--Disable SimpleBankState after logging out and log back in. Open a mailbox on one of the characters in which it locked up previously. The problem goes away.

--Reenable SimpleBankState after successfully logging on as above. It does not cause lockups any more. Only on the mailbox openings on an account right after a patch with it enabled.
Zidomo is offline Report comment to moderator  
Reply With Quote
Unread 01-18-07, 07:23 AM  
Zidomo
A Cliff Giant
 
Zidomo's Avatar

Forum posts: 76
File comments: 1049
Uploads: 0
Re: Re: This mod causes a severe WoW problem

Originally posted by Fleetfoot
A better test would probably have been to just enable this mod and nothing else and then see if you could reproduce the crash. And since it seem this isnt a universal problem i would say that youre statment that it is unacceptable is pretty far off from the truth. The simple truth is that problems like this can be hard to reproduce for an author and even more hard to fix.
Thanks for the useless fanboi comment, its appreciated .

As the end result is the same, what major difference does the testing criteria make? Whether or not its an interaction with another mod (I already listed the only mail/inventory mod I had running, which was Postal), it is this mod that was determined to be the cause of the crash.

Sure, it may be slightly easier to debug if you know that for sure its not an interaction with another mod helping to cause the problem. But there is only so much program crashing and file corruption that a person will put up with trying to find the cause of a problem before saying "no more". Lucky I tested as much as I did to find the cause.

Irregardless of whether its "hard for an author to fix" or not, it shouldn't have been allowed to have happen in the first place. Other inventory mods don't have this problem currently. But one that did cause lockups when opening a mailbox after a patch (before it was fixed a few patches ago) was MaterialsTracker.

So its not a problem unique to this mod. And more than one person has experienced it. It happens only in specific circumstances. And seeing as the cause was this mod (whether alone or in combination with other mods being run) and the problem was WoW crashing, yes, it is unacceptable.

Have fun.
Zidomo is offline Report comment to moderator  
Reply With Quote
Unread 01-17-07, 09:20 AM  
Fleetfoot
A Murloc Raider
AddOn Author - Click to view AddOns

Forum posts: 5
File comments: 67
Uploads: 6
Re: This mod causes a severe WoW problem

Originally posted by Zidomo
SimpleBankState (SBS) v1.2.8 here (the latest on any UI site) freezes/crashes WoW opening a mailbox on an existing character immediately after a WoW patch (2.0.5 the latest). Same behavior as with earlier versions (as mentioned by a poster on Curse called "ainfigree" at this link on Nov 24/06).

This has happened during WoW 2.0.4 here too with an earlier SBS version. But I was not as methodical in my testing as I was this time to make sure SBS was the guilty party.

After coming back from the opening of my mailbox that caused WoW to freeze/crash in WoW 2.0.5, I disabled inventory & mailbox mods one at a time until the culprit was found. To make sure it was SimpleBankState (after several WoW crashes/freezes), I enabled everything I had going when the crash first happened, then disabled just this mod. It is for sure this mod.

A terrible bug; SimpleBankState really should not still be available for release as it is. Depending on whether you are fullscreen or windowed when the crash/freeze caused by SimpleBankState happens, you may have to reboot, causing a forced close & loss of open data in all apps on your desktop. Or else kill WoW alone (if you are able to) losing all saved variables data. And so on. Doing this has the real potential of causing file errors on your hard disk as well.

Unacceptable behavior for a released mod.
A better test would probably have been to just enable this mod and nothing else and then see if you could reproduce the crash. And since it seem this isnt a universal problem i would say that youre statment that it is unacceptable is pretty far off from the truth. The simple truth is that problems like this can be hard to reproduce for an author and even more hard to fix.
Fleetfoot is offline Report comment to moderator  
Reply With Quote
Unread 01-17-07, 05:56 AM  
rophy
A Fallenroot Satyr
AddOn Author - Click to view AddOns

Forum posts: 24
File comments: 126
Uploads: 12
Re: This mod causes a severe WoW problem

I have never experience a freeze myself, and the code for mailbox event handling is so simple that I can't find anything wrong with it. So I have no idea on how to solve the problem.

Anyway I added a pre-check on the mailbox event handling code as an attempt to fix the problem, I hope you can give it another test to see if the code works.

If you have any info on how to reproduce the freeze it'll be very helpful too.
Last edited by rophy : 01-17-07 at 05:57 AM.
rophy is offline Report comment to moderator  
Reply With Quote
Unread 01-17-07, 12:34 AM  
Zidomo
A Cliff Giant
 
Zidomo's Avatar

Forum posts: 76
File comments: 1049
Uploads: 0
This mod causes a severe WoW problem

SimpleBankState (SBS) v1.2.8 here (the latest on any UI site) freezes/crashes WoW opening a mailbox on an existing character immediately after a WoW patch (2.0.5 the latest). Same behavior as with earlier versions (as mentioned by a poster on Curse called "ainfigree" at this link on Nov 24/06).

This has happened during WoW 2.0.4 here too with an earlier SBS version. But I was not as methodical in my testing as I was this time to make sure SBS was the guilty party.

After coming back from the opening of my mailbox that caused WoW to freeze/crash in WoW 2.0.5, I disabled inventory & mailbox mods one at a time until the culprit was found. To make sure it was SimpleBankState (after several WoW crashes/freezes), I enabled everything I had going when the crash first happened, then disabled just this mod. It is for sure this mod.

A terrible bug; SimpleBankState really should not still be available for release as it is. Depending on whether you are fullscreen or windowed when the crash/freeze caused by SimpleBankState happens, you may have to reboot, causing a forced close & loss of open data in all apps on your desktop. Or else kill WoW alone (if you are able to) losing all saved variables data. And so on. Doing this has the real potential of causing file errors on your hard disk as well.

Unacceptable behavior for a released mod.
Zidomo is offline Report comment to moderator  
Reply With Quote
Unread 01-05-07, 10:22 PM  
nosceteipsum
A Kobold Labourer

Forum posts: 0
File comments: 1
Uploads: 0
I get this message when I try and sort the items.

Interface/AddOns/SimpleBankState/SimpleBankState.lua:499: attempt to index local 'self' (a nil value)
Could this be fixed asap, please?

And great addon btw, simple and very user friendly.... if I could get the sorting to work. I mean the leftclick sorting btw, not the filtering because that is working as intended (i.e. very nicely).
Last edited by nosceteipsum : 01-05-07 at 10:23 PM.
nosceteipsum is offline Report comment to moderator  
Reply With Quote
Unread 12-18-06, 05:58 AM  
Nakawe
A Kobold Labourer

Forum posts: 0
File comments: 67
Uploads: 0
I love this mod. Thanks for update
Nakawe is offline Report comment to moderator  
Reply With Quote
Post A Reply



Category Jump: