This add-on combines the functionality of avngr's FuBar_ProfessionsFu, Kemayo's FuBar_KungFu, and smuggles FubarTradeCooldownFu. This add-on is uploaded with their approval. I decided to merge the the first two because they seemed to have a rather large overlap, although both had bits that were unique and very useful (or just plain good looking). I have tried to keep the best of both. Next I wanted to get rid of another add-on on my bar and added the Trade Cooldown functionality. It took me a while to get the salt shaker support correct, as I'm still figuring out the event flow.
On popular demand, I added the option to show the skills for your other toons.
SkillsPlusFu is currently localised only for English, but should be easy to expand to cover other languages. However, by using BabbleLib it should at least properly for those languages supported by that library.
Use
The FuBar menu will display either Skills or the name of a skill that can be used to make things (so, say, Mining doesn't show, but Smelting does). Behind the skill (name and/or icon depending on your preferences) the number of cooldown items is displayed. This display show (total item - items ready) This will not be shown when you have no cooldown items for any of the toons you play.
By selecting the (right-click) menu you see all skills that you can use to make things with for your current toon. Selecting one of these skills will open the relevant skill window and put it's name/icon up in the FuBar. Clicking this later will open the associated skill window again. The last used skill is saved between sessions.
Options
Show skill label - Toggles the display of the skill name (or the text skills) on the FuBar. Use this when you want to show only the icon and the cooldown info.
Show boolean skills - Toggles skills that do not progress, this includes proficiencies.
Show other player skills - Allows you to select which other toons and skills are shown.
Show cross faction skills - Toggles whether the skills mentioned above include those of other faction toons.
Show player names - Toggles display of the player names in the cooldown info
Show cooldown notification - Toggles displaying the cooldown info on the FuBar
Clear current cooldown data - Clears the current cooldown database.
Hide cooldown data for - Allows you to hide a specific cooldown
Acknowledgements
This add-on is based on avngr's FuBar_ProfessionsFu, Kemayo's FuBar_KungFu, and smuggles FubarTradeCooldownFu. Thanks guys!
I'd like to add a special thank you to avngr who put me on this path by pointing out to me how easy it was to expand FuBar_PetInfo to my wishes.
Furthermore I'd like to thank all of you who helped me by logging bugs and offering suggestions. Thanks!
Change Log - FuBar - SkillsPlusFu
3.0.1 - bugfix embed.xml, Salt Shaker cooldown
3.0.0 - updated for WotLK, streamlined code, added Inscriptions
2.4.7b - cleaned up code (still possible Alchemy problems)
2.4.7 - bugfix for alchemy cooldoown issue, added transmutes for WotLK (untested)
2.4.6 - removed cooldown for Mooncloth (Patch 2.4.3)
2.4.5 - updated cooldowns (Patch 2.4.2), cleaned up code, fixed problem with Alchemy cooldown failing
2.4.4f - hopefully fixed memory issue.
2.4.4 - updated TOC, redone cooldowns for v. and p. spheres (by Ackis), redone salt shaker, elune's lantarn and snowmaster 9000 (thanks Seerah), removed Alchemy Hack (Ackis)
2.4.3 - updated TOC, zhTW localisation updated (helium), koKR localisation added (7destiny/ochocobo)
2.4.2 - redone cooldowns for v. and p. spheres (by Ackis), updated T.O.C. Fixed Blood Elf issue. Hacked alchemy issue.
2.4.1 - attempted to add cooldowns for void and prismatic spheres
2.4.0b - fixed BabbleRace again
2.4.0 - updated TOC
- added herbalism, mining and skinning to the Other toons skills
- Traditional Chinese (zhTW) localisation added by helium
2.3.1 - fixed bug with showing other toons
- fixed bug in Babble-Race for "Blood Elf"
2.3.0 - added interface to hide specific cooldowns and skills (or a specific toon) as suggested by Highend
2.2.8 - expanded cooldowns for new cloth (hopefully)
- added Blood elf to faction check
2.2.7 - added Jewelcrafting
2.2.6 - fixed some more library issues
- changed datamodel for better functionality
- fixed Purge option
- added fishing skill back to the list of saved skills for other toons
- added a partial French translation for the Cooldown functionality (ID1755), courtesy of sturmy
2.2.5 - actually removed dewdrop:Close()
2.2.4 - added German translation to TOC again (ID2631)
2.2.3 - finally fixed library issues
- set LoadOnDemand to 0 (false) so it will run without FuBar
2.2.2 - added German translation, courtesy of Xanatandor
- added CloseWhenClickd to dewdrops back in (ID2400)
2.2.1 - fixed sloppy coding and removed unnecessary libraries
2.2.0 - updated to WoW 2.0
- updated libraries
- using SkillsPlus to Disenchant, Fish or Pick Locks is no longer possible
Fix for saving invalid Cooldowns for linked tradeskills
Replace with this function at line 417:
function SkillsPlusFu:TRADE_SKILL_CLOSE()
local cooldown = nil
if (IsTradeSkillLinked()) then
_, self.currentPlayer = IsTradeSkillLinked()
if not (self.currentPlayer == UnitName("player")) then return end
else
local numSkills = GetNumTradeSkills()
for i=1, numSkills do
local itemName = GetTradeSkillInfo(i)
-- check name with name in spellMatrix, cooldown item is member of spellMatrix[itemName]
if spellMatrix[itemName] ~= nil then
cooldown = GetTradeSkillCooldown(i)
-- self:Print('Found: '..itemName..' '..spellMatrix[itemName])
if cooldown == nil then cooldown = 0 end -- safety catch; should cooldown be removed (or wrong spell ID used
-- self:Print('Found: '..itemName..format(cooldown))
self:WriteCooldownInfo(spellMatrix[itemName],cooldown)
end
end
end
self:Update()
end
Zidomo, that error is really weird. It's triggered off a variable that is never set inside my code. It seems to be referring to another addon: TradeskillInfo by wmrojer. Digging into the changelog I see:
r70 | mcc | 2007-10-22 18:14:23 +0000 (Mon, 22 Oct 2007) | 2 lines
Changed paths:
M /tmp/trunk/FuBar_SkillsPlusFu/SkillsPlusFu.lua
FuBar_SkillsPlusFu:
- add TradeSkillInfo Menu support..I don't know what I done is legal or not,If not pls remove it.
So it's not a SkillsPlus issue, it's something that has changed in TradeskillInfo. As I wasn't aware it was there, I had no idea what or even how to update it. I'm removing it from the next version, as it seems to be broken.
I've been having issues with wrong cooldowns showing up for Alchemy/Enchanting. I'm trying to figure out what is wrong, but... =/ I'm beginning to think it may have something to do with the toonSaveKey not being properly reset when switching toons.
Zidomo, thanks for the information. I think the portal is still up and I can see I got a warning for two new bugs.
That happens to me as well, but it does actually save the skills for the current character and for others. It seems to happen more often if I reloadui or if I log out almost immediately after logging in (wrong char, forgot to install the addon I just DLd, etc). If I delete that section from the saved variables file and restart, I have no issues (unless I reloadui/relog too quickly again).
Well, deleted saved variables and relogged. The mouse-over tooltip with the cooldown & other info now works & shows things properly. But the right-click options tooltip still doesn't work properly.
The previously mentioned errors are consistently thrown up upon right-clicking the SkillsPlusFu icon/text & the professions in the menu.
Again, this is the only FuBar plugin I run (and I run/test a lot) that has such an issue.
GL fixing it.
EDIT: I submitted a bug report yesterday and tried again today at your portal; they are not showing up in the list. Is the list no longer active?
A character learns the "Grand Master" skill levels in a few trades (450 maximum skill). After that, turn on SkillsPlusFu on that character that has had it disabled for a few months.
Log on and the FuBar Tablet dropdown menu doesn't work properly. It lists the professions (and they are clickable to open the menus), but no other text shows up. Not the cooldowns, other character listings or anything.
As well, when trying to access the FuBar menu, the following error is thrown up. It repeats every time you right-click the plugin (has a problem with the OpenMenu function):
Code:
FuBar_SkillsPlusFu-3.0.1\\SkillsPlusFu.lua:635: attempt to call method 'IsActive' (a nil value)\nFuBarPlugin-2.0-90006:1134: in function <...\\FuBarPlugin-2.0\\FuBarPlugin-2.0\\FuBarPlugin-2.0.lua:1124>\nDewdrop-2.0-90320 (DewdropLib):1894: in function <...erface\\AddOns\\DewdropLib\\Dewdrop-2.0\\Dewdrop-2.0.lua:1843>\nDewdrop-2.0-90320 (DewdropLib):2779: in function <...erface\\AddOns\\DewdropLib\\Dewdrop-2.0\\Dewdrop-2.0.lua:2738>\nDewdrop-2.0-90320 (DewdropLib):2995: in function `Open'\nFuBarPlugin-2.0-90006:1179: in function `OpenMenu'\nFuBarPlugin-2.0-90006:991: in function <...\\FuBarPlugin-2.0\\FuBarPlugin-2.0\\FuBarPlugin-2.0.lua:989>\nFuBar-3.0.90012\\FuBar.lua:1213: in function <Interface\\AddOns\\FuBar\\FuBar.lua:1207>\nTablet-2.0-90216 (TabletLib):2556: in function <Interface\\AddOns\\TabletLib\\Tablet-2.0\\Tablet-2.0.lua:2554>
And when clicking a profession or similar, the following error is thrown up (has a problem with the Refresh function):
Code:
FuBar_SkillsPlusFu-3.0.1\\SkillsPlusFu.lua:635: attempt to call method 'IsActive' (a nil value)\nFuBarPlugin-2.0-90006:1134: in function <...\\FuBarPlugin-2.0\\FuBarPlugin-2.0\\FuBarPlugin-2.0.lua:1124>\nDewdrop-2.0-90320 (DewdropLib):1894: in function <...erface\\AddOns\\DewdropLib\\Dewdrop-2.0\\Dewdrop-2.0.lua:1843>\nDewdrop-2.0-90320 (DewdropLib):1908: in function `Refresh'\nDewdrop-2.0-90320 (DewdropLib):3470: in function <...erface\\AddOns\\DewdropLib\\Dewdrop-2.0\\Dewdrop-2.0.lua:3468>
Have had no problems with any other updated FuBar mod with Tablet menus. Also never had a problem with SkillsPlusFu on a mid-level hunter (with 375 or less skills) in WoW 3.0.3 prior to WotLK installed.
Will try with saved variables deleted next. But SkillsPlusFu does not update properly with old saved variables as it should. At least on characters that know 450-level skills since they last used SkillsPlusFu.
Whenever I open Someones linked tradeskills it adds the cooldown section for that linked tradeskill to my character, meaning I am not enchanter, if I open linked tradeskill for enchanter it adds enchant cooldowns under my characters name even tho I do not have enchant tradeskill.
Sorry if I'm missing something, but is it possible to show more than one icon on the fubar? I'm probably missing something obvious. I'd love to be able to have all my crafting skills icons displayed so it's just a mouse pick to select one.
with newest version i don't get any error. I switched my alts and everything is fine. I kook further into it, if the error return. Thanks for your great work.
Originally posted by Jayhawk As for LDB, I started working on this and have a fairly decent display part, but the menu is shot to smithereens and I'd like to have a proper menu (if only to reduce tooltip length for the alt-aholics among us ).
Great to hear. Thank you very much Jayhawk, and please keep up the wonderful work!
Sha, it seems like there's no proper key saved.
Line 849 tries to split the toon name key into realm and actual toon name. In the SavedVariables file (World of Warcraft\WTF\Account\XXX\SavedVariables\FuBar_SkillsPlusFu.lua) there should be a section ["skillsSave"] which contains sections having a name like ["Lightbringer|Alizarine"] The code looks for the pipe symbol and splits the data to either side. Apparently you have no proper key there, but you do have data.
Could you, once you get the error, close WoW and check (or send me) the SavedVariables file?
I'm also curious, when this happens: have you played a single toon and not swapped to another toon before you. I get a feeling it's not saving data correctly...
As for LDB, I started working on this and have a fairly decent display part, but the menu is shot to smithereens and I'd like to have a proper menu (if only to reduce tooltip length for the alt-aholics among us ).
Jayhawk, I gotta say I love SkillsPlusFu. I've been using it for quite some time, and find it completely invaluable.
Any chance of a LibDataBroker port? LDB seems to be the way the community is going, as it's bar-independent and LDB plugins can still function under FuBar with Broker2FuBar (which from my experience works quite well).
Having just recently switched to Fortress, I'd love to be able to use SkillsPlusFu again.
).
