Phanx

Many authors already address this by licensing their addon under the GPL or another "copyleft" or "open source" license. These types of licenses already say it's okay to redistribute them, so you don't need to ask. You only need to ask if an addon doesn't already give you permission through a license or other declaration. And many authors whose addons don't mention anything are okay with redistribution, but just don't think about it; if they get enough requests, they might just think about it, learn something, and license their addons. Regardless, if you want to redistribute someone else's work, you need to get permission from them, whether it's an addon or anything else. If someone isn't willing to ask for permission, they're completely free to use addons that already give permission, or they're completely free to not upload a compilation. People can download and configure addons on their own, you know.

Darkmoone

Phanx, having to ask permission to include addons in compilations is going to get messy if all the authors start to follow suit. Can you imagine the guy with 30 addons? .

I dunno i don't get it.

Somnifer

Thank you for explaining this, and for the workaround! That should work just fine.

Phanx

Yes, but please file it as a feature request using the link near the Download button so I don't forget about it.

Zabbath

Will you add class color for players that earns a achievement?
Great addon btw! works great with JustifyChat

Phanx

This is an issue with any addon that modifies the chat frame in specific ways. Some time ago Blizzard "protected" the GM petition frame, to prevent anti-spam addons from automatically submitting petitions to report spam. This means that text can only be added to the petition frame if you directly type it in, or if it is inserted by "secure" code (i.e. Blizzard code that isn't "tainted" by an addon). Unfortunately, there's nothing any addon can do about this other than not modify the chat frame, which isn't very appealing to users of chat frame addons.

You can work around this restriction by opening a chat edit box, shift-clicking the player's name into that, and then copying and pasting into the petition frame.

Somnifer

Today, when I shift-clicked on someone's name to add it to a GM ticket I got a popup saying that Phanx Chat was blocked from an action blah blah, etc.

Is this a Phanx Chat issue or do you think some other addon (I use no other addons that interact with chat) might be causing it?

Thanks Phanx.

(lol, I'm a poet...)

Phanx

No, nor do I plan to add one. If you need to copy text from chat (other than URLs) so often that retyping it is a pain, turn on Blizzard's chat logging feature by typing "/chatlog" or "/logchat" (I forget which one). Then, your chat will be logged to World of Warcraft\Logs\WoWChatLog.txt.

Katheria

This is EXACTLY what I was looking for. Thanks a lot. =)

One other thing... (Sorry if it's included in this mod)
Is there an addon that allows you to copy "any" text in your chat window and copy it to your clipboard?

Phanx

Well, the exact time it takes your computer's operating system to read a file from the hard disk depends on your specific computer, but to make a long story short, it takes the same amount of time to load a 1kb file as it does to load a 24kb file, so splitting the advanced config variables into their own file would double the load time of the core + config variables. Due to the fact that each locale has its own translation file (it's much easier to keep them up to date if you can compare line numbers) and there's a TOC and the options file itself, there are currently 10 files to load; adding 1 more would essentially make the addon take 10% longer to load.

If you look at your addons, you'll find that many addons reference all of their embedded libraries from an "embeds.xml" file, and only reference that file in the TOC, instead of each library. This system was originally designed because addon authors discovered that when WoW tries to load a file that doesn't exist but is listed in a TOC, it greatly increases load time. Since some users don't use embedded libraries, and either download addons without them, or delete them after downloading, and run standalone copies of each library, this meant that before embeds.xml, every addon using Ace2, for instance, was referencing a dozen or more files in its TOC that didn't exist. By contrast, referencing the same files that don't exist from an XML file doesn't increase loading time so significantly.

Also, in order to have the variables in their own file, they would need to be in the global namespace, and everything you add to the global namespace slows down access to everything else in the global namespace, and has the potential to conflict with other resources (i.e. if another addon names its global variable the same thing).

brknsoul

I didn't mean to sound ungrateful.. awesome mod.. I'll just keep a copy of the advanced options in another file.

I didn't know file i/o and ref'ing non-existant files increased load times. ;-)

Phanx

The options available in the Lua file are advanced confirguration, and are not officially supported. I'm not willing to significantly increase my addon's loading time (file I/O is by far the slowest part of loading, and on top of that, referencing files from a TOC that don't actually exist greatly increases loading time) just because you don't want to copy and paste a few lines once every couple of months.

brknsoul

Could we have the options in Core.lua be saved in another file? ie: have another file called "coreoptions.lua" or something, not originally with the installation, and if the mod finds it, use those options instead of the default ones?

Phanx

Ah. Well, that right there is exactly why I want bug reports posted in the bug report tracker. I maintain a dozen addons, and have plenty of non-addon related things to keep track of in life too. If I don't have time right away to look into a bug (and right around the Wrath launch I had far more pressing bugs in other addons to fix, not to mention actually playing the game), and it's not something that affects me (to remind me), I'll probably forget about it. If it's posted in the bug report tracker, I'll see it on a daily basis (I leave my bug report page permanently open in a tab), whereas if it's just posted in the comments, I'll probably never see it again. Someone else just posted a bug report about your problem, though, so it will be fixed soon.

Tsoumpleki

Some time ago when Wotlk was launched I quoted another user here facing the same problem, to which you replied as well. Below are the quotes. That is why I assumed this hasn't been fixed yet, maybe I've missed something or maybe not. Hope you're gonna fix it, PhanxChat is a great addon.