ImprovedMerchant : WoWInterface Downloads : Bags, Bank, Inventory Mods

		WoWInterface Downloads » Stand-Alone Addons » Bags, Bank, Inventory Mods
ImprovedMerchant

Category: Bags, Bank, Inventory Mods

Addon Information

Works with 3.1

Author:	Macniel [more]
Version:	3.6x5
Date:	06-08-2009 01:18 AM
Size:	9.68 Kb
Downloads:	25,742
Favorites:	416
MD5:

Pictures

OSP Bug is gone!

new interface with checkbutton to check autorepair on and off

full action buying!!!

ImprovedMerchant Popular! (More than 5000 hits)

Warning
if you depend on item scaling and spacing between items do not upgrade and use version 3.6a instead, this update is not necessary if the previous version (3.6a) is working fine on your computer.

Installation

You install this AddOn like any other, just unpack the downloaded zip into your /Interface/AddOns folder.

Summary
Hello and welcome back to another helpful AddOn which will improves your daily shopping-adventures with merchants.

Okay what did this AddOn do to your merchantframe ? It replaces the paged item display with a scrollable and more informative list which can also be filtered by available item types. It use the same purchase protection like the default merchantframe when buying an item which requires honor-,arena-points or specific items.

Features

Filter: you can filter items from a vendor out. You can setup a filter to show only trainable, usable, purchasable items or just items from a specific type (or subtype)
Searchcraft: you can search item descriptions for certain a or multiple (seperated by an colon ;) keywords and filter those out which does not include your keywords
Scrollable List: you can now scroll through the merchant shop instead of the paged view
Autorepair: as a request you can now check a button on a merchant frame to enable autorepair.

Credits
Thanks again to Dridzt who have uploaded a fixed version here http://www.wowinterface.com/downloads/info12206.html while I was not available. Thanks and kudos to you!

Thanks to Seebs for GetOpt which handels slashcommands / parameterized Inputs

Need some localization help!
If you use a french, spanish, russian, korean, chinese client please provide me with a correct localization for "Recipe"

Thanks.

Change Log - ImprovedMerchant

bugfixes in v3.6x5 :
a bug that prevents items from being clicked has drycoded out.
see changes.txt for more details

bugfixes in v3.6x4 :
A bug that prevents the item list to populate properbly after selecting the filter "nothing" in the dropdown menu has been eliminated.
A cosmetic "feature" has been added that preselect visually the "nothing" filter item in the dropdown menu when this filter is active.
see changes.txt for more details

changes in v3.6x3 :
Reenabled the Trainable filter function
Added file changes.txt for more code specific changes

bugfixes in v3.6x2 :
Localization enGB / enUS are now corrected (mass find/replace is evil!)

changes in v3.6x (xml) :
Rewrote lua Frame definitions into XML Definitions
Heavily improved Memory consumption and CPU Time consumption

bugfixes in v3.6c :
Fixed a call that caused an error message when selling something (this only applies to 3.6b)

changes in v3.6b :
Removed Options (consider v3.6a if you need item scaling and spacing)
Improved performance
- removed 2 functions as they were not necessary to determine if an item is usable
- change the way the functions and variables were accessed (they are now no longer members of an UIObject)

bugfixes in v3.6a :
Reassigned constants properbly so the filter affordable, usable and trainable works again

changes in v3.6 :
Added Autorepair option
Adjust itemcost a bit to appear more stream lined

changes in v3.5d :
Added Count and StockCount fontstrings into XML

changes in v3.5b :
Switched to XML based item definition and stress tested this for the OSP Bug, and it has not occure.

bugfixes in v3.5 :
I do not know what I had done but the OSP Bug does not appear to me anymore

bugfixes in v3.4j :
Fixed a minor bug (try to index local texture a nil value)

bugfixes in v3.4i :
An hidden visibility error has been found (by Dridzt) and eliminated

bugfixes in v3.4h :
Reverted a fix in g and replaced it with another fix - now this shall work

bugfixes in v3.4g :
On-Screen-Printing (sounds cool to me) bug should no longer occure
Fixed a function that hide everything if the filter is set to "NOTHING" (it should not display nothing but filter out nothing!)
Skipped minor version f for unkown reason

bugfixes in v3.4e :
Changed the encoding format of localization.lua to utf-8 so this can be accessed probably (again)

bugfixes in v3.4d :
An error that says there is no filter types available should no longer occure
Added a bunch of comments

bugfixes in v3.4c :
Combinated filter are now working again!

bugfixes in v3.4b :
Removed a ClearAllPoints() that caused to disalign some elements

bugfixes in v3.4a :
Changed a variable name so the count of an stacked item (for example water) will show up again

changes in v3.4 :
Implemented support for Recipe-Book (and similiar AddOns)
Changed lots of code, so it should work now performantly
Fixed filter and search craft when they are used together (they will not longer disable each other)

known bugs:
there is not yet a localization frFR, enES, koKR, zhCN, zhTW and ruRU clients so the Trainable Filter wont work for these Clients (please provide me with a proper translation for the itemtype "recipe")

changes in v2.1 :
Bugfix with stock based Items (they will now properly decreased); new Trainable Filter

changes in v2.0 :
itemcost + money will not longer result in a graphical glitch

changes in v1.9 :
switched to ItemButtonTemplate to enable AddOns to skin the item texture

changes in v1.8 :
improved Searchengine which allows more than one keyword to search for, bugfix which prevented to show every required itemtype to purchase an item (like a pvp mount)

changes in v1.7 :
new affordable filter, filter are hidden on default

changes in v1.6 :
many bugfixes

changes in v1.5 :
click handler are removed, the default click handler are used instead, localization completed by yaroot (thank you very much)

changes in v1.3 :
list is now redesigned for improved experience, major fix in left/rightclick handling, buybackitem will now show probably in the buy frame

changes in v1.1 :
Some designtweaks were applied

changes in v1.06:
Compare Tooltips was added, Dressup function was added

changes in v1.04:
Currency display was changed, Localization should now work probably

bugfix in v1.01:
SplitStack should now work probably

Optional Files - ImprovedMerchant

Sorry, there are currently no optional files available.

Archived Versions - ImprovedMerchant

File Name	Version	Size	Author	Date
ImprovedMerchant	3.6x4	10kB	Macniel	06-07-2009 04:02 PM
ImprovedMerchant	3.6x3	9kB	Macniel	05-25-2009 12:05 PM
ImprovedMerchant	3.6x2	9kB	Macniel	05-25-2009 07:34 AM
ImprovedMerchant	3.6x	9kB	Macniel	05-24-2009 01:32 PM
ImprovedMerchant	3.6c	8kB	Macniel	05-24-2009 04:02 AM
ImprovedMerchant	3.6b	8kB	Macniel	05-23-2009 07:58 PM
ImprovedMerchant	3.6	13kB	Macniel	05-23-2009 01:04 PM
ImprovedMerchant	3.6	13kB	Macniel	05-23-2009 04:36 AM
ImprovedMerchant	3.5d	13kB	Macniel	05-22-2009 08:52 AM
ImprovedMerchant	3.5b	13kB	Macniel	05-22-2009 07:38 AM
ImprovedMerchant	3.5a	13kB	Macniel	05-21-2009 11:30 AM
ImprovedMerchant	3.5	13kB	Macniel	05-21-2009 05:50 AM
ImprovedMerchant	3.4j	13kB	Macniel	05-20-2009 05:17 AM
ImprovedMerchant	3.4i	13kB	Macniel	05-18-2009 05:46 AM
ImprovedMerchant	3.4h	13kB	Macniel	05-17-2009 11:46 PM
ImprovedMerchant	3.4g	13kB	Macniel	05-17-2009 03:18 PM
ImprovedMerchant	3.4e	13kB	Macniel	05-17-2009 11:01 AM
ImprovedMerchant	3.4d	13kB	Macniel	05-17-2009 07:20 AM
ImprovedMerchant	3.4c	12kB	Macniel	05-16-2009 04:17 PM
ImprovedMerchant	3.4b	12kB	Macniel	05-16-2009 09:53 AM
ImprovedMerchant	3.4a	12kB	Macniel	05-15-2009 07:03 PM
ImprovedMerchant	3.4	12kB	Macniel	05-15-2009 06:45 PM
ImprovedMerchant	3.1	11kB	Macniel	04-17-2009 11:50 AM
ImprovedMerchant	2.1a	6kB	Macniel	03-27-2009 02:45 PM
ImprovedMerchant	2.1	6kB	Macniel	03-25-2009 05:29 PM
ImprovedMerchant	2.02	6kB	Macniel	10-25-2008 07:21 AM

Comments - ImprovedMerchant

Page 1 of 14

Last »

Author

Comments

Comment Options

06-19-2009, 05:11 AM
antisocialink A Kobold Labourer Forum posts: 0 File comments: 7 Uploads: 0	I haven't experienced my issue since the last update. Sorry I never got you a screen of it. I had disabled the mod till I saw there was an update. Kept forgetting to enable it and get you a screen.

06-07-2009, 05:22 PM

Dridzt

A Frostmaul Preserver

Forum posts: 257

File comments: 380

Uploads: 35

Quote:

Originally posted by Macniel
thank you dridzt I have finally encountered this bug as well and could pinpoint it. the problem was that UIDropDown_GetSelectedValue(...) will use the .text attribute when the .value attribute is nil. So I had give the nothing item a non-nil value.

As the other bug I could not yet find this bug.

@ antisocialink, I couldnt encounter this bug as well sorry.

Good news

The only possible place for the other bug that I could think off was in the PopulateList function where the item button is created or passed to the ImprovedMerchant_Update() function.

I replaced that line in my local copy with

Code:

local button;
if _G["itemInfo"..iterator] then
	button = _G["itemInfo"..iterator]
	button:SetFrameLevel(ImprovedMerchantScrollChild:GetFrameLevel() + 1)
else
	button = CreateFrame("Button", "itemInfo"..iterator, ImprovedMerchantScrollChild, "ImprovedMerchantItemInfoTemplate")
end

The idea behind it is that the created button is parented to ImprovedMerchantScrollChild so it will always have the proper framelevel to be above it/clickable.
There was nothing to guarantee this happens when you pass the existing itembutton.
After the change above I haven't observed that problem but it is hard to say 100% that this was the cause or solution as it never used to happen consistently.

I can only say that I haven't observed it for a few days now since I made that change while it happened before.

Edit: There's a leftover debug statement as first line of ImprovedMerchant_PopulateList() function.

Last edited by Dridzt : 06-08-2009 at 01:02 AM.

06-07-2009, 03:43 PM
Macniel A Fallenroot Satyr Forum posts: 26 File comments: 125 Uploads: 10	thank you dridzt I have finally encountered this bug as well and could pinpoint it. the problem was that UIDropDown_GetSelectedValue(...) will use the .text attribute when the .value attribute is nil. So I had give the nothing item a non-nil value. As the other bug I could not yet find this bug. @ antisocialink, I couldnt encounter this bug as well sorry.

06-06-2009, 08:55 AM
Dridzt A Frostmaul Preserver Forum posts: 257 File comments: 380 Uploads: 35	v3.6x3 I'm having a repeat of an old issue solved with 3.1 previously. No lua errors but: 1. Occasionally the merchant frame appears empty until I re-set a filter. (was "nothing" to begin with I just need to re-select it from the dropdown). When it bugs out like that it also clears the items with every purchase and I need to re-set the filter again to make them appear. 2. Items after the 7th row become unclickable + do not show their tooltip on mouseover. (seems like a frame strata problem). Both issues can usually be temporarily resolved with reloadui. Edit: Last occurrence of this behavior was at Braeg Stoutbeard but it happens at other merchants as well. Last edited by Dridzt : 06-06-2009 at 08:57 AM.

05-28-2009, 04:34 PM

Macniel

A Fallenroot Satyr

Forum posts: 26

File comments: 125

Uploads: 10

Quote:

Originally posted by antisocialink
This has been acting a bit wonky for me of late.

Some merchants won't have prices for first few items.
And more importantly, when out of the merchant window the currency still continues to show on the game field. This particularly seems to happen when accessing merchants that use alternate currency (i.e. Stone Keeper Shards and all the different badges) but does occasionally leave gold/ silver/ copper on the screen as well.

Logging will reset it and the merchant seems to work fine after but eventually the issue seems to come back up.

could you please provide a Screenshot or a more detailed information : when it happens, what item is affected, who is the merchant.

but as I am now in hospital this fix could take it time...

05-28-2009, 09:35 AM
antisocialink A Kobold Labourer Forum posts: 0 File comments: 7 Uploads: 0	This has been acting a bit wonky for me of late. Some merchants won't have prices for first few items. And more importantly, when out of the merchant window the currency still continues to show on the game field. This particularly seems to happen when accessing merchants that use alternate currency (i.e. Stone Keeper Shards and all the different badges) but does occasionally leave gold/ silver/ copper on the screen as well. Logging will reset it and the merchant seems to work fine after but eventually the issue seems to come back up.

05-25-2009, 12:08 PM

Macniel

A Fallenroot Satyr

Forum posts: 26

File comments: 125

Uploads: 10

Quote:

Originally posted by Cheery
For the Trainable filter, is it possible to filter out patterns/recipies that you already know?

this was actual the function of this filter, but then I decided to remove the algorithmen to scan the tooltiptext for red lines (Already Known.) but then the IsUsable flag betrayed me but I found a GlobalString (which are localized) and now (v3.6x3) the tooltip will be searched for this string.

So it works again.

@HevanusYes, GetOpt is no longer required due removing of settings.

05-25-2009, 11:36 AM
Cheery A Kobold Labourer Forum posts: 0 File comments: 6 Uploads: 0	For the Trainable filter, is it possible to filter out patterns/recipies that you already know?

05-25-2009, 11:29 AM
Hevanus A Deviate Faerie Dragon Forum posts: 15 File comments: 193 Uploads: 0	In case anyone cares, I noticed the optdep on GetOpt was removed and that GetOpt is no longer included. You can probably delete it out of your AddOns folder.

05-25-2009, 07:39 AM

Macniel

A Fallenroot Satyr

Forum posts: 26

File comments: 125

Uploads: 10

Quote:

Also some merchants appear with "empty" list on first open and won't populate
until the filter is refreshed.

Same thing happens when you purchase or sell something to them (list wipes until filter refresh or next interaction).

I hope sincerily that this issue is based on the localization bug.

Quote:

Off-topic:
I'm trying to find what all changed functionality-wise in the last 15 or so releases after v3.10 which is what I'm reverting to when something breaks,
and I can't find much in the changelog
All I can notice is better responsiveness (speed) when it works.

Maybe I should consider writing a more informative changelog...

05-25-2009, 04:40 AM
Dridzt A Frostmaul Preserver Forum posts: 257 File comments: 380 Uploads: 35	There are some localization errors for the enUS/GB locale. (basically the key has been copied over as the tranlation leading to what you see above). Also some merchants appear with "empty" list on first open and won't populate until the filter is refreshed. Same thing happens when you purchase or sell something to them (list wipes until filter refresh or next interaction). Off-topic: I'm trying to find what all changed functionality-wise in the last 15 or so releases after v3.10 which is what I'm reverting to when something breaks, and I can't find much in the changelog All I can notice is better responsiveness (speed) when it works. Last edited by Dridzt : 05-25-2009 at 04:41 AM.

05-25-2009, 01:25 AM
tinyu wowui.incgamers staff Forum posts: 297 File comments: 142 Uploads: 10	using this addon wont let me purchase anything from the general goods and trade vendor in valgarde. __________________ Lothaer Admin @ wowui.incgamers.com Titan Dev Team Member.

05-24-2009, 02:22 PM
Hevanus A Deviate Faerie Dragon Forum posts: 15 File comments: 193 Uploads: 0	I know it's a dead horse now, but I just wanted to mention that I've also become a believer in smallest-possible-scope addons so that I can cherry pick the best addon for each job. I also have too many addons with overlapping functionality when it comes to things like mail features, junk selling, auto repairing, etc. because I like other features that those addons provide. As long as I can turn off the overlapping features it's no big deal though, and I can never fault an author who actually considers people's feature suggestions

05-23-2009, 02:04 PM
Purity A Deviate Faerie Dragon Forum posts: 14 File comments: 111 Uploads: 0	Oh and just wanted to thank you for this addon and your work improving the merchant experience, lol. You could code it for autorepair and autosell and call it another name like MacMerchant or UberMerchant or something. While leaving this addon as is...improved merchant. I don't see adding these features as a far stretch for those unconcerned with bloat...and for people who would rather keep their addon list less bloated. To each their own (addon). <Steps off the soap box.> __________________

05-23-2009, 12:49 PM
Macniel A Fallenroot Satyr Forum posts: 26 File comments: 125 Uploads: 10	I am not bowing With ImprovedMerchant I just wanted to answer a request to enable filtering and searching for items at the vendor. After all this was the second request to auto sell junk. And I do not see that it is not so frequent that you have or be able to sell a massive amount of grey - items (also known as "junk", but I do not consider the urn to summon Nightbane "junk") but it occure more often that you have to repair your inventory. This is just 3 lines of code and I had found a nice little spot on the merchant frame so I had implemented this. so kergoth / cawfee I promise that this AddOn will only be touched for maintenance or improving the used functions not for upgrades.

Page 1 of 14

Last »

Report this File

Category Jump: