Minion Beta! - Help us test our new AddOn updater. Get it now!
Download
(95 Kb)
Download
Updated: 10-22-14 02:00 PM
Pictures
File Info
Compatibility:
Warlords of Draenor Pre-Patch (6.0.2)
Updated:10-22-14 02:00 PM
Created:unknown
Downloads:14,264
Favorites:141
MD5:
6.0.2
Karni's Crap Filter  Updated less than 3 days ago!  Popular! (More than 5000 hits)
Version: 6.0.2.5
by: Karnifex, Brusk
[!] Disable Autoloot in the Blizzard options or the mod will not work [!]

[[ DESCRIPTION ]]
Karnifex finally got tired of looting 8 copper Fish Scales and accepted the quest to figure out how to never do it again. Thus, Karni's Crap Filter was born. It automatically loots what you want and skips what you don't want, saving bag space for good stuff like hookers and weapons. It's also a robust, full-featured and (hopefully) easy to use auto loot system!


[[ NEW STUFF! ]]
v3.2.0
- User can now selectively disable auto-destroy while using tradeskills. This is very useful
when leveling new tradeskills. This setting is on by default for new users but may be off for
users with existing SavedVariables file. Fishing is not currently included in this option.
- Added option to automatically open Crap Filter when talking to a merchant. Window should
automatically move to the correct place.
- Revamped the look of the addon to be a little more like the standard blizzard UI frames.
v3.10 saw the addition of delete confirmation on the inventory tab.
See the changelog for other improvements and fixes.


[[ WHAT IT DOES ]]
* Set a minimum value for automatically looting white and gray items
* Automatically destroy "crap" items
* Cloth: Loot what you want!
* Water: Loot all, none, or just the ones you want!
* Food: Loot all, none, or just the ones you want!
* Potions: Loot all, none, or just the ones you want!
* Scrolls: Loot all, none, or just the ones you want!
* Add items you really hate to a Never Loot list
* Add items you really like to an Always Loot list
* Automatically loots all quest items - never forget a quest item!
* Automatically loots all currency items (Emblem of Valor, Badge of Justice, etc)
* Never loot a fish scale again

* The following tradeskills are automatically looted for your pleasure:
  • Enchanting
  • Milling
  • Mining
  • Prospecting
  • Skinning
* There are options to autoloot for the following:
  • Pickpocketing
  • Fishing
  • Cooking materials
LibDataBroker support... This allows the mod to appear on
* Fortress - freely movable, dockable blocks
* StatBlockCore - freely movable, dockable blocks
* ButtonBin - puts many LDB plugins inside a box.. or bar.. or several!
* TitanPanel - now has built-in LDB support
...and more!


[[ COMMANDS ]]
/crap or /karnicrap to bring up the options menu
/crap on = enable mod (can also be done through UI)
/crap off = disable mod (can also be done through UI)
/crap [itemlink] to add an item to the Never Loot list (/karnicrap works too, but who cares?)
/notcrap [itemlink] to add an item to the Always Loot list

Hold down ALT while looting if you just want to window shop (temporarily disables autoloot behavior)

NOTE: When in a group it won't try to loot anything above the loot threshold. For example the loot threshold is set to [uncommon] by default, so it will only try to automatically loot [common] and [poor] items. It will leave the loot window open for you to select any other items still present.


[[ KNOWN ISSUES ]]
* Item occasionally will be in red (doesn't exist on server) on the Blacklist/Whitelist even if item is in inventory. Probably a timing issue.
* Getting two identical items off a corpse that are crap with autodestroy on, will only destroy one item.
* Taint sometimes when looting in combat
* Possible taint error source: fix might be to disable looting if there is only coins "It's a known issue and it's been around for a year at least I'm afraid. For some silly Blizzard reason, LootSlot() taints in combat when there's only coin to be looted."


[[ TO DO ]]
* Disable the destroy all crap button if there is no crap
* Help/tips screen or a help icon that triggers a tooltip. More tooltips!
* Option to factor in Auctioneer/AH average buyout prices?
* Do I need to do anything for Archaeology?
* Add a way to whitelist/blacklist items from the inventory pane
* Minimap icon
* Make buttons and items non-interactive when mod is disabled
* Organize the code a bit more logically
* Try and localize the mod
* Speed up the list update on the inventory tab (especially when selling items)
* Sync Blacklist/Whitelist across characters (or all settings?)


[[ FEEDBACK WANTED! ]]
* Let me know what's working and what's not, I'll do what I can to fix it.


[[ THANKS! ]]
* Thanks to Sbo of Doomhammer for helping me with a ton of stuff!
* Thanks to Cirk of Doomhammer for unknowingly helping me with his own mods
* Thanks raicuandi for helping fix stuff!
* Thanks EVMaker for keeping me up to date and helping figure out some tricky issues!
* Thanks Speedwaystar for posting the fixes to make it work in 4.0 to make fans happy!


Keywords: loot filter value autoloot pick pocket pickpocket fishing tradeskill profession milling skinning prospecting mining enchanting clam lockbox lootfilter destroy delete autodestroy autodelete bag space blacklist whitelist inventory management
v6.0.2.5
- TOC file updated

v6.0.2.4
- Added license headers

v6.0.2.3
- Updated all lists in the libs subdirectory
- Updated LibStub to version 2 (r102/r103/r104, 1.0.2.60000, Oct 16, 2014)
- Updated CallbackHandler-1.0 to version 6 (r18/r19, 1.0.6.60000, Oct 16, 2014)
- Added support for other-than-gold currency

v6.0.2.2
- Added Windwool cloth to the cloth options
- Fixed detection of Autoloot

v6.0.2.1
- Several fixes to deal with API changes and make the addon compatible with the current version of WoW again

v3.2.1
- Fixed the "Never loot" settings for Frostweave and Netherweave
- Fixed the "Except when using tradeskills" and "Don't destroy while in a group" checkboxes from showing as not checked if they were previously checked.
- Destroy confirmation built in, and option to turn it off removed
- Minor styling adjustments
- Disable the "Destroy All Crap" button when there is no crap in user's bags
- Fixed issue where items in blacklist and whitelist might appear in red on initial login
- Cloth options updated for Cataclysm, [Embersilk Cloth] added (lib_Cloth.lua)
- Food/Water libraries updated for Cataclysm, some additions made to existing lists (lib_Food.lua, lib_Water.lua)
- Scrolls library updated for Cataclysm, but there are no new lootable scrolls (lib_Scrolls.lua)
- Healing/Mana Potions updated for Cataclysm, seems only [Mythical Healing Potion] added, and that is a fished item. Did not include in list so that non-fishermen will continue to be able to loot "max" level potions without this triggering it to mark them as crap. (lib_Potions.lua)
- Tradeskill options updated for Cataclysm. Updated to use SpellID instead of the name when detecting tradeskill use, so non-english clients should also work.
- Minable mobs list updated for Cataclysm, extensive additions to previous expansions as well (lib_MobsMinable.lua)
- Gatherable mobs list updated for Cataclysm, extensive additions to previous expansions as well (lib_MobsGatherable.lua)
- Engineerable (Salvagable) mobs list is not updated and woefully incomplete, not sure how to compile a list of these- there is no option on wowhead.com for this
- Cooking library updated for Cataclysm

- Not yet updated (lib_MobsEngineerable.lua, lib_MobsSkinnable.lua)

v3.2.0
- User can now selectively disable auto-destroy while using tradeskills. This is very useful
when leveling new tradeskills. This setting is on by default for new users but may be off for
users with existing SavedVariables file. Fishing is not currently included in this option.
- Added option to automatically open Crap Filter when talking to a merchant. Window should
automatically move to the correct place.
- Revamped the look of the addon to be a little more like the standard blizzard UI frames.

v3.11
- Fixed auto-destroy not working. I honestly have no idea how this got broken, but I'm blaming murlocs. O=)
- Styled the destroy item confirmation dialog to look nicer
- Fixed the minor issue with the tooltip for cloth filter headers appearing gray the first time you trigger it

v3.10
- Corrected a variable misspelling in kc_inventory.lua
- Added destroy confirmation option to the inventory tab
- Added destroy confirmation functionality, still some minor styling improvements that could be implemented
- Revamped (and hopefully improved) the way cloth options are handled, there are now "always" and "never" loot checkboxes for each cloth type
- Disabled "Destroy all crap" button on inventory tab if there is no crap to destroy
- Moved pickpocketing option into the tradeskill category, removed the Pickpocketing category
- Fixed pickpocketing option being enabled for non-rogue classes
- Clarified the wording on many of the options
- Disabled [destroy] and [destroy all crap] buttons on inventory tab while a merchant window is open
- Added tooltips to cloth options (above the checkboxes)

v3.03
- Updated the mod with Speedwaystar's (thanks!) suggestions so it will work with the latest client
- I have NOT done much testing on this, since I don't play anymore
- Updated TOC

v3.02
- This is a maintenance release
- Updated TOC
- Fixed possible problem with autolooting when pickpocketing (needs testing)
- Not implemented yet: Added option to disable autodestroy when using tradeskills (handy when you're trying to level up a new skill but want to keep the autodestroy functionality)
- Pending: Still need to look into autodestroy bug

v3.01
- Fixed a bug where new install would set the "destroy if x number of slots free" option but would show it as unchecked.
- Cleaned up inventory tab money display function a bit.

v3.0 (Release)
- Removed the "Details" option from the notification setting, replaced by the "debug" command which provides more info on why something was or wasn't looted.
- Added a combat check so it won't use CloseLoot() while in combat (which will currently cause taint errors because Blis didn't FIX IT) See KNOWN ISSUES

v3.0 Beta 4
Notes:
This version is mostly usability and Inventory tab stuff.
- Put the "enable/disable" checkbox next to the title, seems just as intuitive to me and moves it out of the way a bit
- Added headers to the inventory view, clicking on "Current Value" will cycle through "Stack Value" and "Item Value" displays
- Removed the separate Stack/Item value column, simplified the display
- When talking to a vendor, on the inventory tab the "Crap" column changes to a "Sell" column, with coin icons that let you sell items without digging through your bags
- In the Inventory tab, the text indicator for crap items has been replaced with a button that lets you one-click delete items

v3.0 Beta 3
Notes:
- I may clean up the display on the inventory tab, possibly just making a dropdown to select between "Current Value", "Stack Value", and "Item Value" since it seems a bit cluttered to me at the moment.
- I'm fairly happy with this version, the auto-destroy feature seems a lot more robust than I expected it to be considering the time gap between looting items and the items hitting the bag.
- I'm still contemplating combining the [poor] loot value settings with [uncommon], [rare], and [epic] and leaving the [common] items seperate. Right now there's no settings that will allow looting and autodestroying of green or higher items. At best you can just leave them on the corpse using the quality settings.

Known Issues:
- None in this version that I know of (yet). Seems fairly solid. Well, other than Blizzard's fucking LootSlot() still throwing taint errors when used in combat. FIX IT.
http://www.nbc.com/Saturday_Night_Live/video/clips/update-thursday-part-2/742141/

Testing needed:
- How I detect pickpocketing has changed and I haven't gotten to test it at all (Thanks EVmaker! ;P)
- Currency items like badges and such need to be tested to see if they actually autoloot.
- General stress testing on the destroy feature.
- Need to know what happens when someone tries to disenchant with auto-destroy on. Should autodestroy be disabled in situations where the looting is profession related? I've had requests for destroying crap during Fishing, are there other professions where it would or wouldn't apply?

- Fixed auto-destroy returning an error when bags were full
- Fixed auto-destroy not obeying rules when the bag slot minimum was set

v3.0 beta 2
- Wording changed on some items, hopefully clearer
- Trying to split up the functions into seperate files so the main lua isn't such a mess
- Combined "display when destroying items" with the "display when filtering item" option
- Destroy functionality added to "loot all" function (i.e. fishing, looting skinnable mobs the appropriate option checked, etc...)
- Added coin icons to amount display in the Inventory tab
- Destroy suboptions enabled: Disable when in group, disable when in raid, and only destroy when X or fewer bag slots free

v3.0 beta 1
Known Issues:
- None of the Auto-Destroy sub-options work yet, but auto-destroy should work okay. I haven't tried to mess it up too much yet, so what happens in peculiar circumstances (full bags, in raids, etc) isn't known yet. Proceed with caution.
- I'm going to clean up some language in the mod, seperating "ignoring items" from "marking things as crap" so it will be more clear. With the new quality settings and destroy settings people might assume that anything they mark to not loot would be destroyed.
- I may change the [common] item filter to include all other item qualities besides [poor], any opinions?

Things that need testing:
- I don't know if the autolooting on currency items works (Badge of Justice, etc) but if a level 80 could run into somewhere and see that would be great.
- The quality settings are new and need testing.

/crap debug will turn on some debug messages, usually whatever I'm trying to fix at the time. It may help if something confusing is happening though.

- Getglobal()s changed to _G[], more efficient
- Quality filter implemented
- Changed VARIABLES_LOADED event to ADDON_LOADED
- Can now auto-destroy filtered items
- Removed price addon dependency, functionality now in-game UI
- Currency items now always looted (Badge of Justice, etc)
- UI improvements: Drag and drop onto blacklist/whitelist
- UI improvements: Remembers last open tab during a session
- UI improvements: Price threshold fields set to zero when their values are deleted
- UI improvements: KarniCrap now closable using the escape key
- UI improvements: Warns on startup if autoloot is on in Blizzard options
- Fixed issue that nobody noticed where it wouldn't immediately recalculate poor/common thresholds after they were changed

v2.0.10
- Fixed filtering that got broken sometime in the last couple patches. I'm not sure how I fixed it, but it seems to work now.
- Updated the TOC
- Extensive XML cleanup and prep for future versions
- There's a 3rd tab now for inventory that I would like to implement fairly soon. This will tie in with the much requested auto-destroy function. There's also two new categories added: "Auto-destroy" and "Group/Raid". I'm not sure what's going in the group raid tab yet but there have been several requests for special behavior when in a group.

v2.0.9
- Fixed scrolling problem in Blacklists/Whitelists with lots of items
- Fixed problem with links displaying incorrectly when adding items to the blacklist
- Localized some functions that were conflicting with some addons' global functions

v2.0.8
- Woo typos! That's what I get for coding at 4am.
- Fixed a problem with wool cloth not remembering it's settings. Or "woo" cloth.
- Fixed a problem with the libdatabroker library not loading. Damn you hyphen. (thanks raicuandi!)

v2.0.7
- Added the new level VII scrolls to the scroll list
- Fixed the max level potion problem again (I think)

v2.0.6
- Added the ability to enable and disable the mod (/crap on or /crap off, or through the UI)
- Added the (only somewhat tested) ability to only fully autoloot corpses that you have enough skill to actually skin/gather/etc. Check for the "Only if you have required skill level" option under the Corpse settings.
- Fixed problem where uppercase commands would not be recognized

v2.0.5
- Fixed the issue with Informant not being detected as a price addon. Moved the check to the PLAYER_LOGIN event which happens after ALL other addons are loaded (Informant was always loading after KarniCrap, so it didn't know it was there)
- Fixed possible issue where quest items weren't being loaded at first, moved that to the PLAYER_LOGIN event as well.

v2.0.4
Mostly background stuff for future features
- Some background stuff with this one, starting to add in ability for user to turn on debug text, so they know why things are getting looted if they're trying to figure something out (not ready yet)
- Cooking list has been updated with the levels of the cooking items
- Holding down ALT while looting will make it not autoloot, in case you just want to look at something. There's no way to change the key at the moment and if your blizzard autoloot key is set to ALT then their autoloot will take precedence. Just something for convenience and not a fully implemented feature.

v2.0.3
- Fixes an error when loading the addon without a vendor price addon.

v2.0.2
- This should work now on the live client as well as beta
- Updated TOC

v2.0.1 (wotlk)
- Added WotLK skinnable mobs
- Added WotLK gatherable mobs
- Added WotLK minable mobs
- Added WotLK cooking materials
- Fixed TOC version number

v2.0 (wotlk)
- Fully Wrath of the Lich King compatible (I think!)
- Max level scroll looting is level sensitive now
- Max level pots are level sensitive as well
- New max level of health/mana potions (maybe incomplete)
- Blacklist and Whitelist now correctly left-aligned
- Note: Skinnable mobs for WotLK haven't been added yet, so it won't autoloot those corpses. In fact all the corpse options are likely incomplete.
- Note: Cooking mats are incomplete
- Note: Foods and Waters should be in, but there may be more that Wowhead doesn't know about yet.
- Debug text when looting a max mana potion removed
- Known issues: TOC file still says 1.8 Oops!

v1.8
- Tons of changes!
- Items that are in your blacklist or whitelist and aren't in your local cache will show up in red now instead of not showing up until the item was in cache. You can remove them from the list as well.
- Items in your bags that open (Lockboxes, Clams, Shattered Sun Supplies, etc) will now always be autolooted regardless of group loot threshold settings. Previously it wouldn't loot green items if you were in a group.
- Interface streamlined, back to two tabs :)
- Some changes to ease the transition to WotLK
- Milling and Prospecting looting added
- Now detects spellcasts in order to loot tradeskills, previously it was using long item lists that weren't very forward compatible.
- Engineerable Corpses functionality added for WotLK, incomplete though
- Fixed bug where mousing over another object (totem, monster, etc) when skinning would cause it not to loot the corpse automatically
- Pickpocketing option added, you can have it autoloot when picking pockets! Only available for rogues.
- Filter detail option added, so you know what filter caused you not to loot an item
- Max scroll option now changes according to your level.
- This should be the last main release before version 3.0/WotLK

v1.7.1
- Fixed an issue where if one of the items in the default whitelist was not in your item cache it would crash the mod. Huge thanks to Sorian and Cralor!

v1.7
- Lots of changes this version, so keep an eye out for bugs!
- Options interface redesigned
- Quest item looting should now work for all quest items
- Will (theoretically) loot food/water higher than you can currently use
- Blacklist takes priority over quest items (thanks Sentrosi!)
- Health pot/Mana pot overrides added
- Scroll options added, loot only specific scroll types, etc.
- Will autoloot all materials from disenchanting regardless of group loot settings (thanks Kithyara!)

v1.6.2
- I'll say that the max food and water options are fixed again, but I'm not making any promises. It better work this time or I'm half tempted to just rip it out.

v1.6.1
- Fixed the max food and max water checkboxes not working, max food/water relative to level should actually work now.
- Revamped the food list a bit, was missing several items that were findable in crates/chests (Damn you, Spotted Yellowtail). I may have to figure out a better way to separate items out that have low health/mana regen for their required level.

v1.6
- Fixed an issue where items not matching any of the non-price filters would not be autolooted if the user did not have an item value addon
- Fixed various other issues that occurred if the user did not have an item value addon
- Fixed issue where sometimes it would not attempt to loot green or higher items while soloing
+ Now disables "use stack value" option when there is no item value addon present
+ Max food & water option is level sensitive now. if "best for level" option is checked it will only loot the highest available food or water relative to your current level. Alt friendly :) Keep in mind there is only one food that drops off mobs that is good for 65+ (Sporeggar Mushroom), the rest is purchasable. Also, new foods and waters become available every 10 levels starting at 5.


v1.5.2
- Fixed pretty much all of the options not remembering settings after I added in defaults and went on vacation without testing :)

v1.5.1
- Fixed a problem where if user was in a group and a whitelisted item was a higher quality than the loot threshold, it would not attempt to loot the item (i.e. Badge of Justice being epic didn't get autolooted). It now checks for quest and whitelisted items first before other checks are made.
- Added some reasonable default settings so new users can see immediate results. May add a reset to defaults button in the future, for now clear out the saved variables file if you want to start fresh.

v1.5
- Redesigned the options interface, now prettier
- Some debug text removed that was added with the stack option
- Code now uglier

v1.4
- Added a "use full stack value" option, so you can loot items that stack to something worthwile.
- Fixed small problem where it would politely not try looting stuff when loot method was set to Free-For-All

v1.3
- Added a whitelist, use /notcrap [itemlink] to add items. If you are starting fresh it should default to having all the mote types on the whitelist.
- Should be smarter in groups now, won't attempt to loot items that are higher than the loot threshold (i.e stuff that would trigger rolls anyway).
- The fishing option has been improved to use IsFishingLoot() API, should be future-proof now.
- Options dialog now uglier.

v1.2.1
- Fixed issue where if skinning option was checked, but you were looting something you usually get from skinning off a nonskinnable mob it would loot it incorrectly. If that makes sense.

v1.2
- Woot, alphabetized blacklist!

v1.1
- Added mine autolooting option
- Fixed bug where it would correctly loot all items off skinnable corpses but say they were crap in the chatbox.
- Fixed Skinning option to say "Skinning" instead of "Leatherworking". I can't believe the skinners missed that one.

v1.0
- Woohoo, feature complete!
- Blacklist listbox and removing items added
- Possible fix for enchanting items not looting automatically
- Tradeskill options added (not just leatherworking!)

v0.9.2
- renamed main folder and files to KarniCrap from KarniLoot for consistency
- fixed bug where money filter settings weren't being recognized on first load
- added /crap command!

v0.9.1
- fixed chests not autolooting due to new GUID stuff from last version
- should work in BG's theoretically

v0.9
- fixed the fix for quest item filtering
- skinnable/gatherable/minable mob filter bypassing implemented
- blacklist added, kc [itemlink] to add items to it. Can't see it in ui yet though, and it may or may not work

v0.8.1
- added placeholder for skinnable filter bypass option
- fixed quest items getting filtered
- removed some debug text on cloth looting

v0.8
- goes beta (or alpha since it's not technically feature-complete yet)
Archived Files (20)
File Name
Version
Size
Author
Date
6.0.2.4
95kB
Karnifex
10-22-14 01:45 PM
6.0.2.2
83kB
Karnifex
10-20-14 04:21 AM
3.2.1
68kB
Karnifex
12-01-10 10:53 AM
3.2.0
64kB
Karnifex
11-17-10 11:58 PM
3.11
61kB
Karnifex
11-16-10 04:17 AM
3.10
55kB
Karnifex
11-15-10 03:58 AM
3.03
51kB
Karnifex
11-11-10 05:05 PM
3.02
52kB
Karnifex
02-20-10 07:02 AM
3.01
51kB
Karnifex
08-05-09 04:48 PM
3.0
51kB
Karnifex
08-04-09 06:23 PM
3.0 Beta 4
51kB
Karnifex
07-19-09 11:55 PM
3.0 Beta 3
51kB
Karnifex
07-15-09 08:02 PM
3.0 Beta 2
51kB
Karnifex
07-14-09 04:51 PM
3.0 Beta 1
49kB
Karnifex
07-13-09 06:25 PM
2.0.10
43kB
Karnifex
06-17-09 09:51 PM
2.0.9 retry
42kB
Karnifex
06-17-09 08:48 AM
2.0.9
42kB
Karnifex
12-15-08 03:39 AM
2.0.8
42kB
Karnifex
12-03-08 01:31 PM
2.0.7
42kB
Karnifex
11-28-08 09:35 AM
2.0.6
42kB
Karnifex
11-23-08 08:18 AM


Post A Reply Comment Options
Unread 10-20-14, 04:22 AM  
Brusk
A Kobold Labourer
AddOn Author - Click to view AddOns

Forum posts: 0
File comments: 2
Uploads: 1
Thanks to Karnifex for adding me to the dev team. I've now posted an official working version for patch 6.0.2.
Brusk is offline Report comment to moderator  
Reply With Quote
Unread 10-19-14, 09:14 AM  
Brusk
A Kobold Labourer
AddOn Author - Click to view AddOns

Forum posts: 0
File comments: 2
Uploads: 1
I've created a fixed version for 6.0.2 which also includes the fix for 5.0.4:

https://www.scene.org/~jeffry/KarniC...2.1-Khymar.zip

It's unofficial, but it should work. The problem was that in the new patch the GUID formatting has changed dramatically, so when the addon checked if you were looting a creature it failed.

It's very similar to Geadiin's fix below, just that it also extracts the unitID from the GUID as it is used a bit lateron in the code too.
Last edited by Brusk : 10-19-14 at 09:15 AM.
Brusk is offline Report comment to moderator  
Reply With Quote
Unread 10-16-14, 11:23 PM  
Geadiin
A Kobold Labourer

Forum posts: 0
File comments: 1
Uploads: 0
Originally Posted by du4no
Does anybody who knows how to code update this please?
I've never worked on any mods before but I think I've figured out a patch to make this work for 6.0.2.

I've modified KarniCrap.lua and changed lines 183 and 184 to these:

Code:
		--local unitType = bit.band(string.sub(unitString, 1, 5), "0x00F")
		if unitString:find("^Creature") then  -- npc
The first one just comments out line 183. The second line works with the changes to how unit GUIDS are specified.

Hope that helps someone.
Geadiin is offline Report comment to moderator  
Reply With Quote
Unread 01-06-13, 05:35 AM  
du4no
A Kobold Labourer

Forum posts: 1
File comments: 2
Uploads: 0
Does anybody who knows how to code update this please?
du4no is offline Report comment to moderator  
Reply With Quote
Unread 09-20-12, 11:35 AM  
agardin3
A Kobold Labourer

Forum posts: 0
File comments: 7
Uploads: 0
Patch 5.0.x

I've used this for a long time and it worked fine in Cataclysm for me. It stopped working now at 5.0, it no longer loots or deletes anything.
agardin3 is offline Report comment to moderator  
Reply With Quote
Unread 08-24-11, 03:49 PM  
du4no
A Kobold Labourer

Forum posts: 1
File comments: 2
Uploads: 0
Will this be updated?

It is not working at all for patch 4.2

It is such a great add-on for it to go to waste.

EDIT: what the poster below says is also true.

Message say it is not looting blacklisted item, but it loots it anyway.
Last edited by du4no : 08-24-11 at 03:50 PM.
du4no is offline Report comment to moderator  
Reply With Quote
Unread 02-27-11, 03:28 AM  
mantohu
A Kobold Labourer

Forum posts: 0
File comments: 6
Uploads: 0
I got some error here.
Here is my situation.The filter feature seems like didn't work (Stuff in Black list). But the 'crap filtering msg' still shows in the chat frame.

5x KarniCrap-3.2.1\KarniCrap.lua:475: attempt to concatenate local 'link' (a nil value)
<string>:"*:OnEvent":1: in function <[string "*:OnEvent"]:1>

Locals:
self = KarniCrap_Scripts {
0 = <userdata>
}
event = "LOOT_OPENED"

---
Last edited by mantohu : 02-27-11 at 03:30 AM.
mantohu is offline Report comment to moderator  
Reply With Quote
Unread 01-03-11, 01:23 PM  
Karnifex
A Deviate Faerie Dragon
AddOn Author - Click to view AddOns

Forum posts: 13
File comments: 92
Uploads: 1
Does the addon seem to be working okay post-Cataclysm launch? I have a report saying it's not working in some of the new areas, no idea why. Can anyone confirm?
Last edited by Karnifex : 01-04-11 at 02:53 PM.
Karnifex is offline Report comment to moderator  
Reply With Quote
Unread 12-02-10, 04:23 PM  
Karnifex
A Deviate Faerie Dragon
AddOn Author - Click to view AddOns

Forum posts: 13
File comments: 92
Uploads: 1
Originally posted by ChaosInc
Perhaps add an option for whitelisting item types as well as individual items. This would help with tradeskills a bunch since users wouldn't have to add each ore/herb/part individually, not add a bunch of coding (a la current disabled profession options) and save a bunch of time all around. And since settings are saved per character, there's little worry about bleedover settings.

Two more things 1 possible bug and one suggestion:
1) When I enable "if X bag spaces left" option, KCF stops looting "crap" off corpses entirely even if I have more bag space than specified. I may be misunderstanding how this option is supposed to work, but if I disable it "crap" loot will be picked up and deleted again (which is my preference). Not sure if this is what you are referring to with "clean corpses option" you mentioned.

1)I'd suggest an addition to the "if X bag spaces left" option to delete the lowest value item when you reach the "X" bag space. I know several addons out there do this by themselves, but I'm one for single multipurpose addons.
That's working as intended. It might make more sense as a general option, now that you mention it. So it would just loot everything until x slots left, then start filtering. Actually that does make more sense.

I'm a little wary of your suggestion for two reasons. First, I'm realizing that crap filter started out as just avoiding looting certain items, and with the inventory stuff added in there's more of a need to keep track of everything that's crap at all times. Since you never loot a hearthstone, for example, there was no need to find a way to track that it's a white item that you would never want to delete. So there's a bit of a scope issue that's my fault there. Second, unless the person had gone to the trouble of whitelisting everything in their bags they wanted to keep, when their free spaces hit that number probably something unexpected would get deleted since it separates the crap-designating from the looting process.

What I mean by clean corpses is you can make it so it loots everything off of skinnable (gatherable, minable...) corpses, even if it's crap. I'm not sure that still works though. Nobody's complained yet, anyway.
Karnifex is offline Report comment to moderator  
Reply With Quote
Unread 12-01-10, 03:36 PM  
ChaosInc
Curse staff
 
ChaosInc's Avatar
AddOn Author - Click to view AddOns

Forum posts: 670
File comments: 368
Uploads: 21
Originally posted by Karnifex
Thanks, will look into it tonight. Hey, since not many people on Curse comment I wanted to post some ideas over here and maybe get feedback:

I was brainstorming the issue of random stuff you have being marked as crap because it's cheap (like mining pick or engineering tools for example). Since everyone probably has different levels of what they consider "crap", it's not a simple problem.

One idea I came up with I thought might work is to automatically whitelist anything you purchase from a merchant. If you're buying it, obviously you want to keep it. That would (assuming you started out with crap filter) also include stuff like blacksmith hammers and tradeskill mats. It wouldn't get stuff you created though, like the engineering gizmos (gnomish army knife). And adding stuff you created using tradeskills seems messy.

Auto-whitelist items looted when using a tradeskill? (This might not be a good idea, since I know you sometimes get worthless stuff when jewelcrafting ore and such. Or at least you used to a year ago. Is all the stuff from tradeskills usable now? I noticed mining is only 1 hit now and it all seemed like stuff you would want)

If there's a limited amount of tradeskill items (like campfire stuff, cooking stuff, engineering tools, fishing poles, smithing stuff...) maybe it can just be built in to the whitelist as a default.

Built-in autosell options for gray items?

What are some of the inconveniences or issues you're running in to as you play? (Aside from the known issues)
Perhaps add an option for whitelisting item types as well as individual items. This would help with tradeskills a bunch since users wouldn't have to add each ore/herb/part individually, not add a bunch of coding (a la current disabled profession options) and save a bunch of time all around. And since settings are saved per character, there's little worry about bleedover settings.

Two more things 1 possible bug and one suggestion:
1) When I enable "if X bag spaces left" option, KCF stops looting "crap" off corpses entirely even if I have more bag space than specified. I may be misunderstanding how this option is supposed to work, but if I disable it "crap" loot will be picked up and deleted again (which is my preference). Not sure if this is what you are referring to with "clean corpses option" you mentioned.

1)I'd suggest an addition to the "if X bag spaces left" option to delete the lowest value item when you reach the "X" bag space. I know several addons out there do this by themselves, but I'm one for single multipurpose addons.
__________________
Originally posted by Mirrikat45
so says the 1/2 million downloads per week.......
Impossible statistics = FAIL!! But don't point this out, or your post will be deleted!
ChaosInc is offline Report comment to moderator  
Reply With Quote
Unread 11-29-10, 08:13 PM  
Karnifex
A Deviate Faerie Dragon
AddOn Author - Click to view AddOns

Forum posts: 13
File comments: 92
Uploads: 1
Also I'm sitting on a new version that has a couple tweaks and the new cloth in it, hoping to get more Cataclysm-specific stuff in it. Also, not sure if the clean corpses option is working, I hear they made changes to how I'm IDing the units.
Karnifex is offline Report comment to moderator  
Reply With Quote
Unread 11-29-10, 07:56 PM  
Karnifex
A Deviate Faerie Dragon
AddOn Author - Click to view AddOns

Forum posts: 13
File comments: 92
Uploads: 1
Originally posted by ChaosInc
"Except when using tradeskills" and "Don't destroy in group" are not carrying over between sessions.
Thanks, will look into it tonight. Hey, since not many people on Curse comment I wanted to post some ideas over here and maybe get feedback:

I was brainstorming the issue of random stuff you have being marked as crap because it's cheap (like mining pick or engineering tools for example). Since everyone probably has different levels of what they consider "crap", it's not a simple problem.

One idea I came up with I thought might work is to automatically whitelist anything you purchase from a merchant. If you're buying it, obviously you want to keep it. That would (assuming you started out with crap filter) also include stuff like blacksmith hammers and tradeskill mats. It wouldn't get stuff you created though, like the engineering gizmos (gnomish army knife). And adding stuff you created using tradeskills seems messy.

Auto-whitelist items looted when using a tradeskill? (This might not be a good idea, since I know you sometimes get worthless stuff when jewelcrafting ore and such. Or at least you used to a year ago. Is all the stuff from tradeskills usable now? I noticed mining is only 1 hit now and it all seemed like stuff you would want)

If there's a limited amount of tradeskill items (like campfire stuff, cooking stuff, engineering tools, fishing poles, smithing stuff...) maybe it can just be built in to the whitelist as a default.

Built-in autosell options for gray items?

What are some of the inconveniences or issues you're running in to as you play? (Aside from the known issues)
Karnifex is offline Report comment to moderator  
Reply With Quote
Unread 11-29-10, 02:34 PM  
ChaosInc
Curse staff
 
ChaosInc's Avatar
AddOn Author - Click to view AddOns

Forum posts: 670
File comments: 368
Uploads: 21
"Except when using tradeskills" and "Don't destroy in group" are not carrying over between sessions.
__________________
Originally posted by Mirrikat45
so says the 1/2 million downloads per week.......
Impossible statistics = FAIL!! But don't point this out, or your post will be deleted!
ChaosInc is offline Report comment to moderator  
Reply With Quote
Unread 11-18-10, 03:50 PM  
Karnifex
A Deviate Faerie Dragon
AddOn Author - Click to view AddOns

Forum posts: 13
File comments: 92
Uploads: 1
Originally posted by Dekarx
Hey there. First of all, thank you for a great addon. It just had to be said.

I was wondering if there was a way to copy filter settings between characters(never loot, always loot i.e. /crap [] /notcrap []). It can take a long time to set such filters as we want them as and to do it all over again would be excruciating. I don't see an option to do it. I'll have to see if copying saved variables files or something does the trick.

Also I do not know if you've implemented the always loot tradeskill items, but if it is indeed done, they still get destroyed with the "Destroy all crap" button, which might not be optimal.

I was also thinking it could be nice to have a way to export/import and share filter settings. The tricky filter for me is [common] as it is a clusterfrack of crap and useful items mixed in a single category and it'll need a lot of personal tweaking.

Thanks and gl in your finals.
Thanks! You should be able to duplicate settings by copying the savedvariables file. I haven't looked in to duplicating settings across characters yet, in trying to keep it as simple as possible I was avoiding having any in-game interface for that. Also, I expect in most cases multiple characters would probably not all be the same level and some of the settings would be useful for one and not for the other.

If you want to just copy the blacklist/whitelist you can probably figure out how to from looking at the savedvariables file. There's no automatic way to do this though (yet)

For the tradeskill item/destroy all crap thing, it's working as intended. For tradeskills I had two options, one was to just check when a person is performing a tradeskill, or two have a huge list of all the items for every tradeskill. I went with option one That said, I have gotten a suggestion of making it easy to add items to the blacklist/whitelist directly from the inventory tab, which I think is a great idea. I think the inventory tab can be improved quite a bit, but it will have to wait for another time.
Karnifex is offline Report comment to moderator  
Reply With Quote
Unread 11-18-10, 02:07 PM  
Dekarx
A Kobold Labourer

Forum posts: 0
File comments: 11
Uploads: 0
Hey there. First of all, thank you for a great addon. It just had to be said.

I was wondering if there was a way to copy filter settings between characters(never loot, always loot i.e. /crap [] /notcrap []). It can take a long time to set such filters as we want them as and to do it all over again would be excruciating. I don't see an option to do it. I'll have to see if copying saved variables files or something does the trick.

Also I do not know if you've implemented the always loot tradeskill items, but if it is indeed done, they still get destroyed with the "Destroy all crap" button, which might not be optimal.

I was also thinking it could be nice to have a way to export/import and share filter settings. The tricky filter for me is [common] as it is a clusterfrack of crap and useful items mixed in a single category and it'll need a lot of personal tweaking.

Thanks and gl in your finals.
Last edited by Dekarx : 11-18-10 at 02:08 PM.
Dekarx is offline Report comment to moderator  
Reply With Quote
Post A Reply



Category Jump: