WoWInterface - the

WoWInterface (https://www.wowinterface.com/forums/index.php)

- Cataclysm Beta (https://www.wowinterface.com/forums/forumdisplay.php?f=82)

- - the _G changes. (https://www.wowinterface.com/forums/showthread.php?t=35014)

Grimsin

09-16-10 11:59 PM

the _G changes.

can someone explain this better. "The getglobal and setglobal functions are considerd deprecated, and have been removed from the C API's. In the interests of compatibility there remain lua implementations of both, but new code should be updated to use x = _G[globalName] and _G[globalName] = x instead."

what code should be updated? i think this is where the problems with my ui are but not exactly sure why does it mean things like this _G[prefix .. slots[id]] need to be changed? or _G[this:GetName().. ?

nightcracker

09-17-10 12:14 AM

No, only setglobal(prefix .. slots[id], "SOMEVALUE") needs to be updated to _G[prefix .. slots[id]] = "SOMEVALUE".

If you didn't use setglobal or getglobal, then you shouldn't be worried.

Grimsin

09-17-10 07:52 AM

hmmm, well im still confused then about one change or another. I get what appears to be the same value = nil error on a few different chunks of code. some of the chunks are as follows.

lua Code:

local function CreateBorders(frame, prefix)
    local border, start = { }, frame == CharacterFrame and 0 or 1
    for id = start, #slots do
        local frame = _G[prefix .. slots[id]]
        local region = GetNormalTexture(frame:GetRegions())
        local texture = frame:CreateTexture(nil, 'OVERLAY')
        texture:SetTexture([[Interface\Buttons\UI-ActionButton-Border]])
        texture:SetBlendMode('ADD')
        texture:SetAlpha(0.8)
        texture:SetPoint('TOPLEFT', region, -1, 3)
        texture:SetPoint('BOTTOMRIGHT', region, 1, 0)
        border[id] = texture
    end
    borders[frame] = border
end
 
local function OnHide(self)
    addon.UnregisterEvent(self, 'UNIT_INVENTORY_CHANGED')
end
 
local function OnShow(self)
    addon.RegisterEvent(self, 'UNIT_INVENTORY_CHANGED', UpdateItemQualityBorders)
    UpdateItemQualityBorders(self, nil, self.unit)
end
 
local function HookFrame(frame, prefix)
    CreateBorders(frame, prefix)
    frame:HookScript('OnHide', OnHide)
    frame:HookScript('OnShow', OnShow)
end
 
HookFrame(CharacterFrame, 'Character')
CharacterFrame.unit = 'player'
 
if InspectFrame then
    HookFrame(InspectFrame, 'Inspect')
else
    addon.RegisterEvent("Features-MonitorInspectUI", 'ADDON_LOADED', function(self, event, name)
        if name ~= 'Blizzard_InspectUI' then return end
        addon.UnregisterEvent(self, event)
 
        HookFrame(InspectFrame, 'Inspect')
        if InspectFrame:IsShown() then
            UpdateItemQualityBorders(InspectFrame, nil, InspectFrame.unit)
        end
    end)
end

or this chunk

lua Code:

hooksecurefunc('FriendsList_Update', function()
    local buttons, button = FriendsFrameFriendsScrollFrame.buttons
    local colors, CLASS = CUSTOM_CLASS_COLORS or RAID_CLASS_COLORS, addon.CLASS
    for index = 1, FriendsFrameFriendsScrollFrame.usedButtons do
        button = buttons[index]
        if button.buttonType == FRIENDS_BUTTON_TYPE_WOW then
            local _, _, class, _, connected = GetFriendInfo(button.id)
            if connected then
                local color = colors[CLASS[class]]
                button.name:SetTextColor(color.r, color.g, color.b)
            end
        end
    end
end)

and last but not least this chunk also

lua Code:

_G.SlashCmdList["GTIPNOTES_SHORTHAND"] = function(input)
    if not UnitExists("target") then
        DEFAULT_CHAT_FRAME:AddMessage(TARGET_ERROR)
        return
    end
    if type(input) ~= "string" or input:trim():len() == 0 then
        if not StaticPopupDialogs["GTipNotes"] then
            StaticPopupDialogs["GTipNotes"] = {
                text = nil,
                button1 = SET,
                button2 = CANCEL,
                whileDead = 1,
                hideOnEscape = 1,
                timeout = 0,
                OnShow = function()
                    -- We have to do this onshow to reset the previous text
                    local t = UnitExists("target") and UnitName("target") or ""
                    _G[this:GetName().."EditBox"]:SetText(_G.GTipNotesDB[t] or "")
                end,
                OnHide = function()
                    _G[this:GetName().."EditBox"]:SetText("")
                end,
                EditBoxOnEnterPressed = function()
                    addNoteFromPopup(_G[this:GetParent():GetName().."EditBox"]:GetText())
                    this:GetParent():Hide()
                end,
                EditBoxOnEscapePressed = function()
                    this:GetParent():Hide()
                end,
                OnAccept = function()
                    addNoteFromPopup(_G[this:GetParent():GetName().."EditBox"]:GetText())
                end,
                hasEditBox = 1,
            }
        end
        StaticPopupDialogs["GTipNotes"].text = POPUP_TEXT:format(UnitName("target"))
        StaticPopup_Show("GTipNotes")
    else
        local t = UnitName("target")
        _G.GTipNotesDB[t] = input
        DEFAULT_CHAT_FRAME:AddMessage(NOTE_SET:format(t, input))
    end
end

all works on live servers so it has to be the cata changes that caused this im just not sure which one or why.

IQgryn

09-17-10 08:55 AM

Quote:

Originally Posted by Grimsin (Post 206484)

hmmm, well im still confused then about one change or another. I get what appears to be the same value = nil error on a few different chunks of code. some of the chunks are as follows.

<snip>

Which lines are causing the nil errors?

Beoko

09-17-10 09:31 AM

Quote:

* The global variables this, event and arg1, arg2... have been removed. Event handlers and other callbacks must use the appropriate locals.

These changes are present as well.

Grimsin

09-17-10 09:45 AM

my use of "this" in the tooltips code i changed to self and got a way different error, i dont think the use of this in that instance is the same as what was changed? if so i should of been able to simply change this to self or at lest that was my understanding.

the exact line that it starts in the 3rd chunk of code is this one, it says "this" is a nil value
_G[this:GetName().."EditBox"]:SetText(_G.GTipNotesDB[t] or "")

in the first chunk of code it is this one, this one says "frame" is a nil value
local region = GetNormalTexture(frame:GetRegions())

in the 2nd chunk of code im not sure which line it was i have to go back and check.

IQgryn

09-17-10 10:13 AM

Quote:

Originally Posted by Grimsin (Post 206494)

Unless you specifically declare a variable named this, any use of this is now invalid (and using it will cause nil errors). It's also not always just as simple as changing it to say self. That will usually work when you have a function definition of the form:

Code:

Frame:function()

Although even then, there can be problems. If your function is not declared like that (and the ones you posted aren't), you need to add a self parameter to the parameter list and update the code using the function to pass that along as well.

Note that if you add the parameter yourself, you don't have to call it self. You may use whatever name suits your fancy.

Seerah

09-17-10 10:18 AM

You still have to define self with Frame:function() like so

Code:

Frame:function(self)

With the : notation, the frame reference is passed as the first argument (which you need to define with a variable if you wish to use it).

IQgryn

09-17-10 10:53 AM

Quote:

Originally Posted by Seerah (Post 206498)

You still have to define self with Frame:function() like so

Code:

Frame:function(self)

With the : notation, the frame reference is passed as the first argument (which you need to define with a variable if you wish to use it).

Actually, the self parameter is implied in that case. The only time you'd need to declare it specifically is if you called and/or defined it with a period instead of a colon. To quote myself from another thread:

Quote:

Originally Posted by IQgryn (Post 206094)

These four code snippets are exactly the same thing with different syntax:

Code:

function MyAddon:MyFunc(var1) print(self, var1) end

MyAddon:MyFunc("test value")

Code:

function MyAddon.MyFunc(self, var1) print(self, var1) end

MyAddon.MyFunc(MyAddon, "test value")

Code:

function MyAddon:MyFunc(var1) print(self, var1) end

MyAddon.MyFunc(MyAddon, "test value")

Code:

function MyAddon.MyFunc(self, var1) print(self, var1) end

MyAddon:MyFunc("test value")

In other words:
When defining a function, if a colon is used, self will be the first parameter (before any others you list).
When calling a function, self is automatically passed (as the first argument) with the value of whatever is before the colon when you use a colon instead of a period.

This is nothing specific to WoW; all of Lua works this way to make object-oriented code easier to write.

Vrul	09-17-10 11:43 AM

Only the last error has anything to do with the changes to this, and only changing this to self won't fix it, you also need to update the function declarations to include that self is passed:

lua Code:

_G.SlashCmdList["GTIPNOTES_SHORTHAND"] = function(input)
    if not UnitExists('target') then
        print(TARGET_ERROR)
        return
    end
    input = input:trim()
    if type(input) ~= 'string' or input == "" then
        if not StaticPopupDialogs["GTipNotes"] then
            StaticPopupDialogs["GTipNotes"] = {
                text = nil,
                button1 = SET,
                button2 = CANCEL,
                whileDead = 1,
                hideOnEscape = 1,
                timeout = 0,
                OnShow = function(self)
                    -- We have to do this onshow to reset the previous text
                    local name = UnitExists("target") and UnitName("target") or ""
                    _G[self:GetName() .. "EditBox"]:SetText(_G.GTipNotesDB[name] or "")
                end,
                OnHide = function(self)
                    _G[self:GetName() .. "EditBox"]:SetText("")
                end,
                EditBoxOnEnterPressed = function(self)
                    addNoteFromPopup(_G[self:GetParent():GetName() .. "EditBox"]:GetText())
                    self:GetParent():Hide()
                end,
                EditBoxOnEscapePressed = function(self)
                    self:GetParent():Hide()
                end,
                OnAccept = function(self)
                    addNoteFromPopup(_G[self:GetParent():GetName() .. "EditBox"]:GetText())
                end,
                hasEditBox = 1,
            }
        end
        StaticPopupDialogs["GTipNotes"].text = POPUP_TEXT:format(UnitName('target'))
        StaticPopup_Show("GTipNotes")
    else
        local name = UnitName('target')
        _G.GTipNotesDB[name] = input
        print(NOTE_SET:format(name, input))
    end
end

The issue with FriendsFrame code is that Blizzard changed it and no longer uses/sets FriendsFrameFriendsScrollFrame.usedButtons:

lua Code:

hooksecurefunc('FriendsList_Update', function()
    local buttons, button = FriendsFrameFriendsScrollFrame.buttons
    local colors, CLASS = CUSTOM_CLASS_COLORS or RAID_CLASS_COLORS, addon.CLASS
    for index = 1, #buttons do
        button = buttons[index]
        if button:IsShown() then
            if button.buttonType == FRIENDS_BUTTON_TYPE_WOW then
                local _, _, class, _, connected = GetFriendInfo(button.id)
                if connected then
                    local color = colors[CLASS[class]]
                    button.name:SetTextColor(color.r, color.g, color.b)
                end
            end
        else
            break
        end
    end
end)

Part of the problem with the first error is that the ammo slot was removed which is what slots[0] is, so remove the start variable and always begin with an id of 1:

lua Code:

local function CreateBorders(frame, prefix)
    local border = { }
    for id = 1, #slots do
        local frame = _G[prefix .. slots[id]]
        local region = GetNormalTexture(frame:GetRegions())
        local texture = frame:CreateTexture(nil, 'OVERLAY')
        texture:SetTexture([[Interface\Buttons\UI-ActionButton-Border]])
        texture:SetBlendMode('ADD')
        texture:SetAlpha(0.8)
        texture:SetPoint('TOPLEFT', region, -1, 3)
        texture:SetPoint('BOTTOMRIGHT', region, 1, 0)
        border[id] = texture
    end
    borders[frame] = border
end

There may still be errors after making those changes, I don't have access to check, but at least you will be one step closer to fixing it.

Seerah

09-17-10 11:43 AM

Ah, yes, you're right. I was confusing Frame:function with Frame.function. :o

IQgryn

09-17-10 11:53 AM

Quote:

Originally Posted by Seerah (Post 206512)

Ah, yes, you're right. I was confusing Frame:function with Frame.function. :o

Heh. I'll admit that I double-checked before contradicting you. :p

Grimsin

09-17-10 06:00 PM

Obi Vrul Kanobi, you were right on the friends list coloring. Something is amiss on the item boarder though still as well as the notes button. Just finally got into beta for some reason it was freezing up on the load screen for the last hour. heh.

Vrul	09-18-10 12:53 AM

For the item border code you need to make a similar change to the UpdateItemQualityBorders function:

lua Code:

local function UpdateItemQualityBorders(frame, _, unit)
    if frame.unit ~= unit then return end
    local border = borders[frame]
    for id = 1, #slots do
        local link = GetInventoryItemLink(unit, id)                                         -- GetInventoryItemQuality doesn't work for InspectFrame
        if link then
            local color = qualityColor[link:match("|[Cc][Ff][Ff](%x%x%x%x%x%x)")]
            border[id]:SetVertexColor(color[1], color[2], color[3])
            border[id]:Show()
        else
            border[id]:Hide()
        end
    end
end

For the notes code the OnAccept function should be:

lua Code:

OnAccept = function(self)
    addNoteFromPopup(_G[self:GetName() .. "EditBox"]:GetText())
end,

Also, both EditBox functions have "_G[self:GetParent():GetName() .. 'EditBox']:GetText()" which is the same as "self:GetText()" so you may want to change that. However, I think that whole section of code could use some cleaning up:

lua Code:

StaticPopupDialogs["GTipNotes"] = {
    button1 = SET,
    button2 = CANCEL,
    hasEditBox = true,
    hideOnEscape = true,
    text = POPUP_TEXT,
    timeout = 0,
    whileDead = true,
    EditBoxOnEnterPressed = function(self, data)
        local note = self:GetText():trim()
        if note == "" then
            note = nil
        end
        GTipNotesDB[data] = note
        self:GetParent():Hide()
    end,
    EditBoxOnEscapePressed = function(self)
        self:GetParent():Hide()
    end,
    OnAccept = function(self, data)
        local note = _G[self:GetName() .. 'EditBox']:GetText():trim()
        if note == "" then
            note = nil
        end
        GTipNotesDB[data] = note
    end
}
 
SlashCmdList["GTIPNOTES_SHORTHAND"] = function(note)
    if UnitExists('target') then
        local name = UnitName('target')
        note = note:trim()
        if note == "" then
            note = GTipNotesDB[name]
        end
        StaticPopup_Show("GTipNotes", name, nil, name)
        if note then
            name = StaticPopup_Visible("GTipNotes")
            if name then
                _G[name .. 'EditBox']:SetText(note)
            end
        end
    else
        print(TARGET_ERROR)
    end
end

weasoug

09-18-10 10:17 AM

I wanted to ask. what i could do with this. as i felt that its about the same. the error i get is based on not being able to local the editbox no more for cata.;

Code:

                local editbox = _G[dialog:GetName().."WideEditBox"]  

                editbox:SetText(value)

                editbox:SetFocus()

                editbox:HighlightText()

thanks for your time,

i think i fixed it. was due to they re,pved WideEditBox/ as i see on an other post.

Grimsin

09-24-10 10:18 AM

Vrul - okay so remember you had said before i should remove the default db stuff which i did. I wonder if that is where i broke this? I have made all the changes you suggested and still get errors as far as it thinking the db is a nil value certain changes make that happen and certain things break the /commands. Im still really not understanding the use of _G now because almost everything that is broken, not just in the GrimUI has to do with _G. like baggins is borked and it has to do with the _G usage again and i just dont see why?

My entire move frames code is borked to in cata but im not even going there right now lol.

I also noticed something strange with the item coloring on the inspect window, when you inspect 2-3 items will have the boarder, then inspect again and more appear until you inspect like 3 times and they all are there then. Is this because of the inspect throttle stuff? Or some other problem?

The tipnotes looks like this, this is with all changes you have suggested including the one months ago about the default db not being stuffed into the base lua.

lua Code:

local addonName, addon = ...
 
local DB_VERSION = 11
 
local defaultDatabase = nil
 
local POPUP_TEXT = "Set a note for |cffff4488%s|r."
local TARGET_ERROR = "You must target something to add a note."
local NOTE_SET = "Note for |cffff4488%s|r set to \"|cff888888%s|r\"."
local SET = "Set"
local CANCEL = "Cancel"
local NOTE_PREFIX = "|cffff4488Note:|r "
-- Keybinding to output the note to chat
BINDING_HEADER_GRIMUI = "GrimUI"
BINDING_NAME_GTIPNOTES_PRINT = "Print ToolTip Note"
 
function GTipNotes_GetNote(name)
    if not name then return end
    return _G.GTipNotesDB[name]
end
 
local frame = CreateFrame("Frame")
frame:SetScript("OnEvent", function()
    if event == "VARIABLES_LOADED" then
        if not _G.GTipNotesDB then
            _G.GTipNotesDB = defaultDatabase
            _G.GTipNotesDB.VERSION = DB_VERSION
        end
 
        if not _G.GTipNotesDB.VERSION or _G.GTipNotesDB.VERSION < DB_VERSION then
            for k, v in pairs(defaultDatabase) do
                if not _G.GTipNotesDB[k] then
                    _G.GTipNotesDB[k] = v
                end
            end
            DEFAULT_CHAT_FRAME:AddMessage("|cffff4488Mob Notes|r database updated to revision " .. tostring(DB_VERSION) .. ".")
            _G.GTipNotesDB.VERSION = DB_VERSION
        end
 
        local orig = GameTooltip:GetScript("OnTooltipSetUnit")
        GameTooltip:SetScript("OnTooltipSetUnit", function(tooltip, ...)
            local name, unitid = tooltip:GetUnit()
            if UnitExists(unitid) and _G.GTipNotesDB[name] then
                GameTooltip:AddLine(NOTE_PREFIX .. _G.GTipNotesDB[name], 0.5, 0.5, 0.5, 1)
            end
            return orig(tooltip, ...)
        end)
    end
end)
 
frame:RegisterEvent("VARIABLES_LOADED")
 
local function addNoteFromPopup(note)
    if type(note) ~= "string" or note:trim():len() == 0 then note = nil end
    local t = UnitExists("target") and UnitName("target") or nil
    if t then
        _G.GTipNotesDB[t] = note
        DEFAULT_CHAT_FRAME:AddMessage(NOTE_SET:format(t, tostring(note)))
    end
end
 
StaticPopupDialogs["GTipNotes"] = {
button1 = SET,
button2 = CANCEL,
hasEditBox = true,
hideOnEscape = true,
text = POPUP_TEXT,
timeout = 0,
whileDead = true,
EditBoxOnEnterPressed = function(self, data)
local note = self:GetText():trim()
if note == "" then
note = nil
end
GTipNotesDB[data] = note
self:GetParent():Hide()
end,
EditBoxOnEscapePressed = function(self)
self:GetParent():Hide()
end,
OnAccept = function(self, data)
local note = _G[self:GetName() .. 'EditBox']:GetText():trim()
if note == "" then
note = nil
end
GTipNotesDB[data] = note
end
 
}
 
SlashCmdList["GTIPNOTES_SHORTHAND"] = function(note)
if UnitExists('target') then
local name = UnitName('target')
note = note:trim()
if note == "" then
note = GTipNotesDB[name]
end
StaticPopup_Show("GTipNotes", name, nil, name)
if note then
name = StaticPopup_Visible("GTipNotes")
if name then
_G[name .. 'EditBox']:SetText(note)
end
end
else
print(TARGET_ERROR)
end
end
_G.SLASH_GTIPNOTES_SHORTHAND1 = "/gtipnotes"
 
 
end

Vrul	09-24-10 07:04 PM

Quote:

Originally Posted by Grimsin (Post 207141)

I have made all the changes you suggested and still get errors as far as it thinking the db is a nil value certain changes make that happen and certain things break the /commands.

Because you didn't remove all of the db stuff, there is still some right in that code you posted.

Code:

local addonName, addon = ...



BINDING_HEADER_GRIMUI = "GrimUI"

BINDING_NAME_GTIPNOTES_PRINT = "Print ToolTip Note"

 

StaticPopupDialogs["GTipNotes"] = {

        button1 = "Set",

        button2 = "Cancel",

        hasEditBox = true,

        hideOnEscape = true,

        text = "Set a note for |cffff4488%s|r.",

        timeout = 0,

        whileDead = true,

        EditBoxOnEnterPressed = function(self, data)

                local note = self:GetText():trim()

                if note == "" then

                        note = nil

                end

                GTipNotesDB[data] = note

                self:GetParent():Hide()

        end,

        EditBoxOnEscapePressed = function(self)

                self:GetParent():Hide()

        end,

        OnAccept = function(self, data)

                local note = _G[self:GetName() .. 'EditBox']:GetText():trim()

                if note == "" then

                        note = nil

                end

                GTipNotesDB[data] = note

        end

}



SlashCmdList["GTIPNOTES_SHORTHAND"] = function(note)

        if UnitExists('target') then

                local name = UnitName('target')

                note = note:trim()

                if note == "" then

                        note = GTipNotesDB[name]

                end

                StaticPopup_Show("GTipNotes", name, nil, name)

                if note then

                        name = StaticPopup_Visible("GTipNotes")

                        if name then

                                _G[name .. 'EditBox']:SetText(note)

                        end

                end

        else

                print("You must target something to add a note.")

        end

end

SLASH_GTIPNOTES_SHORTHAND1 = "/gtipnotes"



addon.RegisterEvent("TooltipNotes-Initialize", 'PLAYER_LOGIN', function(self, event)

        addon.UnregisterEvent(self, event)



        if type(GTipNotesDB) ~= 'table' then

                GTipNotesDB = { }

        end



        GameTooltip:HookScript('OnTooltipSetUnit', function(self)

                local note = GTipNotesDB[self:GetUnit()]

                if note then

                        self:AddLine("|cffff4488Note:|r " .. note, 0.5, 0.5, 0.5, 1)

                end

        end)

end)

Quote:

Originally Posted by Grimsin (Post 207141)

Im still really not understanding the use of _G now because almost everything that is broken, not just in the GrimUI has to do with _G. like baggins is borked and it has to do with the _G usage again and i just dont see why?

My entire move frames code is borked to in cata but im not even going there right now lol.

_G is just a table for the global namespace. Any error resulting from a line of code with _G[someVariableName] is because the object/value that has the name someVariableName on live in now gone, renamed, or significantly changed in beta. Pay attention to the error messages and check the values on the stack, this should easily get you to the relevant portion of Blizzard's code to track down the culprit.

Grimsin

09-25-10 06:36 PM

how do we get into the new cata code? Is there an "addonkit" like for live wow where it decompiles the mpq's into readable lua's?

Starinnia

09-25-10 07:01 PM

Quote:

Originally Posted by Grimsin (Post 207306)

how do we get into the new cata code? Is there an "addonkit" like for live wow where it decompiles the mpq's into readable lua's?

http://github.com/tekkub/wow-ui-source/tree/cat

All times are GMT -6. The time now is 11:12 AM.