Assorted 5.1.0 changes (not all-inclusive)
Selected changes that I think might be of interest for quick fixes/spotting broken addons.
First of all: Zork's post for nameplate changes in 5.1.0 Ketho's comprehensive diff list *LIGHT_FORCE -> *CHI (meaning SPELL_POWER_LIGHT_FORCE -> SPELL_POWER_CHI, LIGHT_FORCE -> CHI in event args etc, best doing a case sensitive search for LIGHT_FORCE) new event: LOSS_OF_CONTROL_UPDATE new event: UPDATE_VEHICLE_ACTIONBAR new event: GROUP_JOINED arg1 = partyCategory (LE_PARTY_CATEGORY_HOME LE_PARTY_CATEGORY_INSTANCE etc) removed chat: BATTLEGROUND / BATTLEGROUND_LEADER new chat: INSTANCE_CHAT / INSTANCE_CHAT_LEADER removed globalstring: BATTLEGROUND_MESSAGE|CHAT_BATTLEGROUND_GET|CHAT_BATTLEGROUND_LEADER_GET|CHAT_BATTLEGROUND_SEND added globalstring: CHAT_INSTANCE_CHAT_GET|CHAT_INSTANCE_CHAT_LEADER_GET|CHAT_INSTANCE_CHAT_SEND added globalstring: FACTION_STANDING_INCREASED_ACH_BONUS|FACTION_STANDING_INCREASED_DOUBLE_BONUS Code:
local id, rep, maxRep, name, text, texture, reaction, threshold, nextThreshold = GetFriendshipReputation(); added: PlayerFrameMultiGroupFrame -- Instance Difficulty globals added DIFFICULTY_DUNGEON_NORMAL = 1; DIFFICULTY_DUNGEON_HEROIC = 2; DIFFICULTY_RAID10_NORMAL = 3; DIFFICULTY_RAID25_NORMAL = 4; DIFFICULTY_RAID10_HEROIC = 5; DIFFICULTY_RAID25_HEROIC = 6; DIFFICULTY_RAID_LFR = 7; DIFFICULTY_DUNGEON_CHALLENGE = 8; DIFFICULTY_RAID40 = 9; removed macros: /clearmaintank /clearmainassist (and their shorthand versions) added macros: /stopspelltarget /summonbattlepet /randomfavoritepet /dismissbattlepet /dismisspet /summonpet (and their shorthand versions) macro conditionals added: "HasVehicleActionBar", "HasOverrideActionBar", "HasTempShapeshiftActionBar", "HasOverrideUI", "GetVehicleBarIndex", "GetOverrideBarIndex", "HasExtraActionBar", "GetTempShapeshiftBarIndex", "CanExitVehicle" Miscellanea / Trivia: Chat bubbles have their own font so it can be overridden separately "ChatBubbleFont" there's also _KO|_RU|_ZH variants. Interface option for setting "displayWorldPVPObjectives" cvar removed (not sure if cvar itself still exists) A stray global _ was removed from WatchFrame.lua, we'll see if that resolves some of the map taint issues. |
Aehm...wait.
Where did you find that Blizzard added those conditions? Do you have any source of information? Lua Code:
So I could basically rewrite this Lua Code:
to Lua Code:
The caveat is that "HasOverrideUI" has to return true on every single occasion where the OverrideActionBar is shown. (Means the main actionbar got swapped out and the override actionbar got swapped in). The problem we had till now is that vehicleui, overridebar and possessbar fired under certain situation while actually showing the OverrideActionBar. Need to test this with Phanx's macro. Lua Code:
------------ Regarding UnitAura change. Are you kidding on that? Why would they have removed value1, value2 and value3 returns? Any aura value tracker now relies on those values. |
Found the conditionals in RestrictedEnvironment.lua (diff from 5.0.5b) DIRECT_MACRO_CONDITIONAL_NAMES
Not sure you can use them like that, there should be proper macro options somewhere, these are just new functions added to state evaluation. About UnitAura() ... yea I know makes no sense. |
The UnitAura change didn't seem to affect my little addon I wrote to watch for the Harmony self buff on my druid. After the patch it still works as expected. Unless those extra options contained values that were needed? For the Harmony self buff it returned the bonus heal %age but I never really needed it for my use.
|
Quote:
Lua Code:
(this is taken from my private fix for freeAbsorbTracker by Freebaser). But what this extra value Returns...hmm i don't know. It Returns me anytime nil Hope this Helps Screamie |
calling settexture of "" in any form Minimap:SetPlayerTexture, frame:SetTexture etc results in an error now instead of silently failing.
|
Quote:
https://github.com/tekkub/wow-ui-sou...6872ff#L56L604 Code:
- local name, rank, icon, count, debuffType, duration, expirationTime, unitCaster, canStealOrPurge, shouldConsolidate, spellId, canApplyAura, isBossDebuff, points1, points2, points3, isCastByPlayer = UnitDebuff(unit, index, filter); |
Quote:
Fixed another addon with the same method as i do on freeAbsorbTracker (added a _, as return value #14 and then the #15 is value1. Greetings Screamie |
Those are the returns from UnitAura for Trap Launcher:
Quote:
|
1 Attachment(s)
60192 - Freezing Trap
82939 - Explosive Trap 82941 - Ice Trap 82948 - Snake Trap Recalling my hunter set up it looks like these are the spells available on the flyout spell button for the trap launcher ability. Yep, screenshot. |
All times are GMT -6. The time now is 08:29 AM. |
vBulletin © 2024, Jelsoft Enterprises Ltd
© 2004 - 2022 MMOUI