WoWInterface

WoWInterface (https://www.wowinterface.com/forums/index.php)
-   nUI: Technical Support (https://www.wowinterface.com/forums/forumdisplay.php?f=92)
-   -   Bag Bar (https://www.wowinterface.com/forums/showthread.php?t=26237)

Nightmare_Lord 08-08-09 11:08 AM

Bag Bar
 
I don't know if it just me, but when I hit the B key to open my bags they scale down and not up. My backpack open up to the left Corner on my mini map, I use the mini map plug it so it open down into the right panel. never did that before but now it does and I have no clue how to fix it.

Depresjon 08-08-09 11:29 AM

like i see it,it's just you.
When i hit ''b'' bags open the way they should do.

Nightmare_Lord 08-08-09 11:35 AM

Bar Bar
 
hmm... I don't know than just started happen, only after that update to work with 3.2. I reinstalled NUI from Beginning and still doing it.

Carz 08-08-09 11:39 AM

that's is the new blizzard bag code they scale down as more open up like if u had 3 18 slot bag's open they would be smaller then having one 18 slot bag open

Nightmare_Lord 08-08-09 11:42 AM

Bag Bar
 
even when I open the backpack by itself it does it, after reading your post I used a 4 slot bag and it still does it. so lame. I need them to scale up as in on top of the right panel. like over target buff bar and stuff.



Edit: if someone also knows how to turn that blizzard code thing off, I take that 2. just want the bags back to how they use 2 be.

Carz 08-08-09 11:55 AM

you can always get an bag mod like ArkInventory or Bagnon so all bags are see able at once

Mycroftxxx1 08-08-09 12:06 PM

There is an addon called Moveable Bags but I am not sure this is a good link for it at the moment. I do know this has the version I am running in the TOC so I believe it is a good one.

spiel2001 08-08-09 12:18 PM

I am not seeing this behavior and cannot reproduce it.

Is there any chance you have any mods installed that interact with the bags and could be causing this?

Quote:

Originally Posted by Nightmare_Lord (Post 152468)
even when I open the backpack by itself it does it, after reading your post I used a 4 slot bag and it still does it. so lame. I need them to scale up as in on top of the right panel. like over target buff bar and stuff.



Edit: if someone also knows how to turn that blizzard code thing off, I take that 2. just want the bags back to how they use 2 be.


Nightmare_Lord 08-08-09 12:51 PM

1 Attachment(s)
nope same addon like normal, Atlas, Dr.Damage, Forte Warlock, Omen, Recount, NUI stuff.

I have put a screen shot of it up

spiel2001 08-08-09 12:52 PM

It's TitanPanel that's causing it apparently. Just for the sake of curiosity, try disabling Titan and see if the problem goes away. Perhaps there's some config options in Titan you can twiddle to resolve it?

Xrystal 08-08-09 01:16 PM

I just noticed it in the last couple of days that it does that. But I just moved the bag bar so I can reach it without being covered by the bags. I generally dont open the bags when needing the pane available.

Nightmare_Lord 08-08-09 02:01 PM

kk I disable it and check, don't know why it would be doing it now after all thsi time. but let me see


*Edit- kk that worked, going to try and see if it part of titan panel and not the whole thing. cuz like I said never did that before, also it could be Titan Panel update they have let me see*

*Edit 2 - nothing I do fixes it no mater if it just the Titan Panel, so I guess it due to an update or maybe the blizzard code for the bag, beside moving the bar up to keep titan panel, any other thing I might be able to do? going to let Titan know so they can try and fix it as well*

Tristanian 08-08-09 03:23 PM

Yes, it's us. In version 4.2.7 we changed our own function that is getting called due to an updateContainerFrameAnchors() hook, to basically mirror Blizzard's functionality and set the bags where the default UI "thinks" they belong. The reason we did this is simple : Our previous implementations to directly set the offset for the bags, by changing the value of Blizzard's global variables CONTAINER_OFFSET_Y and CONTAINER_OFFSET_X was tainting the execution path and was causing "action blocked" messages to people that were using the new totem bar when they were attempting to change totems, while in combat.

So, from that point of view we are not going to revert our code, in fact tainting the globals was a bad idea in the first place, a leftover piece of code from back in 2005. Some of you will wonder why do we need to tamper with bag offsets. Again the reason is simple. If someone wants to use Titan with 1 or 2 bottom bags (without nUI), then we need to take into consideration the case that his bags will be overlapping the MainMenuBar frame.

So what can we do ? In the next version, there will be an option (in the right-click menu - > Options) to disable bag offset adjustment. This means that despite the fact that our function hook will still be called, it won't be doing anything, if you have that option disabled (your bags will not be touched by Titan at all). I have tested this with nUI and it works fine. As for container scaling, there is really nothing that can be done, since Blizzard's own code (http://wowprogramming.com/utils/xmlb...ainerFrame.lua, function updateContainerFrameAnchors()) is resetting the container frame scale to a hardcoded valued (CONTAINER_SCALE = 0.75) as evident by the following piece of code found there :

Code:

while ( containerScale > CONTAINER_SCALE ) do
    screenHeight = GetScreenHeight() / containerScale;
    -- Adjust the start anchor for bags depending on the multibars
    xOffset = CONTAINER_OFFSET_X / containerScale;
    yOffset = CONTAINER_OFFSET_Y / containerScale;
    -- freeScreenHeight determines when to start a new column of bags
    freeScreenHeight = screenHeight - yOffset;
    leftMostPoint = screenWidth - xOffset;
    column = 1;
    local frameHeight;
    for index, frameName in ipairs(ContainerFrame1.bags) do
      frameHeight = _G[frameName]:GetHeight();
      if ( freeScreenHeight < frameHeight ) then
        -- Start a new column
        column = column + 1;
        leftMostPoint = screenWidth - ( column * CONTAINER_WIDTH * containerScale ) - xOffset;
        freeScreenHeight = screenHeight - yOffset;
      end
      freeScreenHeight = freeScreenHeight - frameHeight - VISIBLE_CONTAINER_SPACING;
    end
    if ( leftMostPoint < leftLimit ) then
      containerScale = containerScale - 0.01;
    else
      break;
    end
  end

  if ( containerScale < CONTAINER_SCALE ) then
    containerScale = CONTAINER_SCALE;
  end

I hope our solution proves satisfactory to the users of nUI (and not only).

Respectfully,
~Tristanian.

spiel2001 08-08-09 03:28 PM

Tristanian --

Many thanks for the quick response to the problem.

Out of curiousity, what's the name of the method you're using for your callback to the updateContainerFrameAnchors hook? If you don't mind, I could have nUI set that to an empty method when it detects Titan is loaded as a temporary fix. If me doing that bothers you, however, I can forgo doing that.

Tristanian 08-08-09 03:37 PM

Titan_ContainerFrames_Relocate()

..and I thought about that as well. Yes, setting it to nil, will be a good temporary workaround but I fear that the relevant AceHook will complain about it and error when it attempts to call it, so I guess must also do :

Code:


Titan_ContainerFrames_Relocate = nil

LibStub("AceAddon-3.0"):GetAddon("TitanMovable"):Unhook("updateContainerFrameAnchors", Titan_ContainerFrames_Relocate)

But anyway I intend to push the fix as fast as possible (possibly tomorrow or Monday at the latest).

spiel2001 08-08-09 03:46 PM

I think just doing the following would suffice without breaking the AceHook wouldn't it?

Titan_ContainerFrames_Relocate = function() end;

EDIT: On second thought... I guess that wouldn't -- looks like the AceHook is taking the address of the method, not the name, so this fix wouldn't cut it... I'll just unhook it as per your suggestion.

Tristanian 08-08-09 03:50 PM

Quote:

Originally Posted by spiel2001 (Post 152518)
I think just doing the following would suffice without breaking the AceHook wouldn't it?

Titan_ContainerFrames_Relocate = function() end;

Yep, that's also another idea.

spiel2001 08-08-09 03:56 PM

1 Attachment(s)
For those of you who are experiencing this bag bar issue with the conflict between Titan and nUI, try saving the attached nUI_TitanPanel.lua file to your [ Interface > AddOns > nUI > Integration ] folder and let me know if it fixes the problem for you...

.

Nightmare_Lord 08-08-09 05:37 PM

Quote:

Originally Posted by spiel2001 (Post 152524)
For those of you who are experiencing this bag bar issue with the conflict between Titan and nUI, try saving the attached nUI_TitanPanel.lua file to your [ Interface > AddOns > nUI > Integration ] folder and let me know if it fixes the problem for you...

.

just tried it and sorry no it didn't work.


Aslo thanks Tristanian, for pushing this update your going 2 do.

Tristanian 08-08-09 06:09 PM

4.2.8.30200 is now live, which should resolve this issue. Just enter the right-click menu, and under "Options", uncheck "Automatic bag adjust". Let me know if it works.


All times are GMT -6. The time now is 11:01 AM.

vBulletin © 2024, Jelsoft Enterprises Ltd
© 2004 - 2022 MMOUI