WoWInterface - Amber-Shaper Un'sok

WoWInterface (https://www.wowinterface.com/forums/index.php)

- General Authoring Discussion (https://www.wowinterface.com/forums/forumdisplay.php?f=20)

- - Amber-Shaper Un'sok (https://www.wowinterface.com/forums/showthread.php?t=45083)

Amber-Shaper Un'sok

Does anyone know what type of action bar players get when they turn into the Mutated Construct on this boss? They get 4 abilities and someone using my UI reports that he isn't seeing the bar. He also gets the same problem on heroic Nefarian.

http://www.wowhead.com/npc=63666

Did one try on him for funsies last night, didn't get the buff/debuff so couldn't see.
I would expect vehicle or override.

Haven't tested the boss yet but seen a lot of videos, and it looks just like altpowerbar to me.

The video i checked was from one pov so same UI, and when they were doing stone guards his altpowerbar was showing in the same spot as this one.

Not much of help, what im trying to say is that i think it's the altpowerbar controlling it, though like p3lim said you also get pet/vehicle actionbar showing so i might be wrong. :)

He was talking about actionbar states, not the statusbar that shows the power.

I did indeed mean action bar, I should've specified because there's lots of bars in the UI. :p

Anyone have an idea? It's pretty much impossible for me to test this.

If that is your actionbar code:
https://github.com/Haleth/FreeUI/blo...actionbars.lua

Hmm...well it should work. The only reason for it not to work is [overridebar] or [vehicleui] not firing correctly. We could do nothing about that.

Yep, that's the code I use today. I pretty much follow rActionBarStyler plus/minus a few things.

I'll have a look at other action bars and see how they handle it.

Quote:

Originally Posted by Haleth (Post 268452)

Run this macro, or if you don't have access to the content yourself, have someone else who does run it:

Code:

/run local s=SecureCmdOptionParse print(s("[extrabar]extrabar"),s("[overridebar]overridebar"),s("[possessbar]possessbar"),s("[vehicleui]vehicleui"))

It will print to chat which condition(s) apply at the moment.

I checked ElvUi since his and TukUi always have some nice code pieces to look at.

When building the new rABS for MoP I stepped aways from bar paging because I had no clue how to apply the bar state to protected children (buttons). Actually thats the reason why I had to keep the default OverrideActionBar alive.

But there is a solution for this:

Lua Code:

control:ChildUpdate("snippetid", message) 
    executes the contents of "_childupdate-snippetid" (or, if that attribute is nil/false, "_childupdate"), on all protected children (and children of children) of the restricted environment owner with (self, scriptid, message) arguments.

The interesting code snippets of Elv UI are

Lua Code:

AB["barDefaults"] = {
    ["bar1"] = {
        ['visibility'] = "[petbattle] hide; show", --[petbattle][overridebar][vehicleui] hide; show
        ['page'] = 1,
        ['conditions'] = string.format("[vehicleui] %d; [possessbar] %d; [overridebar] %d; [bar:2] 2; [bar:3] 3; [bar:4] 4; [bar:5] 5; [bar:6] 6;", GetVehicleBarIndex(), GetVehicleBarIndex(), GetOverrideBarIndex()),
    },
}
 
    RegisterStateDriver(bar, "page", self:GetPage(barName, self['barDefaults'][barName].page, self['barDefaults'][barName].conditions));
    --basically returns this: [vehicleui] GetVehicleBarIndex(); [possessbar] GetVehicleBarIndex(); [overridebar] GetOverrideBarIndex(); [bar:2] 2; [bar:3] 3; [bar:4] 4; [bar:5] 5; [bar:6] 6; 1"
    RegisterStateDriver(bar, "visibility", self['barDefaults'][barName].visibility)
 
    bar:SetAttribute("_onstate-page", [[ 
        self:SetAttribute("state", newstate)
        control:ChildUpdate("state", newstate)
    ]])

The problem that we have when building an actionbar on our own is to reproduce this function in the ActionBarController. It handles the actionpage swap on conditions.

Lua Code:

function ActionBarController_UpdateAll()
    PossessBar_Update();
    StanceBar_Update();
    CURRENT_ACTION_BAR_STATE = LE_ACTIONBAR_STATE_MAIN;
    
    -- If we have a skinned vehicle bar or skinned override bar, display the OverrideActionBar
    if ((HasVehicleActionBar() and UnitVehicleSkin("player") and UnitVehicleSkin("player") ~= "")
    or (HasOverrideActionBar() and GetOverrideBarSkin() and GetOverrideBarSkin() ~= "")) then
        -- For now, a vehicle has precedence over override bars (hopefully designers make it so these never conflict)
        if (HasVehicleActionBar()) then
            OverrideActionBar_Setup(UnitVehicleSkin("player"), GetVehicleBarIndex());
        else
            OverrideActionBar_Setup(GetOverrideBarSkin(), GetOverrideBarIndex());
        end
        
        CURRENT_ACTION_BAR_STATE = LE_ACTIONBAR_STATE_OVERRIDE;
    -- If we have a non-skinned override bar of some sort, use the MainMenuBarArtFrame
    elseif ( HasBonusActionBar() or HasOverrideActionBar() or HasVehicleActionBar() or HasTempShapeshiftActionBar() or C_PetBattles.IsInBattle() ) then
        if (HasVehicleActionBar()) then
            MainMenuBarArtFrame:SetAttribute("actionpage", GetVehicleBarIndex());
        elseif (HasOverrideActionBar()) then
            MainMenuBarArtFrame:SetAttribute("actionpage", GetOverrideBarIndex());
        elseif (HasTempShapeshiftActionBar()) then
            MainMenuBarArtFrame:SetAttribute("actionpage", GetTempShapeshiftBarIndex());
        elseif (HasBonusActionBar() and GetActionBarPage() == 1) then
            MainMenuBarArtFrame:SetAttribute("actionpage", GetBonusBarIndex());
        else
            MainMenuBarArtFrame:SetAttribute("actionpage", GetActionBarPage());
        end
        
        for i=1, NUM_ACTIONBAR_BUTTONS do
            local button = _G["ActionButton"..i];
            ActionButton_UpdateAction(button);
        end
    else
        -- Otherwise, display the normal action bar
        ActionBarController_ResetToDefault();
    end
    
    ValidateActionBarTransition();
end

In vehicle and possess state ElvUI uses the ID from GetVehicleBarIndex().
In overridebar state ElvUI uses the ID from GetOverrideBarIndex().

There is no state for temp shapeshift and bonusbar.

So basically what ElvUi does is creating an actionbar on its own using LibActionButton-1.0.
On page-state the bar state swaps and additionally all children swap aswell.

Regarding rABS. I have no clue why the bar should not show up.

The only reason I could think of is the [overridebar] firing without actually loading the OverrideActionbar and instead loading the override actionbuttons into the main actionbar. This would result in me removing the main actionbar and showing an probably empty (?!) overridebar. No clue.

If I happen to get transformed during that boss fight I'll run the script which Phanx posted and report the results. That might make the situation a little more clear.

Quote:

Originally Posted by Haleth (Post 268945)

If I happen to get transformed during that boss fight I'll run the script which Phanx posted and report the results. That might make the situation a little more clear.

I'll try that macro too :)
I have made a screenshot and Alt-Powerbar of my UI is working fine. You can see the pink bar on top of Bossframes.
I use Gnosis with

Code:

resource,unit=player:altpower

to display alt power. Also using Dominos and Shadowed Unit frames.

Check this out: (used the macro from Phanx)

The interesting part is the Vehicle Exit Button. My condition to spawn it is:

Code:

[possessbar][@vehicle,exists]

Why on earth does possessbar fire but neither vehicleui or overridebar.

The problem is that the possessbar changes the default actionbar by default. But not this time. Strange.

That actually fixes the other problem imo. The solution is using this:

Code:

RegisterStateDriver(OverrideActionBar, "visibility", "[overridebar][vehicleui][possessbar,@vehicle,exists] show; hide")

Basically adding another condition checking if possessbar is fired but actually a vehicle exists. This actually reminded me ... why not use "@vehicle,exists" in first place? Because there may be vehicles that do not change your bars (like the camel encounter in the 5man dungeon). Crazy stuff...

Going to update rABS in a minute.

Changelog:
http://code.google.com/p/rothui/source/detail?r=1002

What I really don't understand is: If the OverrideBar is used. How can the [overridebar] statement return nil?

That damn feast fest table is using the OverrideBar, thus the [overridebar] condition should in no way be nil. Yet it is.

I did LFR today. Got mindcontrolled. Got bar. So the possessbar thingy fixed it.

Awesome. Great that you got on this :D

Was also getting comments about the silly table, I figured the two bars might be related in some way.