WoWInterface - OnLeave & Frame

WoWInterface (https://www.wowinterface.com/forums/index.php)

- Lua/XML Help (https://www.wowinterface.com/forums/forumdisplay.php?f=16)

- - OnLeave & Frame (https://www.wowinterface.com/forums/showthread.php?t=54975)

Hi,

I was rewriting one of my addons trying to implement a custom frame instead of the standard LDB.

Everything works just fine but I was wondering if it is possible to use an onLeave codition to close it.

The skeleton code is something like this (shorter than the full code):

Lua Code:

local ADDON = ...
 
local Menu = CreateFrame('Frame', nil, UIParent)
Menu:SetClampedToScreen(true)
Menu:SetSize(100,100)
Menu:Hide()
-- Menu:SetScript('OnLeave', OnLeave)
Menu:SetBackdrop({
    bgFile = "Interface/DialogFrame/UI-DialogBox-Background",
    edgeFile = "Interface/Tooltips/UI-Tooltip-Border",
    tile = true, tileSize = 32, edgeSize = 16,
    insets = { left = 5, right = 5, top = 5, bottom = 5 }
})
 
local ldb = LibStub:GetLibrary("LibDataBroker-1.1")
local dataobj = ldb:NewDataObject(ADDON , {
    type = "data source",
    icon = "Interface\\Addons\\"..ADDON.."\\icon.tga",
    text = "Test Only"
})
 
dataobj.OnClick = function(self, button)  
 
    if button == "LeftButton" then
 
        if(Menu:IsShown()) then         
    
            Menu:Hide()
 
        else
            
            -- position code taken from Broker_Equipment by p3lim
            Menu:ClearAllPoints()
            Menu:SetPoint('TOP', self, 'BOTTOM') -- temporary anchor
 
            local sideAnchor = ''
            if(Menu:GetRight() > GetScreenWidth()) then
                sideAnchor = 'RIGHT'
            elseif(Menu:GetLeft() <= 0) then
                sideAnchor = 'LEFT'
            end
 
            Menu:ClearAllPoints()
            if(Menu:GetBottom() <= 0) then
                Menu:SetPoint('BOTTOM' .. sideAnchor, self, 'TOP' .. sideAnchor)
            else
                Menu:SetPoint('TOP' .. sideAnchor, self, 'BOTTOM' .. sideAnchor)
            end                     
            Menu:Show()
            
        end
        
    end
end

I thought a simple:

Lua Code:

Menu:SetScript('OnLeave', Menu:Hide())

was ok to hide the frame when not hovering on it, but I was wrong :)

So now I ask:
Is there a simple way to accomplish this and prevent the fact the frame remains open until someone clicks the bar again ?

Thanks very much for your input.

P.s.
Actually the Tooltip is this:

Menu:SetScript('OnLeave', Menu.Hide)

Quote:

Originally Posted by Vrul (Post 321522)

Menu:SetScript('OnLeave', Menu.Hide)

Why this works and what it does:

You're setting the frame handler to be the :Hide() metamethod. As this isn't a function call, just passing a function pointer, it loses the internal self argument. Frames just happen to push themselves as the first argument to their handlers, so everything works out anyway.

Hi,
thanks really so much for the reply and explanation on the differences from : and .

I have tried to implement your suggestion but I have a problem ...
Since I left click in the Data Broker to make the menu appears and it works until I hover the frame but when I touch the buttons it breaks :/

Probably the buttons are not checked as whole frame ?

Here is a gif (in loop) showing the thing:
http://s23.postimg.org/bw238gnjv/test_menu.gif

Surely is a problem of my code because I am really not so skilled in the frame management.
I post the full thing:

Lua Code:

local ADDON = ...
 
local ActiveSpec = GetSpecialization()
local ACTSPEC = {}
 
local fontName, fontHeight, fontFlags = GameFontNormal:GetFont()
local btn = {}
 
local num_lines = 9
local btn_o = 5
local btn_h = fontHeight + 4
local line_v = - btn_h
local line_o = btn_o + 4
local frame_w = 190
local frame_h = abs(num_lines * line_v) + 10
local btn_w = frame_w - btn_o - 2
local line_o2 = frame_w/2 
 
local string_format = string.format
 
local ldb = LibStub:GetLibrary("LibDataBroker-1.1")
local dataobj = ldb:NewDataObject(ADDON, {
    type = "data source",
    icon = "Interface\\Icons\\INV_Misc_QuestionMark.blp",
    text = "None"
})
 
local Menu = CreateFrame('Frame', nil, UIParent)
Menu:SetClampedToScreen(true)
Menu:SetSize(frame_w,frame_h)
Menu:Hide()
Menu:SetScript('OnLeave', Menu.Hide)
Menu:SetBackdrop({
    bgFile = "Interface/DialogFrame/UI-DialogBox-Background",
    edgeFile = "Interface/Tooltips/UI-Tooltip-Border",
    tile = true, tileSize = 32, edgeSize = 16,
    insets = { left = 5, right = 5, top = 5, bottom = 5 }
})
 
local talent_desc = Menu:CreateFontString("talent_desc")
talent_desc:SetPoint("TOPLEFT", Menu,"TOPLEFT",line_o, line_v)
talent_desc:SetFont(fontName, fontHeight)
talent_desc:SetTextColor(1,0.8,0,1)
talent_desc:SetText("Spec config: ")
 
local talent_value = Menu:CreateFontString("talent_value")
talent_value:SetPoint("TOPLEFT", Menu,"TOPLEFT",line_o2, line_v)
talent_value:SetFont(fontName, fontHeight)
talent_value:SetTextColor(0,1,0,1)
 
local lclick_desc = Menu:CreateFontString("lclick_desc")
lclick_desc:SetPoint("TOPLEFT", Menu,"TOPLEFT",line_o, 7*line_v)
lclick_desc:SetFont(fontName, fontHeight)
lclick_desc:SetTextColor(1,0.8,0,1)
lclick_desc:SetText("Left Click: ")
 
local lclick_value = Menu:CreateFontString("lclick_value")
lclick_value:SetPoint("TOPLEFT", Menu,"TOPLEFT",line_o2, 7*line_v)
lclick_value:SetFont(fontName, fontHeight)
lclick_value:SetTextColor(0,1,0,1)
lclick_value:SetText("Change Spec")
 
local rclick_desc = Menu:CreateFontString("rclick_desc")
rclick_desc:SetPoint("TOPLEFT", Menu,"TOPLEFT",line_o, 8*line_v)
rclick_desc:SetFont(fontName, fontHeight)
rclick_desc:SetTextColor(1,0.8,0,1)
rclick_desc:SetText("Right Click: ")
 
local rclick_value = Menu:CreateFontString("rclick_value")
rclick_value:SetPoint("TOPLEFT", Menu,"TOPLEFT",line_o2, 8*line_v)
rclick_value:SetFont(fontName, fontHeight)
rclick_value:SetTextColor(0,1,0,1)
rclick_value:SetText("Open Talents")
 
 
local function BuildActiveSpec()
 
    local ptalenttree = {}
 
    local ActiveSpec = GetSpecialization()
    if ActiveSpec then
        local id, name, description, icon, background, role = GetSpecializationInfo(ActiveSpec)
        ACTSPEC = { id = id, name = name, description = description, icon = icon , background = background, role = role }
    end
 
    for i=1, GetMaxTalentTier()  do
       for j=1, 3 do
            if select(4, GetTalentInfo(i,j,1)) == true then
                ptalenttree[i] = j
            end
       end
    end
 
    ACTSPEC["tree"] = table.concat(ptalenttree,".")
end
 
local function UpdateLDB()
        local currentSpec = GetSpecialization()
        if currentSpec ~= nil then      
            local id, name, description, icon, background, role = GetSpecializationInfo(currentSpec)        
            dataobj.text = name
            dataobj.icon = icon     
        else
            dataobj.icon = "Interface\\Icons\\INV_Misc_QuestionMark.blp"
            dataobj.text = "None"
        end
end
 
 
local function BuildMenu()
 
    for index=1,GetNumSpecializations() do
 
        local id, name, description, icon, background, role = GetSpecializationInfo(index)
        
        btn[index]=CreateFrame("Button", nil, Menu)
        btn[index]:SetPoint("TOP", btn_o, -20 + (index * line_v))
        btn[index]:SetWidth(btn_w)
        btn[index]:SetHeight(btn_h)
        btn[index]:SetNormalFontObject("GameFontNormal")
        btn[index]:SetHighlightTexture("Interface\\QuestFrame\\UI-QuestTitleHighlight")
            
        local text = btn[index]:CreateFontString(ADDON .. "btn_font", nil, "GameFontNormal")
        text:SetAllPoints(true)
        text:SetJustifyH("LEFT")
        text:SetJustifyV("MIDDLE")
        text:SetTextColor(1,1,1,1)
        btn[index]:SetFontString(text);
        btn[index]:SetText(string.format("|T%s:0|t %s",icon,name))
        btn[index]:SetScript("OnClick",  
        function()
            Menu:Hide()
            SetSpecialization(index)
        end) 
    end 
end
 
local frame = CreateFrame("Frame")
frame:RegisterEvent('ACTIVE_TALENT_GROUP_CHANGED')
frame:RegisterEvent('PLAYER_SPECIALIZATION_CHANGED')
frame:RegisterEvent("PLAYER_ENTERING_WORLD")
frame:SetScript("OnEvent", function(self, event, ...)
 
    BuildActiveSpec()
    UpdateLDB()
        
    if event == "PLAYER_ENTERING_WORLD" then 
        BuildMenu()
    end
end
)
 
 
function dataobj.OnClick(self, button)  
 
    if InCombatLockdown() then 
        return 
    end
 
    if button == "RightButton" then
        ToggleTalentFrame()
    end
 
    if button == "LeftButton" then
 
        if(Menu:IsShown()) then         
    
            Menu:Hide()
 
        else
                    
            talent_value:SetText(ACTSPEC["tree"])
            
            -- position code taken from Broker_Equipment by p3lim
            Menu:ClearAllPoints()
            Menu:SetPoint('TOP', self, 'BOTTOM') -- temporary anchor
 
            local sideAnchor = ''
            if(Menu:GetRight() > GetScreenWidth()) then
                sideAnchor = 'RIGHT'
            elseif(Menu:GetLeft() <= 0) then
                sideAnchor = 'LEFT'
            end
 
            Menu:ClearAllPoints()
            if(Menu:GetBottom() <= 0) then
                Menu:SetPoint('BOTTOM' .. sideAnchor, self, 'TOP' .. sideAnchor)
            else
                Menu:SetPoint('TOP' .. sideAnchor, self, 'BOTTOM' .. sideAnchor)
            end         
            
            Menu:Show()
        end     
    end
end

Thanks all.

From what I can tell, Menu is firing OnLeave you mouseover the spec buttons. You might want to have a custom handler check for that before hiding itself. You're also recreating them at every loading screen instead of just at login. You should either unregister PLAYER_ENTERING_WORLD when done or use PLAYER_LOGIN instead.

Quote:

Originally Posted by SDPhantom (Post 321536)

You're also recreating them at every loading screen instead of just at login. You should either unregister PLAYER_ENTERING_WORLD when done or use PLAYER_LOGIN instead.

Thanks very much for your suggestions and hints.

About the second part of the problems I have changed in this way (I realized that it should be broken because sometime the buttons fonts were mangled).

I used a mix of your tips using event "PLAYER_LOGIN" and then unregister once fired.

Lua Code:

local frame = CreateFrame("Frame")
frame:RegisterEvent('ACTIVE_TALENT_GROUP_CHANGED')
frame:RegisterEvent('PLAYER_SPECIALIZATION_CHANGED')
frame:RegisterEvent("PLAYER_ENTERING_WORLD")
frame:RegisterEvent("PLAYER_LOGIN")
frame:SetScript("OnEvent", function(self, event, ...)
    BuildActiveSpec()
    UpdateLDB()
        
    if event == "PLAYER_LOGIN" then 
        BuildMenu()
        frame:UnregisterEvent("PLAYER_LOGIN")
    end
end
)

Quote:

Originally Posted by SDPhantom (Post 321536)

From what I can tell, Menu is firing OnLeave you mouseover the spec buttons. You might want to have a custom handler check for that before hiding itself.

Uhm ...

This works but is so ugly ?

Lua Code:

Menu:SetScript('OnLeave', function()
    local name = GetMouseFocus():GetName() or tostring(GetMouseFocus())
    if string.sub(name,1,6) ~= "table:" then Menu:Hide() end
end)

The problem is when I hovering the buttons the "name" var is something like:
table:00000149a7cf46e0

or if I exit from the frame values I get are:
WorldFrame
ChocolateBar1
etc etc ...

Thanks anyway for your suggestions.

Here is a modified version of your code with the OnLeave script fixed. I also changed it to behave and look more like other LDB plugins I've seen.

Code:

local ADDON = ...



local fontName, fontHeight, fontFlags = GameFontNormal:GetFont()



local BUTTON_HEIGHT = fontHeight + 4

local BUTTON_SPACING = 0

local MENU_BUFFER = 10

local MENU_SPACING = 1

local MENU_WIDTH = 190



local Menu = CreateFrame('Frame', nil, UIParent)

Menu:SetFrameStrata('TOOLTIP')

Menu:SetClampedToScreen(true)

Menu:SetBackdrop({

        bgFile = "Interface/DialogFrame/UI-DialogBox-Background",

        edgeFile = "Interface/Tooltips/UI-Tooltip-Border",

        tile = true, tileSize = 32, edgeSize = 16,

        insets = { left = 5, right = 5, top = 5, bottom = 5 }

})

Menu:Hide()



local function Menu_OnLeave()

        local focus = GetMouseFocus() or WorldFrame

        if focus ~= Menu and focus:GetParent() ~= Menu then

                Menu:Hide()

        end

end

Menu:SetScript('OnLeave', Menu_OnLeave)



local talent_desc = Menu:CreateFontString()

talent_desc:SetPoint("TOPLEFT", Menu, "TOPLEFT", MENU_BUFFER, -MENU_BUFFER)

talent_desc:SetFont(fontName, fontHeight)

talent_desc:SetTextColor(1, 1, 1, 1)

talent_desc:SetText("Spec config:")



local talent_value = Menu:CreateFontString()

talent_value:SetPoint("TOPRIGHT", Menu, "TOPRIGHT", -MENU_BUFFER, -MENU_BUFFER)

talent_value:SetFont(fontName, fontHeight)

talent_value:SetTextColor(1, 1, 1, 1)



local rclick_desc = Menu:CreateFontString()

rclick_desc:SetPoint("BOTTOMLEFT", Menu, "BOTTOMLEFT", MENU_BUFFER, MENU_BUFFER)

rclick_desc:SetFont(fontName, fontHeight)

rclick_desc:SetTextColor(0, 1, 0, 1)

rclick_desc:SetText("Right-Click")



local rclick_value = Menu:CreateFontString()

rclick_value:SetPoint("BOTTOMRIGHT", Menu, "BOTTOMRIGHT", -MENU_BUFFER, MENU_BUFFER)

rclick_value:SetFont(fontName, fontHeight)

rclick_value:SetTextColor(1, 0.8, 0, 1)

rclick_value:SetText("Toggle Talents")



local lclick_desc = Menu:CreateFontString()

lclick_desc:SetPoint("BOTTOMLEFT", rclick_desc, "TOPLEFT", 0, MENU_SPACING)

lclick_desc:SetFont(fontName, fontHeight)

lclick_desc:SetTextColor(0, 1, 0, 1)

lclick_desc:SetText("Left-Click")



local lclick_value = Menu:CreateFontString()

lclick_value:SetPoint("BOTTOMRIGHT", rclick_value, "TOPRIGHT", 0, MENU_SPACING)

lclick_value:SetFont(fontName, fontHeight)

lclick_value:SetTextColor(1, 0.8, 0, 1)

lclick_value:SetText("Toggle Menu")



local dataobj = LibStub:GetLibrary("LibDataBroker-1.1"):NewDataObject(ADDON, {

        type = "data source",

        icon = "Interface\\Icons\\INV_Misc_QuestionMark.blp",

        text = "None",

        OnClick = function(self, button)

                if button == "LeftButton" then

                        Menu:SetShown(not Menu:IsShown())

                elseif button == "RightButton" then

                        ToggleTalentFrame()

                end

        end,

        OnEnter = function(self)

                if not Menu:IsShown() then

                        local _, selfCenter = self:GetCenter()

                        local _, uiCenter = UIParent:GetCenter()

                        Menu:ClearAllPoints()

                        if selfCenter >= uiCenter then

                                Menu:SetPoint('TOP', self, 'BOTTOM')

                        else

                                Menu:SetPoint('BOTTOM', self, 'TOP')

                        end

                        Menu:Show()

                end

        end,

        OnLeave = Menu_OnLeave

})



local function EventHandler()

        local activeSpec = GetSpecialization()

        if activeSpec then

                local id, name, description, icon = GetSpecializationInfo(activeSpec)

                dataobj.text = name

                dataobj.icon = icon    

        else

                dataobj.icon = "Interface\\Icons\\INV_Misc_QuestionMark.blp"

                dataobj.text = "None"

        end



        local talents = ""

        for tier = 1, GetMaxTalentTier()  do

                local talentTier = "x"

                for column = 1, 3 do

                        local talentID, name, texture, selected = GetTalentInfo(tier, column, 1)

                        if selected then

                                talentTier = column

                                break

                        end

                end

                if talents ~= "" then

                        talents = talents .. "." .. talentTier

                else

                        talents = talentTier

                end

        end

        talent_value:SetText(talents)

end



local function Button_OnClick(self)

        Menu:Hide()

        if not InCombatLockdown() and GetSpecialization() ~= self.index then

                SetSpecialization(self.index)

        end

end



Menu:RegisterEvent('PLAYER_LOGIN')

Menu:SetScript('OnEvent', function(self, event)

        Menu:UnregisterEvent(event)

        Menu:SetScript('OnEvent', EventHandler)



        local numButtons = GetNumSpecializations()

        for index = 1, numButtons do

                local id, name, description, icon, background, role = GetSpecializationInfo(index)



                local button = CreateFrame("Button", nil, Menu)

                if index ~= 1 then

                        button:SetPoint("TOPLEFT", Menu[index - 1], "BOTTOMLEFT", 0, -BUTTON_SPACING)

                else

                        button:SetPoint("TOPLEFT", talent_desc, "BOTTOMLEFT", 0, -MENU_BUFFER)

                end

                button:SetPoint("RIGHT", -MENU_BUFFER, 0)

                button:SetHeight(BUTTON_HEIGHT)

                button:SetNormalFontObject("GameFontNormal")

                button:SetHighlightTexture("Interface\\QuestFrame\\UI-QuestTitleHighlight")

                button.index = index

                button:SetScript("OnClick", Button_OnClick)

                button:SetScript("OnLeave", Menu_OnLeave)

                Menu[index] = button



                local text = button:CreateFontString(ADDON .. "btn_font", nil, "GameFontNormal")

                text:SetAllPoints()

                text:SetJustifyH("LEFT")

                text:SetJustifyV("MIDDLE")

                text:SetTextColor(1, 1, 1, 1)

                button:SetFontString(text)

                button:SetText(("|T%s:0|t %s"):format(icon, name))

        end 

        Menu:SetSize(MENU_WIDTH, (MENU_BUFFER * 4) + (fontHeight * 3) + MENU_SPACING + ((BUTTON_HEIGHT + BUTTON_SPACING) * numButtons - BUTTON_SPACING))



        EventHandler()

        Menu:RegisterEvent('PLAYER_ENTERING_WORLD')

        Menu:RegisterEvent('ACTIVE_TALENT_GROUP_CHANGED')

        Menu:RegisterEvent('PLAYER_SPECIALIZATION_CHANGED')

end)

Thanks Vrul,

your code is awesome and work like a charm :)
I am studying it :)

Thanks again.
It is much appreciated.