WoWInterface - ENVIRONMENTAL_DAMAGE Event Type Changed

WoWInterface (https://www.wowinterface.com/forums/index.php)

- MoP Beta archived threads (https://www.wowinterface.com/forums/forumdisplay.php?f=162)

- - ENVIRONMENTAL_DAMAGE Event Type Changed (https://www.wowinterface.com/forums/showthread.php?t=43757)

Mikord

07-20-12 04:41 PM

ENVIRONMENTAL_DAMAGE Event Type Changed

The ENVIRONMENTAL_DAMAGE sub-event of COMBAT_EVENT_LOG_UNFILTERED has been changed from reporting an unlocalized hazard type token to a localized value. While this probably won't affect very many addons (luckily it doesn't affect MSBT since it just reports the localized value anyways), it does make it difficult to detect a specific type of environmental damage.

As detailed on wowpedia here it previously returned tokens such as "FALLING" and "DROWNING" making it easy to detect specific types of environmental damage in a language independent manner.

semlar

08-17-12 01:30 PM

The localized environmental damage strings appear to be in the GlobalStrings.lua file, if you need to compare them.

Code:

ACTION_ENVIRONMENTAL_DAMAGE = "damaged";

ACTION_ENVIRONMENTAL_DAMAGE_DROWNING = "Drowning";

ACTION_ENVIRONMENTAL_DAMAGE_FALLING = "Falling";

ACTION_ENVIRONMENTAL_DAMAGE_FATIGUE = "Fatigue";

ACTION_ENVIRONMENTAL_DAMAGE_FIRE = "Fire";

ACTION_ENVIRONMENTAL_DAMAGE_LAVA = "Lava";

ACTION_ENVIRONMENTAL_DAMAGE_SLIME = "Slime";



STRING_ENVIRONMENTAL_DAMAGE_DROWNING = "Drowning";

STRING_ENVIRONMENTAL_DAMAGE_FALLING = "Falling";

STRING_ENVIRONMENTAL_DAMAGE_FATIGUE = "Fatigue";

STRING_ENVIRONMENTAL_DAMAGE_FIRE = "Fire";

STRING_ENVIRONMENTAL_DAMAGE_LAVA = "Lava";

STRING_ENVIRONMENTAL_DAMAGE_SLIME = "Slime";

Meorawr

08-21-12 01:25 PM

As an update, the argument isn't a localised value - it's simply not capitalised. Checked this just by just logging into the beta with the french client where, for falling damage, the value is still "Falling", but ACTION_ENVIRONMENTAL_DAMAGE_FALLING is "Chute".

Someone with a lot of time on their hands could try that with all localisations, if they want to be really sure.

semlar

08-22-12 06:13 AM

Well that's good to know. On the other hand, if you do want to convert to the localized string you could use one of the globals :p

All times are GMT -6. The time now is 09:23 AM.