Requesting critique on something I've made
Hey, I am quite new to programming and especially Lua.
I am not sure if this kind of topic is allowed on this forum, or if I've posted in the wrong category, if so, please remove. I've made myself an addon that tries to detect what equipment set you are wearing and tells you if you're, for example, accidentally wearing you're PvP gear in a PvE instance. I was inspired to write this, since I use the same transmogrification sets for both my PvP and PvE gear and often noticed too late that I was wearing the wrong gear. I realize that detecting what equipment set you are wearing, is difficult, because you might not have every itemslot filled within an equipment set. So, this will only work if you are using full equipment sets. (Shirt and tabard are ignored.) Now, I have everything working, but I am just wondering if there's things that I might have missed and should improve on. TLDR: Not really a question, but a request for critique on the following code. Lua Code:
Thanks! |
I've gone through your code and written up recommendations as I encounter issues:
I've written quite a lot, but many of these are very simple to fix. This probably belongs in General Authoring Discussion or Lua/XML Help; it'll probably be moved to the appropriate forum. |
Thanks!
You've been very informative. |
All times are GMT -6. The time now is 12:58 PM. |
vBulletin © 2024, Jelsoft Enterprises Ltd
© 2004 - 2022 MMOUI