View Single Post
Unread 07-21-12, 05:49 AM   #119
Lombra
A Chromatic Dragonspawn
 
Lombra's Avatar
AddOn Author - Click to view addons
Join Date: Nov 2006
Posts: 192
The old/current IsSpellKnown had a lot of "problems" with not recognising known spells. Namely a lot of spell IDs extracted from a combat log event were different than the ID of the same spell in your spell book, the latter of which worked with IsSpellKnown, while the combat log event did not. I've had to make a lot of special cases because of this. As far as I understand this function is now replaced with IsPlayerSpell.. has anyone noticed if this one is at all improved in this regard?

Here's everything I've had to make exceptions for, for the record. Granted, many of these aren't simple strikes or direct damage effects, but it would be cool if these could be considered "known", as well, depending on what the intended purpose of IsPlayerSpell is.
__________________
Grab your sword and fight the Horde!
Lombra is online now