View Single Post
Unread 09-24-12, 01:20 PM   #2
Dridzt
A Pyroguard Emberseer
 
Dridzt's Avatar
AddOn Author - Click to view addons
Join Date: Nov 2005
Posts: 1,192
Looks good

A couple things.
a and b are global, that can be troublesome especially if someone (or even Blizz with recent _ history fresh) forgets a global themselves (eg r, g, b ?)

Whitespace is good for explaining things but there should be a note that in the final macro everything that can be removed is removed so you can fit more stuff in the 255 char limit.
';' is completely useless in any case.

I don't think your final macro fits in 255 chars as it is.

Last edited by Dridzt : 09-24-12 at 01:22 PM.
Dridzt is offline   Reply With Quote