|
That error is odd. Your syntax is fine. Are you sure there's no line breaks? When you begin a /script everything involved in the script must be one continuous line. You can use multiple /script's but they need to be self-contained. (ie, you can't do /script if (ct==1) then (newline) /script dostuff end) Copy-pasting can often add line breaks when it wraps. I'd double check there are none. Your syntax is correct.
That said, in that macro ct will never equal 1.
When you CastSpellByName() it begins casting and then if the beneficial spell can't land on the current target then you will be in spell targeting mode and SpellCanTargetUnit("target") will return nil. (otherwise it would've cast the spell and you would not be in targeting mode and SpellCanTargetUnit() will return nil)
For detrimental spells, you never get into targeting mode and SpellCanTargetUnit() will always return nil. (Generally, WoW functions with a yes/no result often return 1 for true and nil for false. IsActionInRange is a notable exception that uses 1 or 0 for yes/no.)
You asked if there was a cleaner way to do it so here's the same macro:
/script CastSpellByName("spell") if SpellCanTargetUnit("target") then SendChatMessage('your say message', 'Say') else SpellStopTargeting() end
In lua if you have this:
if Something then
-- do stuff
end
Something is true if it's anything except nil or false. Even an empty string or 0 is "true", which can be confusing when coming from another language.
Since I assume this macro is for detrimental spells (nukes, debuffs, etc), you will probably want to check if you can cast it before casting:
/script if UnitCreatureType("target")=="Humanoid" or UnitCreatureType("target")=="Beast" then CastSpellByName("Polymorph") end
Another tip on shortcuts: You can substitute functions and strings used by assigning them to a variable:
/script local t="target" local u=UnitCreatureType if u(t)=="Humanoid" or u(t)=="Beast" then CastSpellByName("Polymorph") end
the local tag makes it so the variable only exists for that macro and doesn't persist in the game. (Which you sometimes want to do if the macro depends on setting a variable in a previous press). You can string many variables and their values together by clumping them with commas:
/script local t,u="target",UnitCreatureType if u(t)=="Humanoid" or u(t)=="Beast" then CastSpellByName("Polymorph") end
If the macro is intended for beneficial spells, unfortunately that's a lot more complicated. Macros run instantly and you can't tell it to react to something that happens in the future. In this case when you eventually target something you can't tell it what to do then. Well, you can but that involves function hooks and stuff and is generally far beyond the scope of a macro.
|