WoWInterface - View Single Post - I have a coding question about my new addon.

SDPhantom · 10-08-12, 01:15 PM

Originally Posted by Mayoren

Code:

if combatEvent == "SPELL_CAST_SUCCESS" then
	local spell = spellData[spellID]
	if not spell then
		return
	end

	if combatEvent == "SPELL_AURA_APPLIED" then
		SendChatMessage(sChat,"Say")
	end

	if combatEvent == "SPELL_INTERRUPT" then
		SendChatMessage(sChat,"Say")
	end

	SendChatMessage(fChat,"Say")
end

This structure makes it so the success messages would never show since a variable can't have two values at once. Honestly, the SPELL_CAST_SUCCESS handling doesn't make sense since the spell finishing casting isn't related to whether or not it actually hit. I would get rid of that check and the fail message at the end of it.