*sigh* well looks like the problem wasn't to do with the onupdate routines at all.
Turned off all the OnUpdate scripts and converted them to OnEvent scripts with a few events set up and stepped into a building .. 60fps. Step outside into Dalaran and get between 34 and 44fps.
Okay, disabled MagePorts and getting about 40fps outside of the store, so at least a guide line to see if want I enable back into the addon.
Ah, I see whats happening .. camera zoomed in on my character 58fps in dalaran outside the store. Zoom Out from my character and it drops to 40fps or thereabouts. That would explain the difference with the store and outside the store with the automatic zoom in
Well, switching out the biggest onUpdate routines for onEvent routines may help but some of the items need to be in an onUpdate as there are no onEvent routines to use and direct updating of the frames fonts outside of the frame doesn't seem to work .. rofl