View Single Post
02-19-13, 01:29 AM   #71
Phanx
Cat.
 
Phanx's Avatar
AddOn Author - Click to view addons
Join Date: Mar 2006
Posts: 5,617
The new, standardized order of arguments will be:

Functions:
Code:
status, endTime, casterUnit, casterGUID          = lib:UnitHasIncomingRes(unit)
        endTime, targetUnit, targetGUID, isFirst = lib:UnitIsCastingRes(unit)
Callbacks:
Code:
"LibResInfo_ResCastStarted",   targetUnit, targetGUID, casterUnit, casterGUID, endTime
"LibResInfo_ResCastCancelled", targetUnit, targetGUID, casterUnit, casterGUID
"LibResInfo_ResCastFinished",  targetUnit, targetGUID, casterUnit, casterGUID
"LibResInfo_ResPending",       targetUnit, targetGUID
"LibResInfo_ResExpired",       targetUnit, targetGUID
"LibResInfo_ResUsed",          targetUnit, targetGUID
I'll update the documentation pages once I actually make the changes.

After further consideration, I'm on the fence about the previously proposed addition of a spellID arg to the ResCastStarted callback, though I am now considering adding an isFirst arg to the Started/Cancelled/Finished callbacks. Feedback welcome.

I also added a list of addons using the lib to the download page; currently that list consists of Grid, oUF_Phanx, SmartRes2, and sRaidFrames. If anyone knows of any other addons, please let me know. I'm happy to make any necessary changes for addons with open repositories.

On the other hand, it may be better to bump the major version to 1.1. Thoughts, anyone?
__________________
Retired author of too many addons.
Message me if you're interested in taking over one of my addons.
Don’t message me about addon bugs or programming questions.
  Reply With Quote