Announcing addon not working as expected

[pedropacan]

Original Thread - http://www.mmo-champion.com/threads/...ng-as-expected
little about a problem: i have code for announce in chat pvp trinket/wotf but i get problem with spam (over10 msg in one sec about use) when i playing and my addon get over4mb memory.
my lua file - www.pastebin.com/vVsif26G
Thx

[Rilgamon]

The size might be caused by creating new functions in your onevent handlers.
Create the function outside ...

local function dummy() end

...

MultiBarBottomRight.SetPoint = dummy

Edit:
Another problem is that your functions use very generic names (db) while being global . Thats extremly dangerous for stability.
Edit 2:
Your trinket OnEvent creates a table for every event and this sums up quickly and is cleared only on the next garbage collect.
Again it would make sense to have it created outside so that it is reused.

[pedropacan]

did not quite understand about the dummy.
this ?

local function dummy() end
        MultiBarBottomLeft:ClearAllPoints()
        MultiBarBottomLeft:SetPoint("BOTTOMLEFT",ActionButton1,"TOPLEFT",0,6)
        MultiBarBottomLeft.SetPoint = dummy
        MultiBarBottomRight:ClearAllPoints()
        MultiBarBottomRight:SetPoint("BOTTOMLEFT",ActionBarDownButton,"TOPLEFT",9.2,19)
        MultiBarBottomRight.SetPoint = dummy
        FocusFrame:ClearAllPoints()
        FocusFrame:SetPoint("CENTER", TargetFrame, "CENTER", 0, -236)
        FocusFrame.SetPoint = dummy
        PetActionBarFrame:ClearAllPoints()
        PetActionBarFrame:SetPoint("BOTTOMLEFT",ActionButton1,"TOPLEFT",-7,46.8)
        MultiBarLeft:ClearAllPoints()
        MultiBarLeft:SetPoint("BOTTOMRIGHT", UIParent,-43,86)
        MultiBarLeft.SetPoint = dummy
        MultiBarRight:ClearAllPoints()
        MultiBarRight:SetPoint("BOTTOMRIGHT", UIParent,-1,86)
        MultiBarRight.SetPoint = dummy
        ShapeshiftBarFrame:ClearAllPoints()
        ShapeshiftBarFrame:SetPoint("BOTTOM", UIParent, "BOTTOM", -473, 86)
        ShapeshiftBarFrame:SetPoint = dummy

i tried to use

local spellIds = {
    [42292] = "SPELL_CAST_SUCCESS",
    [7744] = "SPELL_CAST_SUCCESS",
};
 
local f = CreateFrame("frame");
f:SetScript("OnEvent", function(self, event, ...) f[event](f, ...); end);
f:RegisterEvent("COMBAT_LOG_EVENT_UNFILTERED");
 
 
 
function f:COMBAT_LOG_EVENT_UNFILTERED(...)
    local _, event, _, sourceGuid, _, _, _, _, _, _, _, spellId, spellName = select(1, ...);
    if ( sourceGuid == UnitGUID("player") and event == spellIds[spellId] ) then
        if ( GetNumPartyMembers() > 0 ) then -- not sure about returns
            SendChatMessage(spellName.." used!", "PARTY");
        end
    end
end

spam not stopping in both cases and addon memory 50kb~

[Rilgamon]

To place the dummy-function outside make sure it is above your SetScript.

local function dummy() end
a:SetScript("OnEvent",function(self,event)

[Rilgamon]

I'm not sure about the spam. I'd just add a delay roughly your spells duration (100ms) or even the cd (2min) before you send the message again.

local nextStamp = 0
function f:COMBAT_LOG_EVENT_UNFILTERED(...)
    local _, event, _, sourceGuid, _, _, _, _, _, _, _, spellId, spellName = select(1, ...);
    if ( sourceGuid == UnitGUID("player") and event == spellIds[spellId] ) then
        if ( GetNumPartyMembers() > 0 ) then -- not sure about returns
            if ( nextStamp < GetTime()) then
                  SendChatMessage(spellName.." used!", "PARTY");
                  nextStamp = GetTime() + 0.1
            end
        end
    end
end

[pedropacan]

your version doesn't work nothing announces

[pedropacan]

up. problem isn't solved

[Phanx]

Post your current code. I don't understand why people always think we can tell them what's wrong with their code without looking at it.

[pedropacan]

sorry. http://pastebin.com/7Pcbqk2E