Thread Tools Display Modes
Unread 07-30-12, 07:00 AM   #1
Miiru
A Theradrim Guardian
 
Miiru's Avatar
AddOn Author - Click to view addons
Join Date: Dec 2008
Posts: 66
Addon blocks Glyph Ui

So today i wanted to remove some more frames and continue to work on my texture pack and i came along the Glyph Ui, tried to equip a glyph and noticed that i get the usual action blocked message.

Curiously i wasn't even changing anything near the glyph UI so i looked over and over and it came down to this little code:

Code:
local frame = CreateFrame("FRAME");																					
		frame:RegisterEvent("ADDON_LOADED")
		function frame:OnEvent(event, arg1)
		
			if event == "ADDON_LOADED" and arg1 == "Blizzard_TalentUI" then
			
			_,c= PlayerTalentFrameSpecialization:GetRegions();		
			c:Hide()		
			c1,_,_,_,_,_,_,_,_,_,_,c4 = PlayerTalentFrameSpecializationSpellScrollFrameScrollChild:GetRegions();
			c1:SetTexture(0,0,0,0)
			c4:SetTexture(0.129,0.113,0.129,1)
	
   	 end
   	end
   	 
  frame:SetScript("OnEvent", frame.OnEvent);
If i delte those few lines, everything runs fine. I tested if those frames are protected by i always returned nil (unless i did it wrong ). Another interesting thing is that if i open up the Glyph Window and proceed to first remove a glyph and the equip one, i don't get an error at at all.

Any ideas on how to get rid of it? :/

edit: digged a bit deeper and it seems to be child c and child c4 causing the error.
__________________
◘◘ Author of MiirGui Texture Pack ◘◘

Last edited by Miiru : 07-30-12 at 11:01 AM.
Miiru is online now  
Unread 07-30-12, 12:55 PM   #2
Dridzt
A Pyroguard Emberseer
 
Dridzt's Avatar
AddOn Author - Click to view addons
Join Date: Nov 2005
Posts: 1,192
Are those variables local in some part of your code that's not visible in the snippet or are they global like that?

Mainly talking about the throwaway variable '_'

Since that's a throwaway variable by programmer convention and not an automatically discarded variable, that's where I'd start.

There's a possibility Blizzard programmers have overlooked localizing some instance of _ in their own code so there's no telling what code paths are tainted.

Start by putting
Code:
local _,c,c1,c4
at the top of your file.
Dridzt is offline  
Unread 07-30-12, 01:32 PM   #3
Barjack
A Black Drake
AddOn Author - Click to view addons
Join Date: Apr 2009
Posts: 80
Yeah, I've definitely seen taintLog errors since 5.0 that mention a tainted global _ when getting a Glyph UI action blocked error. Making sure all your _ variables are local seems to have become even more necessary now.
Barjack is offline  
Unread 07-30-12, 01:39 PM   #4
Xrystal
nUI User and Supporter
 
Xrystal's Avatar
Premium Member
AddOn Author - Click to view addons
Join Date: Feb 2006
Posts: 5,035
I've seen the same problem so far. First it reports nUI as being the addon factor and when I turn that off Titan Panel. But finding common ground with those 2 addons may be a bit difficult rofl.
__________________
Xrystal is offline  
Unread 07-30-12, 06:33 PM   #5
Phanx
A Pyroguard Emberseer
 
Phanx's Avatar
AddOn Author - Click to view addons
Join Date: Mar 2006
Posts: 4,576
I've found a lot of leaked globals in Blizzard's beta UI code, including underscores. I haven't looked at the Glyph UI code, but it would not surprise me in the least if Blizzard forgot their "local" declarations there too.
__________________
Author/maintainer of Grid, PhanxChat, ShieldsUp, and many more.
Troubleshoot an addonTurn any code into an addonMore addon resources
Need help with your code? Post all of your actual code! Attach or paste your files.
Please don’t PM me about addon bugs or code questions. Post a comment or forum thread instead!
Phanx is offline  
Unread 07-30-12, 06:49 PM   #6
Xrystal
nUI User and Supporter
 
Xrystal's Avatar
Premium Member
AddOn Author - Click to view addons
Join Date: Feb 2006
Posts: 5,035
the only block of code I can see that may be causing the problem is ..

CastGlyph command perhaps?

Lua Code:
  1. 517.function GlyphFrameSpell_OnClick (self, button)
  2.  518.  if ( IsModifiedClick("CHATLINK") ) then
  3.  519.    local _, _, _, _, _, link = GetGlyphInfo(self.glyphIndex);
  4.  520.    if ( link ) then
  5.  521.      ChatEdit_InsertLink(link);
  6.  522.    end
  7.  523.  else
  8.  524.    if self.disabledBG:IsShown() then
  9.  525.      return;
  10.  526.    end
  11.  527.    CastGlyph(self.glyphIndex);
  12.  528.    StaticPopup_Hide("CONFIRM_GLYPH_PLACEMENT");
  13.  529.  end
  14.  530.end
__________________
Xrystal is offline  
 

Go BackWoWInterface » WoD Beta » MoP archived threads » Addon blocks Glyph Ui

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

vB code is On
Smilies are On
[IMG] code is On
HTML code is Off