Thread Tools Display Modes
Old 08-12-12, 02:45 AM   #1
myrroddin
Premium Member
 
myrroddin's Avatar
Premium Member
AddOn Author - Click to view addons
Join Date: Oct 2008
Posts: 357
SmartRes2 and LibResComm-1.0

I updated SmartRes2 and LibResComm-1.0 for Mist of Pandaria. No errors as I tested them, but both need more thorough testing, especially if anyone is in a level 25+ guild on the beta.

Neither addon will work on live servers with their current builds.

SR2 gained a new slash command, /smartres test or /sr test which will show the test bars without loading the entire config screen. This is for people who don't have an LDB display, which already offers this option.

Both addons need some Italian loving in the localization department. There are also several untranslated strings for other languages. Please help!
myrroddin is offline  
Old 08-12-12, 08:30 PM   #2
Phanx
A Pyroguard Emberseer
 
Phanx's Avatar
AddOn Author - Click to view addons
Join Date: Mar 2006
Posts: 3,977
Have you considered using the built-in resurrection API instead of LibResComm-1.0? I don't know about any other addons, but Grid uses the API now, so that's likely cutting down on the install base for LibResComm.

Also, links to the download and localization pages would probably be a good idea.
__________________
Author/maintainer of Grid, PhanxChat, ShieldsUp, and many more.
Troubleshoot an addonTurn any code into an addonMore addon resources
Need help with your code? Post all of your actual code! Attach or paste your files.
Please don’t PM me about addon bugs or code questions. Post a comment or forum thread instead!
Phanx is offline  
Old 08-13-12, 02:55 AM   #3
Vlad
A Molten Giant
 
Vlad's Avatar
AddOn Author - Click to view addons
Join Date: Dec 2005
Posts: 751
That's true, there is new API to help resurrection so it could be neat to use that instead of using the custom code.
Vlad is offline  
Old 08-13-12, 09:48 AM   #4
myrroddin
Premium Member
 
myrroddin's Avatar
Premium Member
AddOn Author - Click to view addons
Join Date: Oct 2008
Posts: 357
As to why the library is still useful: http://forums.wowace.com/showthread....110#post322110 I forgot to mention the Lib:IsUnitBeingRessed(unit) returns both boolean and resser, whereas the Blizzard API just returns the boolean, afaik.

Links. You can get to the localization tab of both from them.
http://www.wowace.com/addons/smartres2/
http://www.wowace.com/addons/librescomm-1-0/

tl;dr: The API does not return caster, only boolean for unit being ressed. Nor does it return cast time. Also, if your target is a unit frame or in the world frame, you get "unknown" and with the library, you always get a target, which is especially important if OTHER people want to know whom you are ressing. You need a comm for that information.
myrroddin is offline  
Old 08-13-12, 09:53 AM   #5
Vlad
A Molten Giant
 
Vlad's Avatar
AddOn Author - Click to view addons
Join Date: Dec 2005
Posts: 751
Shame because Blizzard went trough the trouble to implement a new API that works fine for showing if someone is being ressed or not, but could have added name, cast start, cast end, e.g. information, like a couple of more parameters returned and it would have been a good addition that saves us a lot of coding.
Vlad is offline  
Old 08-13-12, 10:08 AM   #6
myrroddin
Premium Member
 
myrroddin's Avatar
Premium Member
AddOn Author - Click to view addons
Join Date: Oct 2008
Posts: 357
Vladinator, while it is true that you can get quite a lot of information from UnitHasIncomingResurrection() and UnitCastingInfo() between them, even combined, there are gaps. The two biggest are the lack of caster and especially getting a target from someone else casting. Strangely, you can't even use UnitCastingInfo() to get a target to pass to UnitHasIncomingResurrection() because the former does not return a target. And you can't pass caster to the latter.

Only UNIT_SPELLCAST_SENT has caster and target, and it is a player-only event. Unless MoP changed that, but I doubt it.

So for those of us who want to know who is ressing whom, we still need LibResComm. I have no issues dropping it if and when Blizzard fills the gaps in their API returns.
myrroddin is offline  
 

Go BackWoWInterface » WoD Beta » MoP archived threads » SmartRes2 and LibResComm-1.0

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

vB code is On
Smilies are On
[IMG] code is On
HTML code is Off