Announce to Raid Chat issue

[Flaer]

I've been using the mouseover macro below to both whisper the target I cast my battle rez on and announce it to the raid but since 5.1 changed GetRealNumRaidMembers the raid chat announce doesn't work anymore. Does anyone have insight into what I'd need to change to make it work again? I'd also like it to stop the whisper to the target if the spell doesn't fire but I haven't been able to figure that part out. Lastly, I never PvP so the Battleground part can be removed if it's unneeded but I don't know if that's the case. Thanks.

#showtooltip Raise Ally
/stopmacro [@mouseover,nodead]
/cast [@mouseover,dead,help][@target,dead,help][]Raise Ally
/run SendChatMessage("Raise Ally cast on you. Rise up and fight!!","WHISPER",nil, UnitName("mouseover") or UnitName("target"))
/stopmacro [nogroup][@mouseover,nodead]
/run SendChatMessage("Aethran cast Raise Ally on "..UnitName("mouseover")..".", GetRealNumRaidMembers() > 0 and "RAID" or GetNumRaidMembers() > 0 and "BATTLEGROUND" or GetNumPartyMembers() > 0 and "PARTY" or "SAY")

[F16Gaming]

Changing the last line to this should work:

/run SendChatMessage("Aethran cast Raise Ally on "..UnitName("mouseover")..".", UnitInBattleground("player") and "BATTLEGROUND" or IsInRaid() and "RAID" or IsInGroup() and "PARTY" or "SAY")

Note that I haven't tested it.

Edit: Changed to IsInRaid and IsInGroup instead of checking player count.

[Phanx]

Change the last line to:

/run SendChatMessage("Aethran cast Raise Ally on "..UnitName("mouseover")..".", IsInGroup(LE_PARTY_CATEGORY_INSTANCE) and "INSTANCE_CHAT" or IsInRaid() and "RAID" or IsInGroup() and "PARTY" or "SAY")

Uses IsInRaid/IsInGroup, but also supports the INSTANCE_CHAT channel added in 5.1 for LFG/LFR/battleground groups.

[F16Gaming]

Ah, didn't realize IsInGroup took a parameter. I should start checking wowpedia and not just wowprogramming :P

[Phanx]

Wowprogramming's documentation tends to be more consistent, but the problem is that it's only updated by a very small group of people (I don't actually know, but I'd guess 1-5 people) while anyone can add info to Wowpedia, so while the documentation can be inconsistent (eg. random functions not documented, writing quality varies wildly, some stuff is really outdated, etc.) it's also more thorough, with lots of notes and examples on usage, bugs, etc.

When in doubt, check the default UI code to verify current API usage. Blizzard is generally pretty bad at writing efficient code, but one thing they are good at is using descriptive variable names.

[Flaer]

Awesome, thanks guys!

[F16Gaming]

Originally Posted by Phanx the problem is that it's only updated by a very small group of people (I don't actually know, but I'd guess 1-5 people) while anyone can add info to Wowpedia

Just thought I should add, anyone can edit wowprogramming as well (I updated http://wowprogramming.com/docs/api/IsInGroup for example). But it probably doesn't have as many active editors as wowpedia does.

[Torhal]

Originally Posted by Phanx Wowprogramming's documentation tends to be more consistent, but the problem is that it's only updated by a very small group of people (I don't actually know, but I'd guess 1-5 people) while anyone can add info to Wowpedia, so while the documentation can be inconsistent (eg. random functions not documented, writing quality varies wildly, some stuff is really outdated, etc.) it's also more thorough, with lots of notes and examples on usage, bugs, etc. When in doubt, check the default UI code to verify current API usage. Blizzard is generally pretty bad at writing efficient code, but one thing they are good at is using descriptive variable names.

Anyone can edit WoWProgramming's API documentation - you simply need to make an account and start editing.

Edit: This is what I get for replying before reading later posts. Meh.

[Flaer]

Anyone have insight into what change would be needed to stop the whisper if the spell doesn't activate?