oUF - Layout discussion

[haste]

The old oUF thread over at WoWace has become, quite a monster to say it softly. It's a mess of bug reports, layout issues and general issues/feature people have/want.

Please use this thread for layout discussion only.

Related forum thread: oUF - General discussion
Bug reports and feature requests should be posted over at the author portal. Issues with specific layouts should be posted in their respective place (not here, unless you are the author of the layout in question (and don't you dare to bend this exception! :p)).

[MoonWitch]

Haste, is there actually a way to overwrite/override the pvp functions, because I prefer a textual tag, but would like to do that by not editting the oUF core?

[haste]

There isn't any internal functions for that on PvP, mostly because it's a shared event, and the shared event system is still to be written.

You can however do: self.UNIT_FACTION = myOwnUpdatePvPFunction;. Setting functions directly on the layout doesn't touch the core at all.

[MoonWitch]

Originally Posted by haste There isn't any internal functions for that on PvP, mostly because it's a shared event, and the shared event system is still to be written. You can however do: self.UNIT_FACTION = myOwnUpdatePvPFunction;. Setting functions directly on the layout doesn't touch the core at all.

Thanks I'll do that. I still get freaked out when I see the pvp icon, so I figured it'd be better for my heart to use text. :P

[Caellian]

Is it possible to change the level of a text (fontstring) the same way it works for frames (SetFrameLevel).
I'm toying with portraits and would like to display something over it, but right now the portrait comes above of the text.

[zork]

Maybe I can help you out here. You could just use a helperframe that lays between portrait and text.

    
    --I don't know the Portrait call but it should be similar
    self.pm1 = CreateFrame("PlayerModel", nil, self)
    self.pm1:SetFrameStrata("BACKGROUND")
    self.pm1:SetAllPoints(self)
    self.pm1:SetUnit(unit)
    --self.pm1:SetModelScale(1)
    self.pm1:SetCamera(0)    
    --self.pm1:SetRotation(0)    
    
    self.pm1helper = CreateFrame("FRAME", nil, self.pm1)
    self.pm1helper:SetFrameStrata("LOW")
    self.pm1helper:SetAllPoints(self.pm1)
    
    self.pm1helper.Text = SetFontString(self.pm1helper, nil, 13, "THINOUTLINE")
    self.pm1helper.Text:SetPoint('CENTER', 0, 0)

[Caellian]

Ahhh, clever, gonna give it a try right now

Actually it's not really helping much in my case, here's what i'm trying to do.



Unfortunately i already had to lower the portrait's alpha to 0.25 to be able to read the value and see the healthbar progression.

[zork]

Originally Posted by Caellian Ahhh, clever, gonna give it a try right now Unfortunately i already had to lower the portrait's alpha to 0.25 to be able to read the value and see the healthbar progression.

Please post the code of your fontstring, helper and the portrait.

[Caellian]

Originally Posted by zork Please post the code of your fontstring, helper and the portrait.

In the example above i didn't use any helper, here it is though

	self.Health.value = SetFontString(self.Health, font,(unit == 'player' or unit == 'target') and 10 or 9)

			self.Portrait = CreateFrame('PlayerModel', nil, self)
			self.Portrait.type = '3D'
			self.Portrait:SetAlpha(.25)
			self.Portrait:SetPoint('TOPLEFT', self.Health, 'TOPLEFT', 0, -.5)
			self.Portrait:SetPoint('BOTTOMRIGHT', self.Health, 'BOTTOMRIGHT', .5, -.5)

In this case, it looks ok but isn't really useable, if i increase the alpha, the value and also the health bar progression are impossible to see.

[haste]

At what layer is your font-strings created? OVERLAY should position your text above the model just fine.

[Caellian]

Originally Posted by haste At what layer is your font-strings created? OVERLAY should position your text above the model just fine.

Yes

local fs = parent:CreateFontString(nil, 'OVERLAY')

But you made me think i had to do this to have my mouseover highlight to work corectly

	self.Health:SetFrameLevel(unit and 1 or 2)

	self.Highlight = self:CreateTexture(nil, 'HIGHLIGHT')
	self.Highlight:SetAllPoints(self.Health)
	self.Highlight:SetBlendMode('ADD')
	self.Highlight:SetTexture('Interface\\AddOns\\oUF_Caellian\\media\\mouseoverHighlight')

[haste]

Then it's probably your portrait that has a rather high frame level. You can do the following however:
a) Change the frame level of the portrait.
or
b) Create the font-strings with the portrait as parent.

[Caellian]

Weird, i'm sure i tried to change the portrait level before and it didn't work for some reason, now it does. Anyway thanks, though i don't know yet if i like the result or not

Anyway, i'd like to understand something, since i've added portraits, i've created a "fake" frame above them so they don't look so flat, i've anchored a few things to that "fake" frame, like health value, power value and so on and it works just fine. But, when i try to do the same with Druidmana, it works but return an error. I'm not sure to understand it because it works for everything else using the exact same method, why not for Druidmana.

Interface\AddOns\oUF_Caellian\oUF_Caellian.lua:56: attempt to index local 'parent' (a nil value)
Count: 1

Call Stack:
[C]: ?
Interface\AddOns\oUF_Caellian\oUF_Caellian.lua:56: in function <Interface\AddOns\oUF_Caellian\oUF_Caellian.lua:55>
Interface\AddOns\oUF_Caellian\oUF_Caellian.lua:464: in function `style'
Interface\AddOns\oUF\ouf.lua:212: in function <Interface\AddOns\oUF\ouf.lua:206>
Interface\AddOns\oUF\ouf.lua:269: in function <Interface\AddOns\oUF\ouf.lua:266>
Interface\AddOns\oUF\ouf.lua:323: in function `Spawn'
Interface\AddOns\oUF_Caellian\oUF_Caellian.lua:614: in main chunk

Line 464 being my SetFontString

	if(IsAddOnLoaded('oUF_DruidMana')) then
		if(portraits == true) then
			self.DruidManaText = SetFontString(self.Portrait2, font, 10)
			self.DruidManaText:SetPoint('CENTER', 0, 1)
			self.DruidManaText:SetTextColor(1, .49, .04)
		else
			self.DruidManaText = SetFontString(self.Health, font, 10)
			self.DruidManaText:SetPoint('CENTER', 0, 1)
			self.DruidManaText:SetTextColor(1, .49, .04)
		end
	end

In the following example it's working just fine

		if(portraits == true) then
			self.CombatFeedbackText = SetFontString(self.Portrait2, fontnum, 18, 'OUTLINE')
			self.CombatFeedbackText:SetPoint('CENTER', 0, 1)
		else
			self.CombatFeedbackText = SetFontString(self.Health, fontnum, 18, 'OUTLINE')
			self.CombatFeedbackText:SetPoint('CENTER', 0, 1)
		end

Another question, i want to hide my target's name if it's casting and display the castbar text instead.
This didn't work, apparently self.Castbar.Text:GetText()) is not correct, is there any other way ? (only the hide part doesn't work here, the rest is fine, i just paste the whole thing)

	if(unit == 'target') then
		self.Name:ClearAllPoints()
		if(not self.Castbar.Text:GetText()) then
			if(self.Power.value:GetText()) then
				self.Name:SetPoint('CENTER', 0, 1)
			else
				self.Name:SetPoint('LEFT', 1, 1)
			end
		else
			self.Name:Hide()
		end
	end

Note: WTB [tt] tag plz ?

[vadda]

Hi!

I wanted to create a black frame under player and target-frame.

It worked for the player-frame, as you can see on the screenshot:


But I'm not able to get it working for the target-frame.
Any ideas how the code should look like?

Here's my noobish code for the player-frame:

blackbar = CreateFrame("Frame", nil, self)
blackbar:SetHeight(15)
blackbar:SetWidth(230)
blackbar:SetFrameStrata("LOW")
t = blackbar:CreateTexture(nil,"BACKGROUND")
t:SetTexture(0,0,0)
t:SetAllPoints(blackbar)
blackbar.texture = t
blackbar:SetPoint('TOP', self, 'BOTTOM', 0, -9)

thx,
Vadda

[Coldfury]

Originally Posted by vadda Hi! Any ideas how the code should look like?

im pretty sure its the :SetPoint('TOP', self, 'BOTTOM', 0, -9) part. You should use the name of the frames instead(names are defined where you spawn the frame) or use "oUF.units.player" and "oUF.units.target".

something like
blackframe:SetPoint('TOP', oUF.units.player, 'BOTTOM', 0, -9)
blackframe2:SetPoint('TOP', oUF.units.target, 'BOTTOM', 0, -9)

[Coldfury]

@Caellian:

try using "SetFont" instead of "SetFontString".

ie.: self.DruidManaText = SetFont(font, 10)





which lead me to the question... why use setfontstring? what does it have more than setfont? whats the point of setting a parent there?

[p3lim]

Originally Posted by Coldfury @Caellian: try using "SetFont" instead of "SetFontString". ie.: self.DruidManaText = SetFont(font, 10) which lead me to the question... why use setfontstring? what does it have more than setfont? whats the point of setting a parent there?

Its a function to create the whole fontstring

[vadda]

Originally Posted by Coldfury something like blackframe:SetPoint('TOP', oUF.units.player, 'BOTTOM', 0, -9) blackframe2:SetPoint('TOP', oUF.units.target, 'BOTTOM', 0, -9)

I created a second blackbar like this:

blackbar2 = CreateFrame("Frame", nil, oUF.units.target)
blackbar2:SetHeight(150)
blackbar2:SetWidth(300)
blackbar2:SetFrameStrata("LOW")
bla = blackbar2:CreateTexture(nil,"BACKGROUND")
bla:SetTexture(0,0,0)
bla:SetAllPoints(blackbar2)
blackbar2.texture = bla
blackbar2:SetPoint('TOP', oUF.units.target, 'BOTTOM', 0, 90)

Now I see the second black-bar constantly on the bottom of the screen.
Even if I have no target selected. Quite weird.

[Caellian]

Originally Posted by Coldfury @Caellian: try using "SetFont" instead of "SetFontString". ie.: self.DruidManaText = SetFont(font, 10) which lead me to the question... why use setfontstring? what does it have more than setfont? whats the point of setting a parent there?

I use SetFontString instead of CreateFontString because i have a SetFontString function at the top of my layout including all the default i want for all my fonts, so i don't have to repeat them each time. I don't know if it's a good reason but that's why i do that

self.DruidManaText = SetFont(self.Portrait2, font, 10)

Didn't work

Interface\AddOns\oUF_Caellian\oUF_Caellian.lua:458: attempt to call global 'SetFont' (a nil value)

But anyway, i really have no clue why it works for everything but DruidMana.

[zynix]

how in the earth do you move stuff, do you need to edit something in the .lua files or something


would love you help

Zynix