Reply
 
Thread Tools Display Modes
Old 02-27-11, 01:44 PM   #1
MysticalOS
A Wyrmkin Dreamwalker
 
MysticalOS's Avatar
AddOn Author - Click to view addons
Join Date: May 2009
Posts: 52
4.1 COMBAT_LOG_EVENT_UNFILTERED changes

4.1 adds a new arg, hideCaster (boolean), and of course, with blizz tradition, not at the end, but right smack in the middle offseting rest of args and breaking mods not updated to account for it. This boolean isn't logged by /combatlog so that parsing seems unaffected.

4.0.6
COMBAT_LOG_EVENT_UNFILTERED(timestamp, event, sourceGUID, sourceName, sourceFlags, destGUID, destName, destFlags, ...)

4.1
COMBAT_LOG_EVENT_UNFILTERED(timestamp, event, hideCaster, sourceGUID, sourceName, sourceFlags, destGUID, destName, destFlags, ...)
MysticalOS is offline   Reply With Quote
Old 02-27-11, 02:47 PM   #2
Ketho
A Molten Giant
 
Ketho's Avatar
AddOn Author - Click to view addons
Join Date: Mar 2010
Posts: 539
.. that sucks.
__________________
Ketho is offline   Reply With Quote
Old 02-27-11, 03:42 PM   #3
MysticalOS
A Wyrmkin Dreamwalker
 
MysticalOS's Avatar
AddOn Author - Click to view addons
Join Date: May 2009
Posts: 52
not really, it's a 2 second fix in most mods when 4.1 launches, to support it now though just means some if/else rules and a client build check to have your mod support ptr and live similtaniously.
MysticalOS is offline   Reply With Quote
Old 02-27-11, 04:16 PM   #4
Seerah
Fishing Trainer
 
Seerah's Avatar
WoWInterface Super Mod
Featured
Join Date: Oct 2006
Posts: 9,479
To perhaps help explain why it's in the middle instead of the end... The different CLEU events add returns to the end of the normal CLEU returns.
__________________
"You'd be surprised how many people violate this simple principle every day of their lives and try to fit square pegs into round holes, ignoring the clear reality that Things Are As They Are." -Benjamin Hoff, The Tao of Pooh

Seerah is offline   Reply With Quote
Old 03-03-11, 05:00 PM   #5
Crissa
A Flamescale Wyrmkin
 
Crissa's Avatar
Join Date: May 2008
Posts: 136
What does the new item mean, though?

-Crissa
Crissa is offline   Reply With Quote
Old 03-03-11, 06:32 PM   #6
SDPhantom
A Molten Giant
 
SDPhantom's Avatar
AddOn Author - Click to view addons
Join Date: Jul 2006
Posts: 933
it's a flag telling the combat log if it should show the message or not, this could possibly mean events firing for spells currently not fired for CLEU?
__________________
"All I want is a pretty girl, a decent meal, and the right to shoot lightning at fools."
-Anders (Dragon Age: Origins - Awakening)
SDPhantom is offline   Reply With Quote
Old 03-03-11, 08:19 PM   #7
Waky
A Cobalt Mageweaver
 
Waky's Avatar
AddOn Author - Click to view addons
Join Date: Aug 2010
Posts: 200
Thanks for that note, I'll have some changing to do come 4.1
Waky is offline   Reply With Quote
Old 03-05-11, 12:42 PM   #8
Nuggs
A Deviate Faerie Dragon
 
Nuggs's Avatar
AddOn Author - Click to view addons
Join Date: Feb 2010
Posts: 19
lol, lovely place to stick it. Thanks for the heads up though.
Nuggs is offline   Reply With Quote
Old 03-05-11, 03:48 PM   #9
Morsker
A Fallenroot Satyr
 
Morsker's Avatar
AddOn Author - Click to view addons
Join Date: May 2006
Posts: 22
When trying to make mods compatible between 4.0.6 and 4.1 I noticed that GetBuildInfo() is still returning 40000 as its 4th value on the PTR, even though the 1st value is "4.1.0". I resorted to this for consistency's sake:

Code:
local clientVersion
do
	local version = GetBuildInfo() -- e.g. "4.0.6"
	local a, b, c = strsplit(".", version) -- e.g. "4", "0", "6"
	clientVersion = 10000*a + 100*b + c -- e.g. 40006
end
Morsker is offline   Reply With Quote
Reply

Go BackWoWInterface » Developer Discussions » Tutorials & Other Helpful Info. » 4.1 COMBAT_LOG_EVENT_UNFILTERED changes

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

vB code is On
Smilies are On
[IMG] code is On
HTML code is Off