4.2 COMBAT_LOG_EVENT_UNFILTERED changed (again)

[Ketho]

• v4.2.0 threads
  http://us.battle.net/wow/en/forum/topic/2483689044
  http://forums.wowace.com/showthread.php?t=19431
  http://eu.battle.net/wow/en/forum/topic/2057506348

4.1: timestamp, subevent, hideCaster, sourceGUID, sourceName, sourceFlags, destGUID, destName, destFlags 4.2: timestamp, subevent, hideCaster, sourceGUID, sourceName, sourceFlags, sourceRaidFlags, destGUID, destName, destFlags, destRaidFlags

It seems that Blizzard has run out of space on the original UnitFlags, so they had to add another pair of UnitFlags parameters, and for now at least, moved the Raid Target Icon Flags into there

• v4.1.0 threads
  http://us.battle.net/wow/en/forum/topic/2140267259
  http://www.wowinterface.com/forums/s...ad.php?t=39104
  http://forums.wowace.com/showthread.php?t=19274

• FrameXML
  Blizzard_CombatLog.lua L2180 CombatLog_OnEvent
  Blizzard_CombatLog.lua L2037 CombatLog_String_GetIcon

• Wowpedia info by Mikord
  http://www.wowpedia.org/API_COMBAT_L...ase_Parameters
  http://www.wowpedia.org/RaidFlag

-- credits to the wowace.com, us.battle.net threads

[Rilgamon]

hehe, we're not even trough with the first change

[Ketho]

This time Blizzard wasn't so lazy and properly updated the TOC on the PTRs to 40200 which is less of a hassle
I'm interested in the solutions for forwards compatibility, and I want to share some myself

• Quoting the forwards compatible fix of Omegal:

  -- fix for 4.2 which introduces some new argument
  -- this is a temporary work-around which just drops the new argument for a quick and easy fix that is compatible with 4.2
  if tonumber((select(4, GetBuildInfo()))) >= 40200 then
  	local oldHandler = mod.COMBAT_LOG_EVENT_UNFILTERED
  	function mod:COMBAT_LOG_EVENT_UNFILTERED(timestamp, event, hideCaster, sourceGUID, sourceName, sourceFlags, mysteryArgument, destGUID, destName, destFlags, anotherMysteryArgument, ...)
  		return oldHandler(self, timestamp, event, hideCaster, sourceGUID, sourceName, sourceFlags, destGUID, destName, destFlags, ...)
  	end
  end

• Here is my own (Ace3) fowards compatible fix:

  local toc = select(4, GetBuildInfo())
   
  function MyAddOn:COMBAT_LOG_EVENT_UNFILTERED(event, ...)
      local timestamp, subevent, hideCaster, sourceGUID, sourceName, sourceFlags, sourceRaidFlags, destGUID, destName, destFlags, destRaidFlags
      local spellID, spellName, spellSchool
      local SuffixParam1, SuffixParam2, SuffixParam3, SuffixParam4, SuffixParam5, SuffixParam6, SuffixParam7, SuffixParam8, SuffixParam9
   
      local suffixPos
      if toc >= 40200 then
          timestamp, subevent, hideCaster, sourceGUID, sourceName, sourceFlags, sourceRaidFlags, destGUID, destName, destFlags, destRaidFlags = ...
          suffixPos = 12
      else
          timestamp, subevent, hideCaster, sourceGUID, sourceName, sourceFlags, destGUID, destName, destFlags = ...
          suffixPos = 10
      end
   
      local prefix = strsub(subevent, 1, 5)
      if prefix == "SWING" then
          SuffixParam1, SuffixParam2, SuffixParam3, SuffixParam4, SuffixParam5, SuffixParam6, SuffixParam7, SuffixParam8, SuffixParam9 = select(suffixPos, ...)
      elseif prefix == "SPELL" or prefix == "RANGE" then
          spellID, spellName, spellSchool, SuffixParam1, SuffixParam2, SuffixParam3, SuffixParam4, SuffixParam5, SuffixParam6, SuffixParam7, SuffixParam8, SuffixParam9 = select(suffixPos, ...)
      end
   
      -- do stuff
  end

I've also seen some addons use a "tail call" solution for patch 4.1.0,
but I'm not sure how it would be done now for patch 4.2.0

Edit:
Myself I still don't really understand the mod stuff/solution though, but somehow it looks like a way better solution .. (><)

[Ailae]

It saves a reference to the old handler for CLEU and then declares a new one. The new one then has the new parameters in the function-call (so things line up correctly) and then just passes the all parameters besides the new ones to the old handler.

[Xinhuan]

I use this for pre-4.1, 4.1 and 4.2 compat:

local TOC -- Pre-4.1 CLEU compat
local dummyTable = {}
local recurse = true
do
    -- Because GetBuildInfo() still returns 40000 on the PTR
    local major, minor, rev = strsplit(".", (GetBuildInfo()))
    TOC = major*10000 + minor*100
end
function Omen:COMBAT_LOG_EVENT_UNFILTERED(event, timestamp, eventtype, hideCaster, srcGUID, srcName, srcFlags, dstGUID, dstName, dstFlags, ...)
    -- Pre-4.1 CLEU compat
    if TOC < 40100 and hideCaster ~= dummyTable then
        -- Insert a dummy for the new argument introduced in 4.1 and perform a tail call
        return self:COMBAT_LOG_EVENT_UNFILTERED(event, timestamp, eventtype, dummyTable, hideCaster, srcGUID, srcName, srcFlags, dstGUID, dstName, dstFlags, ...)
    elseif TOC >= 40200 and recurse then
        local arg1 = ...
        recurse = false
        return self:COMBAT_LOG_EVENT_UNFILTERED(event, timestamp, eventtype, hideCaster, srcGUID, srcName, srcFlags, dstName, dstFlags, arg1, select(3, ...))
    end
    recurse = true
 
    -- Rest of Omen code
end

It only uses tailcalls if the version is NOT 4.1, so for standard users suffer no performance penalties. Omegal's solution is essentially the same thing, just that he created a second function to call the original, and I instead made the function call itself.

Note the unorthodox way of calculating the TOC only because for most of the 4.1 PTR testing, the 4th return of GetBuildInfo() returned 40000 rather than 40100.