Need help coloring "widget"

[Sauerkraut]

I've started playing around with a new layout and I've gotten most things working, however there is a small arrow that I am using to indicate power on the power bar. I've included an image since it is a little hard to explain


I'm currently using the follow to color it

  oUF.colors.power['MANA'] = {0.0, 0.56, 1.0}
  oUF.colors.power['RAGE'] = {1.0,0,0}
  oUF.colors.power['FOCUS'] = {1.0,0.75,0.25}
  oUF.colors.power['ENERGY'] = {1.0, 0.9, 0.35}
  oUF.colors.power['RUNIC_POWER'] = {0.44,0.44,0.44}
  local _, pType = UnitPowerType("player")
  local pcolor = oUF.colors.power[pType] or {.3,.45,.65}

	s.arrow:SetVertexColor(unpack(pcolor))

It works most of the time but others I need to do a /rl to have it pick up the proper color. Also if I am on a druid and I shapeshift to a different form it doesn't update. I'm sure I'm just missing some thing but I'm not sure how to go about making it update. Any help would be appreciated.

[Rainrider]

How did you created the arror? (is it a texture, what is its parent frame and what events are registered to the frame?)

You have 2 options: creating an element as an oUF module and registering the proper events so it updates correctly, or just do it directly in the layout. This is what I currently use for threat, maybe it helps you a bit

create the element and expose it to the namespace

local AddThreatHighlight = function(self, event, unit)
    if (unit ~= self.unit) then return end
 
    local status = UnitThreatSituation(unit)
    if (status and status > 0) then
        local r, g, b = GetThreatStatusColor(status)
    
        self.FrameBackdrop:SetBackdropBorderColor(r, g, b)
    else
        self.FrameBackdrop:SetBackdropBorderColor(0, 0, 0)
    end
end
ns.AddThreatHighlight = AddThreatHighlight

enable it for the frame:

self:RegisterEvent("UNIT_THREAT_SITUATION_UPDATE", ns.AddThreatHighlight)

I'm unsure if an element as a module has any benefits.

And if you plan to release your layout, you should use metatables for the colors and not overwrite the oUF dafault table, in case a user wants to use a diffenrent layout for say raid frames or so.

ns.colors = setmetatable({
    power = setmetatable({
        ['MANA'] = {0.0, 0.56, 1.0},
        ['RAGE'] = {1.0,0,0},
        ['FOCUS'] = {1.0,0.75,0.25},
        ['ENERGY'] = {1.0, 0.9, 0.35},
        ['RUNIC_POWER'] = {0.44,0.44,0.44},
    }, {__index = oUF.colors.power}),
}, {__index = oUF.colors})

[Sauerkraut]

The arrow is a texture spawned on the power bar frame.

		s.arrow = s:CreateTexture(nil, "OVERLAY")
		s.arrow:SetTexture([[Interface\Addons\oUF_Fail\media\textureArrow]])
		s.arrow:SetSize(16,16)
		s.arrow:SetPoint("BOTTOM", s:GetStatusBarTexture(), "RIGHT", 0, 7)
		s.arrow:SetVertexColor(unpack(pcolor))
		fixTex(s.arrow)

Thanks for the code i'll see if I can figure out how or if it will work.

[Rainrider]

You could probably just use PostUpdate for the power element to change the color of the arrow.

[Sauerkraut]

I'm stumped. I'm sure I am doing something stupid but I can't figure it out. I found and example of a similar postupdate in Dawn's oUF_Nivea but I can't get it to work.

local PostUpdatePower = function(f, event, unit, Power)

	local _, ptype = UnitPowerType("player")
        if(oUF.colors.power[ptype]) then
		r, g, b = unpack(oUF.colors.power[ptype])
	end

	f:SetVertexColor(r, g, b)

end

NM I figured it out. Thanks for the help.

[zork]

@Kraut
There are events to track the druid shapeshift.

Your arrow frame needs to hook them and change it's color accordingly.

The unit powertype colors of oUF are initiated on login.

By the time it loads it may be possible that UnitPowerType("player") still returns nil. But not sure about that. I think it should work, at least UnitClass etc. does.

EVENT: UNIT_DISPLAYPOWER "Fired when the unit's mana stype is changed. Occurs when a druid shapeshifts as well as in certain other cases." http://wowprogramming.com/docs/events/UNIT_DISPLAYPOWER

Basically...register the event to your arrow frame and then call UnitPowerType player and set the color of the arrow.

I recommend registering PLAYER_LOGIN aswell. By that time the function will be working and you should be able to set the color correctly.

Sth like this should work...

--set color
  lib.setArrowColor = function(self)
    local _, pType = UnitPowerType("player")
    local pcolor = oUF.colors.power[pType] or {.3,.45,.65}
    self.arrow:SetVertexColor(unpack(pcolor))
  end
  
  --hook events  
  self:RegisterEvent("PLAYER_LOGIN", lib.setArrowColor)
  self:RegisterEvent("PLAYER_ENTERING_WORLD", lib.setArrowColor)
  self:RegisterEvent("UNIT_DISPLAYPOWER", lib.setArrowColor)

~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Btw I found a neat trick for threat coloring (I guess I'm the last one to find out about forceUpdate O_O).
It is awesome because if color is set via self.Health.colorHealth = true then if you don't have aggro the color will stay and the color is updated as soon as any of the events if fired.

--update health func
  lib.updateHealth = function(bar, unit, min, max)
    --color the hp bar in red if the unit has aggro
    if unit and UnitThreatSituation(unit) == 3 then
      bar:SetStatusBarColor(1,0,0)
      if bar.bg then bar.bg:SetVertexColor(1*bar.bg.multiplier,0,0) end
    end   
  end
  
  --check threat
  lib.checkThreat = function(self,event,unit)
    --force an update on the health frame
    self.Health:ForceUpdate()
  end
 
  self.Health.PostUpdate = lib.updateHealth
  self:RegisterEvent("PLAYER_TARGET_CHANGED", lib.checkThreat)
  self:RegisterEvent("UNIT_THREAT_SITUATION_UPDATE", lib.checkThreat)

[Sauerkraut]

Thanks Zork. My way didn't work. Well it works, until you enter combat and try to perform an action. How would I implement your solution. Would I just call it from within the arrow code or would I have to add it in some where else? I'm going to try and play around with it see if I can figure it out. I do appreciate any help you can offer though. I think I'm in way over my head here.

[Sauerkraut]

I either need to start drinking or stop I'm not sure which. I've got the postupdate working. Seems to be doing the job. I've uploaded a short vid to youtube since it is pretty hard to describe exactly what is going on.

If you watch it in 1080p you can see what is going on. The lower resolutions suck.

Oh and I made this video on my really crappy laptop that only gets like 12fps so excuse the crappy quality.

[Rainrider]

Sauerkraut,

in Zork's (and in mine) example you register an event and assign an event handler (that's setArrowColor in Zork's code) to it. You'll just pick the player frame for this. The handler has to be known before you assign it, meaning if you are using one file for all, setArrowColor has to be defined before your style function. If you are using different files, then the file that contains the declaration of setArrowColor has to be loaded before the file with your style function. By style function I mean the function set in oUF:RegisterStyle("style name", style_function). If you use the UnitSpecific table, you could register the event there, else it goes into the style function like this:

if unit == "player" then
    self:RegisterEvent("UNIT_DISPLAYPOWER", lib.setArrowColor)
end

The same for the other events if they are needed.

[Sauerkraut]

Again way over my head. I am amazed anything I write even works. Anyhow using PostUpdate works and seems to be doing exactly what I needed.

local PostUpdatePower = function(Power, unit, min, max)
	local _, ptype = UnitPowerType("player")
        if(oUF.colors.power[ptype]) then
		r, g, b = unpack(oUF.colors.power[ptype])
	end
	Power.arrow:SetVertexColor(r, g, b)
end

		s.PostUpdate = PostUpdatePower

It may not be the most elegant or the best way to do it, but it seems to work.

[Rainrider]

Only using UNIT_DISPLAYPOWER would be better as it is the only one you need (maybe apart from PLAYER_ENTERING_WORLD but you'd rather test this) and it fires a whole lot less that UNIT_POWER. Why does registering the events to the frame not work? Any errors? Could you post your code?

[Sauerkraut]

Well I finally figured out what I was doing wrong. I was trying to put the registerevent lines into the creation code for the arrow rather than in the layout code. If that makes sense. Anyhow it is working. Final code looks like this:

in my lib.lua file

--set color
lib.setArrowColor = function(self)
	local _, pType = UnitPowerType("player")
	local pcolor = oUF.colors.power[pType] or {.3,.45,.65}
	self.Power.arrow:SetVertexColor(unpack(pcolor))
end

in the player section of my core.lua file

		self:RegisterEvent("PLAYER_LOGIN", lib.setArrowColor)
		self:RegisterEvent("PLAYER_ENTERING_WORLD", lib.setArrowColor)
		self:RegisterEvent("UNIT_DISPLAYPOWER", lib.setArrowColor)

Big thanks to both of you for helping. I get my head so twisted up some times I think I over complicate things. This code seems much faster for the updates.

New question now, can I use the same sort of RegisterEvent in a tag? It seems now that if my power bar is at full (say in cat form full energy) and I switch to caster form (full mana) it still shows 100 (energy) rather than 6.0k (mana).

[zork]

Isn't that exactly what I wrote?

Dawn wrote it in the other thread and oUF_Simple2 has a tag tutorial aswell.

Coypied from Dawn

local MAELSTROM_WEAPON = GetSpellInfo(53817)
oUF.Tags["maelstrom"] = function(unit)
    if unit == "player" then
        local name, _, icon, count = UnitBuff("player", MAELSTROM_WEAPON)
        return name and count
    end
end 
oUF.TagEvents["maelstrom"] = "UNIT_AURA UNIT_HEALTH"

The "UNIT_AURA UNIT_HEALTH" part is where you have your events that will call the tag.

[Sauerkraut]

Originally Posted by zork Isn't that exactly what I wrote?

Yes and thank you. I was frustrated and lost my focus. Things just didn't want to line up yesterday. When I went back to it after a couple hours I saw the errors I had made and it finally clicked. I really appreciate your help and patience Zork. Thank you.

[Coldkil]

I have a similar problem with druids. (i hate they multiple forms)

I have made the combobar as a simple frame with 5 text strings, that stay at .2 alpha when not up, then go at alpha 1 when the combo builds up.

The fact is that i want to register the shapeshift events for make them disappear completely when the druid isn't in cat form.

Same would be good for eclipse bar, displaying it only when in moonkin form.

Is it possible or it's something that i canot achieve? thanks.

[Mischback]

Originally Posted by Coldkil The fact is that i want to register the shapeshift events for make them disappear completely when the druid isn't in cat form.

No you don't want to do this, because there are some quests, spots where you will need Combo-Point-display, even if you're not cat nor rogue.

You can use the cpoints PostUpdate-mechanism to achieve this (hide, if there is no CP, show if there is at least one).

As for the eclipse-bar: Yes, using a shapeshift event to check if you're in moonkin-form would do the trick, works exactly as you already described it!

[Coldkil]

Ok, can i do that just editing the combopoint_update method? I made a simple edit on the oUF element, from show/hide to .2/1 alpha.

Looking better at the eclipse bar elemnt though, it seems it's already handled, so no problem for that.

Can you give me more details? An example of pseudo code wold be fantastic, i still have some difficulties with lua.

edit: this is what i have done

the original

local cpoints = self.CPoints
	for i=1, MAX_COMBO_POINTS do
		if(i <= cp) then
			cpoints[i]:Show()
		else
			cpoints[i]:Hide()
		end
	end

my edit

local cpoints = self.CPoints
	for i=1, MAX_COMBO_POINTS do
		if(i <= cp) then
			cpoints[i]:SetAlpha(1)
		else
			cpoints[i]:SetAlpha(.2)
		end
	end

[Mischback]

Originally Posted by Coldkil I have a similar problem with druids. (i hate they multiple forms) I have made the combobar as a simple frame with 5 text strings, that stay at .2 alpha when not up, then go at alpha 1 when the combo builds up. The fact is that i want to register the shapeshift events for make them disappear completely when the druid isn't in cat form. Same would be good for eclipse bar, displaying it only when in moonkin form. Is it possible or it's something that i canot achieve? thanks.

No, I didn't want to suggest an altering of oUF's core! At least not on parts, that are working perfectly.
On the other hand, the cpoints-module doesn't include a PostUpdate (hint at haste!), so you'll have to put some effort into it!

Go and style your CPoints in your layout as you want them to be. Don't include any conditions to them, though.

The oUF-module DOES include the possibility to override the original update-function, and this would be the way to go!

You can merely use, what you already got and put it into a function inside of your layout

local function CPointsOverride(self, event, unit)
        if (unit == 'pet') then return end
    local cp = nil
    if(UnitHasVehicleUI'player') then
        cp = GetComboPoints('vehicle', 'target')
    else
        cp = GetComboPoints('player', 'target')
    end
 
        local cpoints = self.CPoints
        if (cp) then
                cpoints:Show()
            for i=1, MAX_COMBO_POINTS do
                if(i <= cp) then
                    cpoints[i]:SetAlpha(1)
                else
                    cpoints[i]:SetAlpha(0.2)
                end
            end
        else
                cpoints:Hide()
        end
end

This way, you're getting your CPoints shown everytime, when CPoints are on the target, regardless of your class. If there is at least one combo point, the whole element is shown and updated as you want it with the alpha settings.

Note: You don't have to include those cpoints:Show() / :Hide() stuff, it would be my approach.
If you want your CPoints always visible if you're in cat-form or on an rogue, just show them all the time (rogue) or if you're in cat (drood).

Create a frame and register the "UPDATE_SHAPESHIFT_FORM"-event and apply a script to this event

local function ShapeshiftControl()
    if (currentform == CAT) then
        ShowCPoints()
    else
        HideCPoints()
    end
end

This is of course pseudo-code, you will have to fill it with life.

edit: Second approach is easily modified to handle eclipse-bar, too!

[Coldkil]

Thanks a lot. That was the thing i was searching for. Gonna give it a try this night.

Anyway, since eclipse bar is already handled in this way by default and, in fact, it could be useful to keep track of combo points even if not in cat form (i'm thinking about feral PvP, dunno if it's really useful) i think i'll fiollow your approach.

It's simple, easily understandable for the ones who likes to edit lua, and works well.

Thanks again.

[Mischback]

Glad I could help you!

In fact, I'm currently working on this problem myself, so here's my override:

core.CPointOverride = function(self, event, unit)
    if ( unit == 'pet' ) then return end
 
    local cp
    if ( UnitHasVehicleUI('player') ) then
        cp = GetComboPoints('vehicle', 'target')
    else
        cp = GetComboPoints('player', 'target')
    end
 
    local cpoints = self.CPoints
    if ( cp > 0 ) then
        cpoints:Show()
        self.Debuffs:SetPoint('BOTTOM', cpoints, 'TOP', 0, 7)
        for i=1, MAX_COMBO_POINTS do
            if( i <= cp ) then
                cpoints[i]:SetAlpha(1)
            else
                cpoints[i]:SetAlpha(0.35)
            end
        end
    else
        cpoints:Hide()
        self.Debuffs:SetPoint('BOTTOM', self, 'TOP', 0, 10)
    end
end

Note that I'm moving my Debuffs with this, you should erase these lines!