Thread Tools Display Modes
Unread 07-20-12, 04:41 PM   #1
Mikord
A Theradrim Guardian
AddOn Author - Click to view addons
Join Date: Jul 2006
Posts: 61
ENVIRONMENTAL_DAMAGE Event Type Changed

The ENVIRONMENTAL_DAMAGE sub-event of COMBAT_EVENT_LOG_UNFILTERED has been changed from reporting an unlocalized hazard type token to a localized value. While this probably won't affect very many addons (luckily it doesn't affect MSBT since it just reports the localized value anyways), it does make it difficult to detect a specific type of environmental damage.

As detailed on wowpedia here it previously returned tokens such as "FALLING" and "DROWNING" making it easy to detect specific types of environmental damage in a language independent manner.
Mikord is offline  
Unread 08-17-12, 01:30 PM   #2
semlar
A Molten Giant
 
semlar's Avatar
AddOn Author - Click to view addons
Join Date: Sep 2007
Posts: 596
The localized environmental damage strings appear to be in the GlobalStrings.lua file, if you need to compare them.

Code:
ACTION_ENVIRONMENTAL_DAMAGE = "damaged";
ACTION_ENVIRONMENTAL_DAMAGE_DROWNING = "Drowning";
ACTION_ENVIRONMENTAL_DAMAGE_FALLING = "Falling";
ACTION_ENVIRONMENTAL_DAMAGE_FATIGUE = "Fatigue";
ACTION_ENVIRONMENTAL_DAMAGE_FIRE = "Fire";
ACTION_ENVIRONMENTAL_DAMAGE_LAVA = "Lava";
ACTION_ENVIRONMENTAL_DAMAGE_SLIME = "Slime";

STRING_ENVIRONMENTAL_DAMAGE_DROWNING = "Drowning";
STRING_ENVIRONMENTAL_DAMAGE_FALLING = "Falling";
STRING_ENVIRONMENTAL_DAMAGE_FATIGUE = "Fatigue";
STRING_ENVIRONMENTAL_DAMAGE_FIRE = "Fire";
STRING_ENVIRONMENTAL_DAMAGE_LAVA = "Lava";
STRING_ENVIRONMENTAL_DAMAGE_SLIME = "Slime";

Last edited by semlar : 08-17-12 at 01:33 PM.
semlar is offline  
Unread 08-21-12, 01:25 PM   #3
Meorawr
A Chromatic Dragonspawn
AddOn Author - Click to view addons
Join Date: Nov 2010
Posts: 193
As an update, the argument isn't a localised value - it's simply not capitalised. Checked this just by just logging into the beta with the french client where, for falling damage, the value is still "Falling", but ACTION_ENVIRONMENTAL_DAMAGE_FALLING is "Chute".

Someone with a lot of time on their hands could try that with all localisations, if they want to be really sure.

Last edited by Meorawr : 08-21-12 at 01:37 PM.
Meorawr is offline  
Unread 08-22-12, 06:13 AM   #4
semlar
A Molten Giant
 
semlar's Avatar
AddOn Author - Click to view addons
Join Date: Sep 2007
Posts: 596
Well that's good to know. On the other hand, if you do want to convert to the localized string you could use one of the globals
semlar is offline  
 

Go BackWoWInterface » WoD Beta » MoP archived threads » ENVIRONMENTAL_DAMAGE Event Type Changed

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

vB code is On
Smilies are On
[IMG] code is On
HTML code is Off