Combo Points (and related class powers)

[Senit24]

For days, I've been working on creating class class power (specifically combo points) bars. I'm working off some code from another layout. I've tried modifying it numerous ways, but I just can't get any result. I'm not getting any errors, it's just displaying nothing. Can anyone help me find a good sample, or solution to my problem?

Current code: --The function lib.genCPoints being called by my TargetStyle function, obviously.

do
	ComboDisplay = function(self, event, unit)
		if(unit == 'pet') then return end
		
		local cpoints = self.CPoints
		local cp
		if (UnitHasVehicleUI("player") or UnitHasVehicleUI("vehicle")) then
			cp = GetComboPoints('vehicle', 'target')
		else
			cp = GetComboPoints('player', 'target')
		end

		for i=1, MAX_COMBO_POINTS do
			if(i <= cp) then
				cpoints[i]:SetAlpha(1)
			else
				cpoints[i]:SetAlpha(0.15)
			end
		end
		
		if cpoints[1]:GetAlpha() == 1 then
			for i=1, MAX_COMBO_POINTS do
				cpoints[i]:Show()
			end
			
		else
			for i=1, MAX_COMBO_POINTS do
				cpoints[i]:Hide()
			end
			
		end
	end
end

lib.genCPoints = function(self)
	local bars = CreateFrame("Frame", nil, self)
	bars:SetPoint("BOTTOMLEFT", oUF_Player, "TOPLEFT", 0, 7)
	bars:SetWidth(210)
	bars:SetHeight(2)
	bars:SetBackdrop(backdrop)
	bars:SetBackdropBorderColor(0,0,0,0)
	bars:SetBackdropColor(0,0,0,0)
		
	for i = 1, 5 do		
	
		bars[i] = CreateFrame("StatusBar", self:GetName().."_Combo"..i, bars)
		bars[i]:SetHeight(20)					
		bars[i]:SetStatusBarTexture(config.statusbar_texture)
		bars[i]:GetStatusBarTexture():SetHorizTile(false)
							
		if i == 1 then
			bars[i]:SetPoint("LEFT", bars)
		else
			bars[i]:SetPoint("LEFT", bars[i-1], "RIGHT", 1, 0)
		end
		bars[i]:SetAlpha(1)
		bars[i]:SetWidth((210 - 4)/5)
	end
		
	bars[1]:SetStatusBarColor(0.69, 0.31, 0.31)		
	bars[2]:SetStatusBarColor(0.69, 0.31, 0.31)
	bars[3]:SetStatusBarColor(0.65, 0.63, 0.35)
	bars[4]:SetStatusBarColor(0.65, 0.63, 0.35)
	bars[5]:SetStatusBarColor(0.33, 0.59, 0.33)
		
	self.CPoints = bars
	self.CPoints.Override = ComboDisplay
		
	bars.FrameBackdrop = CreateFrame("Frame", nil, bars[1])
	bars:SetBackdrop(backdrop)
	bars.FrameBackdrop:SetBackdropBorderColor(0,0,0,1)
	bars.FrameBackdrop:SetPoint("TOPLEFT", bars, "TOPLEFT", -1, 1)
	bars.FrameBackdrop:SetPoint("BOTTOMRIGHT", bars, "BOTTOMRIGHT", 1, -1)
	bars.FrameBackdrop:SetFrameLevel(bars:GetFrameLevel() - 1)
end

[Phanx]

Erm, I have no idea why you're defining that ComboDisplay function and using it as an element Override, when it's functionally identical to oUF's standard combo point update function, but contains a lot of unnecessary redundancy. You set the alpha to 15% and then hide the frame, instead of just hiding it, for example. Try getting rid of the Override and see if it works then.

I also don't understand what you're trying to do with the bars.FrameBackdrop section at the end of the block you posted. It's just an extra frame, attached to the bars frame, with no visible anything, since you call SetBackdrop on bars instead of bars.FrameBackdrop, and anyway you're setting the same backdrop that you already set on bars, so even if you did set it on the bars.FrameBackdrop frame, you'd only see 1 pixel of it around the edges since the frames are stacked on top of each other. I'd suggest just getting rid of the whole thing. If you want a 1px border on the bars frame, just change its backdrop to include a 1px border, eg:

local backdrop = {
    bgFile = "Interface\\BUTTONS\\WHITE8X8", tile = true, tileSize = 8,
    edgeFIle = "Interface\\BUTTONS\\WHITE8X8", edgeSize = 1,
    insets = { left = 1, right = 1, top = 1, bottom = 1 },
}

Finally, your genCPoints function parents bars to self, but anchors it to oUF_Player. If multiple frames call genCpoints, you'll end up with multiple objects piled on top of each other. I'd also suggest combo points be attached to the target frame, rather than the player frame. Not only does that give you more room on the player frame for class powers, but combo points also logically belong on the target, at least for druids, who can have different numbers of combo points on different targets at the same time.

Try this:

lib.genCPoints = function(self)
    local bars = CreateFrame("Frame", nil, self)
    bars:SetPoint("BOTTOMLEFT", self, "TOPLEFT", 0, 7)
        -- ^^^ Attach to self, and then just call this function from the
        --     frame you actually want it attached to, probably target.
    bars:SetWidth(210)
    bars:SetHeight(2)
    bars:SetBackdrop(backdrop)
    bars:SetBackdropBorderColor(0,0,0,0)
    bars:SetBackdropColor(0,0,0,0)
 
    for i = 1, 5 do
        bars[i] = CreateFrame("StatusBar", nil, bars)
            -- ^^^ No reason to give this a global name.
        bars[i]:SetWidth(41.2) -- (210 - 4) / 5
            -- ^^^ No need to do the math on the fly since it isn't dynamic.
        bars[i]:SetHeight(20)
        bars[i]:SetStatusBarTexture(config.statusbar_texture)
        bars[i]:GetStatusBarTexture():SetHorizTile(false)
        if i == 1 then
            bars[i]:SetPoint("LEFT", bars)
        else
            bars[i]:SetPoint("LEFT", bars[i-1], "RIGHT", 1, 0)
        end
    end
 
    bars[1]:SetStatusBarColor(0.69, 0.31, 0.31)
    bars[2]:SetStatusBarColor(0.69, 0.31, 0.31)
    bars[3]:SetStatusBarColor(0.65, 0.63, 0.35)
    bars[4]:SetStatusBarColor(0.65, 0.63, 0.35)
    bars[5]:SetStatusBarColor(0.33, 0.59, 0.33)
 
    self.CPoints = bars
end

[Senit24]

It works great! The original was a rough copy of "oUF_Qulight", hence the redundancy and misfit calls and functions.

As always, thank you Phanx, for you are the reason my UI works. I'm sure you'll be all over the credits :)

[Senit24]

After hours of coding, I am more confused than I was to begin with. (Trying to create Warlock Power Bars).
What I wrote for soul shards seems to work:

UpdateShards = function(self, event, unit, powerType)
    if(self.unit ~= unit or (powerType and powerType ~= 'SOUL_SHARDS')) and (GetSpecialization() ~= SPEC_WARLOCK_AFFLICTION) then return end
        local maxshards = 3
            for i = 1, GetNumGlyphSockets() do
            local glyphID = select(4, GetGlyphSocketInfo(i))
                if glyphID == 63302 then maxshards = 4 end  
        
            local num = UnitPower(unit, SPELL_POWER_SOUL_SHARDS)
            for i = 1, maxshards do
                if(i <= num) then
                    self.SoulShards[i]:SetAlpha(1)
                else
                    self.SoulShards[i]:SetAlpha(0)
                end     
            end
    end
end

I tried doing the same thing for burning embers, but with no success. Does this function only work because self.SoulShards is predefined in oUF elements? Does this mean I need to write a new element for Embers/Fury/ShadowOrbs/Monks etc?

[Phanx]

You must be working with an old version of oUF... get the current one from Haste's GitHub repo:
https://github.com/haste/oUF

There aren't separate elements for Soul Shards, Holy Power, etc. anymore. Instead, all of the class powers that are displayed like combo points are combined into the ClassIcons element. It covers Harmony Orbs (chi), Holy Power, Shadow Orbs, and Soul Shards. If you look at the top of the classicons.lua element file, you'll see an example. You shouldn't need to change much; mainly changing the name of the element from SoulShards to ClassIcons, getting rid of your separate HolyPower element if you have one, and if your layout uses custom textures, add a class check when you're setting up the ClassIcons element to set the appropriate textures.

Here's the ClassIcons example from the oUF/elements/classicons.lua file:

   local ClassIcons = {}
   for index = 1, 5 do
      local Icon = self:CreateTexture(nil, 'BACKGROUND')
   
      -- Position and size.
      Icon:SetSize(16, 16)
      Icon:SetPoint('TOPLEFT', self, 'BOTTOMLEFT', index * Icon:GetWidth(), 0)
   
      ClassIcons[index] = Icon
   end
   
   -- Register with oUF
   self.ClassIcons = ClassIcons

You don't need to worry about defining your own Update function for the element; oUF takes care of everything. It does support PreUpdate, PostUpdate, and Override methods though, if you want to change how the element updates. I'd recommend using PostUpdate, and changing only the things you want to change, instead of definining an Override and having to do all the work yourself.

The other warlock powers -- Burning Embers and Demonic Fury -- are not yet supported by oUF itself, but Haste is working on a ClassBars element that will cover those plus all other class powers that have fill values or durations. If you want to support them in the meantime, you'll have to either write your own element, or use Tukz' oUF Warlock Spec Bars plugin. If you're writing your own, feel free to look at the WarlockPower.lua file in oUF Phanx for an example.

[Senit24]

Yep. Mine was outdated; I'll get the new one. Great info as always!

p.s. I'm very close to finished with my oUF Layout. I'll be sure to post the finished product, then I can start contributing to the other lua newbs!

Edit: Dun broke the entire addon... where to start...

Edit 2: Seems like everything's working except "oUF.TagEvents", know what's up with that?

Seems like the change from

oUF.Tags = tags
oUF.TagEvents = tagEvents
oUF.UnitlessTagEvents = unitlessEvents

to

oUF.Tags = {
	Methods = tags,
	Events = tagEvents,
	SharedEvents = unitlessEvents,

}

would indicate that I need to change "oUF.Tags" to "Methods" and "oUF.TagEvents" to "Events", is there more to it than that?

Edit 3: Nevermind, figured it out! oUF.Tags.Methods and oUF.Tags.Events. Hope this helps anyone else reading!

[Senit24]

Okay -- I finally had a chance to look this over and this was my result for holy power (not working):

lib.genHoly = function(self)
    if select(2, UnitClass("player")) ~= "PALADIN" then return end
    local ClassIcons = {}
    for i = 1, 3 do
        local Icon = CreateFrame("StatusBar", nil, ClassIcons)
        Icon:SetSize(20, 20)
        Icon:SetPoint("BOTTOMLEFT", self, "TOPLEFT", 0, 7)
        Icon:SetStatusBarTexture(config.statusbar_texture)
        Icon:GetStatusBarTexture():SetHorizTile(false)
        Icon:SetBackdrop(backdrop)
        Icon:SetBackdropColor(0,0,0,1)
        if i == 1 then
            ClassIcons[i]:SetPoint("LEFT", ClassIcons)
        else
            ClassIcons[i]:SetPoint("LEFT", ClassIcons[i-1], "RIGHT", 10, 0)
        end
        ClassIcons[i] = Icon
    end
     
    ClassIcons[1]:SetStatusBarColor(0.69, 0.31, 0.31)
    ClassIcons[2]:SetStatusBarColor(0.69, 0.31, 0.31)
    ClassIcons[3]:SetStatusBarColor(0.65, 0.63, 0.35)
 
   self.ClassIcons = ClassIcons
end

I feel like it's still over complicated, but I'm not sure where to put the frame options in the example given. I must be functionally retarded. How do!?

[Phanx]

I'm not sure what "frame options" you mean, but there are a couple issues with your code.

For one, oUF expects 5 objects, not 3, so you should be getting errors from that. Paladins start out with a max of 3 holy power, but gain an additional 2 (for a total of 5) from the Boundless Conviction passive ability at level 85. oUF will automatically hide the ones that aren't currently in use.

Also, oUF will try to call :SetVertexColor on your objects; since StatusBar objects don't have this method, this should trigger another error unless you remap it to SetStatusBarColor (if you want oUF to color your objects) or a dummy function (if you don't).

Make sure you have BugSack or Swatter or something running when you're working on addons; it will make your life a lot easier.

Try this. It will make sure the last holy power is always the one with the different color, and stop oUF from setting its own holy power color.

local noop = function() return end

local HolyPostUpdate = function(icons, cur, max, changed)
	for i = 1, 5 do
		if i == max then
			ClassIcons[i]:SetStatusBarColor(0.65, 0.63, 0.35)
		else
			ClassIcons[i]:SetStatusBarColor(0.69, 0.31, 0.31)
		end
	end
end

lib.genHoly = function(self)
	if select(2, UnitClass("player")) ~= "PALADIN" then return end
	local ClassIcons = {}
	for i = 1, 5 do
		local Icon = CreateFrame("StatusBar", nil, ClassIcons)
		Icon:SetSize(20, 20)
		Icon:SetPoint("BOTTOMLEFT", self, "TOPLEFT", 0, 7)
		Icon:SetStatusBarTexture(config.statusbar_texture)
		Icon:GetStatusBarTexture():SetHorizTile(false)
		Icon:SetBackdrop(backdrop)
		Icon:SetBackdropColor(0,0,0,1)
		-- Map the method oUF tries to call to one that actually exists:
		Icon.SetVertexColor = noop
		if i == 1 then
			ClassIcons[i]:SetPoint("LEFT", ClassIcons)
		else
			ClassIcons[i]:SetPoint("LEFT", ClassIcons[i-1], "RIGHT", 10, 0)
		end
		ClassIcons[i] = Icon
	end
	ClassIcons.PostUpdate = HolyPostUpdate
	self.ClassIcons = ClassIcons
end

If you want to let oUF color the bars, change:

Icon.SetVertexColor = noop

to:

Icon.SetVertexColor = Icon.SetStatusBarColor

... and feel free to delete the noop function definition.

[Senit24]

So I got BugSack, which is fairly more informative than the regular lua error reports. Anyway, I seem to have a circle of errors with this function:

lib.genHoly = function(self)
	if select(2, UnitClass("player")) ~= "PALADIN" then return end
	local ClassIcons = {}
	for i = 1, 5 do
		local Icon = CreateFrame("StatusBar", nil, ClassIcons)
		Icon:SetSize(20, 20)
		Icon:SetPoint("BOTTOMLEFT", self, "TOPLEFT", 0, 7)
		Icon:SetStatusBarTexture(config.statusbar_texture)
		Icon:GetStatusBarTexture():SetHorizTile(false)
		Icon:SetBackdrop(backdrop)
		Icon:SetBackdropColor(0,0,0,1)
		-- Map the method oUF tries to call to one that actually exists:
		Icon.SetVertexColor = noop
		if i == 1 then
		       ClassIcons[i]:SetPoint("LEFT", ClassIcons)
		else
		       ClassIcons[i]:SetPoint("LEFT", ClassIcons[i-1], "RIGHT", 10, 0)
		end
		ClassIcons[i] = Icon
	end
	ClassIcons.PostUpdate = HolyPostUpdate
	self.ClassIcons = ClassIcons
end

The CreateFrame is telling me it "can't find "this" in parent object", but when I try to change it then it breaks the last two highlighted lines.

[haste]

Originally Posted by Senit24 So I got BugSack, which is fairly more informative than the regular lua error reports.

The default error handler is superb now. I though BugSack only provided coloring and logging these days.

Originally Posted by Senit24 The CreateFrame is telling me it "can't find "this" in parent object", but when I try to change it then it breaks the last two highlighted lines.

You're anchoring your frame to a table, that won't work. You either need to anchor it to the frame or calculate out the position like the example does.

[Phanx]

Originally Posted by haste The default error handler is superb now. I though BugSack only provided coloring and logging these days.

The default error handler does not showing errors that occur during the initial loading process. Since 90% of the errors I've ever seen while developing addons occur during loading, that makes it superbly worthless.

[haste]

Odd, I've always had that problem with custom error handlers :P.

[Talyrius]

BugSack is able to capture loading errors, because it uses a separate module (!BugGrabber) that is loaded ahead of other addons (! precedes A-Z).

[Rainrider]

Addons are not always loaded alphabetically as far as I know. I depends on the operating system and on what dependencies the individual .toc files contain. WoW just loads addons starting with ! prior to others.

[Phanx]

Addons are loaded alphabetically on NTFS filesystems, which, as the filesystem used by Windows, covers the vast majority of users.

I don't know what the Mac filesystem does, or Linux filesystems...

[Rainrider]

World of Warcraft Programming (Second Edition), p. 141, 6a:

If the addon is dependent on any other addons and they are not currently loaded, load them first in an order that is dependent on the operating system (some are alphabetic, others are by date created).

P.S: Would this mean we can't catch load errors form !BlizzBugsSuck because !BugGrabber is loaded later?

[Senit24]

Okay... let me be more precise.
I'm getting the error, "CreateFrame: Couldn't find "this" in parent object" on this line.
However, if I change it, I get the error, "attempt to index field "?" (a nil value)" here.

lib.genHoly = function(self)
	if select(2, UnitClass("player")) ~= "PALADIN" then return end
	local ClassIcons = {}
	for i = 1, 5 do
                local Icon = CreateFrame("StatusBar", nil, ClassIcons)
		Icon:SetSize(20, 20)
		Icon:SetPoint("BOTTOMLEFT", self, "TOPLEFT", 0, 7)
		Icon:SetStatusBarTexture(config.statusbar_texture)
		Icon:GetStatusBarTexture():SetHorizTile(false)
		Icon:SetBackdrop(backdrop)
		Icon:SetBackdropColor(0,0,0,1)
		-- Map the method oUF tries to call to one that actually exists:
		Icon.SetVertexColor = noop
		if i == 1 then
			ClassIcons[i]:SetPoint("LEFT", ClassIcons)
		else
			ClassIcons[i]:SetPoint("LEFT", ClassIcons[i-1], "RIGHT", 10, 0)
		end
		ClassIcons[i] = Icon
	end
	ClassIcons.PostUpdate = HolyPostUpdate
	self.ClassIcons = ClassIcons
end

Sorry if I'm asking for too complex of an explanation, but I'm still not getting this. What should I set as the parent frame?

[Phanx]

The parent frame must actually be a frame. You are currently passing ClassIcons, which is a table, not a frame. Similarly, you cannot use SetPoint to position things relative to a table, because a table does not have any position or of the other "physical" attributes a frame has.

The easiest solution would be to make ClassIcons a frame, like the combo point holder is:

local noop = function() return end

lib.genHoly = function(self)
	if select(2, UnitClass("player")) ~= "PALADIN" then return end

	local ClassIcons = CreateFrame("Frame", nil, self)
	ClassIcons:SetPoint("BOTTOMLEFT", self, "TOPLEFT", 0, 7)
	ClassIcons:SetSize(140, 20) -- 5 icons * 20 width + 4 spaces * 10 width

	-- Optional, to match the combo points:
	bars:SetBackdrop(backdrop)
	bars:SetBackdropBorderColor(0,0,0,0)
	bars:SetBackdropColor(0,0,0,0)

	for i = 1, 5 do
		local Icon = CreateFrame("StatusBar", nil, ClassIcons)
		Icon:SetSize(20, 20)

		-- You do not need a SetPoint line here, because you have some
		-- later that just override the one that was here.	

		Icon:SetStatusBarTexture(config.statusbar_texture)
		Icon:GetStatusBarTexture():SetHorizTile(false)

		Icon:SetBackdrop(backdrop)
		Icon:SetBackdropColor(0,0,0,1)

		-- Map the method oUF tries to call to one that actually exists:
		Icon.SetVertexColor = noop

		if i == 1 then
			Icon:SetPoint("LEFT", ClassIcons)
		else
			Icon:SetPoint("LEFT", ClassIcons[i-1], "RIGHT", 10, 0)
		end
		ClassIcons[i] = Icon
	end

	ClassIcons.PostUpdate = HolyPostUpdate
	self.ClassIcons = ClassIcons
end

[Senit24]

Thanks so much Phanx, it's working again! I made a couple modifications. Also got rid of the post update entirely.

lib.genHoly = function(self)
	if select(2, UnitClass("player")) ~= "PALADIN" then return end

	local ClassIcons = CreateFrame("Frame", nil, self)
	ClassIcons:SetPoint("BOTTOMLEFT", self, "TOPLEFT", 0, 7)
	ClassIcons:SetSize(140, 20) -- 5 icons * 20 width + 4 spaces * 10 width
	
	for i = 1, 5 do
		local Icon = CreateFrame("StatusBar", nil, ClassIcons)
		Icon:SetSize(20, 20)

		-- You do not need a SetPoint line here, because you have some
		-- later that just override the one that was here.	

		Icon:SetStatusBarTexture(config.statusbar_texture)
		Icon:GetStatusBarTexture():SetHorizTile(false)

		Icon:SetBackdrop(backdrop)
		Icon:SetBackdropColor(0,0,0,1)

		-- Map the method oUF tries to call to one that actually exists:
		Icon.SetVertexColor = noop

		if i == 1 then
			Icon:SetPoint("LEFT", ClassIcons)
		else
			Icon:SetPoint("LEFT", ClassIcons[i-1], "RIGHT", 10, 0)
		end
		ClassIcons[i] = Icon
	end

	ClassIcons[1]:SetStatusBarColor(0.69, 0.31, 0.31)
    ClassIcons[2]:SetStatusBarColor(0.69, 0.31, 0.31)
    ClassIcons[3]:SetStatusBarColor(0.65, 0.63, 0.35)
    ClassIcons[4]:SetStatusBarColor(0.69, 0.31, 0.31)
    ClassIcons[5]:SetStatusBarColor(0.65, 0.63, 0.35)
	
	--ClassIcons.PostUpdate = HolyPostUpdate
	self.ClassIcons = ClassIcons
end

[dartz]

thank you Phanx, you solved my problem too.