Combo Points (and related class powers)

[MoonWitch]

Originally Posted by Phanx Addons are loaded alphabetically on NTFS filesystems, which, as the filesystem used by Windows, covers the vast majority of users. I don't know what the Mac filesystem does, or Linux filesystems...

I use a Mac (and a Windows machine btw).
Basically the alphabetical part stands on Mac as well. Since you can't play WoW natively on Linux, you'd be stuck with Wine or a VM with Mac OS X/Windows, you'd end up with the default situation.

And god I need to go to bed NOW. :P

[Paopao001]

Hello.
I would like to change the width of each class icon when the max number of the resource changes.

local ClassIconsPostUpdate = function(element, cur, max, maxchange)
    for i = 1, 5 do
        if cur == max then
            element[i]:SetStatusBarColor(unpack(classicon_colors[cur]))
        else
            element[i]:SetStatusBarColor(unpack(classicon_colors[i]))
        end
        if maxchange then
            element[i]:SetWidth((oUF_MlightDB.width+3)/max-3)
        end     
    end
end

local _, class = UnitClass("player")
        
        -- Runes, Shards, HolyPower and so on --
        if multicheck(class, "DEATHKNIGHT", "WARLOCK", "PALADIN", "MONK", "SHAMAN", "PRIEST", "MAGE", "ROGUE", "DRUID") then
            local count
            if class == "DEATHKNIGHT" then 
                count = 6
            elseif class == "WARLOCK" then
                count = 4
            elseif class == "PALADIN" or class == "PRIEST" or class == "MONK" then
                count = 5
            elseif class == "SHAMAN" then
                count = 4
            elseif class == "MAGE" then
                count = 6
            elseif class == "ROGUE" or class == "DRUID" then
                count = 5 -- combopoints
            end
 
            local bars = CreateFrame("Frame", nil, self)
            bars:SetPoint("BOTTOMLEFT", self, "TOPLEFT", 0, 3)
            bars:SetSize(oUF_MlightDB.width, 10)
 
            for i = 1, count do
                bars[i] = createStatusbar(bars, texture, nil, oUF_MlightDB.height*-(oUF_MlightDB.hpheight-1), (oUF_MlightDB.width+2)/count-3, 1, 1, 1, 1)
 
                if i == 1 then
                    bars[i]:SetPoint("BOTTOMLEFT", bars, "BOTTOMLEFT")
                else
                    bars[i]:SetPoint("LEFT", bars[i-1], "RIGHT", 3, 0)
                end
 
                bars[i].bd = createBackdrop(bars[i], bars[i], 1)
            end
 
            if class == "DEATHKNIGHT" then
                self.Runes = bars
            elseif class == "WARLOCK" then
                self.WarlockSpecBars = bars
            elseif class == "PALADIN" or class == "PRIEST" or class == "MONK" then
                self.ClassIcons = bars
                self.ClassIcons.UpdateTexture = function() end
                self.ClassIcons.PostUpdate = ClassIconsPostUpdate
            elseif class == "SHAMAN" then
                self.TotemBar = bars
            elseif class == "MAGE" then
                self.ArcaneCharge = bars
            elseif class == "ROGUE" or class == "DRUID" then
                self.CPoints = bars
                self.CPoints.PostUpdate = CpointsPostUpdate
            end
        end

When the max number of power changes, it works properly. But there's a problem when log-in.
If the player is shadow priest. The width of each element is 1/5 of the width of player frame.
I would like it to be 1/3. A paladin under lvl 85 ,a warlock with 3 soul shards and a monk with 4 chis got the same problem.
The solution I found is to change element.__max to 5 in oUF\elements\classicons.lua(because I can't find a right place to make it in my layout).
This means: when I create the frames/textures for the element, I set the width of each icon suppose the player got 5 class icons. When PLAYER_TALENT_UPDATE fires, oUF update the element and oldMax ~= max is true in element:PostUpdate(cur, max, oldMax ~= max). So the layout can change the width of each icon when log-in.

Haste, I really appreciate if you could set element.__max to 5 in oUF\elements\classicons.lua or make it easier to change element.__max in layout.

[Phanx]

Well, the obvious problem in your login code is that you are dividing the total width by 5, not by 3...

[Paopao001]

Originally Posted by Phanx Well, the obvious problem in your login code is that you are dividing the total width by 5, not by 3...

Then should I divided it by PRIEST_BAR_NUM_ORBS for shadow priest, by 4 for monk, by 3 for warlock, by HOLY_POWER_FULL for paladin? I think that's different from the intent of combine them together in some way.

[Phanx]

Originally Posted by Paopao001 Then should I divided it by PRIEST_BAR_NUM_ORBS for shadow priest, by 4 for monk, by 3 for warlock, by HOLY_POWER_FULL for paladin? I think that's different from the intent of combine them together in some way.

They're only combined into one element so Haste isn't copy/pasting the same code 3+ times and just changing the name. You don't have to treat them all exactly the same, all the time. ShadowOrbs isn't going to get upset if you pick HolyPower first for the team.

Simply updating the width in your PostUpdate should work, though you may need to set some kind of flag on the element, and update the width if it's set even if oUF didn't think the max changed, to catch that initial update:

self.ClassIcons.PostUpdate = ClassIconsPostUpdate
self.ClassIcons.forceUpdate = true

Then, in your ClassIconsPostUpdate function:

if maxchange or element.forceUpdate then
     element.forceUpdate = nil
     element[i]:SetWidth((oUF_MlightDB.width+3)/max-3)

[Rainrider]

You both missed the last argument of the ClassIcons' PostUpdate function, which tells you whether the number of bars changed. Here is what I use for reference:

Register the element:

local AddClassPowerIcons = function(self, width, height, spacing)
    self.ClassIcons = {}
 
    self.ClassIcons.width  = width
    self.ClassIcons.height = height
    self.ClassIcons.spacing = spacing
 
    local maxPower = 5
 
    for i = 1, maxPower do
        self.ClassIcons[i] = self.Overlay:CreateTexture("oUF_Rain_ComboPoint_"..i, "OVERLAY")
        self.ClassIcons[i]:SetSize((width - spacing * (maxPower - 1)) / maxPower, height)
        self.ClassIcons[i]:SetPoint("BOTTOMLEFT", self.Overlay, (i - 1) * self.ClassIcons[i]:GetWidth() + i * spacing, 1)
        self.ClassIcons[i]:SetTexture(ns.media.TEXTURE)
    end
 
    self.ClassIcons.PostUpdate = ns.PostUpdateClassPowerIcons
end
ns.AddClassPowerIcons = AddClassPowerIcons

The PostUpdate function:

local PostUpdateClassPowerIcons = function(element, power, maxPower, maxPowerChanged)
    if (not maxPowerChanged) then return end
 
    local self = element.__owner
    local width = element.width
    local height = element.height
    local spacing = element.spacing
 
    for i = 1, maxPower do
        element[i]:SetSize((width - spacing * (maxPower - 1)) / maxPower, height)
        element[i]:SetPoint("BOTTOMLEFT", self.Overlay, (i - 1) * element[i]:GetWidth() + i * spacing, 1)
    end
end
ns.PostUpdateClassPowerIcons = PostUpdateClassPowerIcons

Add the element to the frame appropriate unit frames:

if (playerClass == "DEATHKNIGHT") then
    ns.AddRuneBar(self, 215, 5, 1)
    ns.AddTotems(self, 60, 5)
elseif (playerClass == "DRUID") then
    ns.AddEclipseBar(self, 230, 7)
    ns.AddTotems(self, 30, 5)
elseif (playerClass == "HUNTER") then
    ns.AddFocusHelper(self)
elseif (playerClass == "MONK") then
    ns.AddClassPowerIcons(self, 215, 5, 1)
elseif (playerClass == "PALADIN") then
    ns.AddClassPowerIcons(self, 215, 5, 1)
elseif (playerClass == "PRIEST") then
    ns.AddClassPowerIcons(self, 215, 5, 1)
elseif (playerClass == "SHAMAN") then
    ns.AddTotems(self, nil, 5)
elseif (playerClass == "WARLOCK") then
    ns.AddWarlockPowerBar(self, 215, 5, 1)
end

Apart from that, adding combo points only for druid and rogue is a bad idea, as other classes can use them too when in vehicle (Aces High! comes to mind)

EDIT: Ouch, Phanx got it right of course, I kind of have the annoying habit of reading too fast and thinking to slow. I don't think the call to ForceUpdate is needed, as oUF does this for you when it sets up the unit frame. But I would trust Phanx more than me, so you'd better check.

[Phanx]

Originally Posted by Rainrider You both missed the last argument of the ClassIcons' PostUpdate function, which tells you whether the number of bars changed.

No, I didn't. The problem is that oUF does not consider the number to have changed the first time it updates the element, so you need to set your own flag if you want to run some code when the value changes or if the element is being updated for the first time.

Also, I'm not sure what "call to ForceUpdate" you're referring to. My code never calls the element's ForceUpdate method. Remember that Lua is case-sensitive; "forceUpdate" is not the same as "ForceUpdate", and so both keys -- the former containing my boolean flag, the latter containing oUF's function -- will coexist the same table without any conflicts or any relation to each other.

You're right, though, that combo points should be created for all classes. Many vehicles use them. I don't know about current content since I'm not really playing the game 99% of the time I'm logged in, but there have been encounters in the past (eg. Malygos) where vehicle combo points were critical to being able to use the vehicle successfully.

[Rainrider]

You are right, Phanx.

Wouldn't it be better to just set element.__max = 5 in the ClassIcons' Enable function and not individually in ClassPowerEnable? This way oUF will pick the correct max values on it's initial update and inform the user about the change through PostUpdate.

@@ -155,11 +155,10 @@ do
 			DARK_FORCE = true,
 		}
 
 		ClassPowerEnable = function(self)
 			local element = self.ClassIcons
-			element.__max = 4
 
 			self:RegisterEvent('UNIT_DISPLAYPOWER', Update)
 			self:RegisterEvent('UNIT_POWER_FREQUENT', Update)
 		end
 
@@ -173,11 +172,10 @@ do
 			HOLY_POWER = true,
 		}
 
 		ClassPowerEnable = function(self)
 			local element = self.ClassIcons
-			element.__max = HOLY_POWER_FULL
 
 			self:RegisterEvent('UNIT_DISPLAYPOWER', Update)
 			self:RegisterEvent('UNIT_POWER', Update)
 		end
 
@@ -192,11 +190,10 @@ do
 		}
 		RequireSpec = SPEC_PRIEST_SHADOW
 
 		ClassPowerEnable = function(self)
 			local element = self.ClassIcons
-			element.__max = PRIEST_BAR_NUM_ORBS
 
 			self:RegisterEvent('UNIT_DISPLAYPOWER', Update)
 			self:RegisterEvent('UNIT_POWER_FREQUENT', Update)
 		end
 
@@ -211,11 +208,10 @@ do
 		}
 		RequireSpell = WARLOCK_SOULBURN
 
 		ClassPowerEnable = function(self)
 			local element = self.ClassIcons
-			element.__max = 3
 
 			self:RegisterEvent('UNIT_DISPLAYPOWER', Update)
 			self:RegisterEvent('UNIT_POWER_FREQUENT', Update)
 		end
 
@@ -229,10 +225,11 @@ end
 local Enable = function(self, unit)
 	local element = self.ClassIcons
 	if(not element) then return end
 
 	element.__owner = self
+	element.__max = 5
 	element.ForceUpdate = ForceUpdate
 
 	if(ClassPowerEnable) then
 		if(PlayerClass == 'PRIEST') then
 			self:RegisterEvent('PLAYER_TALENT_UPDATE', Visibility, true)

I could push this to oUF's github repo if you think it would be a better way.

[Phanx]

Maybe, but you'd want to set the initial value to 0 (or some other unlikely value) so that the initial update would also report a change for classes who do actually have 5 icons.

[Rainrider]

Why would that be needed? The layout should create 5 ui widgets and if maxPower happens to be that, than we are good to go and don't have to change anything. Or am I missing something?

[Phanx]

Because if you do that, then you have to duplicate code by setting the widths in two places: once where you create the element, and again in the PostUpdate. If oUF reports a change on the first update, then you only need the code in one place: in the PostUpdate.

[Rainrider]

https://github.com/haste/oUF/pull/156