2 Script Questions

[laukond]

Hello, I would appreciate if you could help me with 2 questions.
http://i.imgur.com/7Ehq2.jpg


1.
As you can see on the screenshot the rested expbar has a bigger height than the not-rested expbar.

I use this code to decrease the height of MainMenuExpBar and I would like it to reduce the width of the rested bar too, but I cannot locate its name:

MainMenuExpBar:SetHeight(5)

I have looked here, but there doesn't seem to be anything about the height:
http://wowprogramming.com/utils/xmlb...ainMenuBar.lua


2.


I searched google for NUM_ADDONS_TO_DISPLAY and stumpled upon the code below.
It attaches AddOn memory usage to the Tracking Button.
Is there a way to make it not generate as much memory usage?

Currently when I am hovering the Tracking Button it keeps updating the usage.
My thought would be to make it only update once, which would reduce the amount of info it passes therefore less usage by itself?

local Stats = CreateFrame('Button')
Stats:SetScript('OnEvent', function(self) self:Load() end)
Stats:RegisterEvent('PLAYER_LOGIN')
 
 
--[[ Startup ]]--
 
function Stats:Load()
    local f = _G['MiniMapTrackingButton']
    f:SetScript('OnEnter', self.OnEnter)
    f:SetScript('OnLeave', self.OnLeave)
    setmetatable(f, {__index = self})
end
 
 
--[[ Stats Frame Widget ]]--
 
local NUM_ADDONS_TO_DISPLAY = GetNumAddOns()
local UPDATE_DELAY = 1
local topAddOns
 
function Stats:OnEnter()
    GameTooltip:SetOwner(self, 'ANCHOR_BOTTOMLEFT', 0, self:GetHeight())
    self:UpdateTooltip()
end
 
function Stats:OnLeave()
    GameTooltip:Hide()
end
 
function Stats:UpdateTooltip()
    --clear topAddOns list
    if topAddOns then
        for i,addon in pairs(topAddOns) do
            addon.value = 0
        end
    else
        topAddOns = {}
        for i=1, NUM_ADDONS_TO_DISPLAY do
            topAddOns[i] = {name = '', value = 0}
        end
    end
 
    --add FPS and latency
    local down, up, latency = GetNetStats()
    local fps = format('FPS: %.1f', GetFramerate())
    local net = format('Ping: %d ms', latency)
 
    GameTooltip:SetOwner(self, 'ANCHOR_BOTTOMLEFT', 0, self:GetHeight())
    GameTooltip:ClearLines()
    GameTooltip:AddDoubleLine(fps, net, 1, 1, 1, 1, 1, 1)
    GameTooltip:AddLine('--------------------------------------------------')
 
    self:UpdateAddonsList(GetCVar('scriptProfile') == '1' and not IsModifierKeyDown())
end
 
function Stats:UpdateAddonsList(watchingCPU)
    if watchingCPU then
        UpdateAddOnCPUUsage()
    else
        UpdateAddOnMemoryUsage()
    end
 
    local total = 0
    for i=1, GetNumAddOns() do
        local value = (watchingCPU and GetAddOnCPUUsage(i)/1000) or GetAddOnMemoryUsage(i)
        local name = (GetAddOnInfo(i))
        total = total + value
 
        for j,addon in ipairs(topAddOns) do
            if value > addon.value then
                for k = NUM_ADDONS_TO_DISPLAY, 1, -1 do
                    if k == j then
                        topAddOns[k].value = value
                        topAddOns[k].name = GetAddOnInfo(i)
                        break
                    elseif k ~= 1 then
                        topAddOns[k].value = topAddOns[k-1].value
                        topAddOns[k].name = topAddOns[k-1].name
                    end
                end
                break
            end
        end
    end
 
    if total > 0 then
        if watchingCPU then
            GameTooltip:AddLine('Addon CPU Usage')
        else
            GameTooltip:AddLine('Addon Memory Usage')
        end
        GameTooltip:AddLine('--------------------------------------------------')
 
        for _,addon in ipairs(topAddOns) do
            if watchingCPU then
                self:AddCPULine(addon.name, addon.value)
            else
                self:AddMemoryLine(addon.name, addon.value)
            end
        end
 
        GameTooltip:AddLine('--------------------------------------------------')
        if watchingCPU then
            self:AddCPULine('Total', total)
        else
            self:AddMemoryLine('Total', total)
        end
    end
    GameTooltip:Show()
end
 
function Stats:AddCPULine(name, secs)
    if secs > 3600 then
        GameTooltip:AddDoubleLine(name, format('%.2f h', secs/3600), 1, 1, 1, 1, 0.2, 0.2)
    elseif secs > 60 then
        GameTooltip:AddDoubleLine(name, format('%.2f m', secs/60), 1, 1, 1, 1, 1, 0.2)
    elseif secs >= 1 then
        GameTooltip:AddDoubleLine(name, format('%.1f s', secs), 1, 1, 1, 0.2, 1, 0.2)
    elseif secs > 0 then
        GameTooltip:AddDoubleLine(name, format('%.1f ms', secs * 1000), 1, 1, 1, 0.2, 1, 0.2)
    end
end
 
function Stats:AddMemoryLine(name, size)
    if size > 1000 then
        GameTooltip:AddDoubleLine(name, format('%.2f mb', size/1000), 1, 1, 1, 1, 1, 0.2)
    elseif size > 0 then
        GameTooltip:AddDoubleLine(name, format('%.2f kb', size), 1, 1, 1, 0.2, 1, 0.2)
    end
end

Taken from https://github.com/Tuller/tullaTweak...ster/stats.lua

Any help is appreciated. Have a good day.

[Phanx]

1. In the Lua file you linked, searching for "GetXPExhaustion" -- the API function that tells you how much rested XP you have -- quickly reveals the Lua function the default UI calls to update the bar, "ExhaustionTick_OnEvent". Looking at the contents of this function, it appears that the rest bar is named named "ExhaustionLevelFillBar". Looking in the corresponding XML file reveals that "ExhaustionLevelFillBar", is actually a texture, not a statusbar, so it will have SetWidth and SetHeight methods, but not SetValue or other frame/statusbar methods.

2. I'm not sure what you mean by "make it not generate as much memory usage". The tooltip just shows you how much memory your addons are using. It doesn't "generate" any memory. If you're seeing your tooltip addon occupy increasing amounts of memory, it's probably because you're generating a new table on every update, which is very expensive and wasteful. You should only create the "topAddOns" table once, outside of the "UpdateTooltip" method. Since the number of table entries (NUM_ADDONS_TO_DISPLAY) never changes you don't even need to clear the table between uses; you can just overwrite the values like you're already doing.

[laukond]

Thanks for your reply Phanx

What I mean by "make it not generate as much memory usage" is:

The above code in 2. uses ~40kb of memory, but when I am hovering the TrackButton its memory usage raises with ~1kb/s. I believe it's doing this because the tooltip keeps updating.

Is there a way to rewrite the code so it does not update the FPS, ping, and memory all the time when hovering the TrackButton?

[SDPhantom]

There are a couple issues I'm seeing. First of all, it's not a good idea to replace the metatable of a frame unless you absolutely need to. Also, you're creating an extra frame that you're not using for any specific purpose that needs a frame. Taking these issues in hand and some further optimizations, here is the code that I'd propose.

--  Settings
local MaxDisplay=5;
local UpdateSpeed=1;
 
--  Init table
local AddonData={};
for i=1,GetNumAddOns() do
    AddonData[i]={ID=i,Name=GetAddOnInfo(i),Value=0};
end
 
--  Format time func
local function AddCPULine(tooltip,name,secs)
    if secs > 3600 then
        tooltip:AddDoubleLine(name,format('%.2f h',secs/3600),1,1,1,1,0.2,0.2);
    elseif secs > 60 then
        tooltip:AddDoubleLine(name,format('%.2f m',secs/60),1,1,1,1,1,0.2);
    elseif secs >= 1 then
        tooltip:AddDoubleLine(name,format('%.1f s',secs),1,1,1,0.2,1,0.2);
    elseif secs > 0 then
        tooltip:AddDoubleLine(name,format('%.1f ms',secs*1000),1,1,1,0.2,1,0.2);
    end
end
 
--  Format memory func
local function AddMemoryLine(tooltip,name, size)
    if size>1000 then
        tooltip:AddDoubleLine(name,format('%.2f mb',size/1000),1,1,1,1,1,0.2);
    elseif size>0 then
        tooltip:AddDoubleLine(name,format('%.2f kb',size),1,1,1,0.2,1,0.2);
    end
end
 
--  GameTooltip calls this OnUpdate if it exists
local LastUpdate=0;
function MiniMapTrackingButton:UpdateTooltip()
--  FPS and latency
    local down,up,latency=GetNetStats();
    local fps=format('FPS: %.1f',GetFramerate());
    local net=format('Ping: %d ms',latency);
 
    GameTooltip:SetOwner(self,"ANCHOR_BOTTOMLEFT",0,self:GetHeight());
    GameTooltip:ClearLines();
    GameTooltip:AddDoubleLine(fps,net,1,1,1,1,1,1);
    GameTooltip:AddLine("--------------------------------------------------");
 
--  Update throttle
    local now=GetTime();
    if now-LastUpdate>UpdateSpeed then
        local watchingCPU=(GetCVar("scriptProfile")=="1" and not IsModifierKeyDown());
 
--      Request game client to update internal cache
        if watchingCPU then
            UpdateAddOnCPUUsage();
        else
            UpdateAddOnMemoryUsage();
        end
 
--      Update data
        local total=0;
        for i,j in ipairs(AddonData) do
            local val=(watchingCPU and GetAddOnCPUUsage(j.ID)/1000 or GetAddOnMemoryUsage(j.ID));
            j.Value=val;
            total=total+val;
        end
 
--      Sort data
        for i=1,#AddonData-1 do
            local max,id=0;
            for j=i+1,#AddonData do
                local val=AddonData[j].Value;
                if val>max then max,id=val,j; end
            end
 
            if AddonData[i].Value<max then
                AddonData[i],AddonData[id]=AddonData[id],AddonData[i];
            end
        end
 
        if watchingCPU then
            GameTooltip:AddLine("Addon CPU Usage");
            GameTooltip:AddLine("--------------------------------------------------");
 
            for i,j in ipairs(AddonData) do
                if i>MaxDisplay then break; end
                AddCPULine(GameTooltip,j.Name,j.Value);
            end
            GameTooltip:AddLine("--------------------------------------------------");
            AddCPULine(GameTooltip,"Total",total);
        else
            GameTooltip:AddLine("Addon Memory Usage");
            GameTooltip:AddLine("--------------------------------------------------");
 
            for i,j in ipairs(AddonData) do
                if i>MaxDisplay then break; end
                AddMemoryLine(GameTooltip,j.Name,j.Value);
            end
            GameTooltip:AddLine("--------------------------------------------------");
            AddMemoryLine(GameTooltip,"Total",total);
        end
    end
    GameTooltip:Show()
end
 
MiniMapTrackingButton:SetScript("OnEnter",function(self)
    GameTooltip:SetOwner(self,"ANCHOR_BOTTOMLEFT",0,self:GetHeight());
    self:UpdateTooltip();
end);
 
MiniMapTrackingButton:SetScript("OnLeave",function() GameTooltip:Hide(); end);

[Phanx]

Originally Posted by laukond Is there a way to rewrite the code so it does not update the FPS, ping, and memory all the time when hovering the TrackButton?

Yes, and I already told you how:

Originally Posted by Phanx If you're seeing your tooltip addon occupy increasing amounts of memory, it's probably because you're generating a new table on every update, which is very expensive and wasteful. You should only create the "topAddOns" table once, outside of the "UpdateTooltip" method. Since the number of table entries (NUM_ADDONS_TO_DISPLAY) never changes you don't even need to clear the table between uses; you can just overwrite the values like you're already doing.

The code SDPhantom posted includes a number of other improvements/optimizations, so you should probably just use that, but you could solve the specific problem you asked about by making the one specific change I suggested (moving the "topAddOns" table creation outside of the "UpdateTooltip" method).

[laukond]

Thank you both for your reply I really appreciate it.

I get this error: "attempt to compare number with string" in this line: (line 71)

if val>max then max,id=val,j; end

Phanx, I am sorry I don't understand how to do as you say
Could you please show me?
I tried moving the topAddOns table a couple of places outside of functions:
Once it would not show AddOn memory usage at all.
Another time the AddOn itself would start at 600kb usage and raise with 120kb/s.

I am really bad a programming, but I believe the AddOn is not creating a new table on every update; it is refilling it. What I want is just to make it not refill.

Offtopic: Do you know a good place for newbies to start learning Lua? A book, website, etc.

Again I really appreciate your help, I am sorry to be so bad at receiving it

[SDPhantom]

Fixed the problem on line 62 of my posted code. I had j.Name being set there too, but removed it in favor of the addon name and ID being loaded into the table at initialization instead of on update. I had forgotten to remove GetAddOnInfo(j.ID) from the value list too.