Thread Tools Display Modes
Unread 03-06-13, 09:02 PM   #1
Trelis
A Murloc Raider
Join Date: Jul 2012
Posts: 5
5.2 combatlog spell order changes

I hope this is the right place to post this even though the changes have gone live. I haven't seen these mentioned in any of the 5.2 lua changelogs I have seen.

Some of the COMBAT_LOG_EVENT spell orders have changed. I have found the following have changed

SPELL_DISPEL
SPELL_AURA_BROKEN
SPELL_AURA_BROKEN_SPELL

For 5.1, the order was: spellid, spellName, spellSchool, extraSpellID, extraSpellName, extraSpellSchool
For 5.2, the order is changed to: extraSpellID, extraSpellName, extraSpellSchool, spellid, spellName, spellSchool

Has anyone else found other events that have changed order?
Trelis is offline  
Unread 03-06-13, 09:37 PM   #2
Phanx
A Pyroguard Emberseer
 
Phanx's Avatar
AddOn Author - Click to view addons
Join Date: Mar 2006
Posts: 4,409
This is a known issue:

Combat log is reporting purges, friendly dispels, and spellsteals backwards.
__________________
Author/maintainer of Grid, PhanxChat, ShieldsUp, and many more.
Troubleshoot an addonTurn any code into an addonMore addon resources
Need help with your code? Post all of your actual code! Attach or paste your files.
Please don’t PM me about addon bugs or code questions. Post a comment or forum thread instead!
Phanx is offline  
Unread 03-09-13, 01:09 AM   #3
oscarucb
A Murloc Raider
 
oscarucb's Avatar
AddOn Author - Click to view addons
Join Date: Jun 2009
Posts: 5
So it's a "known issue", but that doesn't tell us how soon to expect a fix.

Should we be updating addons to interpret spellids in the "new" order or not?
oscarucb is offline  
Unread 03-09-13, 05:26 AM   #4
Phanx
A Pyroguard Emberseer
 
Phanx's Avatar
AddOn Author - Click to view addons
Join Date: Mar 2006
Posts: 4,409
Probably, if you don't want users to complain that your addon is broken, but don't be surprised if Blizzard fixes it 3 days after you update your addon.
__________________
Author/maintainer of Grid, PhanxChat, ShieldsUp, and many more.
Troubleshoot an addonTurn any code into an addonMore addon resources
Need help with your code? Post all of your actual code! Attach or paste your files.
Please don’t PM me about addon bugs or code questions. Post a comment or forum thread instead!
Phanx is offline  
Unread 05-27-13, 03:24 AM   #5
Trelis
A Murloc Raider
Join Date: Jul 2012
Posts: 5
I just thought I should note that this issue is fixed in 5.3 so if you updated for 5.2, you can return to your 5.1 code now.
Trelis is offline  
 

Go BackWoWInterface » WoD Beta » MoP archived threads » 5.2 combatlog spell order changes

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

vB code is On
Smilies are On
[IMG] code is On
HTML code is Off