Reply
 
Thread Tools Display Modes
Old 03-15-13, 05:09 AM   #21
Voxxel
A Black Drake
Join Date: Mar 2009
Posts: 80
Yea, seems we don't need to track Oondasta quest at all since it seems the boss works as the Pre-nerfed Galleon where you were able to loot anytime you find him (because it could happen only once or twice a week)
Voxxel is offline   Reply With Quote
Old 03-15-13, 09:24 AM   #22
p3lim
A Pyroguard Emberseer
 
p3lim's Avatar
AddOn Author - Click to view addons
Join Date: Feb 2007
Posts: 1,176
If we're really minimalizing something this small

Lua Code:
  1. for name, id in pairs{
  2.     Oondasta = 32519,
  3.     Galleon = 32098,
  4.     Nalak = 32518,
  5.     Sha = 32099
  6. } do
  7.     print(name, IsQuestFlaggedCompleted(id))
  8. end
Lua Code:
  1. /run for k,v in pairs{Oondasta=32519,Galleon=32098,Nalak=32518,Sha=32099} do print(k,IsQuestFlaggedCompleted(v)) end

Returns true or nil based on completion status, good enough for many.
p3lim is offline   Reply With Quote
Old 03-16-13, 11:09 AM   #23
Voxxel
A Black Drake
Join Date: Mar 2009
Posts: 80
Ok, I was wrong, you cannot loot Oondasta more than once a week (despite its loong respawn). Moreover, you're not allowed to use your mogu coins more than once a week.

According to this, the completition quest should be marked as completed but it doens't work actually. Maybe a wrong quest?
Voxxel is offline   Reply With Quote
Old 03-16-13, 11:57 AM   #24
Phanx
A Pyroguard Emberseer
 
Phanx's Avatar
AddOn Author - Click to view addons
Join Date: Mar 2006
Posts: 3,976
Wowhead only lists 4 weekly Short-Supply Reward quests which correspond to the 4 weekly world bosses. I'd guess the quest itself is just buggy.
__________________
Author/maintainer of Grid, PhanxChat, ShieldsUp, and many more.
Troubleshoot an addonTurn any code into an addonMore addon resources
Need help with your code? Post all of your actual code! Attach or paste your files.
Please don’t PM me about addon bugs or code questions. Post a comment or forum thread instead!
Phanx is offline   Reply With Quote
Old 04-25-13, 03:47 PM   #25
Rilgamon
Premium Member
 
Rilgamon's Avatar
Premium Member
AddOn Author - Click to view addons
Join Date: Sep 2009
Posts: 526
Originally Posted by Phanx View Post
Wowhead only lists 4 weekly Short-Supply Reward quests which correspond to the 4 weekly world bosses. I'd guess the quest itself is just buggy.
Yes, Delaene reportet that killing Nalak marks both quests in my addon and I was able to check it tonight. So its blizz's fault.
__________________
The cataclysm broke the world ... and the pandas could not fix it!
Rilgamon is offline   Reply With Quote
Old 05-02-13, 10:39 AM   #26
Rilgamon
Premium Member
 
Rilgamon's Avatar
Premium Member
AddOn Author - Click to view addons
Join Date: Sep 2009
Posts: 526
http://us.battle.net/wow/en/forum/topic/8728854089#3

We are aware of the request and looking to add a way for characters to track which world boss had already been defeated in a given week.
Why not just fix the weekly quests in question?
__________________
The cataclysm broke the world ... and the pandas could not fix it!
Rilgamon is offline   Reply With Quote
Old 05-02-13, 07:40 PM   #27
Phanx
A Pyroguard Emberseer
 
Phanx's Avatar
AddOn Author - Click to view addons
Join Date: Mar 2006
Posts: 3,976
In addition to fixing the quest, they should just add these as raid locks so they show up on /raidinfo and the calendar. Doesn't seem like it would be too difficult.
__________________
Author/maintainer of Grid, PhanxChat, ShieldsUp, and many more.
Troubleshoot an addonTurn any code into an addonMore addon resources
Need help with your code? Post all of your actual code! Attach or paste your files.
Please don’t PM me about addon bugs or code questions. Post a comment or forum thread instead!
Phanx is offline   Reply With Quote
Old 05-30-13, 09:19 AM   #28
Voxxel
A Black Drake
Join Date: Mar 2009
Posts: 80
hello again,

I'm using an extended veriosn of that beautiful color-coded macro made by Phanx, however I can't realize how can I set up the order of the list. Here is my extended code:

Code:
/run for k, v in pairs({ Galleon = 32098, Chest = 32609, Rares = 32610, Room_key = 32626, Nalak = 32518, Oondasta = 32519, Sha = 32099}) do print(format("%s: %s", k, IsQuestFlaggedCompleted(v) and "\124cff00ff00Yes\124r" or "\124cffff0000No\124r")) end
I tried to move them forth and back but the list order does not follow. It would be fine if it could print them in the following order:

1. Galleon
2. Sha
3. Chest
4. Rares
5. Room_key
6. Nalak
7. Oondasta
Voxxel is offline   Reply With Quote
Old 05-30-13, 10:41 AM   #29
Seerah
Fishing Trainer
 
Seerah's Avatar
WoWInterface Super Mod
Featured
Join Date: Oct 2006
Posts: 9,526
You can't. This is because it is set up as a dictionary style table with string keys rather than numerical indexes.
__________________
"You'd be surprised how many people violate this simple principle every day of their lives and try to fit square pegs into round holes, ignoring the clear reality that Things Are As They Are." -Benjamin Hoff, The Tao of Pooh

Seerah is offline   Reply With Quote
Old 05-30-13, 11:41 AM   #30
Dridzt
A Pyroguard Emberseer
 
Dridzt's Avatar
AddOn Author - Click to view addons
Join Date: Nov 2005
Posts: 1,190
You can try this.
Code:
/run for k,v in ipairs({{32098,"Galleon"},{32099,"Sha"},{32609,"Chest"},{32610,"Rares"},{32626,"Key"},{32518,"Nalak"},{32519,"Oondasta"}}) do print(format("%d.%s:%s",k,v[2],IsQuestFlaggedCompleted(v[1]) and "\124cff00ff00Yes" or "\124cffff0000No"))end
Dridzt is online now   Reply With Quote
Old 05-30-13, 12:14 PM   #31
Voxxel
A Black Drake
Join Date: Mar 2009
Posts: 80
Originally Posted by Dridzt View Post
You can try this.
Code:
/run for k,v in ipairs({{32098,"Galleon"},{32099,"Sha"},{32609,"Chest"},{32610,"Rares"},{32626,"Key"},{32518,"Nalak"},{32519,"Oondasta"}}) do print(format("%d.%s:%s",k,v[2],IsQuestFlaggedCompleted(v[1]) and "\124cff00ff00Yes" or "\124cffff0000No"))end
Wow! You're my man, Dridzt! Thanks!
Voxxel is offline   Reply With Quote
Old 05-30-13, 01:25 PM   #32
ravagernl
A Pyroguard Emberseer
AddOn Author - Click to view addons
Join Date: Feb 2006
Posts: 1,140
Yay! 8 new tables each time that macro runs
ravagernl is offline   Reply With Quote
Old 05-30-13, 03:55 PM   #33
Phanx
A Pyroguard Emberseer
 
Phanx's Avatar
AddOn Author - Click to view addons
Join Date: Mar 2006
Posts: 3,976
Here is a cleaner version of that that only creates one table instead of eight:
Code:
/run local t={"Galleon",32098,"Sha",32099,"Chest",32609,"Rares",32610,"RoomKey",32626,"Nalak",32518,"Oondasta",32519}for i=1,#t-1,2 do print(t[i],IsQuestFlaggedCompleted(t[i+1])and "\124cff00ff00Yes" or "\124cffff0000No")end
__________________
Author/maintainer of Grid, PhanxChat, ShieldsUp, and many more.
Troubleshoot an addonTurn any code into an addonMore addon resources
Need help with your code? Post all of your actual code! Attach or paste your files.
Please don’t PM me about addon bugs or code questions. Post a comment or forum thread instead!
Phanx is offline   Reply With Quote
Old 06-01-13, 05:44 AM   #34
Rilgamon
Premium Member
 
Rilgamon's Avatar
Premium Member
AddOn Author - Click to view addons
Join Date: Sep 2009
Posts: 526
Someone asked me to include those quests (key,chest,roll) into zz_Worldboss. So I tried to find an event that would indicate when one of those hidden quests is marked.

I tried "QUEST_AUTOCOMPLETE" and "QUEST_LOG_UPDATE" both dont fire. I hate the idea to have it running in an onupdate.

I tested with the chest which is easy enough to find on my empty realm. The key-quest was marked right the moment I looted it from the chest and the chest itself took a few seconds before it was marked. But cant find the right event for this
__________________
The cataclysm broke the world ... and the pandas could not fix it!
Rilgamon is offline   Reply With Quote
Old 06-01-13, 09:25 PM   #35
Phanx
A Pyroguard Emberseer
 
Phanx's Avatar
AddOn Author - Click to view addons
Join Date: Mar 2006
Posts: 3,976
Assuming you are displaying this information in a Broker plugin's tooltip, why do you need an event? Just query IsQuestFlaggedCompleted(id) when the user requests the tooltip. If you really think querying again on each tooltip request is too expensive, you can cache the state for the rest of the session after the first time.
__________________
Author/maintainer of Grid, PhanxChat, ShieldsUp, and many more.
Troubleshoot an addonTurn any code into an addonMore addon resources
Need help with your code? Post all of your actual code! Attach or paste your files.
Please don’t PM me about addon bugs or code questions. Post a comment or forum thread instead!
Phanx is offline   Reply With Quote
Old 06-02-13, 02:03 AM   #36
Rilgamon
Premium Member
 
Rilgamon's Avatar
Premium Member
AddOn Author - Click to view addons
Join Date: Sep 2009
Posts: 526
In my broker I display the information of all chars. So it would be helpfull when the info is stored the moment it's known to make sure the addon has the right data when the player switches to another char. For now I've added an 5 seconds ooc-onupdate additionally to registering PLAYER_LOGOUT.

Lua Code:
  1. local function update()
  2.     for questId, questData in pairs(db['quests']) do
  3.         if(questData['minlevel'] <= db['char_db'][player]['level']) then
  4.             db['char_db'][player][questId] = IsQuestFlaggedCompleted(questId) and true or nil
  5.         end
  6.     end
  7. end
  8. local function onupdate(self,dt)
  9.     self['elapsed'] = (self['elapsed'] or 0) - dt
  10.     if(self['elapsed'] < 0) then
  11.         self['elapsed'] = 5
  12.         update()
  13.     end
  14. end
  15. local function event(self,evnt,...)
  16.     print(evnt)
  17.     print(...)
  18.     if(evnt == "PLAYER_REGEN_DISABLED") then
  19.         self:SetScript("OnUpdate", nil)
  20.     elseif(evnt == "PLAYER_REGEN_ENABLED") then
  21.         self:SetScript("OnUpdate", onupdate)
  22.     else
  23.         update()
  24.     end
  25. end
__________________
The cataclysm broke the world ... and the pandas could not fix it!
Rilgamon is offline   Reply With Quote
Old 06-05-13, 10:17 AM   #37
Tonyleila
A Frostmaul Preserver
 
Tonyleila's Avatar
AddOn Author - Click to view addons
Join Date: Mar 2010
Posts: 287
I love this macro its not containing the rar mobs @ Isel of thunder but If you were there to get the key guess u have killed a rar mob. Also one questflag that missing in your macros is the new 5.3 Weekly in the Barrens:
Code:
/run for k, v in pairs({ Galleon=32098, Sha=32099, Nalak=32518, Oon=32519, Champ=32641, Key=32626, Barrens=32862}) do print(format("%s: %s", k, IsQuestFlaggedCompleted(v) and "\124cff00ff00Yes" or "\124cffff0000No")) end
__________________
Author of: LeilaUI and Aurora: Missing Textures
__________________
Tonyleila is offline   Reply With Quote
Old 06-17-13, 05:02 PM   #38
oscarucb
A Murloc Raider
 
oscarucb's Avatar
AddOn Author - Click to view addons
Join Date: Jun 2009
Posts: 4
SavedInstances shows the world boss kills, weekly quests, raid lockouts and other useful information for ALL of your toons.
Better than any macro because you don't have to relog to see your alts..
oscarucb is offline   Reply With Quote
Reply

Go BackWoWInterface » AddOns, Compilations, Macros » Macro Help » macro for Sha / Galleon lock

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

vB code is On
Smilies are On
[IMG] code is On
HTML code is Off