Spiral CD on Buff Frame Issue

[Aftermathhqt]

Hi everyone! I'm trying to add spiral cd on buff frame

But doesn't work either if i parent it to the icon or the actual buff frame..

local CdBuffFrame = CreateFrame("Cooldown", nil, _G[self..index], "CooldownFrameTemplate")
    CdBuffFrame:ClearAllPoints()
    CdBuffFrame:SetReverse()
    CdBuffFrame:SetFrameStrata("MEDIUM")
    CdBuffFrame:SetFrameLevel(4)
    CdBuffFrame:SetPoint('TOPRIGHT', _G[self..index], 'TOPRIGHT', -1, -1)
    CdBuffFrame:SetPoint('BOTTOMLEFT', _G[self..index], 'BOTTOMLEFT', 1, 1)

hooksecurefunc('AuraButton_Update', function(self, index)
    if (_G[self..index]) then 
        _G[self..index]:SetSize(AftermathhUI.buffs.buffbuttonsize, AftermathhUI.buffs.buffbuttonsize)
        _G[self..index]:SetScale(AftermathhUI.buffs.buffbuttonscale)
        CreateBorderLight(_G[self..index], AftermathhUI.media.bordersize, AftermathhUI.bordercolor, AftermathhUI.bordercolor, AftermathhUI.bordercolor, 1)
    end
    
    if (_G[self..index..'Icon']) then
        _G[self..index..'Icon']:SetTexCoord(0.03, 0.97, 0.03, 0.97)
        _G[self..index..'Icon']:SetDrawLayer("ARTWORK")
    end
 
    if (_G[self..index..'Duration']) then
        _G[self..index..'Duration']:ClearAllPoints()
        _G[self..index..'Duration']:SetPoint('BOTTOM', _G[self..index], 'BOTTOM', 1, -17)
        _G[self..index..'Duration']:SetDrawLayer('OVERLAY')
        _G[self..index..'Duration']:SetFont(AftermathhUI.media.font, 13, AftermathhUI.media.fontflag)
        if AftermathhUI.media.shadowoffset == true then
            _G[self..index..'Duration']:SetShadowOffset(1, -1)
            _G[self..index..'Duration']:SetShadowColor(0, 0, 0)
        else
            _G[self..index..'Duration']:SetShadowOffset(0, 0)
            _G[self..index..'Duration']:SetShadowColor(0, 0, 0)
        end 
    end
    
    if (_G[self..index..'Count']) then
        _G[self..index..'Count']:ClearAllPoints()
        _G[self..index..'Count']:SetPoint('BOTTOMRIGHT', _G[self..index], 1, 1)
        _G[self..index..'Count']:SetDrawLayer('OVERLAY')
        _G[self..index..'Count']:SetFont(AftermathhUI.media.font, 14, AftermathhUI.media.fontflag)
        if AftermathhUI.media.shadowoffset == true then
            _G[self..index..'Count']:SetShadowOffset(1, -1)
            _G[self..index..'Count']:SetShadowColor(0, 0, 0)
        else
            _G[self..index..'Count']:SetShadowOffset(0, 0)
            _G[self..index..'Count']:SetShadowColor(0, 0, 0)
        end 
    end
    
    if (_G[self..index..'Border']) then
        local r,g,b = _G[self..index..'Border']:GetVertexColor()
        _G[self..index..'Border']:Hide()
        _G[self..index..'Border'].Show = function() end
        _G[self..index..'Border']:SetTexture(nil)
        ColorBorder(_G[self..index], r, g, b)       
    end
end)

[Phanx]

Before I look at anything else, please, for the love of... whatever it is you love, stop doing this:

    if (_G[self..index..'Duration']) then
        _G[self..index..'Duration']:ClearAllPoints()
        _G[self..index..'Duration']:SetPoint('BOTTOM', _G[self..index], 'BOTTOM', 1, -17)
        _G[self..index..'Duration']:SetDrawLayer('OVERLAY')
        _G[self..index..'Duration']:SetFont(AftermathhUI.media.font, 13, AftermathhUI.media.fontflag)
        if AftermathhUI.media.shadowoffset == true then
            _G[self..index..'Duration']:SetShadowOffset(1, -1)
            _G[self..index..'Duration']:SetShadowColor(0, 0, 0)
        else
            _G[self..index..'Duration']:SetShadowOffset(0, 0)
            _G[self..index..'Duration']:SetShadowColor(0, 0, 0)
        end 
    end

Just in that block alone you're doing 9 string concatenations and 9 global lookups. I strongly suggest you familiarize yourself with how to create and use variables:

    local duration = _G[self..index..'Duration']
    if duration then
        duration:ClearAllPoints()
        duration:SetPoint('BOTTOM', _G[self..index], 'BOTTOM', 1, -17)
        duration:SetDrawLayer('OVERLAY')
        duration:SetFont(AftermathhUI.media.font, 13, AftermathhUI.media.fontflag)
        if AftermathhUI.media.shadowoffset == true then
            duration:SetShadowOffset(1, -1)
            duration:SetShadowColor(0, 0, 0)
        else
            duration:SetShadowOffset(0, 0)
            duration:SetShadowColor(0, 0, 0)
        end 
    end

Now you only have one concatenation and one global lookup, and 9 much faster local lookups. When you expand the above problem and solution to cover the entire block of code you posted, and considering how often AuraButton_Update runs (hint: it's called in every OnUpdate, so if you're getting 45 FPS, it's running 45 times every second!) you could potentially improve the efficiency of your code by a huge amount.

As for the topic problem, (1) you can't parent anything to a texture, only to a frame, and (b) can you be more specific about "doesn't work"? Do you have an error display running? Did you try adding "print" statements throughout your code to see what's happening in real-time in-game? Does anything appear in-game? If so, how is its appearance or behavior different than what you expected?

[Aftermathhqt]

Originally Posted by Phanx Before I look at anything else, please, for the love of... whatever it is you love, stop doing this: if (_G[self..index..'Duration']) then _G[self..index..'Duration']:ClearAllPoints() _G[self..index..'Duration']:SetPoint('BOTTOM', _G[self..index], 'BOTTOM', 1, -17) _G[self..index..'Duration']:SetDrawLayer('OVERLAY') _G[self..index..'Duration']:SetFont(AftermathhUI.media.font, 13, AftermathhUI.media.fontflag) if AftermathhUI.media.shadowoffset == true then _G[self..index..'Duration']:SetShadowOffset(1, -1) _G[self..index..'Duration']:SetShadowColor(0, 0, 0) else _G[self..index..'Duration']:SetShadowOffset(0, 0) _G[self..index..'Duration']:SetShadowColor(0, 0, 0) end end Just in that block alone you're doing 9 string concatenations and 9 global lookups. I strongly suggest you familiarize yourself with how to create and use variables: local duration = _G[self..index..'Duration'] if duration then duration:ClearAllPoints() duration:SetPoint('BOTTOM', _G[self..index], 'BOTTOM', 1, -17) duration:SetDrawLayer('OVERLAY') duration:SetFont(AftermathhUI.media.font, 13, AftermathhUI.media.fontflag) if AftermathhUI.media.shadowoffset == true then duration:SetShadowOffset(1, -1) duration:SetShadowColor(0, 0, 0) else duration:SetShadowOffset(0, 0) duration:SetShadowColor(0, 0, 0) end end Now you only have one concatenation and one global lookup, and 9 much faster local lookups. When you expand the above problem and solution to cover the entire block of code you posted, and considering how often AuraButton_Update runs (hint: it's called in every OnUpdate, so if you're getting 45 FPS, it's running 45 times every second!) you could potentially improve the efficiency of your code by a huge amount. As for the topic problem, (1) you can't parent anything to a texture, only to a frame, and (b) can you be more specific about "doesn't work"? Do you have an error display running? Did you try adding "print" statements throughout your code to see what's happening in real-time in-game? Does anything appear in-game? If so, how is its appearance or behavior different than what you expected?

Wow that was a huge learning. Didn't know that thank you!

Literately nothing happens not even a error.

[Phanx]

Don't overlook this part:

Originally Posted by Phanx Did you try adding "print" statements throughout your code to see what's happening in real-time in-game?

99% of the time this simple debugging method will show you exactly what the problem is. At the beginning of each function, print the name of the function and each of its arguments, eg:

hooksecurefunc('AuraButton_Update', function(self, index)
   print('AuraButton_Update', self, index)
   -- rest of the function here
end)

(On a side note, I would rename "self" to "buttonName" there, since "self" is traditionally used to name a frame/object reference, but that particular value is a string, which is not the same thing at all.)

Anywhere you have significant "if" checks inside a function -- for example, if you call UnitHealth and then do an "if" check on the result -- add another print statement to show you what's being checked, eg:

local hp, hpMax = UnitHealth("player"), UnitHealthMax("player")
local hpPercent = hp / hpMax
print("Player health:", hp, hpMax, hpPercent)
if hpPercent < 0.1 then
    UIErrorsFrame:AddMessage("You're about to die!")
end

This way you can see everything that's happening, as it happens. If something doesn't happen when you think it should, the information printed will usually tell you why, or at least tell you exactly where to look.

[Aftermathhqt]

Originally Posted by Phanx Don't overlook this part: 99% of the time this simple debugging method will show you exactly what the problem is. At the beginning of each function, print the name of the function and each of its arguments, eg: hooksecurefunc('AuraButton_Update', function(self, index) print('AuraButton_Update', self, index) -- rest of the function here end) (On a side note, I would rename "self" to "buttonName" there, since "self" is traditionally used to name a frame/object reference, but that particular value is a string, which is not the same thing at all.) Anywhere you have significant "if" checks inside a function -- for example, if you call UnitHealth and then do an "if" check on the result -- add another print statement to show you what's being checked, eg: local hp, hpMax = UnitHealth("player"), UnitHealthMax("player") local hpPercent = hp / hpMax print("Player health:", hp, hpMax, hpPercent) if hpPercent < 0.1 then UIErrorsFrame:AddMessage("You're about to die!") end This way you can see everything that's happening, as it happens. If something doesn't happen when you think it should, the information printed will usually tell you why, or at least tell you exactly where to look.

It works, but says nothing about the part about

local CdBuffFrame = CreateFrame("Cooldown", nil, BuffButton, "CooldownFrameTemplate")
    CdBuffFrame:ClearAllPoints()
    CdBuffFrame:SetReverse()
    CdBuffFrame:SetFrameStrata("MEDIUM")
    CdBuffFrame:SetFrameLevel(4)
    CdBuffFrame:SetPoint('TOPRIGHT', BuffIcon, 'TOPRIGHT', -1, -1)
    CdBuffFrame:SetPoint('BOTTOMLEFT', BuffIcon, 'BOTTOMLEFT', 1, 1)

And prints just "AuraButton_Update BuffButton 123.. AuraButton_Update DebuffButton 123..."

[Duugu]

Beat me, but I can't see any code to set up or start the cooldown in your example.

Like http://wowprogramming.com/docs/widge...wn/SetCooldown

[Aftermathhqt]

Originally Posted by Duugu Beat me, but I can't see any code to set up or start the cooldown in your example. Like http://wowprogramming.com/docs/widge...wn/SetCooldown

Well that works better, but it tracks but Holy Shock and it goes over my whole screen

hooksecurefunc('AuraButton_Update', function(ButtonName, index)
    
    local BuffButton = _G[ButtonName..index]
    local BuffIcon = _G[ButtonName..index..'Icon']
    local BuffDuration = _G[ButtonName..index..'Duration']
    local BuffCount = _G[ButtonName..index..'Count']
    local BuffBorder = _G[ButtonName..index..'Border']
        
    local CdBuffFrame = CreateFrame("Cooldown", nil, BuffButton, "CooldownFrameTemplate")
    CdBuffFrame:SetAllPoints(BuffIcon)
    CdBuffFrame:SetReverse()
    CdBuffFrame:SetFrameStrata("MEDIUM")
    CdBuffFrame:SetFrameLevel(4)
    --CdBuffFrame:SetPoint('TOPRIGHT', BuffIcon, 'TOPRIGHT', -1, -1)
    --CdBuffFrame:SetPoint('BOTTOMLEFT', BuffIcon, 'BOTTOMLEFT', 1, 1)
    CdBuffFrame:SetCooldown(GetTime(), 5)
    
    if BuffButton then 
        BuffButton:SetSize(AftermathhUI.buffs.buffbuttonsize, AftermathhUI.buffs.buffbuttonsize)
        BuffButton:SetScale(AftermathhUI.buffs.buffbuttonscale)
        CreateBorderLight(BuffButton, AftermathhUI.media.bordersize, AftermathhUI.bordercolor, AftermathhUI.bordercolor, AftermathhUI.bordercolor, 1)
    end
    
    if BuffIcon then
       BuffIcon:SetTexCoord(0.03, 0.97, 0.03, 0.97)
       BuffIcon:SetDrawLayer("ARTWORK")
    end 
 
    if BuffDuration then
        BuffDuration:ClearAllPoints()
        BuffDuration:SetPoint('BOTTOM', BuffButton, 'BOTTOM', 1, -17)
        BuffDuration:SetDrawLayer('OVERLAY')
        BuffDuration:SetFont(AftermathhUI.media.font, 13, AftermathhUI.media.fontflag)
        if AftermathhUI.media.shadowoffset == true then
            BuffDuration:SetShadowOffset(1, -1)
            BuffDuration:SetShadowColor(0, 0, 0)
        else
            BuffDuration:SetShadowOffset(0, 0)
            BuffDuration:SetShadowColor(0, 0, 0)
        end 
    end
    
    if BuffCount then
        BuffCount:ClearAllPoints()
        BuffCount:SetPoint('BOTTOMRIGHT', BuffButton, 1, 1)
        BuffCount:SetDrawLayer('OVERLAY')
        BuffCount:SetFont(AftermathhUI.media.font, 14, AftermathhUI.media.fontflag)
        if AftermathhUI.media.shadowoffset == true then
            BuffCount:SetShadowOffset(1, -1)
            BuffCount:SetShadowColor(0, 0, 0)
        else
            BuffCount:SetShadowOffset(0, 0)
            BuffCount:SetShadowColor(0, 0, 0)
        end 
    end
    
    if BuffBorder then
        local r,g,b = BuffBorder:GetVertexColor()
        BuffBorder:Hide()
        BuffBorder.Show = function() end
        BuffBorder:SetTexture(nil)
        ColorBorder(BuffButton, r, g, b)        
    end
end)

[Phanx]

AuraButton_Update runs every time anything about the aura button is updated -- what icon it's showing, what duration to display on the text, etc. That code you just posted is creating a new cooldown object each time, so if you're getting 50 FPS, you're creating 50 cooldown objects per buff icon per second. It's also re-setting all the fonts and making all the other changes that often.

I'd suggest hooking BuffButton_OnLoad instead:

hooksecurefunc("BuffButton_OnLoad", function(self)
   -- self is the button object, not its name.
   -- Use :GetName() to get the name for building the names of regions.

   -- Put your code here.
   -- Assign "self.cooldown" as a reference to the cooldown object you create.
end)

The other problem with your code is that while you are indeed creating a cooldown object, you're never telling it to display anything. That's what you should be doing in AuraButton_Update:

hooksecurefunc("AuraButton_Update", function(buttonName, index, filter)
   local button = _G[buttonName..index]
   local _, _, _, _, _, duration, expirationTime = UnitAura(PlayerFrame.unit, index, filter)
   if duration > 0 and expirationTime then
      button.cooldown:SetCooldown(expirationTime - GetTime(), duration)
   end
end)

[Aftermathhqt]

Okay! Thanks i'll try get around this some way