Need Help with PlayerModel!

[Mayron]

Hi, I have been trying to understand how PlayerModel's work and I get very strange behaviours.

This is my first attempt code:

f.model = CreateFrame("PlayerModel", nil, f)
f.model:SetSize(600, 800)
f.model:SetPoint("BOTTOMLEFT", f, "TOPLEFT", 100, -100)
f.model:SetUnit("player")
f.model:SetPosition(0, 0, -0.75)
f.model:SetCustomCamera(1)
f.model:SetCameraPosition(2.8, -1, 0.4)

But this causes the Lua error below which I do not know why:

<unnamed> is not using a custom camera.

I set a custom camera only because without a custom camera, the positioning and size etc kept getting changed and I have no clue why. I then changed the code to be used in an "OnShow" event like this:

f.model = CreateFrame("PlayerModel", nil, f)
f.model:SetSize(600, 800)
f.model:SetPoint("BOTTOMLEFT", f, "TOPLEFT", 100, -100)
f.model:SetUnit("player")                   
 
f.model:SetScript("OnShow", function(self)
    self:SetPosition(0, 0, -0.75)
    self:SetCustomCamera(1)
    self:SetCameraPosition(2.8, -1, 0.4)
end)

This removed the strange Lua error but I get the same problem with the camera being altered some how. The first time the model is shown, the positioning is completely wrong but GetCameraPosition() shows the right numbers. The 2nd time is gets shown, it displays correctly and the number with GetCameraPosition() are the same as the first time.

Obviously I must be not understanding something important?
That is all the code as I'm just getting started.

Can anyone help me?
Thank you!

EDIT: Also even without using any custom cameras, altering any positions, or distance values, the first time it shows is always very different to the 2nd time it shows..

[Mayron]

I've been running some tests,

So far the only difference between the two appearances are this:

first time shown:
print(f.model:GetWorldScale()) -- prints 0.817...

second time shown:
print(f.model:GetWorldScale()) -- prints 0.581...

not sure if that's anything to do with it.

[Lombra]

They are just weird in my experience. You could try various combinations of resetting the position (0, 0, 0) before setting it, or onhide, or onshow, but I can't remember if any of those actually made a difference.

[SDPhantom]

Do you have anywhere else in the code that sets the model's unit? For example, in response to the UNIT_MODEL_CHANGED event. When you tell a ModelFrame to set its unit, it resets camera position and rotation. Even if it's the same unit as before.

[Mayron]

Originally Posted by SDPhantom Do you have anywhere else in the code that sets the model's unit? For example, in response to the UNIT_MODEL_CHANGED event. When you tell a ModelFrame to set its unit, it resets camera position and rotation. Even if it's the same unit as before.

No I don't. That is all the code which is why I usually try to avoid PlayerModel's because they confuse me.

[Mayron]

Originally Posted by Lombra They are just weird in my experience. You could try various combinations of resetting the position (0, 0, 0) before setting it, or onhide, or onshow, but I can't remember if any of those actually made a difference.

Been experimenting with this idea but no luck.

[Seerah]

Is your OnShow script even firing? A frame is shown as soon as it's created (meaning, your frame is already shown when you set the OnShow handler).

[semlar]

The way the model is displayed is affected by your screen resolution for god knows why, but if you're creating it as soon as the addon is loaded it will have a different scale than if you create it after the ui scale is applied, which happens later in the loading process.

Anyway, you should probably be using model:SetPortraitZoom(n) rather than those camera functions.

[Mayron]

Originally Posted by Seerah Is your OnShow script even firing? A frame is shown as soon as it's created (meaning, your frame is already shown when you set the OnShow handler).

Sorry yes it definitely is firing. I have it anchored to a frame "f" which I control by showing and hiding it.

Originally Posted by semlar The way the model is displayed is affected by your screen resolution for god knows why, but if you're creating it as soon as the addon is loaded it will have a different scale than if you create it after the ui scale is applied, which happens later in the loading process..

Thank you!!
Yeah I am creating it instantly which I think is the problem. I've added that block of code into an event which happens after the game has been loaded and it works now.. really strange but makes sense

Thanks everyone!

[Resike]

You need to create your model after the ADDON_LOADED trigger.

local model = CreateFrame("PlayerModel", nil, UIParent)
model:SetSize(600, 800)
model:SetPoint("CENTER", UIParent, "CENTER", 0, 0)
model:SetUnit("player")
model:SetPosition(0, 0, -0.75)
model:SetCustomCamera(1)
model:SetCameraPosition(2.8, -1, 0.4)
model:RefreshCamera()
 
model:Show()

Changing the scale of the model's frame or the UIScale will fuck up models which doesn't have their camera target set to 0,0,0.

I can point you to this code, where you can manipulate your model's camera stuff in real time:

http://www.wowinterface.com/forums/s...5&postcount=37

[Mayron]

Originally Posted by Resike You need to create your model after the ADDON_LOADED trigger. local model = CreateFrame("PlayerModel", nil, UIParent) model:SetSize(600, 800) model:SetPoint("CENTER", UIParent, "CENTER", 0, 0) model:SetUnit("player") model:SetPosition(0, 0, -0.75) model:SetCustomCamera(1) model:SetCameraPosition(2.8, -1, 0.4) model:RefreshCamera()   model:Show() Changing the scale of the model's frame or the UIScale will fuck up models which doesn't have their camera target set to 0,0,0.

No clue why but I still get the Lua error when I use this code in "PLAYER_ENTERING_WORLD" and "ADDON_LOADED"

<unnamed> is not using a custom camera.
Time: 03/27/15 14:54:08
Count: 1
Stack: [C]: in function `SetCameraPosition'

Still no idea why I cannot have any camera functions being used outside of "OnShow".

EDIT: Thanks for the link. I will have to investigate further

[Resike]

Originally Posted by Mayron No clue why but I still get the Lua error when I use this code in "PLAYER_ENTERING_WORLD" and "ADDON_LOADED" <unnamed> is not using a custom camera. Time: 03/27/15 14:54:08 Count: 1 Stack: [C]: in function `SetCameraPosition' Still no idea why I cannot have any camera functions being used outside of "OnShow". EDIT: Thanks for the link. I will have to investigate further

Yeah i forgot that model:RefreshCamera() kills the model:SetCustomCamera(1) call, just add model:SetCustomCamera(1) after the model:RefreshCamera() again.

[Resike]

I don't remember well but i also think some model functions might return wrong values when called immediately after login. Maybe even the ADDON_LOADED event is too early too.

[Resike]

I updated some code in this thread:

http://www.wowinterface.com/forums/s...61&postcount=3

I'll dig deeper into models in the summer, when i'm (hopefully) gonna be back on this project:

http://www.wowinterface.com/forums/s...ad.php?t=48761