Swapping equipment sets in stealth

[Frayol]

I've recently been trying out the Blizzard equipment manager with a view to no longer using Outfitter as it does far more than I need. So far been fairly satisfied, but about the only real automation I require is weapon swapping on my rogue. There are addons that will automate this, but nothing seems to work properly with most of the LDB equipment manager displays (i.e. they don't update with the weapon change) so I've taken a stab at my own version. This is what I've come up with:

local f = CreateFrame("FRAME", "Frame_fStealth");
f:RegisterEvent("UPDATE_STEALTH");

local function eventHandler(self, event, ...)
local nStance = GetShapeshiftForm();
	if nStance == 0 then EquipmentManager_EquipSet("Normal");
	elseif nStance ~= 0 then EquipmentManager_EquipSet("Stealth");
	else return;
end
end
f:SetScript("OnEvent", eventHandler);

It relies on two sets, one called "Normal" and one called "Stealth". On my rogue I have a full outfit for "Normal" and only a main hand dagger on "Stealth" with all other slots set to ignore. Everything seems to be working fine, but could some kind person please advise if I have missed anything or am doing something horrendously wrong?

[Slakah]

"FRAME" should be "Frame"

[Frayol]

Thanks, so I'm guessing that apart from that everything else was OK? In that case brilliant, I had a feeling that I was missing something or doing something wrong so it's good to know that it wasn't anything serious.

[Foxlit]

Originally Posted by Slakah "FRAME" should be "Frame"

That makes no difference whatsoever.

---

Your indentation is a bit weird, and the last else clause would never run (but everything should work without changes). It can be cleaned up and shortened a bit:

local f = CreateFrame("FRAME", "Frame_fStealth");
f:RegisterEvent("UPDATE_STEALTH");

local function eventHandler(self, event, ...)
	local nStance = GetShapeshiftForm();
	EquipmentManager_EquipSet(nStance == 0 and "Normal" or "Stealth");
end
f:SetScript("OnEvent", eventHandler);

[Frayol]

Originally Posted by Foxlit Your indentation is a bit weird, and the last else clause would never run (but everything should work without changes). It can be cleaned up and shortened a bit:

Hmmm... not sure what happened with the indentation, it doesn't look like that on the actual file. As for the shortening, TYVM now that I see how you've put it I realise that I goofed a bit with that initially.

[p3lim]

Originally Posted by Foxlit That makes no difference whatsoever. --- Your indentation is a bit weird, and the last else clause would never run (but everything should work without changes). It can be cleaned up and shortened a bit: local f = CreateFrame("FRAME", "Frame_fStealth"); f:RegisterEvent("UPDATE_STEALTH"); local function eventHandler(self, event, ...) local nStance = GetShapeshiftForm(); EquipmentManager_EquipSet(nStance == 0 and "Normal" or "Stealth"); end f:SetScript("OnEvent", eventHandler);

If you really want to clean it:

local f = CreateFrame('Frame')
f:RegisterEvent('UPDATE_STEALTH')
f:SetScript('OnEvent', function() EquipmentManager_EquipSet(GetShapeshiftForm() == 0 and 'Normal' or 'Stealth') end)

[Frayol]

Originally Posted by p3lim If you really want to clean it: local f = CreateFrame('Frame') f:RegisterEvent('UPDATE_STEALTH') f:SetScript('OnEvent', function() EquipmentManager_EquipSet(GetShapeshiftForm() == 0 and 'Normal' or 'Stealth') end)

Now that is shortened! Tested it out and it all works perfectly, TYVM.

Is there any benefit to doing this way as opposed to how I was originally doing it other than shorter code?