ACTIVE_TALENT_GROUP_CHANGED firing on log in?

suicidalkatt · 02-01-10, 04:56 PM

Is there any way to prevent the ACTIVE_TALENT_GROUP_CHANGED from firing on log in?

Someone suggested using a dummy frame and using the OnUpdate of the frame to avoid it firing too soon in the addon load sequence.

Code:

-- Dual Spec Talent Change
local setDualSpec = CreateFrame('Frame')
setDualSpec:RegisterEvent('ACTIVE_TALENT_GROUP_CHANGED')
setDualSpec:SetScript('OnEvent', function(self, event)
	setDualSpec:Show()
	print(tostring(event))
end)
setDualSpec:Hide()
setDualSpec:SetScript('OnUpdate', function()
	local Active = GetActiveTalentGroup()
	local t = TidyPlatesThreat.db.char.specInfo[Active]
	TidyPlatesThreat.db.char.threat.tanking = currentRoleBool(GetActiveTalentGroup())
	print("|cff89F559Threat Plates|r: Player spec change detected: |cff"..classColors[PlayerClass]..specName()..": ("..t[1].."/"..t[2].."/"..t[3]..")|r, you are now in your |cff89F559"..dualSpec(current).."|r spec and are now in your "..roleText(current).." role.")
	TidyPlates:ForceUpdate()
	setDualSpec:Hide()
end)

However it still will fire and display on log in.

Any thoughts?

Rilgamon · 02-01-10, 05:04 PM

Why not store the value of talentgroup when you last checked ?
Something like

Code:

If Active ~= OldActive then
  OldActive = Active
  [... Whatever ...]
end

suicidalkatt · 02-01-10, 05:16 PM

Originally Posted by Rilgamon

Why not store the value of talentgroup when you last checked ?
Something like

Code:

If Active ~= OldActive then
  OldActive = Active
  [... Whatever ...]
end

I could but it's not really needed.

Any help on my problem?

suicidalkatt · 02-01-10, 05:32 PM

I could always just make a variable and set it to a value on the ADDON_LOADED then set it to something else on PLAYER_ALIVE or w/e.

... but that seems like the improper thing to do.

Is there something I'm missing?

Recluse · 02-01-10, 06:17 PM

Just use a flag to suppress the first firing of the event from doing anything?

lua Code:

local suppressed
local f = CreateFrame("Frame")
f:RegisterEvent("ACTIVE_TALENT_GROUP_CHANGED")
f:SetScript("OnEvent", function()
    if not suppressed then
        suppressed = true
        return
    end
    
    -- Do yer stuffs!
end)

Similar (maybe the same?) as the other poster mentioned, you could also do the following, which just uses the spec as the flag.

lua Code:

local previous_spec
local f = CreateFrame("Frame")
f:RegisterEvent("ACTIVE_TALENT_GROUP_CHANGED")
f:SetScript("OnEvent", function()
    if not previous_spec then
        previous_spec = GetActiveTalentGroup()
        return
    end
    
    local current_spec = GetActiveTalentGroup()
    if current_spec ~= previous_spec then
        previous_spec = current_spec
 
        -- Do yer stuffs!
    end
end)

Katae · 02-01-10, 06:25 PM

Here's the solution I used in litestats. You can register/unregister on player_leaving_world or player_entering_world. It will then no longer fire during login:

Code:

local f = CreateFrame'frame'
f:RegisterEvent'PLAYER_ENTERING_WORLD'
f:RegisterEvent'PLAYER_LEAVING_WORLD'

f:SetScript("OnEvent", function(self, event, ...)
    if event == "PLAYER_ENTERING_WORLD" then
        self:RegisterEvent'ACTIVE_TALENT_GROUP_CHANGED'
    elseif event == "PLAYER_LEAVING_WORLD" then
        self:UnregisterEvent'ACTIVE_TALENT_GROUP_CHANGED'
    elseif event == "ACTIVE_TALENT_GROUP_CHANGED" then
        -- Talent stuff.
    end
end)

Disclaimer: I use this for PLAYER_TALENT_UPDATE, which might be a better event to watch, depending on what you use it for.

suicidalkatt · 02-01-10, 07:24 PM

Thank you all for your suggestions

They're much appreciated!