Updating from 1.5.16 (4.3) to 1.6.5 (5.3)

[Senit24]

I just came back from a bit of a break and I'm trying to get my layout up to date.

Could anyone give me a quick run-through of what has changed from 1.5.16 to 1.6.5?
Currently I'm not getting and Lua errors - my frames are simply not being displayed.

Thanks so much to anyone with a little time to help me get back into it!

[Rainrider]

I'm wearing a t-shirt right now. Could you tell me what color it is?

Apart from that:
https://github.com/haste/oUF/compare/1.5.16...1.6.5
http://www.wowinterface.com/download...html#changelog

[Senit24]

Yeah... sorry about that vagueness of my request. The GitHub comparison page is very helpful - thank you. I'll be more specific if I need something in the future.

[Senit24]

Hey I fixed it! Just had to change a couple Tag functions.

[FaulTier]

I did the same thing - updating from 1.5.16 to 1.6.5.

Getting atm these errors:

1.

1x oUF_Fauli-1.0\tags.lua:54: attempt to index field "TagEvents" (a nil value)
oUF_Fauli-1.0\tags.lua:54: in main chunk

Locals:

2.

1x oUF_Fauli-1.0\core.lua:124: Attempted to use invalid tag [fauli:hp].
<in C code>
oUF-1.6.5\elements\tags.lua:579: in function "Tag"
oUF_Fauli-1.0\lib.lua:230: in function "addTextTags"
oUF_Fauli-1.0\core.lua:124: in function <oUF_Fauli\core.lua:75>
(tail call): ?
oUF-1.6.5\ouf-1.6.5.lua:262: in function <oUF\ouf.lua:192>
(tail call): ?
oUF-1.6.5\ouf-1.6.5.lua:552: in function "Spawn"
oUF_Fauli-1.0\core.lua:367: in function "func"
oUF-1.6.5\factory.lua:20: in function <oUF\factory.lua:16>
(tail call): ?

Locals:
self = oUF_fauliPlayer {
 0 = <userdata>
 Highlight = <unnamed> {}
 Power = <unnamed> {}
 __tags = <table> {}
 PLAYER_ENTERING_WORLD = <func> @oUF\ouf.lua:149
 mystyle = "player"
 unit = "player"
 HealPrediction = <table> {}
 style = "fauli"
 Health = <unnamed> {}
 menu = <func> @oUF_Fauli\core.lua:69
 UNIT_EXITED_VEHICLE = <func> @oUF\ouf.lua:38
 __elements = <table> {}
 UNIT_ENTERED_VEHICLE = <func> @oUF\ouf.lua:38
}
fs = <unnamed> {
 0 = <userdata>
 parent = oUF_fauliPlayer {}
}
tagstr = "[fauli:hp]"
func = nil
format = "%s"
numTags = 1
args = <table> {}
(for generator) = <func> =[C]:-1
(for state) = nil
(for control) = "[fauli:hp]"
bracket = "[fauli:hp]"
tagFunc = nil
OnShow = <func> @oUF\elements\tags.lua:456
tagPool = <table> {}
_PATTERN = "%[..-%]+"
funcPool = <table> {}
tags = <table> {
 curhp = <func> =[C]:-1
 race = <func> =[C]:-1
 faction = <func> =[C]:-1
 class = <func> =[C]:-1
 maxhp = <func> =[C]:-1
 maxpp = <func> =[C]:-1
 curpp = <func> =[C]:-1
}
getTagName = <func> @oUF\elements\tags.lua:462
_ENV = <table> {
 Hex = <func> @oUF\elements\tags.lua:11
 ColorGradient = <func> @oUF\colors.lua:59
 _TAGS = <table> {}
}
tmp = <table> {}
eventlessUnits = <table> {}
createOnUpdate = <func> @oUF\elements\tags.lua:430
RegisterEvents = <func> @oUF\elements\tags.lua:477

... it might be the late night, but I'm not seeing through it.

if anyone wants to look through it:
http://www.wowinterface.com/download...ouf_Fauli.html

it's not that much of Code.

[FaulTier]

okay, I got rid of these errors - and changed 2 against 1 error:

2x oUF_Fauli-1.0\core.lua:377: Bad argument #3 to "RegisterStyle" (function, table expected, got nil
<in C code>
oUF-1.6.5\private.lua:13: in function <oUF\private.lua:4>
oUF-1.6.5\ouf-1.6.5.lua:316: in function "RegisterStyle"
oUF_Fauli-1.0\core.lua:377: in main chunk

Locals:
value = nil
num = 3
types = "function, table"
name = "RegisterStyle"

I'm not able to find the problem - if you need anything to help from my cods, tell me.

edit:
thats my register style part:

oUF:RegisterStyle("fauli", UnitStyle)
oUF:RegisterStyle("fauliBoss", BossStyle)

oUF:Factory(function(self)
	-- Single Frames
	self:SetActiveStyle('fauli')
	
	self:Spawn('player'):SetPoint("BOTTOMRIGHT", UIParent, cfg.playerRelativePoint, cfg.playerX, cfg.playerY)
	self:Spawn('target'):SetPoint("BOTTOMLEFT", UIParent, cfg.targetRelativePoint, cfg.targetX, cfg.targetY)
	if cfg.showTot then self:Spawn('targettarget'):SetPoint("TOPRIGHT",oUF_fauliTarget,"BOTTOMRIGHT", 0, -8) end
	if cfg.showPet then self:Spawn('pet'):SetPoint("TOPLEFT",oUF_fauliPlayer,"BOTTOMLEFT", 0, -8) end
	if cfg.showFocus then self:Spawn('focus'):SetPoint("CENTER",UIParent,"BOTTOM", 0, 242) end
	
	-- Boss frames
	if cfg.showBossFrames then
		self:SetActiveStyle('fauliBoss')
		local bossFrames = {}
		for i = 1, MAX_BOSS_FRAMES do
			local unit = self:Spawn('boss' .. i)
			if i > 1 then
				unit:SetPoint('BOTTOMLEFT', bossFrames[i - 1], 'TOPLEFT', 0, 8)
			else
				unit:SetPoint('BOTTOMRIGHT', UIParent, 'BOTTOMRIGHT', -90, 320) 
			end
			bossFrames[i] = unit
		end
	end
end)
do

[Rainrider]

If I read this right it would mean that either UnitStyle or BossStyle are not present when calling RegisterStyle.

[FaulTier]

Nah, it's even worse - I forgot to edit everything else (tags.lua, core.lua) to suit 1.6.5 - too much work just to update a still working layout.

Seem's i'll stuck with 1.5.16 until it won'T work anymore

[Phanx]

Originally Posted by FaulTier ... too much work just to update a still working layout.

The changes are really not that extensive. Using an ancient version of oUF that isn't actually compatible with the current version of WoW is not a real solution. If there are specific problems you're seeing, or errors you're getting, and you need help with them, post the problems/errors and you'll find plenty of people who are happy to help you.

If you're not using BugSack already, go install it now. The game's built-in error display can't show you errors that happen during the initial loading sequence, which is when the majority of errors you will encounter as an addon developer happen, making it pretty much useless for developers. Error messages will generally tell you exactly what's wrong on which line in which file, making it trivial to pinpoint the problem. Without error messages, you're pretty much working blind.

[FaulTier]

although it's an ancient version, it doesn't throw any errors - as long, as I'm not trying to update the layout code to 1.6

Maybe I'm trying to code it again this weekend, then I'll gladly ask for your help