Problen using events

[gibogubo]

Hello!
I´ve been programing addons for a bit, but now that i´m trying to use events some problems appear...
This addon is supossed to send a chat mesage when the player leves up and receives a whisper whith the message "Hello!", but it does nothing...

Can anybody tell me where´s the error?

local creat = CreateFrame("FRAME", "TestingFrame");

function TestingFrame_OnLoad(self)
	self:RegisterEvent("PLAYER_LEVEL_UP");
	self:RegisterEvent("CHAT_MSG_SYSTEM");
end

function TestingFrame_OnEvent(self, event, ...)
	local arg1 = ...;
		if event ==  "PLAYER_LEVEL_UP" then
			local level = ...
			SendChatMessage("I´ve leveled up!", "SAY");
		elseif event == "CHAT_MSG_SYSTEM" then
			local message = arg1;
			if string.find(message, "Hello!", 1, true) ~= nil then
				SendChatMessage("Somebody has whispered me!", "SAY");
			end
		end
end

[semlar]

This is how I would write this..

local f = CreateFrame('frame')
f:RegisterEvent('PLAYER_LEVEL_UP')
f:RegisterEvent('CHAT_MSG_WHISPER')
 
f:SetScript('OnEvent', function(self, event, ...)
    if event == 'PLAYER_LEVEL_UP' then
        SendChatMessage("I've leveled up!")
    else
        local message = ...
        if message:find('Hello!') then
            SendChatMessage('Somebody has whispered me!')
        end
    end
end)

I think you meant CHAT_MSG_WHISPER instead of CHAT_MSG_SYSTEM, but if not feel free to change it.

You also don't need string.find if you're matching literally the message "Hello!", you could just compare the string like if message == "Hello!". String.find is for when you want to search through the entire string for any instance of the term.

It's also case sensitive, so you could call string.lower on it and compare it to 'hello!' if you want to match any case.

[SDPhantom]

Originally Posted by gibogubo Hello! I´ve been programing addons for a bit, but now that i´m trying to use events some problems appear... This addon is supossed to send a chat mesage when the player leves up and receives a whisper whith the message "Hello!", but it does nothing... Can anybody tell me where´s the error? local creat = CreateFrame("FRAME", "TestingFrame"); function TestingFrame_OnLoad(self) self:RegisterEvent("PLAYER_LEVEL_UP"); self:RegisterEvent("CHAT_MSG_SYSTEM"); end function TestingFrame_OnEvent(self, event, ...) local arg1 = ...; if event == "PLAYER_LEVEL_UP" then local level = ... SendChatMessage("I´ve leveled up!", "SAY"); elseif event == "CHAT_MSG_SYSTEM" then local message = arg1; if string.find(message, "Hello!", 1, true) ~= nil then SendChatMessage("Somebody has whispered me!", "SAY"); end end end

First of all, without registering your functions as the frame's script handlers, those functions will never run. For example, you'll need to add this line to register your OnEvent handler.

creat:SetScript("OnEvent",TestingFrame_OnEvent);

Note it's impossible to have Lua create a frame and then register an OnLoad for it to run immediately as the OnLoad handler runs as a part of the CreateFrame() call. Registering the handler function does nothing. Instead, you should move the code contained in the function into the main chunk.

local creat = CreateFrame("FRAME", "TestingFrame");
creat:RegisterEvent("PLAYER_LEVEL_UP");
creat:RegisterEvent("CHAT_MSG_SYSTEM");

With these modifications and the fact you don't need to create a global function to use as a script handler, your code should look something like semlar's post above.

[ravagernl]

If a frame registers more then 3 events, I personally like to set up a table approach for events. I realise this may be overkill, but it sure helps if your AddOn is properly divided into sections. As a bonus, you no longer have to type "local level, hp, mp = ..." and you can basically skip the event type checking.

local frame = CreateFrame('Frame')
frame:SetScript('OnEvent', function(self, event, ...)
    assert(self[event], 'No event handler for event' .. event)
    self[event](self, ...)
end)
 
function frame:PLAYER_LOGIN()
    -- player has logged in
    self:RegisterEvent('PLAYER_LEVEL_UP')
end
 
local levelUpMsg = 'Level: %d, extra health:%d, extra mana:%d'
function addon:PLAYER_LEVEL_UP(level, hp, mp)
    print(levelUpMsg:format(level, hp, mp))
end
 
--[[
    IsLoggedIn() 
    - Returns nil before the PLAYER_LOGIN event has fired, 1 afterwards.
    - Player data is available once PLAYER_LOGIN fires, so either wait for it,
      or run it if player is already logged in ( /reloadui )
]]
if IsLoggedIn() then
    addon:PLAYER_LOGIN()
else
    addon:RegisterEvent('PLAYER_LOGIN')
end

Thanks to the awesome tekkub for coding in this fashion, I haven't written eventlisteners any otherwise since I discovered this trick

[gibogubo]

Thanks all of you guys, now it´s working as intended

[Phanx]

Also, another problem in your original code was that you were registering for CHAT_MSG_SYSTEM -- which fires when a yellow system message like "Soandso has come online" -- instead of CHAT_MSG_WHISPER -- which fires when another player sends you a whisper message.